Differential D15334

WIP: Add support for mDNS advertisements
AbandonedPublic
Actions

Authored by sredman on Sep 7 2018, 4:14 PM.

Details

Reviewers
rytilahti
Group Reviewers
KDE Connect
Summary

This commit adds mDNS [https://tools.ietf.org/html/rfc6762] advertising for the mobile application,
allowing other applications to discover kdeconnect-supporting devices in the local network without resorting to implement the proprietary discovery protocol.

Note that this is a WIP, just to get some feedback if such would be accepted. The code requires clean-up before this can be merged.

Example output from avahi-browse -ar:

= enp0s31f6 IPv6 KDE Connect on google                         _kdeconnect._tcp     local
   hostname = [Android-4.local]
   address = [192.168.200.146]
   port = [1716]
   txt = ["version=7" "type=phone" "name=google" "id=ea29c924xxxxxxx"

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Lint Skipped
Unit
Unit Tests Skipped
rytilahti created this revision.Sep 7 2018, 4:14 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 7 2018, 4:14 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
rytilahti requested review of this revision.Sep 7 2018, 4:14 PM
rytilahti edited the summary of this revision. (Show Details)
rytilahti added a comment.Sep 7 2018, 6:25 PM

Added a preliminary implementation for the desktop counterpart: https://phabricator.kde.org/D15338

sredman added a subscriber: sredman.Sep 12 2018, 9:09 PM

Same as I said on the KDE side, I think this is neat! Since you said that you have some code cleanup in mind I will hold a through review until you are satisfied :)

I am not able to cleanly apply this patch. Did you use arc? After I hand-apply the changes the app builds and seems to work as intended

sredman commandeered this revision.Jul 25 2019, 8:32 AM
sredman added a reviewer: rytilahti.

Hi @rytilahti,

We have done a little bit more on mDNS on our Gitlab. Feel free to check it out! Android C++

I am going to close this merge request since we are moving away from Phabricator.

Thanks for your work and inspiration!

sredman abandoned this revision.Jul 25 2019, 8:32 AM

Revision Contents
Changeset List

Diff 41161

View Options

src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java

Loading...