Petross404 (Petros Siligkounas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2018, 4:06 PM (55 w, 5 d)
Availability
Available

Recent Activity

Sat, Sep 14

Petross404 updated the diff for D23905: Modernize the signal-slot syntax.

Some wrong tabs and spaces are fixed.

Sat, Sep 14, 1:15 PM
Petross404 updated the diff for D23905: Modernize the signal-slot syntax.
set(CMAKE_CXX_STANDARD_REQUIRED ON)

is added.

Sat, Sep 14, 9:05 AM
Petross404 added a comment to D23905: Modernize the signal-slot syntax.

Also CMAKE_CXX_STANDARD_REQUIRED to also set it as a requirement

Sat, Sep 14, 4:19 AM

Fri, Sep 13

Petross404 updated the diff for D23905: Modernize the signal-slot syntax.

In the top level CMakelists.txt I added build system support for C++14 which was necessary for the qOverload macro.

Fri, Sep 13, 6:53 PM

Thu, Sep 12

Petross404 added a comment to D23905: Modernize the signal-slot syntax.

You need to add
"set(CMAKE_CXX_STANDARD 14)" if you want to use C++14 in CMakeLists.txt (at toplevel)

Thu, Sep 12, 4:40 PM
Petross404 requested review of D23905: Modernize the signal-slot syntax.
Thu, Sep 12, 1:51 PM

Fri, Aug 23

Petross404 added a comment to D22854: Added support for configurable font styles for syntax highlighting.

This functionality would be great.

Fri, Aug 23, 8:46 PM · KDevelop

Jul 11 2019

Petross404 added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

Actually, there is a bit of a problem... The version of the file currently on master is bugged :(

See: https://phabricator.kde.org/D17908#492404

Jul 11 2019, 9:56 AM · KDevelop
Petross404 added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

@Petross404 are you still around? Do you have any documentation references for how Microsoft expects the registry to look with regard to which key should contain the Visual Studio installation path? (I don't know if such documentation even exists...)

Jul 11 2019, 9:55 AM · KDevelop

Jun 10 2019

Petross404 added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.

brauch is referring to this

Jun 10 2019, 6:39 PM · KDevelop
Petross404 added a comment to D21589: Duplicate Visual Studio 2017 hack for VS 2019.
echo Define which compiler for VS2017 to use. Possible architectures are:
Jun 10 2019, 6:22 PM · KDevelop

Jan 29 2019

Petross404 added inline comments to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..
Jan 29 2019, 10:34 AM · KDevelop
Petross404 added a comment to D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

you can pick whatever you prefer for the reviews for now.

do you have commit rights? if so, please feel free to push this directly, otherwise someone from us can take care of that for you

Jan 29 2019, 10:21 AM · KDevelop

Jan 28 2019

Petross404 updated the diff for D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..

Upload the minimum diff.

Jan 28 2019, 7:34 PM · KDevelop

Jan 1 2019

Petross404 requested review of D17908: kdevelop-msvc.bat finds VS-2017 based on a registry key on Windows..
Jan 1 2019, 11:01 PM · KDevelop

Oct 25 2018

Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

@Petross404 If you want to reapply the registry-reading on top of that, feel free to do so. Sorry, but I dont think I'll have time to test that. :(

Oct 25 2018, 2:56 PM · KDevelop

Oct 12 2018

Petross404 added a comment to D16123: windows: Detect VS2017 compiler and tools.

I hate tο be a naysayer here, but shouldn't we not assume that VS2017 is installed in C:\Program Files (x86) so that we don't hardcode it's path? I remember my self installing VS once in another drive, because C:\ was tiny and full.

Oct 12 2018, 9:16 AM · KDevelop
Petross404 added a comment to D16123: windows: Detect VS2017 compiler and tools.

This batch file seems very clean and simple, I like it. Unfortunately I can't help reviewing this patch as I no longer have access to Windows machines and I don't a dual-boot system :(

Oct 12 2018, 4:52 AM · KDevelop

Oct 9 2018

Petross404 updated the diff for D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Our script now initializes the environment correctly (at least for VS2017) even if the user doesn't run it from Developers Command Prompt. It reads Registry to find the path under which VS2017 is installed (I fear that I read the wrong variable from the Registry).

Oct 9 2018, 7:55 PM · KDevelop
Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Can a windows user with VS installed, give me the content of HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\VisualStudio\SxS\VS7?

Oct 9 2018, 5:17 PM · KDevelop
Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

People with Visual Studio other than Community Edition, please consider trying out these changes. If a typo or a bug exists, it should be found early.

Oct 9 2018, 12:25 AM · KDevelop
Petross404 updated the diff for D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
  1. The script (sadly) uses hardcoded paths for vcvarsall.bat, instead of needing VS150COMNTOOLS. This way it can be found and executed, without the need of Developer's Command Prompt.
Oct 9 2018, 12:20 AM · KDevelop

Oct 8 2018

Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

@kfunk As I already have mentioned, clicking the script (finding it in Start menu) doesn't initialize correctly the environment. It has to be run from within Developer Command Prompt or the complete path of MSCV binaries (for the wanted target) has to be in %PATH%.

Oct 8 2018, 2:44 PM · KDevelop

Oct 6 2018

Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Not sure about x64 part. What if user wants x32 project? Or that is arch of the toolchain itself?

Oct 6 2018, 11:39 AM · KDevelop

Oct 5 2018

Petross404 requested review of D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
Oct 5 2018, 11:06 PM · KDevelop