Add support for per package capabilities and namespaces for Appx packages
ClosedPublic

Authored by brute4s99 on Jun 3 2020, 7:40 PM.

Details

Reviewers
vonreth
Group Reviewers
Craft
Summary

Adds support to Craft for per-package capabilities and namespaces for Appx packages

  • Particularly useful for the new developments in KDE Connect for Windows port.

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27103
Build 27121: arc lint + arc unit
brute4s99 requested review of this revision.Jun 3 2020, 7:40 PM
brute4s99 created this revision.
sredman added inline comments.
bin/Packager/AppxPackager.py
55

Is it really a good default to have all apps in runFullTrust mode? On the one hand we don't want to break old recipies, but I think this isn't the best way to do that

143

Won't this always be true? Above you set a default for defines["capabilities"], so in what case would the value of capabilities be none?

brute4s99 added inline comments.Sun, Jun 7, 10:18 PM
bin/Packager/AppxPackager.py
55

We had this in the template manifest for all Appx packages built from Craft.
I'm not sure how to better do that, since it was already around for all packages by default.

143

we already had check for extensions so I thought of just following suit. 😅
Should I remove the checks? I did the same for xml_namespaces below.

vonreth accepted this revision.Sat, Jun 13, 8:22 PM
vonreth added inline comments.
bin/Packager/AppxPackager.py
55

All desktop apps run in full trust.

This revision is now accepted and ready to land.Sat, Jun 13, 8:22 PM
brute4s99 closed this revision.Sun, Jun 14, 5:57 PM