[Widget Explorer] always show the search field
ClosedPublic

Authored by ngraham on Aug 27 2018, 2:03 PM.

Details

Summary

Most Plasma widgets and apps that have search fields show them by default. Two exceptions are Kickoff and Widget Explorer (for background, see D15011#315779).

Kickoff is being addressed in D15011. That would leave Widget Explorer as the only case in Plasma (that I could find) where a search field invisibly has keyboard focus and appears when you start typing, but is not actually visible until then. This patch changes that by making the search field always visible, matching everything else in Plasma.

Thanks to @sharvey for doing most of the work already to move the Search Field to its own row in the layout. This patch simply makes it always visible and removes the Search button that shows and hides it.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 27 2018, 2:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 27 2018, 2:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 27 2018, 2:03 PM
ngraham edited the summary of this revision. (Show Details)Aug 27 2018, 2:05 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham added a reviewer: VDG.
ngraham edited the summary of this revision. (Show Details)Aug 27 2018, 2:10 PM
abetts accepted this revision.Aug 27 2018, 8:48 PM

Approved depending on the code review.

This revision is now accepted and ready to land.Aug 27 2018, 8:48 PM
ngraham removed a reviewer: Plasma.Aug 27 2018, 9:20 PM
ngraham added a reviewer: Plasma.
sharvey accepted this revision.Aug 27 2018, 10:29 PM

Can I get a review from someone on the Plasma team before I land this?

davidedmundson accepted this revision.Aug 28 2018, 10:22 PM

Thanks David!

This revision was automatically updated to reflect the committed changes.