User Details
- User Since
- Nov 10 2017, 1:42 PM (337 w, 15 h)
- Availability
- Available
Dec 27 2018
Just tested all previous mentioned issues on current master:
- "Repeatedly clicking fast on one of the forward or backward buttons will only change the image for every second click"
- This still exists in View Mode (not in Browse Mode)
- "Doing the same for videos will accidentally trigger fullscreen mode"
- Still exists if the second of the double clicks happens on the now selected video
- "After (left-)clicking an image to view and pressing Return to come back to Browse Mode, pressing a navigation button while over a thumbnail switches to View Mode again"
- I still can reproduce this:
- Open Gwenview in Browse Mode
- Left-click an image -> Switch to View Mode
- Press Return to go back to Browse Mode
- If you did not move the mouse and it's still over the image which was clicked - if you now press a navigation button the prev/next image is selected and switched to View Mode.
- I still can reproduce this:
Oct 16 2018
Moved vertical item centering from CropWidget to FlowLayout
Removed some superfluous layout settings
Some style fixes
Oct 2 2018
No objections from me. 🙂
Oct 1 2018
Looks good to me and scrolling with Shift/Alt+wheel is still possible.
Just one thing I noticed - see inline comment.
Sep 26 2018
If there's no shortcut set (ok, not the default) the message looks a bit strange and doesn't make much sense.
Btw. The title should be called Reminder isn't it?
Sep 21 2018
Sep 19 2018
I had a quick look at the Browse Mode problem and tried adding the following event handler:
void ThumbnailView::mousePressEvent(QMouseEvent* event) { if (event->button() == Qt::ForwardButton || event->button() == Qt::BackButton) { return; } QListView::mousePressEvent(event); }
This does not work in every situation but maybe it's a starting point for you.
- After (left-)clicking an image to view and pressing Return to come back to Browse Mode, pressing a navigation button while over a thumbnail switches to View Mode again
- Subfolders and archives are ignored in navigating by mouse buttons
Sep 18 2018
Set background in tool container (fixes slide out color change)
Use for instead of foreach loops
If there are no objections I'll commit this at end of the week.
Added comment and grouping
Sep 12 2018
I noticed this bug report but can't confirm a change in JPEG quality or file size when saving (as the original reporter stated).
ATM the transformation is not done by just changing the Exif orientation as Christoph suggested, but by lossless data transformation.
So I think this patch does not really fix that bug.
A good set of sample images can be found here:
https://github.com/ianare/exif-samples/tree/master/jpg/orientation
Sep 11 2018
Center all lines in multiline layout too
Readded original margin (Crop and RedEye toolbar)
Sorry, forgot about your question here.
I have no touch hardware too but try to help out with the code part.
Sep 10 2018
Looks good to me. Compiles, works as before and enhances readability.
I found no way to add a custom layout to Qt Designer, so CropWidget is now created in (not generated) code.
Sep 7 2018
The empty menu looked really odd.
Maybe it would be better to not only depend on KIPI's absence, but it's the only one using Plugins ATM and because of the delayed population it's a bit tricky to check for an empty menu.
So I think it's ok to hide it this way, if there are no objections from anybody else.
Looks good to me, printing to hardware and file shows the image name now.
Btw. there's a bug report for this: https://bugs.kde.org/show_bug.cgi?id=332207
Sep 4 2018
Thanks, works flawlessly now.
Nice simplification. :)
Works good, just one maybe unnecessary call (see inline comment).
Looks good, compiles and makes the code more consistent.
Sep 3 2018
Patch looks good to me, except for the thumbnail dimensions (see inline comment).
Sep 1 2018
Ok, let's get rid of this unused code. ;)
@ngraham Do you know of any plans to reactivate this Gwenview special plugin? If not I would say it's ok to remove it and better keep on with the standard libraries. The patch looks good to me.
Aug 23 2018
Should we get rid of mStatus and just use stackedWidget->currentWidget()?
Something like this: P254 (diff against this patch).
Aug 22 2018
Rebase
Prevent zooming over resize handles
The trouble with the red eye Close button creeped into master now (stable is still fine).
Pressing Close (not Cancel) with Return does not work. This needs some adjustment for the new widget helpDialogButtonBox.
Aug 21 2018
- Rebase
- Handle double click events
- Accept event outside checkAndRequestZoomAction
The centered layout looks good to me, slightly better than right aligned.
Nice idea to use the role! 👍
Works perfect now.
Aug 20 2018
make test regained all Gwenview tests. CMake code looks good to me (compared e.g. to Dolphin).
(UrlUtilsTest still fails for me in 50% of the runs because of returning krarc instead of zip/cbz, but that's nothing new.)
Use stretch factor instead of fixed policy for message label
Works mostly good, except for the red eye Close (see inline comment).
Btw. Backspace still goes to the previous image. But not sure if we should change this too. It's not used otherwise and could be assigned to any other action by the user.
Aug 19 2018
Set message label to QSizePolicy::Fixed
Thanks for fixing. Compiler is happy again.
I read about some special comments for Krazy to ignore this. Should we add this here or use another way, e.g. QStringLiteral?
Aug 18 2018
I can't compile the master branch anymore and Jenkins failed too.
I found an issue with the ignored keyReleaseEvent - pressing and releasing Ctrl changes the cursor to open or closed hand. For Crop this corrects when the mouse is moved but not for RedEye. Maybe we could solve this in combination with D14485 or just override keyReleaseEvent for now?
Removed unneeded leftover header
I tried to keep the appearance of the SaveBar. Maybe there are better suggestions to change the layout?
No code change and visual check looks good.
The Advanced settings bar is really wide. Should we try to split this into two lines if there is not enough space, e.g. with a floating layout?
Aug 17 2018
Aug 16 2018
Code and functionality looks good to me. The described issues are all fixed.
Aug 14 2018
I found an old MS 5-button mouse at the office, so I can test with real hardware now. :)
Aug 13 2018
Looks good to me. Works as stated and I can't find any issues, also zooming by Ctrl+DoubleClick still works.
Aug 11 2018
Aug 9 2018
Aug 5 2018
Aug 4 2018
The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule for this?
Use singleShot timer instead of showEvent
Aug 3 2018
Aug 2 2018
Works good for me and solves the issue as stated.
Copy&paste is not affected and operates as before for all applications I tested.
For drag&drop I can't find any restrictions where something is not working as expected.