Feed Advanced Search

Dec 27 2018

muhlenpfordt removed a reviewer for D14583: [MainWindow] Navigate through mouse forward/back buttons: muhlenpfordt.
Dec 27 2018, 1:10 PM · Gwenview
muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Just tested all previous mentioned issues on current master:

  • "Repeatedly clicking fast on one of the forward or backward buttons will only change the image for every second click"
    • This still exists in View Mode (not in Browse Mode)
  • "Doing the same for videos will accidentally trigger fullscreen mode"
    • Still exists if the second of the double clicks happens on the now selected video
  • "After (left-)clicking an image to view and pressing Return to come back to Browse Mode, pressing a navigation button while over a thumbnail switches to View Mode again"
    • I still can reproduce this:
      1. Open Gwenview in Browse Mode
      2. Left-click an image -> Switch to View Mode
      3. Press Return to go back to Browse Mode
      4. If you did not move the mouse and it's still over the image which was clicked - if you now press a navigation button the prev/next image is selected and switched to View Mode.
Dec 27 2018, 10:05 AM · Gwenview
muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

Landing on Peter's behalf since he's probably on vacation right now. :)

Dec 27 2018, 8:33 AM · Gwenview

Oct 16 2018

muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Moved vertical item centering from CropWidget to FlowLayout
Removed some superfluous layout settings
Some style fixes

Oct 16 2018, 6:59 AM · Gwenview

Oct 2 2018

muhlenpfordt added a comment to D15809: Add Zoom scroll wheel option.

No objections from me. 🙂

Oct 2 2018, 5:05 PM · Gwenview

Oct 1 2018

muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

Sorry it's taken me so long to get to this. One thing I notice is the paradigm of putting layouts inside their own widgets. Generally I don't think this is necessary.

Oct 1 2018, 7:00 AM · Gwenview
muhlenpfordt added a reviewer for D15809: Add Zoom scroll wheel option: Gwenview.

Looks good to me and scrolling with Shift/Alt+wheel is still possible.
Just one thing I noticed - see inline comment.

Oct 1 2018, 6:45 AM · Gwenview

Sep 26 2018

muhlenpfordt added a comment to D15747: Remainder dialog for re-enabling the menubar once hidden.

For now maybe let's be consistent with Kate and then once we have a KStandardAction for this, we can polish up the presentation there so we don't have to duplicate work. Does that sound sane?

Sep 26 2018, 3:13 PM · Gwenview
muhlenpfordt added a comment to D15747: Remainder dialog for re-enabling the menubar once hidden.

If there's no shortcut set (ok, not the default) the message looks a bit strange and doesn't make much sense.
Btw. The title should be called Reminder isn't it?

Sep 26 2018, 1:46 PM · Gwenview

Sep 21 2018

muhlenpfordt committed R260:b66a292d77e2: Merge remote-tracking branch 'origin/Applications/18.08' (authored by muhlenpfordt).
Merge remote-tracking branch 'origin/Applications/18.08'
Sep 21 2018, 6:30 AM
muhlenpfordt committed R260:e6c60224defa: Fix orientation when saving/transforming JPEG images (authored by muhlenpfordt).
Fix orientation when saving/transforming JPEG images
Sep 21 2018, 6:30 AM
muhlenpfordt closed D15455: Fix orientation when saving/transforming JPEG images.
Sep 21 2018, 6:30 AM · Gwenview

Sep 19 2018

muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

I had a quick look at the Browse Mode problem and tried adding the following event handler:

void ThumbnailView::mousePressEvent(QMouseEvent* event)
{
    if (event->button() == Qt::ForwardButton || event->button() == Qt::BackButton) {
        return;
    }
    QListView::mousePressEvent(event);
}

This does not work in every situation but maybe it's a starting point for you.

  • After (left-)clicking an image to view and pressing Return to come back to Browse Mode, pressing a navigation button while over a thumbnail switches to View Mode again
  • Subfolders and archives are ignored in navigating by mouse buttons
Sep 19 2018, 3:55 PM · Gwenview

Sep 18 2018

muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

Issues in Browse mode persist without the patch, you can click with Forward/Backward button over image, it's selected.

Sep 18 2018, 9:57 AM · Gwenview
muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Set background in tool container (fixes slide out color change)
Use for instead of foreach loops

Sep 18 2018, 8:34 AM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

If there are no objections I'll commit this at end of the week.

Sep 18 2018, 7:19 AM · Gwenview
muhlenpfordt updated the diff for D15455: Fix orientation when saving/transforming JPEG images.

Added comment and grouping

Sep 18 2018, 7:18 AM · Gwenview
muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

What you expect to change on it?

Sep 18 2018, 7:10 AM · Gwenview

Sep 12 2018

muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.
Sep 12 2018, 5:56 PM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

I noticed this bug report but can't confirm a change in JPEG quality or file size when saving (as the original reporter stated).
ATM the transformation is not done by just changing the Exif orientation as Christoph suggested, but by lossless data transformation.
So I think this patch does not really fix that bug.

Sep 12 2018, 3:37 PM · Gwenview
muhlenpfordt added a comment to D15455: Fix orientation when saving/transforming JPEG images.

A good set of sample images can be found here:
https://github.com/ianare/exif-samples/tree/master/jpg/orientation

Sep 12 2018, 3:14 PM · Gwenview
muhlenpfordt requested review of D15455: Fix orientation when saving/transforming JPEG images.
Sep 12 2018, 3:14 PM · Gwenview

Sep 11 2018

muhlenpfordt committed R260:6b83418d3953: Fix warnings from code checker doublequote_chars (authored by muhlenpfordt).
Fix warnings from code checker doublequote_chars
Sep 11 2018, 11:25 AM
muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

Thanks, this looks like it'll be a nice improvement! I'll review soon.

Sep 11 2018, 10:22 AM · Gwenview
muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Center all lines in multiline layout too
Readded original margin (Crop and RedEye toolbar)

Sep 11 2018, 10:16 AM · Gwenview
muhlenpfordt added a comment to D13901: Touch support for Gwenview.

Sorry, forgot about your question here.
I have no touch hardware too but try to help out with the code part.

Sep 11 2018, 7:51 AM · Gwenview

Sep 10 2018

muhlenpfordt accepted D15270: Don't show Plugins menu if built without KIPI support.
Sep 10 2018, 11:29 AM · Gwenview
muhlenpfordt accepted D15271: Don't show empty Rating menu when built without semantic info backend.
Sep 10 2018, 11:29 AM · Gwenview
muhlenpfordt accepted D15296: Use QOverload to select overloaded functions.

Looks good to me. Compiles, works as before and enhances readability.

Sep 10 2018, 9:48 AM · Gwenview
muhlenpfordt committed R260:671ae606778f: Remove not needed SignalBlocker header includes (authored by muhlenpfordt).
Remove not needed SignalBlocker header includes
Sep 10 2018, 8:50 AM
muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

I found no way to add a custom layout to Qt Designer, so CropWidget is now created in (not generated) code.

Sep 10 2018, 8:39 AM · Gwenview
muhlenpfordt requested review of D15398: Use FlowLayout for Crop toolbar.
Sep 10 2018, 8:38 AM · Gwenview

Sep 7 2018

muhlenpfordt added a comment to D15270: Don't show Plugins menu if built without KIPI support.

But the menu isn't empty, is it? It has "Install Plugins" in it, which lets you populate it.

Sep 7 2018, 2:41 PM · Gwenview
muhlenpfordt added a comment to D15270: Don't show Plugins menu if built without KIPI support.

The empty menu looked really odd.
Maybe it would be better to not only depend on KIPI's absence, but it's the only one using Plugins ATM and because of the delayed population it's a bit tricky to check for an empty menu.
So I think it's ok to hide it this way, if there are no objections from anybody else.

Sep 7 2018, 12:22 PM · Gwenview
muhlenpfordt accepted D15325: Set file name on print job.

Looks good to me, printing to hardware and file shows the image name now.
Btw. there's a bug report for this: https://bugs.kde.org/show_bug.cgi?id=332207

Sep 7 2018, 9:53 AM · Gwenview

Sep 4 2018

muhlenpfordt accepted D15248: Use lambdas instead of QSignalMapper.
Sep 4 2018, 3:45 PM · Gwenview
muhlenpfordt accepted D15238: Use QImageReader's auto transform feature for JPEG images.

Thanks, works flawlessly now.

Sep 4 2018, 3:44 PM · Gwenview
muhlenpfordt added a comment to D15248: Use lambdas instead of QSignalMapper.

Nice simplification. :)
Works good, just one maybe unnecessary call (see inline comment).

Sep 4 2018, 9:39 AM · Gwenview
muhlenpfordt accepted D15239: Add override by clang-tidy's modernize-use-override.

Looks good, compiles and makes the code more consistent.

Sep 4 2018, 7:32 AM · Gwenview

Sep 3 2018

muhlenpfordt added a comment to D15238: Use QImageReader's auto transform feature for JPEG images.

Patch looks good to me, except for the thumbnail dimensions (see inline comment).

Sep 3 2018, 6:21 PM · Gwenview

Sep 1 2018

muhlenpfordt accepted D15188: Remove our own JPEG image format plugin.

Ok, let's get rid of this unused code. ;)

Sep 1 2018, 5:43 PM · Gwenview
muhlenpfordt updated subscribers of D15188: Remove our own JPEG image format plugin.

@ngraham Do you know of any plans to reactivate this Gwenview special plugin? If not I would say it's ok to remove it and better keep on with the standard libraries. The patch looks good to me.

Sep 1 2018, 1:46 PM · Gwenview

Aug 23 2018

muhlenpfordt accepted D15014: Fix Enter key not working for new Close button in Red Eye Reduce tool.

Should we get rid of mStatus and just use stackedWidget->currentWidget()?
Something like this: P254 (diff against this patch).

Aug 23 2018, 8:38 AM · Gwenview
muhlenpfordt created P254 Get rid of RedEyeReductionTool mStatus in the S1 KDE Community space.
Aug 23 2018, 8:34 AM

Aug 22 2018

muhlenpfordt updated the diff for D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

Rebase
Prevent zooming over resize handles

Aug 22 2018, 1:11 PM · Gwenview
muhlenpfordt added a comment to D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

The trouble with the red eye Close button creeped into master now (stable is still fine).
Pressing Close (not Cancel) with Return does not work. This needs some adjustment for the new widget helpDialogButtonBox.

Aug 22 2018, 12:47 PM · Gwenview
muhlenpfordt accepted D14954: Center numbers in Crop and Reduce Red Eye spinboxes.
Aug 22 2018, 7:14 AM · Gwenview
muhlenpfordt added a comment to D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

Ideally holding Ctrl will never change to a resizing cursor, and zooming in and out will work everywhere.
This is already working great for both the OpenHandCursor and ArrowCursor areas, only the handles are still off.

Aug 22 2018, 7:04 AM · Gwenview
muhlenpfordt committed R260:2ba1e6bcb410: Merge remote-tracking branch 'origin/Applications/18.08' (authored by muhlenpfordt).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 22 2018, 6:40 AM
muhlenpfordt committed R260:d280cc6052a2: Fix Crop tool Aspect ratio sometimes randomly preselected (authored by muhlenpfordt).
Fix Crop tool Aspect ratio sometimes randomly preselected
Aug 22 2018, 6:38 AM
muhlenpfordt closed D14969: Fix Crop tool Aspect ratio sometimes randomly preselected.
Aug 22 2018, 6:38 AM · Gwenview

Aug 21 2018

muhlenpfordt added a comment to D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.

Sorry for the wait, but I did not get to the focus/hover issue yet (and thus did not start with the actual review).

Aug 21 2018, 11:52 AM · Gwenview
muhlenpfordt updated the diff for D14485: [Draft] Set zoom cursor in edit tools while Ctrl is pressed.
  • Rebase
  • Handle double click events
  • Accept event outside checkAndRequestZoomAction
Aug 21 2018, 11:52 AM · Gwenview
muhlenpfordt requested review of D14969: Fix Crop tool Aspect ratio sometimes randomly preselected.
Aug 21 2018, 8:59 AM · Gwenview
Restricted Application added a project to D14954: Center numbers in Crop and Reduce Red Eye spinboxes: Gwenview.

The centered layout looks good to me, slightly better than right aligned.

Aug 21 2018, 7:59 AM · Gwenview
muhlenpfordt committed R260:3a83caf84fe6: Merge remote-tracking branch 'origin/Applications/18.08' (authored by muhlenpfordt).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 21 2018, 6:47 AM
muhlenpfordt committed R260:8e69f60ffa92: Fix Advanced settings crop toolbar sometimes cut off (authored by muhlenpfordt).
Fix Advanced settings crop toolbar sometimes cut off
Aug 21 2018, 6:42 AM
muhlenpfordt closed D14917: Fix Advanced settings crop toolbar sometimes cut off.
Aug 21 2018, 6:42 AM · Gwenview
muhlenpfordt accepted D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

Nice idea to use the role! 👍
Works perfect now.

Aug 21 2018, 6:34 AM · Gwenview

Aug 20 2018

muhlenpfordt accepted D14934: Port to ecm_add_test to stop skipping all test runs.

make test regained all Gwenview tests. CMake code looks good to me (compared e.g. to Dolphin).
(UrlUtilsTest still fails for me in 50% of the runs because of returning krarc instead of zip/cbz, but that's nothing new.)

Aug 20 2018, 11:58 AM
muhlenpfordt updated the diff for D14917: Fix Advanced settings crop toolbar sometimes cut off.

Use stretch factor instead of fixed policy for message label

Aug 20 2018, 8:40 AM · Gwenview
muhlenpfordt added a comment to D14925: Improve keyboard handling for focused buttons in Crop and Reduce Red Eye tools.

Works mostly good, except for the red eye Close (see inline comment).
Btw. Backspace still goes to the previous image. But not sure if we should change this too. It's not used otherwise and could be assigned to any other action by the user.

Aug 20 2018, 8:24 AM · Gwenview

Aug 19 2018

muhlenpfordt added a comment to D14917: Fix Advanced settings crop toolbar sometimes cut off.

I see where you are coming from, but I'm afraid now the common case of modifying a single image will cut off the Current image modified label much earlier, since there is now a gap between both button groups which does not get compressed. Would this be easy to fix?

Aug 19 2018, 11:55 AM · Gwenview
muhlenpfordt updated the diff for D14917: Fix Advanced settings crop toolbar sometimes cut off.

Set message label to QSizePolicy::Fixed

Aug 19 2018, 11:55 AM · Gwenview
muhlenpfordt accepted R260:73e0b8219c2c: Fix minor EBN issues.

Thanks for fixing. Compiler is happy again.
I read about some special comments for Krazy to ignore this. Should we add this here or use another way, e.g. QStringLiteral?

Aug 19 2018, 8:08 AM · Gwenview

Aug 18 2018

muhlenpfordt added a project to R260:73e0b8219c2c: Fix minor EBN issues: Gwenview.

I can't compile the master branch anymore and Jenkins failed too.

Aug 18 2018, 5:04 PM · Gwenview
muhlenpfordt added a comment to D14889: Propagate more unused events in edit tools.

I found an issue with the ignored keyReleaseEvent - pressing and releasing Ctrl changes the cursor to open or closed hand. For Crop this corrects when the mouse is moved but not for RedEye. Maybe we could solve this in combination with D14485 or just override keyReleaseEvent for now?

Aug 18 2018, 10:02 AM · Gwenview
muhlenpfordt updated the diff for D14917: Fix Advanced settings crop toolbar sometimes cut off.

Removed unneeded leftover header

Aug 18 2018, 8:39 AM · Gwenview
muhlenpfordt added a comment to D14917: Fix Advanced settings crop toolbar sometimes cut off.

I tried to keep the appearance of the SaveBar. Maybe there are better suggestions to change the layout?

Aug 18 2018, 8:37 AM · Gwenview
muhlenpfordt requested review of D14917: Fix Advanced settings crop toolbar sometimes cut off.
Aug 18 2018, 8:36 AM · Gwenview
muhlenpfordt accepted D14907: Adjust spacing in crop UI.

No code change and visual check looks good.
The Advanced settings bar is really wide. Should we try to split this into two lines if there is not enough space, e.g. with a floating layout?

Aug 18 2018, 7:50 AM

Aug 17 2018

muhlenpfordt accepted D14888: Keep the width of the crop spinboxes fixed to avoid wiggling.

Sounds simple once you know the trick, but to get there was a bit long-winded…

Aug 17 2018, 10:09 AM

Aug 16 2018

muhlenpfordt accepted D14846: Polish Reduce Red Eye UI.

Code and functionality looks good to me. The described issues are all fixed.

Aug 16 2018, 9:42 AM

Aug 14 2018

muhlenpfordt added a comment to D14583: [MainWindow] Navigate through mouse forward/back buttons.

I found an old MS 5-button mouse at the office, so I can test with real hardware now. :)

Aug 14 2018, 7:23 AM · Gwenview
muhlenpfordt committed R657:06ee3f3e6529: Change default shortcut for "Zoom To Fit" action (authored by muhlenpfordt).
Change default shortcut for "Zoom To Fit" action
Aug 14 2018, 6:22 AM
muhlenpfordt closed D14202: Change default shortcut for "Zoom To Fit" action.
Aug 14 2018, 6:22 AM

Aug 13 2018

muhlenpfordt added a comment to D13344: Add possibility to sort by rating.

I've got it to work by using Document::waitUntilLoaded() but it waits until the full image has been loaded which renders the sorting by image size quite slow. Any suggestions?

Aug 13 2018, 6:26 PM
muhlenpfordt added a comment to D14755: Allow to double-click to accelerate crop and red-eye modifications.

Looks good to me. Works as stated and I can't find any issues, also zooming by Ctrl+DoubleClick still works.

Aug 13 2018, 10:50 AM

Aug 11 2018

muhlenpfordt committed R237:f651a817ab00: Set system default shortcut Ctrl+0 for "Actual Size" action (authored by muhlenpfordt).
Set system default shortcut Ctrl+0 for "Actual Size" action
Aug 11 2018, 11:22 AM
muhlenpfordt closed D14201: Set system default shortcut Ctrl+0 for "Actual Size" action.
Aug 11 2018, 11:22 AM · Frameworks
muhlenpfordt updated the summary of D14201: Set system default shortcut Ctrl+0 for "Actual Size" action.
Aug 11 2018, 11:10 AM · Frameworks

Aug 9 2018

muhlenpfordt committed R114:28fe01674f6c: [Timer applet] Reset opacity on timer start and reset (authored by muhlenpfordt).
[Timer applet] Reset opacity on timer start and reset
Aug 9 2018, 1:39 PM
muhlenpfordt closed D14701: [Timer applet] Reset opacity on timer start and reset.
Aug 9 2018, 1:39 PM · Plasma
muhlenpfordt added a comment to D14701: [Timer applet] Reset opacity on timer start and reset.

do you have commit access?

Aug 9 2018, 11:51 AM · Plasma
muhlenpfordt requested review of D14701: [Timer applet] Reset opacity on timer start and reset.
Aug 9 2018, 8:26 AM · Plasma

Aug 5 2018

muhlenpfordt committed R260:7abac66eca1b: Merge remote-tracking branch 'origin/Applications/18.08' (authored by muhlenpfordt).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 5 2018, 7:22 AM
muhlenpfordt committed R260:fec2cd8b655e: Fix video controls volume slider not vertically centered sometimes (authored by muhlenpfordt).
Fix video controls volume slider not vertically centered sometimes
Aug 5 2018, 7:16 AM
muhlenpfordt closed D14578: Fix video controls volume slider not vertically centered sometimes.
Aug 5 2018, 7:16 AM
muhlenpfordt added inline comments to D14578: Fix video controls volume slider not vertically centered sometimes.
Aug 5 2018, 7:16 AM

Aug 4 2018

muhlenpfordt added a comment to D14201: Set system default shortcut Ctrl+0 for "Actual Size" action.

The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule for this?

Aug 4 2018, 3:38 PM · Frameworks
muhlenpfordt added a comment to D14578: Fix video controls volume slider not vertically centered sometimes.

BTW, unrelated but it would be interesting to know if you can reproduce:

  • When switching many times between a video and an image, sometimes the volume slider is not at the left-most position, but somewhere in the middle. In particular I got this for a webm file without audio, e.g. F5477455. (For this file the slider position is remembered correctly, and the right-most position means loudest.)

I noticed this on Kubuntu but not in Neon VM (maybe because of the disabled audio). It seems to come from a Phonon::AudioOutput::volumeChanged signal but no idea why this happens only sometimes.

Aug 4 2018, 11:16 AM
muhlenpfordt added a comment to D14578: Fix video controls volume slider not vertically centered sometimes.

BTW, unrelated but it would be interesting to know if you can reproduce:

  • When switching many times between a video and an image, sometimes the volume slider is not at the left-most position, but somewhere in the middle. In particular I got this for a webm file without audio, e.g. F5477455. (For this file the slider position is remembered correctly, and the right-most position means loudest.)
Aug 4 2018, 8:32 AM
muhlenpfordt updated the diff for D14578: Fix video controls volume slider not vertically centered sometimes.

Use singleShot timer instead of showEvent

Aug 4 2018, 8:32 AM

Aug 3 2018

muhlenpfordt requested review of D14578: Fix video controls volume slider not vertically centered sometimes.
Aug 3 2018, 1:33 PM
muhlenpfordt added a comment to D9342: Make sure, a newly saved image is selected in ContextManager.

Thanks a lot to all of you for finding and fixing this bug!
It is working in Gwenview as of today's KDE neon unstable edition.

I own you a beer (or some other drink of your choice). Do you come to Wien next week?

Aug 3 2018, 11:06 AM

Aug 2 2018

muhlenpfordt committed R260:cb5cede34fef: Merge remote-tracking branch 'origin/Applications/18.08' (authored by muhlenpfordt).
Merge remote-tracking branch 'origin/Applications/18.08'
Aug 2 2018, 9:24 AM
muhlenpfordt committed R260:b19e0229b0d2: Make sure, a newly saved image is selected in ContextManager (authored by muhlenpfordt).
Make sure, a newly saved image is selected in ContextManager
Aug 2 2018, 9:17 AM
muhlenpfordt closed D9342: Make sure, a newly saved image is selected in ContextManager.
Aug 2 2018, 9:17 AM
muhlenpfordt added a comment to D13249: Refine behaviour for dragging modified images to external applications.

Correct - I used 17.12.3. Tested with 18.07.80 in a Neon VM does not show this problem (but drop on desktop does nothing).

Hm, works for me. Are you sure you ran the unmodified plasmashell, and dragged to a free space on the desktop? If this is really broken, please file a bug.

Aug 2 2018, 9:05 AM
muhlenpfordt accepted D14543: Disable setImageData for dragging of unmodified images.

Works good for me and solves the issue as stated.
Copy&paste is not affected and operates as before for all applications I tested.
For drag&drop I can't find any restrictions where something is not working as expected.

Aug 2 2018, 8:57 AM