Diffusion Gwenview 73e0b8219c2c

Fix minor EBN issues
Audited73e0b8219c2c
Actions

Authored by yurchor on Aug 18 2018, 7:51 AM.

Description

Fix minor EBN issues

Details

Auditors

muhlenpfordt

Committed

yurchor

Aug 18 2018, 7:51 AM

Parents

R260:4de1b3c553d3: GIT_SILENT made messages (after extraction)

Branches

Unknown

Tags

Unknown

yurchor committed R260:73e0b8219c2c: Fix minor EBN issues (authored by yurchor).Aug 18 2018, 7:51 AM

I can't compile the master branch anymore and Jenkins failed too.

/tests/auto/contextmanagertest.cpp
67	contextmanagertest.cpp:67:23: error: invalid user-defined conversion from ‘char’ to ‘const QString&’ [-fpermissive]
78	contextmanagertest.cpp:78:23: error: invalid conversion from ‘char’ to ‘const char*’ [-fpermissive]

/tests/auto/contextmanagertest.cpp

contextmanagertest.cpp:67:23: error: invalid user-defined conversion from ‘char’ to ‘const QString&’ [-fpermissive]

contextmanagertest.cpp:78:23: error: invalid conversion from ‘char’ to ‘const char*’ [-fpermissive]

This commit now has outstanding concerns.Aug 18 2018, 5:04 PM

Should be fixed now. Sorry for breaking things.

Thanks for fixing. Compiler is happy again.
I read about some special comments for Krazy to ignore this. Should we add this here or use another way, e.g. QStringLiteral?

All concerns with this commit have now been addressed.Aug 19 2018, 8:08 AM

Might be so. At least, other developers do this through QStringLiteral. Or it can be ignored...

rkflx mentioned this in D14921: Fix compilation error when removing file in test.Aug 20 2018, 4:37 PM

Changes (11)

				Path	Packages
	M			app/abstractcontextmanageritem.cpp
	M			app/fileopscontextmanageritem.cpp
	M			app/filtercontroller.cpp
	M			importer/importdialog.cpp
	M			importer/main.cpp
	M			lib/contextmanager.cpp
	M			lib/documentview/documentviewcontroller.cpp
	M			lib/slidecontainer.h
	M			tests/auto/contextmanagertest.cpp
	M			tests/auto/placetreemodeltest.cpp
	M			tests/manual/thumbnailgen.cpp