Set system default shortcut Ctrl+0 for "Actual Size" action
ClosedPublic

Authored by muhlenpfordt on Jul 18 2018, 10:08 AM.

Details

Summary

Default shortcuts for zoom in (Ctrl++) and out (Ctrl+-)
already exists but not for going back to 100%.
The shortcut Ctrl+0 is widely used by different applications
for zoom to original size. This patch adds Ctrl+0 as system
default for KStandardAction::ActualSize.

FEATURE: 305702
FIXED-IN: 5.50

Test Plan

Searched lxr for conflicts of KStandardAction::ActualSize and
usage of Ctrl+0 shortcut.
Checked the following applications with set system default shortcut:

  • Gwenview
  • KAlgebra
  • KolourPaint
  • KStars (FITS viewer)
  • Cirkuit

Only Cirkuit uses Ctrl+0 for "Zoom To Fit" action. I'll create a
patch to solve this conflict.

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt created this revision.Jul 18 2018, 10:08 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 18 2018, 10:08 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
muhlenpfordt requested review of this revision.Jul 18 2018, 10:08 AM
rkflx added a comment.Jul 23 2018, 7:18 PM

@ngraham Would this patch be something you could back?

ngraham accepted this revision.Jul 23 2018, 8:45 PM

Yes, I like it the idea. The chosen shortcut makes sense, and I'm always in favor of standardizing these across apps. Let's hold off on landing this patch (if accepted by everyone) until Cirkuit has had a release with D14202 so we don't wind up with the dreaded "Ambiguous Shortcut!" dialog.

This revision is now accepted and ready to land.Jul 23 2018, 8:45 PM
rkflx added a comment.EditedJul 23 2018, 9:04 PM

Thanks for your support ;)

Let's hold off on landing this patch (if accepted by everyone) until Cirkuit has had a release with D14202 so we don't wind up with the dreaded "Ambiguous Shortcut!" dialog.

Are you sure about that? This might mean waiting forever.

AFAIK Cirkuit did not even have a KF5 release yet, I'd assume everyone is just running from the frameworks branch, or stuck on an old KDE4 distro which would not get the new KConfig anyway. Ubuntu shipped it in 16.04, 18.04 does not have it anymore in the default repos. This app is not exactly a second DigiKam where your comment might be coming from, with wide distribution and regular releases.

Edit: See https://repology.org/metapackage/cirkuit/versions and note the large section "Absent in repositories".

I'd say wait until Neon made the switch to Ubuntu 18.04, but no longer.

Hah! Well in that case, that won't be a blocker.

ngraham edited the summary of this revision. (Show Details)Aug 2 2018, 12:55 PM
dfaure accepted this revision.Aug 4 2018, 9:55 AM

5.49 has been tagged, so this is now going into 5.50.

The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule for this?

The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule for this?

As far as I know, the latest status is available at https://jriddell.org/2018/07/26/kde-neon-bionic-update/, but maybe @jriddell can provide an update.

rkflx accepted this revision.Aug 9 2018, 1:12 PM

@muhlenpfordt I'd say go ahead with landing (after updating the version). It would be good to still have some testing time before the next Frameworks release.

(The new Neon seems to be just around the corner, AFAICS.)

muhlenpfordt edited the summary of this revision. (Show Details)Aug 11 2018, 11:10 AM
This revision was automatically updated to reflect the committed changes.