GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Fri, May 29

ngraham closed D28918: Make using monitor color profile optional.
Fri, May 29, 4:37 PM · Gwenview
ngraham accepted D28918: Make using monitor color profile optional.

All good now, sorry for the wait.

Fri, May 29, 4:36 PM · Gwenview

Wed, May 27

karbie added a comment to D28918: Make using monitor color profile optional.

Sorry to bother, what's the status of this review?

Wed, May 27, 6:38 AM · Gwenview

Sun, May 24

twitt requested review of D29829: Fix divide-by-zero crash for zero-sized cropped images.
Sun, May 24, 12:57 AM · Gwenview

Sat, May 16

karbie updated the diff for D28918: Make using monitor color profile optional.
  • make help text smaller
  • stop editing unnecessary files
Sat, May 16, 6:38 PM · Gwenview

Thu, May 14

ngraham requested changes to D28918: Make using monitor color profile optional.

Just a few more changes required:

Thu, May 14, 10:06 PM · Gwenview
ngraham added a comment to D28918: Make using monitor color profile optional.

So sorry I missed your update to this patch! I will re-review.

Thu, May 14, 9:56 PM · Gwenview

Apr 20 2020

nicolasfella abandoned D22706: Port KRun::runService to KRun::runApplication.
Apr 20 2020, 10:52 AM · Gwenview

Apr 19 2020

ngraham added a comment to D28480: Add save and reset state functionality to the crop tool.

Great job with this patch! May it be the first of many. :)

Apr 19 2020, 11:01 PM · Gwenview
ngraham closed D28480: Add save and reset state functionality to the crop tool.
Apr 19 2020, 10:33 PM · Gwenview
aichingm added a comment to D28480: Add save and reset state functionality to the crop tool.

Right here in a comment. This will get a lot better with the GitLab migration in a few weeks. :)

Apr 19 2020, 6:49 PM · Gwenview
sandsmark closed D28346: Fix leaking ThumbnailGenerators.
Apr 19 2020, 2:47 PM · Gwenview
sandsmark added a comment to D28345: Fix segfault/call on invalid pointer.

Sorry for missing this.

Apr 19 2020, 2:44 PM · Gwenview
sandsmark closed D28342: Fix undefined behavior by calling on almost destroyed object.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark closed D28343: Fix leak of Rows in infocontextmanageritem.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark closed D28344: Fix memory leak in CMS.
Apr 19 2020, 2:44 PM · Gwenview
sandsmark closed D28345: Fix segfault/call on invalid pointer.
Apr 19 2020, 2:44 PM · Gwenview

Apr 17 2020

karbie updated the diff for D28918: Make using monitor color profile optional.
  • Add better description for color correction setting
Apr 17 2020, 2:37 PM · Gwenview
ngraham added reviewers for D28918: Make using monitor color profile optional: Gwenview, VDG.
Apr 17 2020, 1:26 PM · Gwenview
ngraham added a comment to D28480: Add save and reset state functionality to the crop tool.

Also, could you provide an email address we could use to land this with correct git authorship information?

I'm new to the phabricator workflow, where would i provide that information?

Apr 17 2020, 1:21 PM · Gwenview
karbie requested review of D28918: Make using monitor color profile optional.
Apr 17 2020, 1:10 PM · Gwenview
aichingm added a comment to D28480: Add save and reset state functionality to the crop tool.

Also, could you provide an email address we could use to land this with correct git authorship information?

I'm new to the phabricator workflow, where would i provide that information?

Apr 17 2020, 11:12 AM · Gwenview

Apr 14 2020

ngraham accepted D28480: Add save and reset state functionality to the crop tool.

Thanks for your patience here. I've had the same use case in the past and this is pretty much how I would implement it too. I just have one insignificant comment that could be addressed (see below).

Apr 14 2020, 9:08 PM · Gwenview
ngraham accepted D28344: Fix memory leak in CMS.

Yup.

Apr 14 2020, 3:27 PM · Gwenview
ngraham accepted D28345: Fix segfault/call on invalid pointer.

Sorry for missing this.

Apr 14 2020, 3:27 PM · Gwenview
ngraham accepted D28343: Fix leak of Rows in infocontextmanageritem.

Whoops.

Apr 14 2020, 3:26 PM · Gwenview
ngraham accepted D28342: Fix undefined behavior by calling on almost destroyed object.
Apr 14 2020, 3:26 PM · Gwenview
ngraham accepted D28346: Fix leaking ThumbnailGenerators.
Apr 14 2020, 3:26 PM · Gwenview

Apr 13 2020

sandsmark added a comment to D28344: Fix memory leak in CMS.

Again, fairly trivial, I hope.

Apr 13 2020, 12:50 PM · Gwenview
sandsmark added a comment to D28345: Fix segfault/call on invalid pointer.

This should be a fairly trivial and straightforward fix, fwiw. And without this and the other patches I can't really run gwenview with ubsan and asan.

Apr 13 2020, 12:49 PM · Gwenview

Apr 7 2020

sandsmark added a comment to D17732: Respect animation settings.

And FWIW, after https://phabricator.kde.org/D28373 landed animations are smooth where they used to bother me, so this isn't really that important for me personally anymore. But being able to turn off animations (without cluttering the gwenview settings more) is nice anyways.

Apr 7 2020, 1:20 PM · Gwenview
sandsmark added a comment to D17732: Respect animation settings.
+        KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));

Just KSharedConfig::openConfig()

it'll include kdeglobals wihtout a reparse

Apr 7 2020, 1:07 PM · Gwenview
sandsmark added a reviewer for D28346: Fix leaking ThumbnailGenerators: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28345: Fix segfault/call on invalid pointer: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28344: Fix memory leak in CMS: ngraham.
Apr 7 2020, 1:05 PM · Gwenview
sandsmark added a reviewer for D28343: Fix leak of Rows in infocontextmanageritem: ngraham.
Apr 7 2020, 1:04 PM · Gwenview
sandsmark added a reviewer for D28342: Fix undefined behavior by calling on almost destroyed object: ngraham.
Apr 7 2020, 1:04 PM · Gwenview

Apr 6 2020

sandsmark added a comment to D24576: Don't link directly against Purpose for sharing.

I can still reproduce.

I have purpose installed from git master (like everything else KDE). The CMake log for Gwenview no longer even mentions Purpose at all. Console output says:

Apr 6 2020, 4:26 PM · Gwenview
sandsmark closed D28375: Don't fill disk with thumbnails if thumbnail saving is turned off.
Apr 6 2020, 4:00 PM · Gwenview
sandsmark closed D28373: Improve responsiveness when showing single image without thumbnail bar.
Apr 6 2020, 3:53 PM · Gwenview
sandsmark closed D28374: Fix hang on exit when viewing huge folder.
Apr 6 2020, 3:52 PM · Gwenview
sandsmark closed D28376: Make it possible to shut up gwenview with e.g. kdebugdialog.
Apr 6 2020, 3:49 PM · Gwenview

Apr 1 2020

aichingm updated the diff for D28480: Add save and reset state functionality to the crop tool.

Now deleting the state in the destructor

Apr 1 2020, 8:46 PM · Gwenview
aichingm requested review of D28480: Add save and reset state functionality to the crop tool.
Apr 1 2020, 11:39 AM · Gwenview

Mar 30 2020

davidedmundson added a comment to D17732: Respect animation settings.
+        KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));
Mar 30 2020, 2:15 PM · Gwenview
ngraham added a comment to D17732: Respect animation settings.

Looks sane enough. Feel free to open a diff on Breeze and just tag Breeze as the reviewer. We'll take a look!

Mar 30 2020, 2:06 PM · Gwenview
ngraham accepted D28373: Improve responsiveness when showing single image without thumbnail bar.

Stable branch

Mar 30 2020, 2:05 PM · Gwenview
ngraham accepted D28374: Fix hang on exit when viewing huge folder.

Land on the stable branch please!

Mar 30 2020, 2:02 PM · Gwenview
ngraham added a comment to D28375: Don't fill disk with thumbnails if thumbnail saving is turned off.

Yikes. Much safer. Please also remove the "Be careful:" warning text for this option on the config dialog's advanced page, as it no longer applies.

Mar 30 2020, 1:59 PM · Gwenview
ngraham accepted D28376: Make it possible to shut up gwenview with e.g. kdebugdialog.

I'm okay with having it off by default.

Mar 30 2020, 1:56 PM · Gwenview