Fri, May 29
All good now, sorry for the wait.
Wed, May 27
Sorry to bother, what's the status of this review?
Sun, May 24
Sat, May 16
- make help text smaller
- stop editing unnecessary files
Thu, May 14
Just a few more changes required:
So sorry I missed your update to this patch! I will re-review.
Apr 20 2020
Apr 19 2020
Great job with this patch! May it be the first of many. :)
Apr 17 2020
- Add better description for color correction setting
I'm new to the phabricator workflow, where would i provide that information?
Apr 14 2020
Thanks for your patience here. I've had the same use case in the past and this is pretty much how I would implement it too. I just have one insignificant comment that could be addressed (see below).
Sorry for missing this.
Apr 13 2020
Again, fairly trivial, I hope.
This should be a fairly trivial and straightforward fix, fwiw. And without this and the other patches I can't really run gwenview with ubsan and asan.
Apr 7 2020
And FWIW, after https://phabricator.kde.org/D28373 landed animations are smooth where they used to bother me, so this isn't really that important for me personally anymore. But being able to turn off animations (without cluttering the gwenview settings more) is nice anyways.
Apr 6 2020
Apr 1 2020
Now deleting the state in the destructor
Mar 30 2020
+ KSharedConfig::Ptr config = KSharedConfig::openConfig(QStringLiteral("kdeglobals"));
Looks sane enough. Feel free to open a diff on Breeze and just tag Breeze as the reviewer. We'll take a look!
Land on the stable branch please!
Yikes. Much safer. Please also remove the "Be careful:" warning text for this option on the config dialog's advanced page, as it no longer applies.
I'm okay with having it off by default.