Sun, Aug 18
If there are no further comments or objections, I will land this in a week.
Wed, Aug 14
Actually, I think it is, since when using portals, you'll see the standard save dialog, not our customized one.
Tue, Aug 13
Question for VDG people: is the settings UI unnecessary? I'm now wondering if it would make more sense to only put the UI in the Save as dialog, and not even bother with showing it elsewhere.
Mon, Aug 12
I believe I've just recently had some noticeable image quality loss after doing a save in Gwenview; the fact that it would happen was unbeknownst to me.
Populate the quality in the Save As dialog's spinbox correctly every time
Don't set quality when saving a non-JPEG image (it triggers https://bugreports.qt.io/browse/QTBUG-43618)
Fix remaining issues; ready for review
Doesn't work unless the image is somehow otherwise changed; fixing
Add custom quality chooser UI in Save As dialog when saving as a JPEG file
It is implemented purely as a setting in the settings dialog rather than a new
part of the save dialog because that would add a kdelibs4support dependency and
not be compatible with Flatpak portals.
Jul 23 2019
Jul 20 2019
Thanks, shipit! 👍
Remove QScreen includes.
Thanks! Almost done...
Revert screenGeometry() changes to keep Qt 5.9 dependency, add appropriate comments.
Jul 19 2019
Darn. Don't port those, then, and instead just add a TODO that says what we should do when we're going to bump the dep to a newer Qt version.
Thanks in advance for your answer.
Use constant iterators.
Jul 18 2019
the description needs to be changed now
Revert Qt 5.9 -> 5.10 and byteCount() -> sizeInBytes() change.
I vote against bumping Qt to 5.10 just because of a single obsolete method. Qt 5.9 is a LTS release, which is supported until May 2020. E.g. I'm using openSUSE Leap 15.1, which uses 5.9.7 . Also, QImage::sizeInBytes() is recommend for images bigger 2GiB, but I never had success to open images that big with Gwenview.
Jul 7 2019
Jul 6 2019
Jul 5 2019
Jul 3 2019
I added https://phabricator.kde.org/D22251 for making it optional.
Jun 28 2019
Good catch, thanks.
Jun 27 2019