GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Today

tommo updated the diff for D21330: Use the embedded thumbnail for preview even if it's too small.

Sry, I should really enable Kate's spell checking.

Thu, May 23, 6:58 AM · Documentation, Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Thu, May 23, 6:49 AM · Gwenview
yurchor added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

Thanks in advance for fixing this minor typo.

Thu, May 23, 6:46 AM · Documentation, Gwenview
tommo updated subscribers of D21285: Remove redundant QImage::loadFromData().

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated subscribers of D21284: Accelerate thumnailgenerator when loading RAW files.

@ngraham Missed?

Thu, May 23, 6:32 AM · Gwenview
tommo updated the diff for D21330: Use the embedded thumbnail for preview even if it's too small.

Docs updated. Need to apply https://phabricator.kde.org/D21329 first, to avoid conflict.

Thu, May 23, 6:30 AM · Documentation, Gwenview
tommo updated the diff for D21337: Do not re-use previously generated thumbnails in case of error.
Thu, May 23, 4:53 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Thu, May 23, 4:49 AM · Gwenview

Yesterday

ngraham requested changes to D21337: Do not re-use previously generated thumbnails in case of error.

Perfect, thanks. Works fine and seems like an appropriate solution. Please fix a typo in the comment and then this is good to go!

Wed, May 22, 5:16 PM · Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 5:10 PM · Gwenview
ngraham added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

Counter-proposal: Only generate high resolution thumbs if the user cares to not throw them away when closing gwenview, that is when deleteThumbnailCacheOnExit() is set to false. If set to true, always use the embedded thumbnail regardless of its size.

Wed, May 22, 5:07 PM · Documentation, Gwenview
tommo added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

I really can't get used to high quality thumbnails. The problem with your approach is that it puts (IMO unnecessary) load on memory bus and CPU: First we would crawl through all files in the directory to quickly display the embedded thumbnail and in a second run we open and decode picture by picture just for generating nice high quality thumbs. This reminds me of https://bugs.kde.org/show_bug.cgi?id=331435

Wed, May 22, 4:48 PM · Documentation, Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 4:36 PM · Gwenview
tommo added a comment to D21337: Do not re-use previously generated thumbnails in case of error.

I just followed the steps to repeat described in the bug, i.e. create an empty file: touch test.jpg

Wed, May 22, 4:29 PM · Gwenview
ngraham added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

I think blurry is better than pixellated.

Wed, May 22, 4:27 PM · Documentation, Gwenview
ngraham closed D21292: Remove orphaned member.
Wed, May 22, 3:31 PM · Gwenview
ngraham accepted D21292: Remove orphaned member.

Nice catch!

Wed, May 22, 3:29 PM · Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:26 PM · Gwenview
ngraham added a comment to D21337: Do not re-use previously generated thumbnails in case of error.

Thanks, this makes sense. Is there an easy way to force thumbnail generation to fail for an image to test this?

Wed, May 22, 3:24 PM · Gwenview
ngraham closed D21333: Update copyright year to 2019.
Wed, May 22, 1:15 PM · Gwenview
ngraham accepted D21333: Update copyright year to 2019.
Wed, May 22, 1:15 PM · Gwenview
tommo added a watcher for Gwenview: tommo.
Wed, May 22, 11:55 AM
tommo updated the summary of D21337: Do not re-use previously generated thumbnails in case of error.
Wed, May 22, 11:52 AM · Gwenview
tommo requested review of D21337: Do not re-use previously generated thumbnails in case of error.
Wed, May 22, 11:43 AM · Gwenview
tommo requested review of D21333: Update copyright year to 2019.
Wed, May 22, 10:39 AM · Gwenview
tommo added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

P.S.: The unit test fails expectedly. However, I'd first like to get some feedback before fixing it.

Wed, May 22, 10:00 AM · Documentation, Gwenview
tommo set the repository for D21292: Remove orphaned member to R260 Gwenview.
Wed, May 22, 6:45 AM · Gwenview
tommo added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 5:49 AM · Gwenview
tommo added a comment to D21330: Use the embedded thumbnail for preview even if it's too small.

Attached is a screenshot demonstrating this suggestion. Even at 512px big thumbs, the embedded thumbnail (160x120) is big enough to get a rough idea of what's on the picture: A landscape, an animal, maybe which one? (not sure if you can tell the difference between a horse and a donkey, but IMO this isn't the purpose of a thumbnail preview anyway.)

Wed, May 22, 5:36 AM · Documentation, Gwenview
tommo requested review of D21330: Use the embedded thumbnail for preview even if it's too small.
Wed, May 22, 5:20 AM · Documentation, Gwenview
ngraham added inline comments to D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 4:53 AM · Gwenview
tommo updated the summary of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:56 AM · Gwenview
tommo added a comment to D21329: Correctly crop embedded thumbs for Canon JPEGs.

Example Canon thumbnail attached:

Wed, May 22, 3:50 AM · Gwenview
tommo requested review of D21329: Correctly crop embedded thumbs for Canon JPEGs.
Wed, May 22, 3:49 AM · Gwenview

Tue, May 21

ngraham added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

My bad, sorry. I should have done a closer code review. Fixed with 3a5cd96bfc92741e6fb6285b516934ffb76ae56f.

Tue, May 21, 6:31 PM · Gwenview
cfeck added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

There are still code styling issues, but too late...

Tue, May 21, 5:38 PM · Gwenview
ngraham closed D21260: Accelerate thumnailgenerator when loading JpegContent.
Tue, May 21, 5:35 PM · Gwenview
ngraham accepted D21260: Accelerate thumnailgenerator when loading JpegContent.

Thanks very much!

Tue, May 21, 5:34 PM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Unit test fixed. Unfortunately I can't avoid QFile::readAll() entirely. When the same file is saved as the one already open through mem-mapping, we are in trouble when writing to that file: "It is unspecified whether modifications made to the file made after the mapping is created will be visible through the mapped memory." Apparently this might be the case and causes strange behavior when working with the input data later on. And I can't simply unmap the input data, as it may be needed for transformation. Thus postpone QFile::readAll() to JpegContent::save(). At least it speeds up the thumbnail generator.

Tue, May 21, 4:34 PM · Gwenview

Mon, May 20

ngraham requested changes to D21260: Accelerate thumnailgenerator when loading JpegContent.

Thanks very much! However this patch makes the jpegcontenttest crash. Looks like it needs some adjustment to account for your changes.

Mon, May 20, 7:25 PM · Gwenview

Sun, May 19

tommo updated the diff for D21292: Remove orphaned member.
Sun, May 19, 3:42 PM · Gwenview
tommo requested review of D21292: Remove orphaned member.
Sun, May 19, 2:32 PM · Gwenview
tommo requested review of D21285: Remove redundant QImage::loadFromData().
Sun, May 19, 9:40 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Sun, May 19, 8:36 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Sun, May 19, 8:33 AM · Gwenview
tommo updated the summary of D21284: Accelerate thumnailgenerator when loading RAW files.
Sun, May 19, 8:33 AM · Gwenview
tommo requested review of D21284: Accelerate thumnailgenerator when loading RAW files.
Sun, May 19, 8:32 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Typo.

Sun, May 19, 3:58 AM · Gwenview
tommo updated the diff for D21260: Accelerate thumnailgenerator when loading JpegContent.

Use private mapping and handle nullptr.

Sun, May 19, 3:49 AM · Gwenview

Sat, May 18

cfeck added a comment to D21260: Accelerate thumnailgenerator when loading JpegContent.

Also, please use MapPrivate.

Sat, May 18, 9:32 AM · Gwenview