Oct 17 2018
Oct 16 2018
Moved vertical item centering from CropWidget to FlowLayout
Removed some superfluous layout settings
Some style fixes
Oct 13 2018
Oct 12 2018
simplify, leave only invokeMethod() -> QTimer::singleShot() change
Oct 11 2018
Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);
QMetaObject::invokeMethod takes function pointers since Qt 5.10
Oct 10 2018
Oct 9 2018
Just hijacking this Diff b/c I see several places where this can be improved :)
Oct 6 2018
Whoops, I had forgotten about that!
What's the difference to T9226?
Oct 2 2018
No objections from me. 🙂
Excellent. Final review, @muhlenpfordt?
My latest change fixes the canZoom() issue
Checking for canZoom() for all zoom logic
Oct 1 2018
Looks good to me and scrolling with Shift/Alt+wheel is still possible.
Just one thing I noticed - see inline comment.
Alright, I built a new branch and just commited all my changes to that, diff seems to look good
Includes all changes to the config and the code to enable the zoom option
How do I push my latest commit to the remote branch? It seems to be replacing all my old commits with the most recent.
- Cleaned up imageviewconfigpage.ui
Sep 30 2018
Wow, this works great! Did you use Qt Creator to change the .ui file, though? The diff is very large for such a small UI change. I'd prefer a hand-edited file so that the change is manageable to review.
Sep 29 2018
Fix some issues
Sep 28 2018
Sorry it's taken me so long to get to this. One thing I notice is the paradigm of putting layouts inside their own widgets. Generally I don't think this is necessary. Also, widgets that will become a part of a layout don't need to be given a parent; Qt automatically re-parents them to the layout you add them to, so the parent argument can simply be left out.