Sat, Mar 16
No worries, and thanks for the attempt! Once they're in, that'll really help other QWidgets-based KDE apps.
I started to transfer the gestures to the framework, but I cannot promise anything.
I imagine by adding what's here into the framework first, and then later raising the Gwenview frameworks dependency high enough and using them from there framework.
Thanks for the patch. How is the gesture code going to get into KWidgetAddons now?
Thanks so much for your patience on this. I think it's ready to land now!
Sun, Mar 10
Move the gestureEvent(QGestureEvent* event) and event(QEvent* event) functions from documentview.cpp and thumbnailview.cpp to the Touch class.
I think this is now ready to land.
Sat, Mar 9
I agree. @steffenh, any chance you'd be interested in that? Then, we could use these very nice gestures in Okular and Dolphin too. Since you've already done the hard work of de-duplicating the code and putting it into helper files, hopefully that shouldn't be too much effort, right?
Sun, Mar 3
+1 for adding gesture recognizers to KWidgetsAddons
- move some of the duplicate code in documentview and thumbnailview to functions in touch and touch_helper
- fix some typos
- fix copyright
Sat, Mar 2
Wed, Feb 27
Sun, Feb 24
Thanks, that makes sense. However, it might also make sense to add generic support for all of this into Qt itself, or at least into a KDE Framework (KWidgetsAddons maybe?). There are lots of other QWidgets-based KDE apps that could benefit from this stuff too! Dolphin and Okular immediately come to mind.
From a high level perspective, I share @rkflx's concern with the amount of duplicate code. ThumbnailView::viewportEvent() is almost entirely duplicate code from DocumentView::event(), for example. Can we refactor this into re-usable functions in touch or touch_helper or something?
I will have a look at this, perhaps I can move same code around.
Fri, Feb 22
Thanks, this works great now!
Test now, i can't reproduce behavior mentioned above.
Thu, Feb 21
Thanks @steffenh. I went back and re-tested everything and it all works *flawlessly* for me. Very impressive work. I really hope we can get it in for KDE Applications 19.04. I'll start on the code review:
Feb 20 2019
Oh no, you didn't do anything wrong at all. It's a Phabricator bug that your authorship information gets discarded when if you use git format-patch (Phab wants everyone to use arc; see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist).
Oh dear, sorry maybe I did something wrong uploading the git format patch. Timo Gurr <firstname.lastname@example.org>.
Thanks. Can you please provide your real name and email address so I can land your patch with correct authorship information?
Feb 19 2019
Sweet, will add the dep in another patch.
FTR: kra support comes from kimageformats plugins to qimage. so do other already listed mimetypes though - it's fine.
Feb 18 2019
Rebase on current master
Clever! Works great.
Just noticed this: should similar support be added into gvpart.desktop too?
Feb 13 2019
Feb 12 2019
modify existing desktop file instead of installing a new one
Feb 11 2019
@steffenh thanks for your patience here, and I'm sorry this hasn't landed yet. Could you rebase it on current master please? I'll redouble my efforts to test and rustle up some code reviewers for you.
Wouldn't it be better to add mime types to org.kde.gwenview.desktop during the build?
https://lxr.kde.org/ doesn't respond, so I can't find an example for now.