GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Oct 17 2018

clintmoyer updated the task description for T9889: Feature: Edit Metadata.
Oct 17 2018, 10:45 PM · Gwenview
clintmoyer updated the task description for T9889: Feature: Edit Metadata.
Oct 17 2018, 9:39 PM · Gwenview
clintmoyer updated the task description for T9889: Feature: Edit Metadata.
Oct 17 2018, 8:23 PM · Gwenview
clintmoyer created T9889: Feature: Edit Metadata.
Oct 17 2018, 8:00 PM · Gwenview
clintmoyer added a watcher for Gwenview: clintmoyer.
Oct 17 2018, 7:53 PM

Oct 16 2018

muhlenpfordt updated the diff for D15398: Use FlowLayout for Crop toolbar.

Moved vertical item centering from CropWidget to FlowLayout
Removed some superfluous layout settings
Some style fixes

Oct 16 2018, 6:59 AM · Gwenview

Oct 13 2018

gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 12:17 PM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 8:49 AM · Gwenview
gregormi added a reviewer for D16172: WIP: Add the transposed aspect ratio of current image to combobox: Gwenview.
Oct 13 2018, 8:17 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 8:16 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 8:14 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 8:09 AM · Gwenview
gregormi updated the summary of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 8:06 AM · Gwenview
gregormi requested review of D16172: WIP: Add the transposed aspect ratio of current image to combobox.
Oct 13 2018, 7:58 AM · Gwenview

Oct 12 2018

ngraham renamed T9226: Unify icon/folder views from Unifiy folder views to Unify icon/folder views.
Oct 12 2018, 11:39 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
volkov updated the summary of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Oct 12 2018, 2:56 PM · Gwenview
volkov updated the diff for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

simplify, leave only invokeMethod() -> QTimer::singleShot() change

Oct 12 2018, 2:55 PM · Gwenview

Oct 11 2018

volkov added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

Yes, but gwenview requires at least 5.9.
And code is longer with QMetaObject::invokeMethod, compare:
QTimer::singleShot(0, this, &FileOpsContextManagerItem::updateActions);
and
QMetaObject::invokeMethod(this, &FileOpsContextManagerItem::updateActions, Qt::QueuedConnection);

Oct 11 2018, 10:44 AM · Gwenview
broulik added a comment to D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.

QMetaObject::invokeMethod takes function pointers since Qt 5.10

Oct 11 2018, 10:26 AM · Gwenview

Oct 10 2018

drod added a member for Gwenview: drod.
Oct 10 2018, 9:17 PM
shubham added reviewers for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg: rkflx, ngraham.
Oct 10 2018, 4:00 PM · Gwenview
volkov added a reviewer for D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg: Gwenview.
Oct 10 2018, 3:59 PM · Gwenview
volkov requested review of D16109: Get rid of QMetaObject::invokeMethod() with 'const char *member' arg.
Oct 10 2018, 3:58 PM · Gwenview

Oct 9 2018

kfunk added a comment to D16056: Fix windows compilation of gwenview.

Just hijacking this Diff b/c I see several places where this can be improved :)

Oct 9 2018, 8:00 AM · Windows, Gwenview
sdepiets added a project to D16056: Fix windows compilation of gwenview: Windows.
Oct 9 2018, 6:16 AM · Windows, Gwenview
sdepiets requested review of D16056: Fix windows compilation of gwenview.
Oct 9 2018, 5:53 AM · Windows, Gwenview

Oct 6 2018

ngraham triaged T9226: Unify icon/folder views as Wishlist priority.
Oct 6 2018, 11:06 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a comment to T9226: Unify icon/folder views.
In T9226#151961, @rkflx wrote:

@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.

From a high-level view it makes sense, but once you dig into the interaction details and also how tightly this integrates with the rest of the codebase (thumbnailing, custom sorting and filtering models, optimized image grid, integration with the data models used in other parts, reuse for the thumbnail strip etc.), you'll find that there are features unique to Gwenview. It's not just Dolphin with thumbnails turned on and a darker background.

Oct 6 2018, 11:06 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham closed T9806: Standardize on a single file/folder/icon view engine that can be re-used across all KDE software as Invalid.

Whoops, I had forgotten about that!

Oct 6 2018, 10:54 PM · Plasma, Frameworks, Gwenview, Dolphin, KDE Applications
nicolasfella added a comment to T9806: Standardize on a single file/folder/icon view engine that can be re-used across all KDE software.

What's the difference to T9226?

Oct 6 2018, 10:51 PM · Plasma, Frameworks, Gwenview, Dolphin, KDE Applications
ngraham triaged T9806: Standardize on a single file/folder/icon view engine that can be re-used across all KDE software as Wishlist priority.
Oct 6 2018, 10:39 PM · Plasma, Frameworks, Gwenview, Dolphin, KDE Applications
ngraham created T9806: Standardize on a single file/folder/icon view engine that can be re-used across all KDE software.
Oct 6 2018, 10:39 PM · Plasma, Frameworks, Gwenview, Dolphin, KDE Applications

Oct 2 2018

ngraham closed D15809: Add Zoom scroll wheel option.
Oct 2 2018, 10:28 PM · Gwenview
muhlenpfordt added a comment to D15809: Add Zoom scroll wheel option.

No objections from me. 🙂

Oct 2 2018, 5:05 PM · Gwenview
ngraham accepted D15809: Add Zoom scroll wheel option.

Excellent. Final review, @muhlenpfordt?

Oct 2 2018, 4:41 PM · Gwenview
chrissuran added a comment to D15809: Add Zoom scroll wheel option.

My latest change fixes the canZoom() issue

Oct 2 2018, 4:39 PM · Gwenview
sourabhboss added a comment to D15809: Add Zoom scroll wheel option.

good job

Oct 2 2018, 5:41 AM · Gwenview
chrissuran updated the diff for D15809: Add Zoom scroll wheel option.

Checking for canZoom() for all zoom logic

Oct 2 2018, 5:16 AM · Gwenview

Oct 1 2018

muhlenpfordt added a comment to D15398: Use FlowLayout for Crop toolbar.

Sorry it's taken me so long to get to this. One thing I notice is the paradigm of putting layouts inside their own widgets. Generally I don't think this is necessary.

Oct 1 2018, 7:00 AM · Gwenview
muhlenpfordt added a reviewer for D15809: Add Zoom scroll wheel option: Gwenview.

Looks good to me and scrolling with Shift/Alt+wheel is still possible.
Just one thing I noticed - see inline comment.

Oct 1 2018, 6:45 AM · Gwenview
chrissuran added a comment to D15809: Add Zoom scroll wheel option.

Alright, I built a new branch and just commited all my changes to that, diff seems to look good

Oct 1 2018, 5:02 AM · Gwenview
chrissuran updated the diff for D15809: Add Zoom scroll wheel option.

Includes all changes to the config and the code to enable the zoom option

Oct 1 2018, 5:01 AM · Gwenview
chrissuran removed a reviewer for D15809: Add Zoom scroll wheel option: Gwenview.

How do I push my latest commit to the remote branch? It seems to be replacing all my old commits with the most recent.

Oct 1 2018, 4:47 AM · Gwenview
chrissuran updated the summary of D15809: Add Zoom scroll wheel option.
Oct 1 2018, 4:45 AM · Gwenview
chrissuran updated the diff for D15809: Add Zoom scroll wheel option.
  • Cleaned up imageviewconfigpage.ui
Oct 1 2018, 4:28 AM · Gwenview

Sep 30 2018

ngraham added a comment to D15809: Add Zoom scroll wheel option.

Wow, this works great! Did you use Qt Creator to change the .ui file, though? The diff is very large for such a small UI change. I'd prefer a hand-edited file so that the change is manageable to review.

Sep 30 2018, 3:50 PM · Gwenview
ngraham added a reviewer for D15809: Add Zoom scroll wheel option: Gwenview.
Sep 30 2018, 4:36 AM · Gwenview

Sep 29 2018

steffenh updated the diff for D13901: Touch support for Gwenview.

Fix some issues

Sep 29 2018, 5:53 AM · Gwenview

Sep 28 2018

ngraham added a comment to D15398: Use FlowLayout for Crop toolbar.

Sorry it's taken me so long to get to this. One thing I notice is the paradigm of putting layouts inside their own widgets. Generally I don't think this is necessary. Also, widgets that will become a part of a layout don't need to be given a parent; Qt automatically re-parents them to the layout you add them to, so the parent argument can simply be left out.

Sep 28 2018, 9:46 PM · Gwenview
volkov closed D15802: Add missing emit keyword.
Sep 28 2018, 10:34 AM · Gwenview