GwenviewProject
ActivePublic

Details

Description

Gwenview is KDE's simple yet powerful image viewer.

Quick links to Bugzilla tickets:

Recent Activity

Wed, Jul 18

rkflx added a comment to T9226: Unifiy folder views.

@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.

Wed, Jul 18, 10:49 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
nicolasfella updated the task description for T9226: Unifiy folder views.
Wed, Jul 18, 3:01 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a project to T9226: Unifiy folder views: Frameworks.
Wed, Jul 18, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham updated the task description for T9226: Unifiy folder views.
Wed, Jul 18, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
nicolasfella created T9226: Unifiy folder views.
Wed, Jul 18, 2:41 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma

Tue, Jul 17

ngraham added a comment to D6083: Bump max thumbnail size to 512px.

Whoops, my bad! It has been so long since I last saw this that I forgot completely what it was about and trusted the Phabricator metadata.

Tue, Jul 17, 4:26 AM · Gwenview

Mon, Jul 16

rkflx requested changes to D6083: Bump max thumbnail size to 512px.

Thanks for coming back to this. Yes, HiDPI support is still in progress. If you could help with the thumbnail-spec/caching side of things that would be great!

Mon, Jul 16, 10:15 PM · Gwenview
rkflx added a comment to T8220: Zoom buttons out of sync sometimes.

Clicking again will undo the zooming action (or zoom to 100% if there is no previous zoom level) and unpress the button.

Mon, Jul 16, 1:05 PM · Gwenview

Fri, Jul 13

rkflx added a comment to T8220: Zoom buttons out of sync sometimes.
  • Click Fill or 100% button and middle-click on image ⇨ Fit button toggles, Fill/100% keeps pressed
Fri, Jul 13, 3:21 PM · Gwenview

Sun, Jul 8

huoni added a comment to D11877: Allow dragging from View mode to external applications.

Finally got around to summarize the cursor issues:

  1. When moving very slowly while initiating a drag, the ForbiddenCursor would appear briefly until you moved the mouse further along. I think this is an issue in Qt, as we can observe the same behaviour in Dolphin. In QBasicDrag::drag, DragCopyCursor is set, then QBasicDrag::updateCursor changes the cursor to ForbiddenCursor, until finally QBasicDrag::updateCursor updates to the final cursor, e.g. DragCopyCursor. We can avoid the flickering by always displaying ForbiddenCursor (see next point).
  2. https://bugs.kde.org/show_bug.cgi?id=386034 proposed that "the image should not be able to be dropped onto itself.", which your patch still allows. As that's actually more related to 131d25855e11, I'll simply fix this in a separate Diff, see D13724.
  3. ClosedHandCursor shown when trying to drop to Dolphin: Turns out that's the correct cursor for the default case of moving objects, which is set implicitly by QGraphicsView. For dragging from the ThumbnailView it works fine, because there copying is set as the default action. That's where there actually is a difference to what your patch is implementing ;) In D13725 I'm doing some further refinements to the dragging of thumbnails, and replicate that change for dragging from the canvas too, which should give us the more pleasant DragCopyCursor.
  4. Not strictly related, but as I mentioned it above: The spurious ClosedHandCursor after showing the context menu will be fixed with D13723.
  5. Slowly starting to drag so the ClosedHandCursor shows, the ClosedHandCursor is shown after the drag. Again, here I believe the issue might be in Qt. qDebug() shows that the cursor is correctly (re)set, but somehow the change takes effect only after moving the mouse again. Workaround which seems to fix the problem in D13726.
Sun, Jul 8, 12:47 AM · Gwenview

Mon, Jun 25

rkflx added a comment to D11877: Allow dragging from View mode to external applications.

Finally got around to summarize the cursor issues:

Mon, Jun 25, 9:48 PM · Gwenview

Sun, Jun 24

rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Spectacle also uses KIPI plugins. A similar patch might be useful there as well :)

Sun, Jun 24, 9:44 PM · Gwenview
nicolasfella added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Spectacle also uses KIPI plugins. A similar patch might be useful there as well :)

Sun, Jun 24, 4:33 PM · Gwenview
huoni added a comment to D11877: Allow dragging from View mode to external applications.

Final polishing LGTM. I'll submit the cursor fixes in separate Diffs, don't worry about it ;) Thanks again for the patch, and sorry it took so long to review…

Sun, Jun 24, 1:28 AM · Gwenview
huoni closed D11877: Allow dragging from View mode to external applications.
Sun, Jun 24, 1:28 AM · Gwenview

Sat, Jun 23

rkflx accepted D11877: Allow dragging from View mode to external applications.

Final polishing LGTM. I'll submit the cursor fixes in separate Diffs, don't worry about it ;) Thanks again for the patch, and sorry it took so long to review…

Sat, Jun 23, 10:12 PM · Gwenview
huoni added a comment to D11877: Allow dragging from View mode to external applications.

The cursor problem is kind of solved. There is still some flickering sometimes.

Nice. Let me look into this in the next days, then we can decide whether we can fix things now or simply open a bug to work on it later…

I identified 5 different cursor issues (and lots of unrelated deficiencies…), and I figured out how to fix 4 of them. I'll keep you posted.

Sat, Jun 23, 5:15 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • resetDragDetection rename
Sat, Jun 23, 5:14 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • const
  • better way of working with KFileItem/KFileItemList
  • lazy initialize thumbnail provider
  • check for mDrag closer to its usage
Sat, Jun 23, 5:11 AM · Gwenview

Jun 21 2018

rkflx added a comment to D11877: Allow dragging from View mode to external applications.

The cursor problem is kind of solved. There is still some flickering sometimes.

Nice. Let me look into this in the next days, then we can decide whether we can fix things now or simply open a bug to work on it later…

Jun 21 2018, 11:25 PM · Gwenview

Jun 19 2018

rkflx requested changes to D11877: Allow dragging from View mode to external applications.

We are pretty close now, just some final polishing 👍

Jun 19 2018, 10:25 PM · Gwenview

Jun 10 2018

huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Remove redundent comments
  • Improve variable naming, code readability
Jun 10 2018, 12:15 AM · Gwenview

Jun 9 2018

huoni added a comment to D11877: Allow dragging from View mode to external applications.

ThumbnailProvider worked nicely. I was initially put off by the complicated use in ThumbnailView which is why I didn't try it to begin with.

Jun 9 2018, 3:18 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Clean up KFileItemList code
Jun 9 2018, 3:13 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Change to using ThumbnailProvider to generate drag pix
  • Fix stuck cursor after dragging an image
Jun 9 2018, 3:04 AM · Gwenview

Jun 8 2018

huoni planned changes to D11877: Allow dragging from View mode to external applications.

Just one note regarding KIO::PreviewJob: This is only a small part of ThumbnailProvider, which seems to contain lots of additional code for special cases. For example this can be observed for fish://, where your approach fails to provide a pixmap, while you'd get a proper thumbnail when dragging from the Thumbnail Bar. I'm sure there are many more cases.

Would it be possible to create a new ThumbnailProvider upon initiating the drag, connect its thumbnailLoaded signal to setPixmap, and then appendItems? That would be the next thing I would try, as it uses proven code and avoids creating a thumbnail when not starting to drag at all.

Jun 8 2018, 11:06 PM · Gwenview
rkflx added a comment to D11877: Allow dragging from View mode to external applications.
  • Don't drag if document failed to load
  • Update to use MimeTypeUtils::selectionMimeData
  • Respect mimimum drag distance
  • Use DragPixmapGenerator
Jun 8 2018, 12:59 PM · Gwenview

Jun 4 2018

rkflx closed D13213: Add possibility to sort by descending order.
Jun 4 2018, 7:07 PM · Gwenview

Jun 3 2018

huoni added a comment to D11877: Allow dragging from View mode to external applications.

Thanks for the update ;)

Any ideas would be helpful.

I'll try to look into it later.

Jun 3 2018, 10:57 AM · Gwenview
rkflx added a comment to D11879: Allow dragging files/folders to View mode.

@huoni The bug reporter likes your patch 👍: https://bugs.kde.org/show_bug.cgi?id=169408#c8

Jun 3 2018, 10:40 AM · Gwenview
rkflx added a comment to D11877: Allow dragging from View mode to external applications.

Thanks for the update ;)

Jun 3 2018, 6:28 AM · Gwenview
huoni added a comment to D11877: Allow dragging from View mode to external applications.

I kept everything in DocumentView because I wanted to support dragging a video.

Jun 3 2018, 6:20 AM · Gwenview
rkflx closed D13197: Prompt to install kipi-plugins when the share button is clicked .
Jun 3 2018, 6:19 AM · Gwenview
huoni updated the diff for D11877: Allow dragging from View mode to external applications.
  • Don't drag if document failed to load
  • Update to use MimeTypeUtils::selectionMimeData
  • Respect mimimum drag distance
  • Use DragPixmapGenerator
Jun 3 2018, 6:17 AM · Gwenview

Jun 2 2018

huoni closed D11879: Allow dragging files/folders to View mode.
Jun 2 2018, 11:31 PM · Gwenview
faridb added a comment to D13213: Add possibility to sort by descending order.

@rkflx Thanks for reviewing and accepting the patch! This is my second patch and your feedback and your advices are encouraging me to keep contributing :-).

Jun 2 2018, 10:53 PM · Gwenview
rkflx accepted D13213: Add possibility to sort by descending order.

Excellent. I tested everything again, and the issue with the folders not appearing first anymore is now solved.

Jun 2 2018, 10:18 PM · Gwenview
faridb updated the diff for D13213: Add possibility to sort by descending order.

I made the changes you requested in your inline comments.

Jun 2 2018, 9:54 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Jun 2 2018, 8:52 PM · Gwenview
faridb added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

I updated the summary. Is it a suitable commit message?

Jun 2 2018, 8:45 PM · Gwenview
faridb updated the summary of D13197: Prompt to install kipi-plugins when the share button is clicked .
Jun 2 2018, 8:40 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Ah, one more thing: You might want to update the summary a bit to reflect the current state of the patch, as it will become the commit message. Simply click on Edit Revision on the top.

Jun 2 2018, 8:32 PM · Gwenview
rkflx accepted D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Jun 2 2018, 8:30 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

I created a separate Diff for the bug fix at D13289.

Jun 2 2018, 8:27 PM · Gwenview
rkflx added a comment to D13213: Add possibility to sort by descending order.

Great, LGTM now except for two minor comments.

Jun 2 2018, 6:56 PM · Gwenview
rkflx added a comment to D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Jun 2 2018, 6:56 PM · Gwenview
rkflx added inline comments to D11879: Allow dragging files/folders to View mode.
Jun 2 2018, 6:56 PM · Gwenview
faridb updated the diff for D13197: Prompt to install kipi-plugins when the share button is clicked .

Rebase on D13252

Jun 2 2018, 6:25 PM · Gwenview
faridb added a dependent revision for D13213: Add possibility to sort by descending order: D13283: Add possibility to sort folders first.
Jun 2 2018, 12:16 PM · Gwenview
faridb updated the diff for D13213: Add possibility to sort by descending order.

Thanks for your detailed feedback! I have made the changes you have requested in your inline comments.
I have also added the ability to sort folders first but I will create a separate revision for that.

Jun 2 2018, 10:38 AM · Gwenview