Wed, Jul 18
@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.
Tue, Jul 17
Whoops, my bad! It has been so long since I last saw this that I forgot completely what it was about and trusted the Phabricator metadata.
Mon, Jul 16
Thanks for coming back to this. Yes, HiDPI support is still in progress. If you could help with the thumbnail-spec/caching side of things that would be great!
Clicking again will undo the zooming action (or zoom to 100% if there is no previous zoom level) and unpress the button.
Fri, Jul 13
- Click Fill or 100% button and middle-click on image ⇨ Fit button toggles, Fill/100% keeps pressed
Sun, Jul 8
Mon, Jun 25
Finally got around to summarize the cursor issues:
Sun, Jun 24
Spectacle also uses KIPI plugins. A similar patch might be useful there as well :)
Sat, Jun 23
Final polishing LGTM. I'll submit the cursor fixes in separate Diffs, don't worry about it ;) Thanks again for the patch, and sorry it took so long to review…
- resetDragDetection rename
- better way of working with KFileItem/KFileItemList
- lazy initialize thumbnail provider
- check for mDrag closer to its usage
Jun 21 2018
Jun 19 2018
We are pretty close now, just some final polishing 👍
Jun 10 2018
- Remove redundent comments
- Improve variable naming, code readability
Jun 9 2018
ThumbnailProvider worked nicely. I was initially put off by the complicated use in ThumbnailView which is why I didn't try it to begin with.
- Clean up KFileItemList code
- Change to using ThumbnailProvider to generate drag pix
- Fix stuck cursor after dragging an image
Jun 8 2018
Jun 4 2018
Jun 3 2018
Thanks for the update ;)
I kept everything in DocumentView because I wanted to support dragging a video.
- Don't drag if document failed to load
- Update to use MimeTypeUtils::selectionMimeData
- Respect mimimum drag distance
- Use DragPixmapGenerator
Jun 2 2018
@rkflx Thanks for reviewing and accepting the patch! This is my second patch and your feedback and your advices are encouraging me to keep contributing :-).
Excellent. I tested everything again, and the issue with the folders not appearing first anymore is now solved.
I made the changes you requested in your inline comments.
I updated the summary. Is it a suitable commit message?
Ah, one more thing: You might want to update the summary a bit to reflect the current state of the patch, as it will become the commit message. Simply click on Edit Revision on the top.
I created a separate Diff for the bug fix at D13289.
Great, LGTM now except for two minor comments.
Rebase on D13252
Thanks for your detailed feedback! I have made the changes you have requested in your inline comments.
I have also added the ability to sort folders first but I will create a separate revision for that.