Change default shortcut for "Zoom To Fit" action
ClosedPublic

Authored by muhlenpfordt on Jul 18 2018, 10:08 AM.

Details

Summary

D14201 sets Ctrl+0 as system default shortcut for
Actual Size (KStandardAction::ActualSize). Ctrl+0 is
used by Cirkuit as shortcut for Zoom To Fit.
To avoid conflicts if D14201 is landed this patch changes Cirkuit's
default shortcut for Zoom To Fit to Ctrl+1.

Test Plan
  1. Open Cirkuit
  2. Check if no shortcut conflict warnings appear
  3. Load a file and check if zoom shortcuts work

Diff Detail

Repository
R657 Cirkuit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Jul 18 2018, 10:08 AM
muhlenpfordt created this revision.

The new shortcut is just a suggestion. If you wish to use another or even any better solution to a possible conflict, I can surely update this patch.

rkflx accepted this revision.Aug 9 2018, 1:12 PM

Thanks, works great. Unless @asturmlechner or @kmorwinski find anything wrong with this until Monday, let's land this to the frameworks branch.

As for the choice of shortcut, the new one should actually be easier to type with only one hand.

(Disclaimer: I originally proposed the change, because instead of adding it to Gwenview it makes more sense to standardize it everywhere. Cirkuit was the only app with a conflict, so I asked Peter to help resolve it.)

This revision is now accepted and ready to land.Aug 9 2018, 1:12 PM
This revision was automatically updated to reflect the committed changes.