QImageReader can rotate JPEG images according to their
orientation since Qt 5.5.
Details
Details
- Reviewers
muhlenpfordt - Group Reviewers
Gwenview - Commits
- R260:e38c2231877e: Use QImageReader's auto transform feature for JPEG images
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Branch
- autotransform
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2488 Build 2506: arc lint + arc unit
Comment Actions
Patch looks good to me, except for the thumbnail dimensions (see inline comment).
Independent of this patch: There's a bug when saving images with a transformation flag - the orientation is wrong in the new image (sometimes visible only after Gwenview restart).
| lib/thumbnailprovider/thumbnailgenerator.cpp | ||
|---|---|---|
| 181 | The image dimensions are not swapped by QImageReader. If you enable View → Thumbnail Details → Image Size in Browse Mode, the size does not match the orientation for images with e.g. ROT_90 flag. I think this switch is still needed. | |
Comment Actions
Thanks, works flawlessly now.
| lib/thumbnailprovider/thumbnailgenerator.cpp | ||
|---|---|---|
| 176 | Smart replacement for the switch statement. ;) | |