Differential D15239

Add override by clang-tidy's modernize-use-override
ClosedPublic
Actions

Authored by volkov on Sep 3 2018, 11:17 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R260:be99a40e5ff3: Add override by clang-tidy's modernize-use-override

Diff Detail

Repository

Branch

add-override

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2463
Build 2481: arc lint + arc unit

volkov created this revision.Sep 3 2018, 11:17 AM

Restricted Application added a project: Gwenview. · View Herald TranscriptSep 3 2018, 11:17 AM

volkov requested review of this revision.Sep 3 2018, 11:17 AM

Harbormaster completed remote builds in B2463: Diff 40907.Sep 3 2018, 11:17 AM

volkov added a reviewer: Gwenview.Sep 3 2018, 11:19 AM

Looks good, compiles and makes the code more consistent.

This revision is now accepted and ready to land.Sep 4 2018, 7:32 AM

volkov closed this revision.Sep 4 2018, 10:40 AM

Revision Contents
Changeset List

			Path	Packages
M			app/abstractcontextmanageritem.h (2 lines)
M			app/fileopscontextmanageritem.h (2 lines)
M			app/filtercontroller.h (8 lines)
M			app/gvcore.h (2 lines)
M			app/imageopscontextmanageritem.h (2 lines)
M			app/infocontextmanageritem.h (2 lines)
M			app/kipiexportaction.h (2 lines)
M			app/kipiimagecollectionselector.h (4 lines)
M			app/kipiinterface.h (40 lines)
M			app/kipiinterface.cpp (8 lines)
M			app/kipiuploadwidget.h (2 lines)
M			app/preloader.h (2 lines)
M			app/renamedialog.h (2 lines)
M			app/saveallhelper.h (2 lines)
M			app/savebar.h (2 lines)
M			app/semanticinfocontextmanageritem.cpp (2 lines)
M			app/sidebar.h (2 lines)
M			importer/dialogpage.h (2 lines)
M			importer/documentdirfinder.h (2 lines)
M			importer/importer.h (2 lines)
M			importer/importerconfigdialog.h (2 lines)
M			importer/progresspage.h (2 lines)
M			importer/thumbnailpage.h (2 lines)
M			lib/abstractimageoperation.h (2 lines)
M			lib/abstractimageoperation.cpp (2 lines)
M			lib/binder.h (2 lines)
M			lib/contextmanager.h (2 lines)
M			lib/crop/cropimageoperation.h (2 lines)
M			lib/crop/cropwidget.h (2 lines)
M			lib/datewidget.h (2 lines)
M			lib/document/abstractdocumentimpl.h (2 lines)
M			lib/document/document.h (2 lines)
M			lib/document/documentfactory.h (2 lines)
M			lib/documentview/abstractdocumentviewadapter.h (2 lines)
M			lib/documentview/abstractrasterimageviewtool.h (2 lines)
M			lib/documentview/documentviewcontroller.h (2 lines)
M			lib/documentview/documentviewsynchronizer.h (2 lines)
M			lib/documentview/rasterimageviewadapter.h (2 lines)
M			lib/documentview/svgviewadapter.h (6 lines)
M			lib/hud/hudmessagebubble.h (2 lines)
M			lib/imagescaler.h (2 lines)
M			lib/invisiblebuttongroup.h (2 lines)
M			lib/print/printoptionspage.h (2 lines)
M			lib/resize/resizeimagedialog.h (2 lines)
M			lib/semanticinfo/semanticinfodirmodel.h (2 lines)
M			lib/semanticinfo/sorteddirmodel.h (2 lines)
M			lib/semanticinfo/tagitemdelegate.h (14 lines)
M			lib/semanticinfo/tagmodel.h (2 lines)
M			lib/semanticinfo/tagwidget.h (2 lines)
M			lib/slideshow.h (2 lines)
M			lib/thumbnailview/abstractthumbnailviewhelper.h (2 lines)
M			lib/thumbnailview/previewitemdelegate.h (2 lines)
M			lib/thumbnailview/thumbnailbarview.h (2 lines)
M			lib/thumbnailview/thumbnailslider.h (2 lines)
M			lib/thumbnailview/thumbnailview.h (4 lines)
M			lib/zoomslider.h (2 lines)
M			lib/zoomwidget.h (2 lines)
M			part/gvbrowserextension.h (2 lines)
M			tests/auto/documenttest.cpp (16 lines)

Diff 40907

app/abstractcontextmanageritem.h

Loading...

app/fileopscontextmanageritem.h

Loading...

app/filtercontroller.h

Loading...

app/gvcore.h

Loading...

app/imageopscontextmanageritem.h

Loading...

app/infocontextmanageritem.h

Loading...

app/kipiexportaction.h

Loading...

app/kipiimagecollectionselector.h

Loading...

app/kipiinterface.h

Loading...

app/kipiinterface.cpp

Loading...

app/kipiuploadwidget.h

Loading...

app/preloader.h

Loading...

app/renamedialog.h

Loading...

app/saveallhelper.h

Loading...

app/savebar.h

Loading...

app/semanticinfocontextmanageritem.cpp

Loading...

app/sidebar.h

Loading...

importer/dialogpage.h

Loading...

importer/documentdirfinder.h

Loading...

importer/importer.h

Loading...

importer/importerconfigdialog.h

Loading...

importer/progresspage.h

Loading...

importer/thumbnailpage.h

Loading...

lib/abstractimageoperation.h

Loading...

lib/abstractimageoperation.cpp

Loading...

lib/binder.h

Loading...

lib/contextmanager.h

Loading...

lib/crop/cropimageoperation.h

Loading...

lib/crop/cropwidget.h

Loading...

lib/datewidget.h

Loading...

lib/document/abstractdocumentimpl.h

Loading...

lib/document/document.h

Loading...

lib/document/documentfactory.h

Loading...

lib/documentview/abstractdocumentviewadapter.h

Loading...

lib/documentview/abstractrasterimageviewtool.h

Loading...

lib/documentview/documentviewcontroller.h

Loading...

lib/documentview/documentviewsynchronizer.h

Loading...

lib/documentview/rasterimageviewadapter.h

Loading...

lib/documentview/svgviewadapter.h

Loading...

lib/hud/hudmessagebubble.h

Loading...

lib/imagescaler.h

Loading...

lib/invisiblebuttongroup.h

Loading...

lib/print/printoptionspage.h

Loading...

lib/resize/resizeimagedialog.h

Loading...

lib/semanticinfo/semanticinfodirmodel.h

Loading...

lib/semanticinfo/sorteddirmodel.h

Loading...

lib/semanticinfo/tagitemdelegate.h

Loading...

lib/semanticinfo/tagmodel.h

Loading...

lib/semanticinfo/tagwidget.h

Loading...

lib/slideshow.h

Loading...

lib/thumbnailview/abstractthumbnailviewhelper.h

Loading...

lib/thumbnailview/previewitemdelegate.h

Loading...

lib/thumbnailview/thumbnailbarview.h

Loading...

lib/thumbnailview/thumbnailslider.h

Loading...

lib/thumbnailview/thumbnailview.h

Loading...

lib/zoomslider.h

Loading...

lib/zoomwidget.h

Loading...

part/gvbrowserextension.h

Loading...

tests/auto/documenttest.cpp

Loading...