mludwig (Michel Ludwig)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 28 2016, 2:16 PM (164 w, 1 d)
Availability
Available

Recent Activity

Sun, Feb 2

mludwig committed R468:6f098b9be7c0: Raise overall copyright year to 2020 (authored by mludwig).
Raise overall copyright year to 2020
Sun, Feb 2, 2:54 PM

Jan 12 2020

mludwig requested changes to D26426: [WIP] Port away from KDirOperator::ActionCollection.

Thanks for the patch!

Jan 12 2020, 3:59 PM · Kile

Jan 3 2020

mludwig added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

Thanks for the updated patch!

Jan 3 2020, 12:39 PM · Frameworks

Jan 1 2020

mludwig updated the diff for D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams.

Small fix to the documentation.

Jan 1 2020, 5:49 PM · Frameworks
mludwig requested review of D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams.
Jan 1 2020, 5:46 PM · Frameworks
mludwig added a comment to D26342: Allow overriding to disable auto language detection.

I'd support such a change for the BackgroundChecker as well. KTextEditor needs a way to do its own language detection or override the detected language.

Jan 1 2020, 4:44 PM · Frameworks
mludwig added a comment to D25495: Fix Sonnet autodetect failing on Indian langs.

You are right that in GuessLanguage::identify(const QString &text, const QStringList &suggestionsListIn), if a language without trigrams is not present in 'suggestionsListIn', it will never be 'guessed'.

Jan 1 2020, 2:58 PM · Frameworks
mludwig committed R39:3026a9caa868: Add "line-count" property to the ConfigInterface (authored by mludwig).
Add "line-count" property to the ConfigInterface
Jan 1 2020, 10:38 AM
mludwig closed D26321: Expose show-line-count in the ConfigInterface.
Jan 1 2020, 10:38 AM · Frameworks, KTextEditor, Kate

Dec 31 2019

mludwig added a comment to D26321: Expose show-line-count in the ConfigInterface.

I am ok with this , but in the long run, we want to change the behavior of the view's config interface to just dispatch to the internal config interface like for the document.
You missed to add the line-count to KTextEditor::ViewPrivate::configKeys()

Dec 31 2019, 1:51 PM · Frameworks, KTextEditor, Kate
mludwig updated the diff for D26321: Expose show-line-count in the ConfigInterface.

Add "line-count" to KTextEditor::ViewPrivate::configKeys()

Dec 31 2019, 1:50 PM · Frameworks, KTextEditor, Kate
mludwig requested review of D26321: Expose show-line-count in the ConfigInterface.
Dec 31 2019, 8:08 AM · Frameworks, KTextEditor, Kate

Dec 30 2019

mludwig committed R468:42ec22cce0ca: Use Kile's smart-new-line feature instead of KatePart's (authored by mludwig).
Use Kile's smart-new-line feature instead of KatePart's
Dec 30 2019, 8:27 AM

Dec 29 2019

mludwig committed R468:52c34f3b0655: Add modern configurations for the ViewHTML tool (authored by mludwig).
Add modern configurations for the ViewHTML tool
Dec 29 2019, 5:18 PM
mludwig committed R468:7ccfa33cb48d: Remove code that is no longer used (authored by mludwig).
Remove code that is no longer used
Dec 29 2019, 5:05 PM
mludwig committed R468:aa57b6f411e5: Update the built-in LaTeX documentation (authored by mludwig).
Update the built-in LaTeX documentation
Dec 29 2019, 5:05 PM

Dec 15 2019

mludwig committed R468:8e362f85f291: Simplify & improve TexDocDialog (authored by mludwig).
Simplify & improve TexDocDialog
Dec 15 2019, 9:46 AM

Dec 14 2019

mludwig committed R468:25b39ebb991e: Replace deprecated KRun::binaryName (authored by mludwig).
Replace deprecated KRun::binaryName
Dec 14 2019, 4:32 PM

Dec 1 2019

mludwig committed R468:793caf50f947: Fix margins of the remove-templates dialog (authored by mludwig).
Fix margins of the remove-templates dialog
Dec 1 2019, 3:57 PM
mludwig committed R468:7a55cf2d93c9: Fix overriding of existing templates (authored by mludwig).
Fix overriding of existing templates
Dec 1 2019, 2:57 PM
mludwig committed R468:483743aa9f19: Don't crash when deleting templates (authored by mludwig).
Don't crash when deleting templates
Dec 1 2019, 1:40 PM

Nov 22 2019

mludwig committed R468:7c050b5e306c: Remove dependency on KHTML (authored by mludwig).
Remove dependency on KHTML
Nov 22 2019, 8:48 AM

Nov 17 2019

mludwig committed R468:75dbd0c046a7: On Windows disable Sonnet's language auto-detection during the first run (authored by mludwig).
On Windows disable Sonnet's language auto-detection during the first run
Nov 17 2019, 3:09 PM

Nov 16 2019

mludwig added a comment to D25244: Implement ISpellChecker backend for Windows >= 8.

I've tried it out and works just fine! :)

Nov 16 2019, 11:26 AM · Frameworks

Nov 15 2019

mludwig added a comment to D25244: Implement ISpellChecker backend for Windows >= 8.

Some feedback?
Else I would just try that.
For me it worked fine (obviously).

Nov 15 2019, 11:59 AM · Frameworks

Nov 13 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

I've also got access to the partner center now. So, I can handle updates from now on. Thanks again!

Nov 13 2019, 5:45 AM · Kile, Windows

Nov 10 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Thanks!

Nov 10 2019, 12:59 PM · Kile, Windows
mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Build 566 works fine now.

Nov 10 2019, 7:38 AM · Kile, Windows

Nov 9 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

I've added a patch to disable Sonnet's language auto-detection during the first run of Kile.

Nov 9 2019, 7:16 AM · Kile, Windows
mludwig committed R877:7b55d895358f: Better disable Sonnet's language auto-detection in Kile itself (authored by mludwig).
Better disable Sonnet's language auto-detection in Kile itself
Nov 9 2019, 6:59 AM

Nov 4 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Thanks a lot, Christoph - that's very useful.

Nov 4 2019, 7:57 PM · Kile, Windows
mludwig committed R877:58b25652f398: Disable Sonnet's language auto-detection as it doesn't work within KatePart… (authored by mludwig).
Disable Sonnet's language auto-detection as it doesn't work within KatePart…
Nov 4 2019, 7:54 PM

Nov 3 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

This issue is also present on Linux.

Nov 3 2019, 6:56 AM · Kile, Windows

Nov 2 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

It's the language autodetection setting.

Nov 2 2019, 8:23 PM · Kile, Windows
mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Kile as such works fine.

Nov 2 2019, 5:37 PM · Kile, Windows

Oct 28 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Ok, sorry, then we must remove that from the blacklist again.
But interesting enough, this first time wizard tells that it will miss okular, is that just a left-over from the time it was needed?

Oct 28 2019, 7:44 PM · Kile, Windows
mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

I tried to install it. Given I have no real experience with TeX stuff on Windows, can't really try it ;=)
I can only say I assume that okular.exe needs to be installed, too, or?

Oct 28 2019, 7:35 PM · Kile, Windows

Oct 19 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Ah, you could add 150/310/44 icons to the icons folder, btw., that will avoid that we need to have that in the craft blueprints.

Oct 19 2019, 1:35 PM · Kile, Windows
mludwig committed R877:a8d7692cff35: Add 2.9.93 release for Kile (authored by mludwig).
Add 2.9.93 release for Kile
Oct 19 2019, 12:59 PM
mludwig committed R468:09ee4ef04171: Add 44x44, 150x150, and 310x310 Kile icons (authored by mludwig).
Add 44x44, 150x150, and 310x310 Kile icons
Oct 19 2019, 10:07 AM

Oct 13 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Quick look at the code tells me you need to add something like

/**
 * enable high dpi support
 */
QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps, true);
QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true);

to have real hidpi support on Windows, I think at the moment just the high dpi pixmap stuff is on.
Both should be done before the application is constructed.

Oct 13 2019, 2:12 PM · Kile, Windows
mludwig committed R468:e161e7cb6cc7: Fix margins on Windows in the ConfigChecker dialog (authored by mludwig).
Fix margins on Windows in the ConfigChecker dialog
Oct 13 2019, 12:49 PM
mludwig committed R468:ba5941809cd5: Some margin fixes (authored by mludwig).
Some margin fixes
Oct 13 2019, 12:24 PM
mludwig committed R468:2dfd05ef571e: Propery enable high-dpi support (authored by mludwig).
Propery enable high-dpi support
Oct 13 2019, 6:33 AM

Oct 12 2019

mludwig committed R468:9a510ddc6363: Fix KILE_LAST_COPYRIGHT_YEAR on Windows (authored by mludwig).
Fix KILE_LAST_COPYRIGHT_YEAR on Windows
Oct 12 2019, 8:04 PM

Oct 6 2019

mludwig added a comment to T9584: Publish Kile in the Microsoft Store.

Michel, would you be ok with this?
That we get some installer in shape for the store?

Oct 6 2019, 7:16 PM · Kile, Windows

Sep 22 2019

mludwig accepted D23616: Get rid of deprecated QSignalMapper.

Looks good - thanks a lot!

Sep 22 2019, 2:23 PM · Kile

Sep 21 2019

mludwig added inline comments to D23616: Get rid of deprecated QSignalMapper.
Sep 21 2019, 10:08 AM · Kile

Apr 22 2019

mludwig added a comment to T10318: Refresh the Kile website .

I'm fine with that - but I don't think I'll create a new style just for Kile. The intention behind this redesign (and others, such as planned in T10827) was to unify the style of various smaller KDE websites which reinforces the KDE branding (see T9122). If this isn't wanted for Kile, I'll move on to other sites.

Apr 22 2019, 8:49 AM · Kile
mludwig added a comment to T10318: Refresh the Kile website .

My idea is to host it under kile.kde.org eventually, but for that I'll need to talk with Sysadmin and set everything up. Right now I simply created a demo hosted on my own server because that was easier and I would not have wasted the precious resources of our sysadmins if in the end the site is not wanted.

Apr 22 2019, 8:31 AM · Kile

Apr 7 2019

mludwig committed R877:6164ff67245b: Update Kile's icon (authored by mludwig).
Update Kile's icon
Apr 7 2019, 6:04 AM
mludwig committed R468:1d493adef930: Add the new version of the Kile icon (authored by mludwig).
Add the new version of the Kile icon
Apr 7 2019, 5:37 AM

Apr 6 2019

mludwig committed R468:628fe8c6dca2: Remove unnecessary warning (authored by mludwig).
Remove unnecessary warning
Apr 6 2019, 6:44 PM
mludwig committed R468:b0e4a02277da: Raise copyright year to 2019 (authored by mludwig).
Raise copyright year to 2019
Apr 6 2019, 6:44 PM
mludwig committed R468:b618146a98a4: PDF Wizard: make the information label fit completely (authored by mludwig).
PDF Wizard: make the information label fit completely
Apr 6 2019, 2:57 PM
mludwig committed R468:6625f736a11e: PDF Wizard: don't select override by default (authored by mludwig).
PDF Wizard: don't select override by default
Apr 6 2019, 2:57 PM
mludwig committed R468:e623ad3139ff: Fix launching actions from the PDF wizard (at least for the pdfpages mode) (authored by mludwig).
Fix launching actions from the PDF wizard (at least for the pdfpages mode)
Apr 6 2019, 2:03 PM

Mar 31 2019

mludwig committed R468:f3355f078e94: Fix override warnings (authored by mludwig).
Fix override warnings
Mar 31 2019, 7:36 AM

Mar 3 2019

mludwig committed R468:8d73233dbecb: Add our own versions of most QStandardPaths:: methods (authored by mludwig).
Add our own versions of most QStandardPaths:: methods
Mar 3 2019, 3:26 PM

Feb 24 2019

mludwig committed R468:62232952aa22: Avoid crashing when closing a document that is being parsed (authored by mludwig).
Avoid crashing when closing a document that is being parsed
Feb 24 2019, 7:47 PM

Feb 7 2019

mludwig reopened T10318: Refresh the Kile website as "Open".

whoops - didn't really mean to set it to resolved...

Feb 7 2019, 1:30 PM · Kile
mludwig added a comment to T10318: Refresh the Kile website .

Thanks for your efforts - I like the idea of refreshing the website!

Feb 7 2019, 1:30 PM · Kile
mludwig closed T10318: Refresh the Kile website as Resolved.
Feb 7 2019, 1:29 PM · Kile

Jan 6 2019

mludwig accepted D17310: Use a Kile Icon that is similar to the original.
Jan 6 2019, 5:34 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.
  • Make Kile letters a lighter color
Jan 6 2019, 5:29 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

I'm the author of this one:

That has been in Breeze for years. Please next time don't wait so much to complain about an icon that being the app launcher one can be easily noticed when updated.

Jan 6 2019, 5:26 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Here are some designs that are more faithful to the original:


This has almost the same letter design as the original. I adjusted it a bit to fit onto the notepad.

@mludwig
What do you think of these designs? Are they close enough to the original to be recognizable?

Jan 6 2019, 9:37 AM · Frameworks

Jan 2 2019

mludwig added a comment to T10243: Some KDE applications could use better icons.

What is the original icon? This?

Jan 2 2019, 7:31 AM · KDE Applications, VDG

Jan 1 2019

mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Kile folks, are you good with this now? If we don't hear back in a week or two, we'll have to assume yes. :)

Jan 1 2019, 7:56 PM · Frameworks
mludwig added a comment to T10243: Some KDE applications could use better icons.

Regarding Okular, the first is not "Oxygen" icon, it's the Okular icon as we ship it as part of the okular codebase, breeze just decides to overwrite it with a different one.

OK, then the Breeze icon runs afoul of the "Don't destroy the app's existing branding" recommendation in the HIG. https://hig.kde.org/style/icon.html#application-icons

Jan 1 2019, 7:45 PM · KDE Applications, VDG

Dec 3 2018

mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no other app does this.

For those reasons, our HIG specifically recommends against this: https://hig.kde.org/style/icon.html?highlight=icons#general-guidelines

Dec 3 2018, 5:35 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Hey, thanks for working on this.

Dec 3 2018, 9:47 AM · Frameworks

Nov 19 2018

mludwig accepted D17011: actually initialize kcrash properly.
Nov 19 2018, 3:29 PM · Kile

Nov 1 2018

mludwig committed R223:2ea44c5291d8: Fix KDirWatch problem description in Part::setWatchFileModeEnabled (authored by mludwig).
Fix KDirWatch problem description in Part::setWatchFileModeEnabled
Nov 1 2018, 6:53 AM

Oct 28 2018

mludwig committed R468:f9de688e223b: Search for the 'file_save_copy_as' action inside 'KTextEditor::View' now (authored by mludwig).
Search for the 'file_save_copy_as' action inside 'KTextEditor::View' now
Oct 28 2018, 6:59 PM
mludwig committed R468:3e585a06492e: Use more functor-based signal/slot connections in 'KileDocument::Manager… (authored by mludwig).
Use more functor-based signal/slot connections in 'KileDocument::Manager…
Oct 28 2018, 6:33 PM
mludwig committed R468:0a71b32f508f: Fix tab icons for informing the user of clandestine file modifications (authored by mludwig).
Fix tab icons for informing the user of clandestine file modifications
Oct 28 2018, 5:12 PM
mludwig committed R223:dcacd830f47f: Don't call 'KDirWatch::stopScan()' (authored by mludwig).
Don't call 'KDirWatch::stopScan()'
Oct 28 2018, 4:37 PM

Oct 7 2018

mludwig added a comment to D15896: Rewrite PlainToLatexConverter.

The complexity of this function doen't change before it was:

for char in result: # line 50
    for replace in replaceMap: # line 53
        compare(replace, char)

and now it's

for replace in replaceMap: # line 47
    for char in result: # line 48
        compare(replace, char)

But I found a better way of doing it, with regex

Oct 7 2018, 6:49 PM · Kile
mludwig requested changes to D15896: Rewrite PlainToLatexConverter.

Thanks for the patch!

Oct 7 2018, 4:27 PM · Kile

Sep 26 2018

mludwig added a comment to D15754: Modernizing Kile code (WIP).

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

Ok I will change that.

To make myself a little clearer, when you replace an iterator variable (typically called 'i') with a range-loop, can you try to find a better variable name than 'i'? I think it would improve the readability of the code.

Sep 26 2018, 1:45 PM · Kile
mludwig added a comment to D15754: Modernizing Kile code (WIP).

One more question, what is the advantage of removing (empty) destructors and replacing them with 'virtual ~Manager() = default;'?

Sep 26 2018, 4:00 AM · Kile
mludwig requested changes to D15754: Modernizing Kile code (WIP).

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

Sep 26 2018, 3:49 AM · Kile

Sep 23 2018

mludwig added a comment to D15711: Allow KXmlGui UI files to be found more easily.

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows

Sep 23 2018, 6:44 PM · Okular
mludwig requested review of D15711: Allow KXmlGui UI files to be found more easily.
Sep 23 2018, 3:04 PM · Okular

May 27 2018

mludwig committed R39:238232adebb0: Don't use title case for the "show word count" checkbox (authored by mludwig).
Don't use title case for the "show word count" checkbox
May 27 2018, 7:18 PM

May 16 2018

mludwig committed R877:21a69f641dab: This time really don't blacklist 'bin/data/hunspell' (authored by mludwig).
This time really don't blacklist 'bin/data/hunspell'
May 16 2018, 5:45 PM

May 13 2018

mludwig accepted D8080: Remove X-DBUS-StartupType from desktop file.
May 13 2018, 10:47 AM · Kile
mludwig committed R468:b73aca1a6d46: Raise version to Kile 3.0 beta 3 (2.9.93) (authored by mludwig).
Raise version to Kile 3.0 beta 3 (2.9.93)
May 13 2018, 10:20 AM
mludwig committed R468:2ec4c207d380: Silence CMake's CMP0071 policy warning (authored by mludwig).
Silence CMake's CMP0071 policy warning
May 13 2018, 10:03 AM
mludwig committed R877:ead74af03419: Fix blacklist append & website in the installer (authored by mludwig).
Fix blacklist append & website in the installer
May 13 2018, 8:21 AM
mludwig committed R877:b829dc3536f0: Don't blacklist 'bin/data/locale' (a few others under 'bin/data') (authored by mludwig).
Don't blacklist 'bin/data/locale' (a few others under 'bin/data')
May 13 2018, 7:19 AM

May 12 2018

mludwig committed R877:3db946a46a79: Add Kile 2.9.92 (authored by mludwig).
Add Kile 2.9.92
May 12 2018, 5:26 AM

May 11 2018

mludwig committed R468:54d2ba4c24c5: Set the full version string to "Kile 3.0 beta 2" (authored by mludwig).
Set the full version string to "Kile 3.0 beta 2"
May 11 2018, 5:42 PM

May 8 2018

mludwig committed R877:7199258a26f9: Don't blacklist 'bin/data/hunspell' for Kile (authored by mludwig).
Don't blacklist 'bin/data/hunspell' for Kile
May 8 2018, 7:29 PM
mludwig committed R468:18ccc0a387d3: Don't indicate that the document has been changed if the live preview is… (authored by mludwig).
Don't indicate that the document has been changed if the live preview is…
May 8 2018, 6:08 PM

Apr 19 2018

mludwig accepted D12360: Use Tree view for the file browser instead of whatever the default view happens to be set to.
Apr 19 2018, 6:22 PM · Kile

Apr 15 2018

mludwig committed R468:78ded21d5be8: Fix the 'Switch Application Language' button (authored by mludwig).
Fix the 'Switch Application Language' button
Apr 15 2018, 5:04 PM

Apr 3 2018

mludwig added a comment to D11838: Turn on line numbers by default.

Personally, I dislike the idea of passing options in createView for a very simple reason: we have document variables, .kateconfig files, settings on the UI, the command line, the ConfigInterface. Adding yet another way to configure KTextEditor sounds like a bad idea.

Apr 3 2018, 5:13 AM · Frameworks, Kate

Apr 2 2018

mludwig added a comment to D11838: Turn on line numbers by default.

So what's our path forward here? Is there a way to only turn on line numbers for Kate itself, and not for the katepart?

Apr 2 2018, 12:32 PM · Frameworks, Kate