mludwig (Michel Ludwig)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 28 2016, 2:16 PM (142 w, 3 d)
Availability
Available

Recent Activity

Today

mludwig added inline comments to D23616: Get rid of deprecated QSignalMapper.
Sat, Sep 21, 10:08 AM · Kile

Apr 22 2019

mludwig added a comment to T10318: Refresh the Kile website .

I'm fine with that - but I don't think I'll create a new style just for Kile. The intention behind this redesign (and others, such as planned in T10827) was to unify the style of various smaller KDE websites which reinforces the KDE branding (see T9122). If this isn't wanted for Kile, I'll move on to other sites.

Apr 22 2019, 8:49 AM · Kile
mludwig added a comment to T10318: Refresh the Kile website .

My idea is to host it under kile.kde.org eventually, but for that I'll need to talk with Sysadmin and set everything up. Right now I simply created a demo hosted on my own server because that was easier and I would not have wasted the precious resources of our sysadmins if in the end the site is not wanted.

Apr 22 2019, 8:31 AM · Kile

Apr 7 2019

mludwig committed R877:6164ff67245b: Update Kile's icon (authored by mludwig).
Update Kile's icon
Apr 7 2019, 6:04 AM
mludwig committed R468:1d493adef930: Add the new version of the Kile icon (authored by mludwig).
Add the new version of the Kile icon
Apr 7 2019, 5:37 AM

Apr 6 2019

mludwig committed R468:628fe8c6dca2: Remove unnecessary warning (authored by mludwig).
Remove unnecessary warning
Apr 6 2019, 6:44 PM
mludwig committed R468:b0e4a02277da: Raise copyright year to 2019 (authored by mludwig).
Raise copyright year to 2019
Apr 6 2019, 6:44 PM
mludwig committed R468:b618146a98a4: PDF Wizard: make the information label fit completely (authored by mludwig).
PDF Wizard: make the information label fit completely
Apr 6 2019, 2:57 PM
mludwig committed R468:6625f736a11e: PDF Wizard: don't select override by default (authored by mludwig).
PDF Wizard: don't select override by default
Apr 6 2019, 2:57 PM
mludwig committed R468:e623ad3139ff: Fix launching actions from the PDF wizard (at least for the pdfpages mode) (authored by mludwig).
Fix launching actions from the PDF wizard (at least for the pdfpages mode)
Apr 6 2019, 2:03 PM

Mar 31 2019

mludwig committed R468:f3355f078e94: Fix override warnings (authored by mludwig).
Fix override warnings
Mar 31 2019, 7:36 AM

Mar 3 2019

mludwig committed R468:8d73233dbecb: Add our own versions of most QStandardPaths:: methods (authored by mludwig).
Add our own versions of most QStandardPaths:: methods
Mar 3 2019, 3:26 PM

Feb 24 2019

mludwig committed R468:62232952aa22: Avoid crashing when closing a document that is being parsed (authored by mludwig).
Avoid crashing when closing a document that is being parsed
Feb 24 2019, 7:47 PM

Feb 7 2019

mludwig reopened T10318: Refresh the Kile website as "Open".

whoops - didn't really mean to set it to resolved...

Feb 7 2019, 1:30 PM · Kile
mludwig added a comment to T10318: Refresh the Kile website .

Thanks for your efforts - I like the idea of refreshing the website!

Feb 7 2019, 1:30 PM · Kile
mludwig closed T10318: Refresh the Kile website as Resolved.
Feb 7 2019, 1:29 PM · Kile

Jan 6 2019

mludwig accepted D17310: Use a Kile Icon that is similar to the original.
Jan 6 2019, 5:34 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.
  • Make Kile letters a lighter color
Jan 6 2019, 5:29 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

I'm the author of this one:

That has been in Breeze for years. Please next time don't wait so much to complain about an icon that being the app launcher one can be easily noticed when updated.

Jan 6 2019, 5:26 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Here are some designs that are more faithful to the original:


This has almost the same letter design as the original. I adjusted it a bit to fit onto the notepad.

@mludwig
What do you think of these designs? Are they close enough to the original to be recognizable?

Jan 6 2019, 9:37 AM · Frameworks

Jan 2 2019

mludwig added a comment to T10243: Some KDE applications could use better icons.

What is the original icon? This?

Jan 2 2019, 7:31 AM · KDE Applications, VDG

Jan 1 2019

mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Kile folks, are you good with this now? If we don't hear back in a week or two, we'll have to assume yes. :)

Jan 1 2019, 7:56 PM · Frameworks
mludwig added a comment to T10243: Some KDE applications could use better icons.

Regarding Okular, the first is not "Oxygen" icon, it's the Okular icon as we ship it as part of the okular codebase, breeze just decides to overwrite it with a different one.

OK, then the Breeze icon runs afoul of the "Don't destroy the app's existing branding" recommendation in the HIG. https://hig.kde.org/style/icon.html#application-icons

Jan 1 2019, 7:45 PM · KDE Applications, VDG

Dec 3 2018

mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no other app does this.

For those reasons, our HIG specifically recommends against this: https://hig.kde.org/style/icon.html?highlight=icons#general-guidelines

Dec 3 2018, 5:35 PM · Frameworks
mludwig added a comment to D17310: Use a Kile Icon that is similar to the original.

Hey, thanks for working on this.

Dec 3 2018, 9:47 AM · Frameworks

Nov 19 2018

mludwig accepted D17011: actually initialize kcrash properly.
Nov 19 2018, 3:29 PM · Kile

Nov 1 2018

mludwig committed R223:2ea44c5291d8: Fix KDirWatch problem description in Part::setWatchFileModeEnabled (authored by mludwig).
Fix KDirWatch problem description in Part::setWatchFileModeEnabled
Nov 1 2018, 6:53 AM

Oct 28 2018

mludwig committed R468:f9de688e223b: Search for the 'file_save_copy_as' action inside 'KTextEditor::View' now (authored by mludwig).
Search for the 'file_save_copy_as' action inside 'KTextEditor::View' now
Oct 28 2018, 6:59 PM
mludwig committed R468:3e585a06492e: Use more functor-based signal/slot connections in 'KileDocument::Manager… (authored by mludwig).
Use more functor-based signal/slot connections in 'KileDocument::Manager…
Oct 28 2018, 6:33 PM
mludwig committed R468:0a71b32f508f: Fix tab icons for informing the user of clandestine file modifications (authored by mludwig).
Fix tab icons for informing the user of clandestine file modifications
Oct 28 2018, 5:12 PM
mludwig committed R223:dcacd830f47f: Don't call 'KDirWatch::stopScan()' (authored by mludwig).
Don't call 'KDirWatch::stopScan()'
Oct 28 2018, 4:37 PM

Oct 7 2018

mludwig added a comment to D15896: Rewrite PlainToLatexConverter.

The complexity of this function doen't change before it was:

for char in result: # line 50
    for replace in replaceMap: # line 53
        compare(replace, char)

and now it's

for replace in replaceMap: # line 47
    for char in result: # line 48
        compare(replace, char)

But I found a better way of doing it, with regex

Oct 7 2018, 6:49 PM · Kile
mludwig requested changes to D15896: Rewrite PlainToLatexConverter.

Thanks for the patch!

Oct 7 2018, 4:27 PM · Kile

Sep 26 2018

mludwig added a comment to D15754: Modernizing Kile code (WIP).

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

Ok I will change that.

To make myself a little clearer, when you replace an iterator variable (typically called 'i') with a range-loop, can you try to find a better variable name than 'i'? I think it would improve the readability of the code.

Sep 26 2018, 1:45 PM · Kile
mludwig added a comment to D15754: Modernizing Kile code (WIP).

One more question, what is the advantage of removing (empty) destructors and replacing them with 'virtual ~Manager() = default;'?

Sep 26 2018, 4:00 AM · Kile
mludwig requested changes to D15754: Modernizing Kile code (WIP).

Also, please leave the variable names as they are and don't introduce 'auto' everywhere. It's useful to know which type one is working with, even if it means that one has to write longer code.

Sep 26 2018, 3:49 AM · Kile

Sep 23 2018

mludwig added a comment to D15711: Allow KXmlGui UI files to be found more easily.

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows

Sep 23 2018, 6:44 PM · Okular
mludwig requested review of D15711: Allow KXmlGui UI files to be found more easily.
Sep 23 2018, 3:04 PM · Okular

May 27 2018

mludwig committed R39:238232adebb0: Don't use title case for the "show word count" checkbox (authored by mludwig).
Don't use title case for the "show word count" checkbox
May 27 2018, 7:18 PM

May 16 2018

mludwig committed R877:21a69f641dab: This time really don't blacklist 'bin/data/hunspell' (authored by mludwig).
This time really don't blacklist 'bin/data/hunspell'
May 16 2018, 5:45 PM

May 13 2018

mludwig accepted D8080: Remove X-DBUS-StartupType from desktop file.
May 13 2018, 10:47 AM · Kile
mludwig committed R468:b73aca1a6d46: Raise version to Kile 3.0 beta 3 (2.9.93) (authored by mludwig).
Raise version to Kile 3.0 beta 3 (2.9.93)
May 13 2018, 10:20 AM
mludwig committed R468:2ec4c207d380: Silence CMake's CMP0071 policy warning (authored by mludwig).
Silence CMake's CMP0071 policy warning
May 13 2018, 10:03 AM
mludwig committed R877:ead74af03419: Fix blacklist append & website in the installer (authored by mludwig).
Fix blacklist append & website in the installer
May 13 2018, 8:21 AM
mludwig committed R877:b829dc3536f0: Don't blacklist 'bin/data/locale' (a few others under 'bin/data') (authored by mludwig).
Don't blacklist 'bin/data/locale' (a few others under 'bin/data')
May 13 2018, 7:19 AM

May 12 2018

mludwig committed R877:3db946a46a79: Add Kile 2.9.92 (authored by mludwig).
Add Kile 2.9.92
May 12 2018, 5:26 AM

May 11 2018

mludwig committed R468:54d2ba4c24c5: Set the full version string to "Kile 3.0 beta 2" (authored by mludwig).
Set the full version string to "Kile 3.0 beta 2"
May 11 2018, 5:42 PM

May 8 2018

mludwig committed R877:7199258a26f9: Don't blacklist 'bin/data/hunspell' for Kile (authored by mludwig).
Don't blacklist 'bin/data/hunspell' for Kile
May 8 2018, 7:29 PM
mludwig committed R468:18ccc0a387d3: Don't indicate that the document has been changed if the live preview is… (authored by mludwig).
Don't indicate that the document has been changed if the live preview is…
May 8 2018, 6:08 PM

Apr 19 2018

mludwig accepted D12360: Use Tree view for the file browser instead of whatever the default view happens to be set to.
Apr 19 2018, 6:22 PM · Kile

Apr 15 2018

mludwig committed R468:78ded21d5be8: Fix the 'Switch Application Language' button (authored by mludwig).
Fix the 'Switch Application Language' button
Apr 15 2018, 5:04 PM

Apr 3 2018

mludwig added a comment to D11838: Turn on line numbers by default.

Personally, I dislike the idea of passing options in createView for a very simple reason: we have document variables, .kateconfig files, settings on the UI, the command line, the ConfigInterface. Adding yet another way to configure KTextEditor sounds like a bad idea.

Apr 3 2018, 5:13 AM · Frameworks, Kate

Apr 2 2018

mludwig added a comment to D11838: Turn on line numbers by default.

So what's our path forward here? Is there a way to only turn on line numbers for Kate itself, and not for the katepart?

Apr 2 2018, 12:32 PM · Frameworks, Kate

Apr 1 2018

mludwig added a comment to D11838: Turn on line numbers by default.

That said, I'm still struggling to understand what the problems is with line numbers in Kile. Most of the editors listed at https://beebom.com/best-latex-editors/ have line numbers on by default, including TeXmaker, which is what all of my scientist friends use. Screens are wider than ever before, and average users are going to just maximize the window anyway, making the small amount of horizontal space taken up by the line numbers a non-issue.

Apr 1 2018, 8:16 PM · Frameworks, Kate
mludwig requested changes to D11838: Turn on line numbers by default.

I don't think that this is ok for Kile.

Apr 1 2018, 6:53 AM · Frameworks, Kate

Feb 25 2018

mludwig committed R468:f87c242a6129: Ensure that 'KileUtilities::canonicalUrl' doesn't return an empty URL if the… (authored by mludwig).
Ensure that 'KileUtilities::canonicalUrl' doesn't return an empty URL if the…
Feb 25 2018, 8:33 AM

Feb 20 2018

mludwig committed R468:f6346b791e93: Don't crash if DBUS is not available (authored by mludwig).
Don't crash if DBUS is not available
Feb 20 2018, 5:07 PM
mludwig committed R138:3920a2683c62: Fix compilation on macOS (authored by mludwig).
Fix compilation on macOS
Feb 20 2018, 4:36 PM

Feb 18 2018

mludwig committed R468:e54d140fcf18: Rename 'KileDocument::Manager::symlinkFreeURL' to 'KileDocument::Manager… (authored by mludwig).
Rename 'KileDocument::Manager::symlinkFreeURL' to 'KileDocument::Manager…
Feb 18 2018, 8:15 AM
mludwig committed R468:4653025059a8: Make 'KileDocument::Manager::symlinkFreeURL' also work on Windows (authored by mludwig).
Make 'KileDocument::Manager::symlinkFreeURL' also work on Windows
Feb 18 2018, 8:03 AM
mludwig committed R468:699d60e8252c: Use canonical file paths in 'KileView::Manager::handleActivatedSourceReference' (authored by mludwig).
Use canonical file paths in 'KileView::Manager::handleActivatedSourceReference'
Feb 18 2018, 7:42 AM

Feb 14 2018

mludwig committed R468:e69122906e02: Use the 'save copy as' action from KatePart (authored by mludwig).
Use the 'save copy as' action from KatePart
Feb 14 2018, 7:14 PM

Feb 10 2018

mludwig committed R468:522ef4a5673c: Disable the 'save as with encoding functionality' (authored by mludwig).
Disable the 'save as with encoding functionality'
Feb 10 2018, 4:54 PM

Feb 8 2018

mludwig committed R468:be912e1b8644: Fix creation of actions in 'Kile::createToolAction' (authored by mludwig).
Fix creation of actions in 'Kile::createToolAction'
Feb 8 2018, 7:58 PM

Feb 4 2018

mludwig committed R468:8417ccbaaf10: Add functionality for saving the compiled document resulting from live preview (authored by mludwig).
Add functionality for saving the compiled document resulting from live preview
Feb 4 2018, 9:48 AM

Jan 28 2018

mludwig committed R468:fe472dc3e4ea: Gracefully handle the absence of Okular part (authored by mludwig).
Gracefully handle the absence of Okular part
Jan 28 2018, 7:09 AM

Jan 26 2018

mludwig committed R468:43db11c815a2: Detect the presence of Okular's ViewerInterface during system check (authored by mludwig).
Detect the presence of Okular's ViewerInterface during system check
Jan 26 2018, 8:12 PM

Jan 22 2018

mludwig committed R468:832ddf9e4623: 'fi' -> 'fi' in 'biblatex.cwl' (authored by mludwig).
'fi' -> 'fi' in 'biblatex.cwl'
Jan 22 2018, 7:29 PM

Jan 21 2018

mludwig committed R877:e617b9dc5d9b: Define an icon for Kile's installer (authored by mludwig).
Define an icon for Kile's installer
Jan 21 2018, 8:17 PM
mludwig committed R468:a2ab287785dc: Update the user menu example file ('example.xml') (authored by mludwig).
Update the user menu example file ('example.xml')
Jan 21 2018, 6:42 PM
mludwig committed R468:0a08fcaca53b: User menu: make 'replace text selection' independent of 'require text selection' (authored by mludwig).
User menu: make 'replace text selection' independent of 'require text selection'
Jan 21 2018, 5:09 PM

Jan 19 2018

mludwig committed R223:6b259d7000c6: Use Windows ANSI versions of the PathFind... methods (authored by mludwig).
Use Windows ANSI versions of the PathFind... methods
Jan 19 2018, 8:29 PM
mludwig closed D9937: synctex: Use Windows ANSI versions of the PathFind... methods.
Jan 19 2018, 8:29 PM · Okular

Jan 13 2018

mludwig committed R468:306a7322bbbf: Use the correct path list separator on Windows (authored by mludwig).
Use the correct path list separator on Windows
Jan 13 2018, 6:07 AM

Jan 2 2018

mludwig committed R468:e9d444bb0c47: Reformat more code to the new coding style (authored by mludwig).
Reformat more code to the new coding style
Jan 2 2018, 7:23 AM

Jan 1 2018

mludwig committed R468:fc4af911577e: Convert the files in 'src/usermenu' to the new code formatting style (authored by mludwig).
Convert the files in 'src/usermenu' to the new code formatting style
Jan 1 2018, 8:16 PM
mludwig committed R468:9f97f751639c: Correctly encode line feed characters (\n) in user menu XML files (authored by mludwig).
Correctly encode line feed characters (\n) in user menu XML files
Jan 1 2018, 8:12 PM
mludwig committed R468:78f869d0f671: Add '.kateconfig' file which switches off indentation by tabs (authored by mludwig).
Add '.kateconfig' file which switches off indentation by tabs
Jan 1 2018, 12:43 PM
mludwig committed R468:8a2c5fd3f140: Avoid crashing in 'SideBar::setPageVisible' (authored by mludwig).
Avoid crashing in 'SideBar::setPageVisible'
Jan 1 2018, 11:15 AM
mludwig committed R468:c30bdeb78ffc: Raise overall copyright year to 2018 (authored by mludwig).
Raise overall copyright year to 2018
Jan 1 2018, 10:55 AM
mludwig committed R468:e102fc0b929a: Redesign the UI for the completion side bar (authored by mludwig).
Redesign the UI for the completion side bar
Jan 1 2018, 9:35 AM

Dec 29 2017

mludwig committed R468:d3b90c64c632: Ensure that "RelWithDebInfo" builds are built with -DQT_MESSAGELOGCONTEXT to… (authored by mludwig).
Ensure that "RelWithDebInfo" builds are built with -DQT_MESSAGELOGCONTEXT to…
Dec 29 2017, 4:56 PM

Nov 25 2017

mludwig committed R468:b74feac9f85c: Ensure that live preview event handlers don't trigger any action when live… (authored by mludwig).
Ensure that live preview event handlers don't trigger any action when live…
Nov 25 2017, 8:13 PM
mludwig committed R468:1255af8b3bf7: Avoid crashing when trying to open a directory (authored by mludwig).
Avoid crashing when trying to open a directory
Nov 25 2017, 7:41 AM
mludwig committed R468:af6881bded34: Fix warning in KileTool::Manager::extract(const QString&, QString&, QString&)… (authored by mludwig).
Fix warning in KileTool::Manager::extract(const QString&, QString&, QString&)…
Nov 25 2017, 6:38 AM

Nov 12 2017

mludwig committed R468:5fdca29bd30a: Ensure that all bibliography files discovered by the parser have a proper… (authored by mludwig).
Ensure that all bibliography files discovered by the parser have a proper…
Nov 12 2017, 7:23 PM

Oct 8 2017

mludwig committed R468:9ce614a225d0: Trying center dialogs more reliably (authored by mludwig).
Trying center dialogs more reliably
Oct 8 2017, 5:37 AM

Oct 7 2017

mludwig committed R468:47328b8d1ccb: Shrink the "edit user menu" dialog a little (authored by mludwig).
Shrink the "edit user menu" dialog a little
Oct 7 2017, 1:18 PM

Oct 5 2017

mludwig updated the image for Kile from F2396295: profile to F4873591: profile.
Oct 5 2017, 6:24 PM

Sep 30 2017

mludwig accepted D8047: Fix opening local files from the command line.
Sep 30 2017, 11:48 AM · Kile
mludwig committed R468:274dd4d59b5d: Fix searching for okular.exe on Windows (authored by mludwig).
Fix searching for okular.exe on Windows
Sep 30 2017, 8:06 AM

Sep 9 2017

mludwig committed R468:e620c437f873: Set the application icon correctly on Windows (authored by mludwig).
Set the application icon correctly on Windows
Sep 9 2017, 8:07 AM

Sep 8 2017

mludwig committed R468:2b14f626afb0: Add missing Q_INIT_RESOURCE call (authored by mludwig).
Add missing Q_INIT_RESOURCE call
Sep 8 2017, 5:41 PM

Sep 3 2017

mludwig committed R468:dd418f8e779a: Raise the version to 2.9.92 (authored by mludwig).
Raise the version to 2.9.92
Sep 3 2017, 6:25 PM
mludwig committed R468:b99399009fed: Don't expand the side bar by default (authored by mludwig).
Don't expand the side bar by default
Sep 3 2017, 6:08 AM

Sep 2 2017

mludwig committed R468:8d4b7eb40335: Simplify & fix the (re-)positioning of the user menu (authored by mludwig).
Simplify & fix the (re-)positioning of the user menu
Sep 2 2017, 8:27 AM
mludwig committed R468:178540ba53a2: Prevent toolbar modifications from changing menus (authored by mludwig).
Prevent toolbar modifications from changing menus
Sep 2 2017, 7:15 AM

Aug 28 2017

mludwig committed R468:5eea4fd65750: Clear the message and error output after running the system check (authored by mludwig).
Clear the message and error output after running the system check
Aug 28 2017, 6:07 PM

Aug 27 2017

mludwig committed R468:570dba621f2c: Don't ask the user about resetting the tools when the config file is fresh/empty (authored by mludwig).
Don't ask the user about resetting the tools when the config file is fresh/empty
Aug 27 2017, 7:16 PM

Aug 26 2017

mludwig committed R468:eb657a669f19: Add a workaround for bug 384039 (deleted groups still appear in KConfig… (authored by mludwig).
Add a workaround for bug 384039 (deleted groups still appear in KConfig…
Aug 26 2017, 6:54 PM