Add the KXmlGui UI files to Qt resource files.
In that way, they can be found and used when Okular(part) is running on macOS.
Lint Skipped |
Unit Tests Skipped |
I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?
This is weird since it seems to work just fine on Windows
Well, I'm not a macOS expert, but from playing around a little, I have already noticed that locating paths is more tricky on macOS than on other platforms.
I cannot say that it will never work, but at the moment kxmlgui cannot correctly locate ui files on macOS.
The qrc approach is followed by Kate, KWrite, Krita, and Kile already, and it works on any platform ;)
Please move as a Merge Request in https://invent.kde.org/kde/okular
We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.