Allow KXmlGui UI files to be found more easily
Needs RevisionPublic

Authored by mludwig on Sep 23 2018, 3:04 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Summary

Add the KXmlGui UI files to Qt resource files.

In that way, they can be found and used when Okular(part) is running on macOS.

Diff Detail

Repository
R223 Okular
Lint
Lint Skipped
Unit
Unit Tests Skipped
mludwig created this revision.Sep 23 2018, 3:04 PM
Restricted Application added a project: Okular. · View Herald TranscriptSep 23 2018, 3:04 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
mludwig requested review of this revision.Sep 23 2018, 3:04 PM
aacid added a comment.Sep 23 2018, 5:38 PM

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows

I don't like qrc, are you saying that the only way kxmlgui works on MacOs is by not installing files?

This is weird since it seems to work just fine on Windows

Well, I'm not a macOS expert, but from playing around a little, I have already noticed that locating paths is more tricky on macOS than on other platforms.

I cannot say that it will never work, but at the moment kxmlgui cannot correctly locate ui files on macOS.

The qrc approach is followed by Kate, KWrite, Krita, and Kile already, and it works on any platform ;)

aacid requested changes to this revision.Feb 21 2020, 6:56 PM

Please move as a Merge Request in https://invent.kde.org/kde/okular

We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.

This revision now requires changes to proceed.Feb 21 2020, 6:56 PM