Get rid of deprecated QSignalMapper
Needs ReviewPublic

Authored by yurchor on Sat, Aug 31, 7:32 PM.

Details

Reviewers
mludwig
Group Reviewers
Kile
Summary

QSignalMapper class is obsolete. This patch replaces its occurrences with lambdas. Qt version upgrade to 5.6 is needed because addAction overload has been added in Qt 5.6

Test Plan
  1. Start User Menu editor with "LaTeX -> Edit User Menu". Try to add some items using popup menu.
  2. Create a project and use sidebar popup menu to handle its components.
  3. Open some structured document and use the "Structure" panel to manage the structure items.

Diff Detail

Repository
R468 Kile
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16867
Build 16885: arc lint + arc unit
yurchor created this revision.Sat, Aug 31, 7:32 PM
Restricted Application added a project: Kile. · View Herald TranscriptSat, Aug 31, 7:32 PM
yurchor requested review of this revision.Sat, Aug 31, 7:32 PM
mludwig added inline comments.Sat, Sep 21, 10:08 AM
src/dialogs/usermenu/usermenutree.cpp
179–180

Do you think you can get rid of 'slotPopupActivated' as well? and also of the other helper slots below?

yurchor updated this revision to Diff 66587.Sat, Sep 21, 1:08 PM

Replace the helper slots with oneliners where appropriate