Differential D23616

Get rid of deprecated QSignalMapper
ClosedPublic
Actions

Authored by yurchor on Aug 31 2019, 7:32 PM.

Details

Reviewers

mludwig

Group Reviewers

Kile

Commits

R468:a55dabdc5b41: Get rid of deprecated QSignalMapper

Summary

QSignalMapper class is obsolete. This patch replaces its occurrences with lambdas. Qt version upgrade to 5.6 is needed because addAction overload has been added in Qt 5.6

Test Plan

Start User Menu editor with "LaTeX -> Edit User Menu". Try to add some items using popup menu.
Create a project and use sidebar popup menu to handle its components.
Open some structured document and use the "Structure" panel to manage the structure items.

Diff Detail

Repository

R468 Kile

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

yurchor created this revision.Aug 31 2019, 7:32 PM

Restricted Application added a project: Kile. · View Herald TranscriptAug 31 2019, 7:32 PM

yurchor requested review of this revision.Aug 31 2019, 7:32 PM

Harbormaster completed remote builds in B15906: Diff 65068.Aug 31 2019, 7:32 PM

mludwig added inline comments.Sep 21 2019, 10:08 AM

src/dialogs/usermenu/usermenutree.cpp
179–180	Do you think you can get rid of 'slotPopupActivated' as well? and also of the other helper slots below?

Replace the helper slots with oneliners where appropriate

Harbormaster completed remote builds in B16867: Diff 66587.Sep 21 2019, 1:08 PM

Looks good - thanks a lot!

This revision is now accepted and ready to land.Sep 22 2019, 2:23 PM

Closed by commit R468:a55dabdc5b41: Get rid of deprecated QSignalMapper (authored by yurchor). · Explain WhySep 22 2019, 2:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/dialogs/usermenu/usermenutree.h (13 lines)
M			src/dialogs/usermenu/usermenutree.cpp (108 lines)
M			src/livepreview.h (1 line)
M			src/widgets/projectview.cpp (50 lines)
M			src/widgets/structurewidget.h (2 lines)
M			src/widgets/structurewidget.cpp (86 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65068	ccb716b		Aug 31 2019, 7:32 PM	★	★
Diff 2	66587	ccb716b	Replace the helper slots with oneliners where appropriate	Sep 21 2019, 1:08 PM	★	★
Diff 3	66623	e6cc129	R468:a55dabdc5b41ae0c8b083bd25cd994f567b4bad7	Sep 22 2019, 2:24 PM	★	★