martinkostolny (Martin Kostolný)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 11:37 PM (131 w, 8 h)
Availability
Available

Recent Activity

Jun 11 2018

martinkostolny accepted D13475: fix sftp links with new uds implementation.

Now it works perfectly, thanks! :)

Jun 11 2018, 7:37 PM
martinkostolny added a comment to D13475: fix sftp links with new uds implementation.

Thanks for working on this! :-)

Jun 11 2018, 9:30 AM

Jun 10 2018

martinkostolny added a comment to D12696: Use the new uds implementation.

I've managed to get more info about the crash also by following this guide:
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves#Attaching_gdb_to_an_io-slave

Jun 10 2018, 1:50 PM · Frameworks

Jun 7 2018

martinkostolny added a comment to D12696: Use the new uds implementation.

Thanks for guidance regarding getting additional debug info. I'll try to get it soon :).

Jun 7 2018, 1:22 PM · Frameworks
martinkostolny added a comment to D12696: Use the new uds implementation.

Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only?

Jun 7 2018, 6:22 AM · Frameworks

May 20 2018

martinkostolny added a comment to T8761: Synchronizer Rework.

Alex, I remember You wanted to do that. So if You still want, feel free to work on it :). If not, I'm going to dive in.

May 20 2018, 5:27 PM · Krusader
martinkostolny created T8761: Synchronizer Rework.
May 20 2018, 5:24 PM · Krusader

May 16 2018

martinkostolny accepted D12906: Unselect all items when calculating occupied space on "..".

Works as expected. Thanks! :)

May 16 2018, 7:33 PM · Krusader
martinkostolny accepted D12904: Fixed ugly message dialog on Compare by Content error.

I like this change, thanks Davide! I think ::sorry dialog is even better for this scenario but that's a matter of taste :).

May 16 2018, 7:29 PM · Krusader
martinkostolny added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

From my testing, it is now working nicely. Thanks, Alex!

May 16 2018, 7:16 PM

May 12 2018

martinkostolny accepted D12818: Updates related to v2.7 release.

Thanks!

May 12 2018, 11:39 AM · Krusader
martinkostolny added a comment to D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right.

Hello after some time. I finally manage to more or less finish the layout rework I was planning. I tried to work in most of what we discussed here.

May 12 2018, 11:38 AM · Plasma
martinkostolny committed R884:00fd69fb2785: configuration profile load/download implemented (authored by martinkostolny).
configuration profile load/download implemented
May 12 2018, 11:25 AM
martinkostolny committed R884:4754fbf13cc4: config profiles implemented (authored by martinkostolny).
config profiles implemented
May 12 2018, 10:47 AM

May 9 2018

martinkostolny committed R884:7eae0a7ba23a: various tune-ups, improvements to configuration (authored by martinkostolny).
various tune-ups, improvements to configuration
May 9 2018, 8:11 PM
martinkostolny added a comment to D12640: Replace default search bar search mode setting with dedicated shortcuts.

I also think it would be better if search-as-you-type mode was configurable. On top of the proposed change of course :).

May 9 2018, 4:43 PM
martinkostolny added a comment to D12753: Released v2.7.0.

I agree, too. Thanks, Yuri!

May 9 2018, 4:38 PM · Krusader

May 8 2018

martinkostolny accepted D12753: Released v2.7.0.

Except the doc changelog mentioned by Toni I haven't found any obvious missing pieces. Thanks Nikita!

May 8 2018, 5:52 PM · Krusader

May 7 2018

martinkostolny committed R884:71284c688fd2: horizontal alignment implemented & layout config tuning (authored by martinkostolny).
horizontal alignment implemented & layout config tuning
May 7 2018, 10:06 PM

May 6 2018

martinkostolny committed R884:e4be55ed9d87: continuing layout rework (authored by martinkostolny).
continuing layout rework
May 6 2018, 10:41 PM
martinkostolny committed R884:3dbcc3735cf7: Merge branch 'layout-rework' of git://anongit.kde.org/plasma-active-window… (authored by martinkostolny).
Merge branch 'layout-rework' of git://anongit.kde.org/plasma-active-window…
May 6 2018, 10:41 PM
martinkostolny committed R884:6ecca5c82ca1: next round of layout rework & updated repo code for appmenu (authored by martinkostolny).
next round of layout rework & updated repo code for appmenu
May 6 2018, 10:41 PM
martinkostolny committed R884:6f218363b2d0: initial layout rework (authored by martinkostolny).
initial layout rework
May 6 2018, 10:41 PM

May 3 2018

martinkostolny accepted D12644: Updated some descriptions, web links, names, author and thanks lists.

Thanks Toni for updating the website! I agree with the current state of this diff.

May 3 2018, 6:36 AM · Krusader

May 2 2018

martinkostolny accepted D12640: Replace default search bar search mode setting with dedicated shortcuts.

Thanks Alex! It is working as expected. And like Toni said, the behaviour is much simpler now :).

May 2 2018, 9:08 PM

Apr 30 2018

martinkostolny accepted D12600: Updated the INSTALL file. Added some steps to follow if Krusader is already installed.

Thanks, Toni! :)

Apr 30 2018, 11:29 PM · Krusader

Apr 29 2018

martinkostolny committed R884:b795a0cddc10: next round of layout rework & updated repo code for appmenu (authored by martinkostolny).
next round of layout rework & updated repo code for appmenu
Apr 29 2018, 9:24 PM
martinkostolny committed R884:9675b724cfa3: initial layout rework (authored by martinkostolny).
initial layout rework
Apr 29 2018, 9:24 PM

Apr 27 2018

martinkostolny accepted D12560: Updated release information in docs.

Nice :).

Apr 27 2018, 10:13 PM · Krusader

Apr 26 2018

martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Nikita, thanks for merging this big thing.

Apr 26 2018, 10:39 PM · Krusader
martinkostolny added a comment to D12369: BookMan: Fixed various issues related to bookmark reloading from file.
In D12369#253383, @nmel wrote:

It means that you can assign shortcuts to specific bookmarks and those were stopped working after managing. For example, I assigned Ctrl+~ to the root data dir on my machine because it's like a home for the most data. This Ctrl+~ is lost together with toolbar buttons. Now it works without a problem.

Apr 26 2018, 10:32 PM · Krusader
martinkostolny accepted D12531: Updated ChangeLog, NEWS and Features page with v2.7 changes.

Good work stacking the changes, Nikita, thanks!

Apr 26 2018, 10:29 PM · Krusader
martinkostolny accepted D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.

Accepting the update, thanks!

Apr 26 2018, 9:36 PM · Krusader
martinkostolny added a comment to D12487: Updated git ignore file.

In-source builds are highly discouraged by CMake. This case is not in-source (binaries are not placed beside source files) or out-of-source (binaries are still inside the source tree). Not a big deal, IMO.

Apr 26 2018, 3:16 PM · Krusader

Apr 25 2018

martinkostolny accepted D12524: Changes in several files because, by default, F2 renames and F9 opens a terminal window.

Thanks Toni!

Apr 25 2018, 9:06 PM · Krusader
martinkostolny accepted D12487: Updated git ignore file.

I was so used to building in nested build folder. KDevelop itself propose it as a default build path. But maybe it is a bad practice, I don't know. Is it? :) I'm accepting since the other change is needed for sure.

Apr 25 2018, 9:04 PM · Krusader
martinkostolny accepted D12486: Cleaned up old auxiliary files, updated references and fixed layout in docs.

Thanks!

Apr 25 2018, 8:48 PM · Krusader

Apr 24 2018

martinkostolny accepted D12369: BookMan: Fixed various issues related to bookmark reloading from file.

Nicely fixed, thanks Nikita!

Apr 24 2018, 4:39 PM · Krusader

Apr 20 2018

martinkostolny accepted D12338: Panel: fixed invisible column issue.

Same here, replicated with attached krusaderrc. And it no longer happens with this patch. Thanks, Nikita! :)

Apr 20 2018, 11:37 PM · Krusader
martinkostolny accepted D10352: Fix insufficient icon theme issues.

Sorry for my late response. Thanks Nikita for fixing all the issues and Toni for useful testing screenshots.

Apr 20 2018, 11:01 PM · Krusader

Apr 15 2018

martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Thanks Nikita for your big work! :) It works nicely. I have 2 observations:

  1. choosing dark theme not working in dark environment - I'm proposing a simple solution - please see my code comment
  2. icon "application-x-cmakecache" (e.g. for file CMakeCache.txt inside krusader/build folder) is now rendered as a fallback icon (even with breeze) although previously it was rendered as "unknown"
    • I'm not sure if this is even solvable, or if it is important; I was currently unable to come up with a solution
Apr 15 2018, 11:36 AM · Krusader

Apr 9 2018

martinkostolny accepted D12061: Changed loading of layout.xml from resource system only.

Thanks, Nikita!

Apr 9 2018, 10:39 PM · Krusader

Apr 8 2018

martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Maybe we need to use something neutral like circle or diamond... With these missing/unreadable/broken icons the app looks like a broken one while it's not...
Also, I guess we better save a particular image we pick into the resource file, so we can load it for sure. Are you fine with it?

Apr 8 2018, 9:07 PM · Krusader
martinkostolny accepted D11898: Implemented bookmark quick search.

Same goes for me, sorry for not replying. The patch works as expected :).

Apr 8 2018, 8:34 PM · Krusader
martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

I'm fine with "emblem-unreadable" although my preference would rather be "image-missing" :).

Apr 8 2018, 7:08 PM · Krusader
martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Fine work, Nikita, now it works! Thanks for the investigation:). I've tested it in Plasma (on Arch linux) as well as in Ubuntu 17.10 VM.

Apr 8 2018, 12:21 PM · Krusader

Apr 7 2018

martinkostolny added a comment to D10352: Fix insufficient icon theme issues.

Nikita, I like this approach, thanks for working on this! Sorry it took me so long.

Apr 7 2018, 5:38 PM · Krusader
martinkostolny accepted D11975: An update to the INSTALL file, in order to avoid a CMake error.

Thanks, Toni! :)

Apr 7 2018, 4:54 PM · Krusader

Apr 4 2018

martinkostolny added a comment to D11551: use the new install_package form.

Last info: on my side everything seems to compile and work just fine now. Thanks for your work! :)

Apr 4 2018, 5:21 PM · Plasma
martinkostolny added a comment to D11903: Fix multirename shortcut.

Rade, interesting thought about the OFM standard! I've created a topic in krusader-devel so we can discuss:
https://groups.google.com/forum/#!topic/krusader-devel/zu1dE3GUK0w

Apr 4 2018, 5:07 PM · Krusader
martinkostolny accepted D11906: Fix casesensitive search for quicksearch-bookmark.

Works on top of latest branch commit. Thanks! :)

Apr 4 2018, 4:26 PM · Krusader
martinkostolny added a comment to D11903: Fix multirename shortcut.

I propose we add CHANGED: ... to commit message, so it goes to the ChangeLog.

Apr 4 2018, 6:51 AM · Krusader

Apr 3 2018

martinkostolny accepted D11906: Fix casesensitive search for quicksearch-bookmark.

Thanks for fixing the shift scenarios. And good idea with the smart case-matching, I like that :).

Apr 3 2018, 10:10 PM · Krusader
martinkostolny accepted D11903: Fix multirename shortcut.

Thanks, Rade, for the fix :).

Apr 3 2018, 9:40 PM · Krusader

Apr 2 2018

martinkostolny accepted D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.

Now everything seems to work just fine, thanks!

Apr 2 2018, 8:49 PM
martinkostolny added a comment to D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right.

Sorry for being dark for so long, Radek. I was busy and I hope it will get better. Thanks a lot for your ideas.

Apr 2 2018, 7:57 PM · Plasma
martinkostolny accepted D11622: Fix regression in "Open in new tab" behaviour.

Sorry it took me so long.

Apr 2 2018, 5:58 PM
martinkostolny accepted D11829: Fixed bugs in bookmark search that appear after exiting from submenu.

Thank you both for the effort to fix this issue! I'm accepting since this patch fixes the issue flawlessly and is readable for me. Rade's readability code suggestion is also OK but I really cannot decide which one is better, sorry :).

Apr 2 2018, 10:47 AM · Krusader

Apr 1 2018

martinkostolny abandoned D11699: Fix unability to scroll file view when files are constantly refreshing.

Nikita, thanks for review and testing! However I'm abandoning this diff because Alex wrote a more comprehensive patch for the problem. So we can discuss there: D11840

Apr 1 2018, 9:28 PM · Krusader
martinkostolny requested changes to D11840: Panel: Fixed unwanted scrolling and preserving current item on refresh.

Hi Alex! Thanks for looking into this. You seem to have a complex patch that fixes more issues regarding the refreshing. I'll abandon D11699 in favour of this one.

Apr 1 2018, 9:21 PM
martinkostolny accepted D11777: Updated credits, copyrights, license headers in code and docs.

Thanks Nikita for unifying the comments and docs!

Apr 1 2018, 2:11 PM · Krusader

Mar 29 2018

martinkostolny added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..

Looks good, although I think it should be "won't" not "wouldn't" as it is an action that will not happen in the future not an action that has not happened in the past. I think there should be a 'the' between 'in' and 'currently' as well, but it's perfectly understandable without it.

Mar 29 2018, 9:32 PM · Krusader
martinkostolny committed R167:c118ca1eb5fd: Comment added to explain a removal of _quickSearchAction before every menu… (authored by martinkostolny).
Comment added to explain a removal of _quickSearchAction before every menu…
Mar 29 2018, 9:29 PM
martinkostolny added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..

Sorry about that, I should have waited a bit longer. So how about this?

// removing action from previous menu is necessary 
// otherwise it wouldn't be displayed in currently populating menu
if (_mainBookmarkPopup) {
    _mainBookmarkPopup->removeAction(_quickSearchAction);
}
Mar 29 2018, 7:04 AM · Krusader

Mar 27 2018

martinkostolny added a comment to D11699: Fix unability to scroll file view when files are constantly refreshing.

I found the change that's introduced the lines you want to remove. As the lines were added as a response to a bug, I was interested what was the problem.

Mar 27 2018, 10:21 PM · Krusader
martinkostolny added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..

I think the root cause is slightly different because if your statement were true, the bar wouldn't be shown again with the same menu where it was shown for the first time. Likely, if you add an action to many menus (in this case, each tab has its own menu), QWidgetAction is displayed only on the first one. Given many menus could be visible at the same time, it might be a feature, not a bug...

Mar 27 2018, 9:52 PM · Krusader
martinkostolny committed R167:7e57c7204fd3: Merge branch 'bookmark-quicksearch-disappearing-searchbar' into bookmark… (authored by martinkostolny).
Merge branch 'bookmark-quicksearch-disappearing-searchbar' into bookmark…
Mar 27 2018, 9:49 PM
martinkostolny committed R167:c4f8a3b937c2: Fix disappearing searchbar when bookmark menu is opened for another tab. (authored by martinkostolny).
Fix disappearing searchbar when bookmark menu is opened for another tab.
Mar 27 2018, 9:49 PM
martinkostolny closed D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..
Mar 27 2018, 9:49 PM · Krusader

Mar 26 2018

martinkostolny added reviewers for D11731: Fix disappearing searchbar when bookmark menu is opened for another tab.: rade, nmel.
Mar 26 2018, 10:32 PM · Krusader
martinkostolny added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..

Sorry for the first iteration in this CR. It seems I still have much to learn with arc :).

Mar 26 2018, 10:32 PM · Krusader
martinkostolny updated the diff for D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..
Mar 26 2018, 10:30 PM · Krusader
martinkostolny requested review of D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..
Mar 26 2018, 10:29 PM · Krusader
martinkostolny added a comment to D11699: Fix unability to scroll file view when files are constantly refreshing.

Thanks for taking the time to trace the code changes!

Mar 26 2018, 9:34 PM · Krusader
martinkostolny accepted D11706: Fixed the issue with jump back actions not closing bookmark menu when triggered.

Works nice, thanks!

Mar 26 2018, 9:20 PM · Krusader
martinkostolny added a comment to D11593: Fixed warnings that appear when building release version.

Thanks for extensive info! I was still unable to see all the warnings with the flags -Wmaybe-uninitialized -Wstrict-aliasing -Wunused-result enabled. So I guess it is indeed specific to GCC version 7. It doesn't really matter, thanks Nikita for taking care of the warnings!

Mar 26 2018, 8:38 PM · Krusader
martinkostolny added a comment to D11654: [colorcorrection] Apply current color temperature on screen hot plug.

Can you test the latest revision one more time?

Mar 26 2018, 7:23 PM · KWin

Mar 25 2018

martinkostolny added inline comments to D11622: Fix regression in "Open in new tab" behaviour.
Mar 25 2018, 9:24 PM
martinkostolny added a project to D11699: Fix unability to scroll file view when files are constantly refreshing: Krusader.
Mar 25 2018, 8:27 PM · Krusader
martinkostolny requested review of D11699: Fix unability to scroll file view when files are constantly refreshing.
Mar 25 2018, 8:27 PM · Krusader
martinkostolny accepted D11624: Prevent quicksearch from searching special bookmarks.

ideas are appreciated

Mar 25 2018, 7:32 PM
martinkostolny added a comment to D11654: [colorcorrection] Apply current color temperature on screen hot plug.

Just testing info: it works nicely, thanks! :) I'll test further diff updates if there are any.

Mar 25 2018, 6:41 PM · KWin
martinkostolny added a comment to D11622: Fix regression in "Open in new tab" behaviour.

Is there a better way too accomplish what I have done? E.g without having to add a new function to listpanel?

Mar 25 2018, 5:29 PM
martinkostolny accepted D11593: Fixed warnings that appear when building release version.

Thanks Nikita for fixing the warnings :). I can only replicate the one in krjob.cpp. How do do I display the rest of the warnings? I've only used -DCMAKE_BUILD_TYPE=Release when calling cmake, is there something else to set up for release building? Maybe the version of my gcc (7.3.1) can play a part in this...

Mar 25 2018, 3:39 PM · Krusader
martinkostolny added a comment to D11551: use the new install_package form.

Is there something I may be doing wrong?

Mar 25 2018, 2:33 PM · Plasma
martinkostolny added a comment to D11551: use the new install_package form.

Sorry to be late on this. I cannot compile plasma-pa anymore after this change with error:

Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc
make[2]: *** No rule to make target 'applet/org.kde.plasma.volume-contents.rcc', needed by 'applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:191: applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Mar 25 2018, 1:47 PM · Plasma
martinkostolny added a comment to R165:b85632826fbc: Use debug category.

Hi! After this commit various akonadi dependent projects won't compile - e.g. akonadi-contacts, akonadi-mime and others claiming this error:

In file included from /home/kotelnik/kde/usr/include/KF5/AkonadiCore/item.h:27:0,
                 from /home/kotelnik/kde/usr/include/KF5/AkonadiCore/itemfetchjob.h:24,
                 from /home/kotelnik/kde/src/kde/pim/akonadi-mime/src/removeduplicatesjob.cpp:23:
/home/kotelnik/kde/usr/include/KF5/AkonadiCore/tag.h:25:10: fatal error: akonadicore_debug.h: No such file or directory
 #include "akonadicore_debug.h"
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I'm using kdesrc-build environment.

Mar 25 2018, 2:08 AM
martinkostolny accepted D11623: Add set jump back et al. to specialbookmarks to fix right click bug.

Thanks for the fix!

Mar 25 2018, 1:31 AM · Krusader
martinkostolny added a comment to D11624: Prevent quicksearch from searching special bookmarks.
In D11624#233131, @rade wrote:

Given Rade's points, I see that it may be useful for some people, so I suggest we add another config option "Search in special items" for this feature and stop arguing. My only ask is to leave it off by default.

Sounds good to me. Would you mind doing the patch for it though? I'm not really sure how the config code works, and you seem to have a good grasp of it.

Mar 25 2018, 1:24 AM

Mar 22 2018

martinkostolny accepted D11444: Fixed jump-back actions in bookmark menu, improved separators.

It works:), thanks!

Mar 22 2018, 10:33 PM · Krusader

Mar 21 2018

martinkostolny added inline comments to D11525: Fix accidentally triggering menus.
Mar 21 2018, 10:24 PM
martinkostolny accepted D11348: Fixed deletion of files by Del button on Numeric Keypad.

Thanks Nikita for looking into this! I was unable to test it until now since I don't usually have access to a PC with standard keyboard with numeric keypad. It works nicely.

Mar 21 2018, 10:01 PM · Krusader
martinkostolny added a comment to D11523: Key handling bug and a QoL improvement.

adding all the keys we _know_ we don't want to search for like tab etc to the filtering if statement is a good idea

Mar 21 2018, 6:20 PM
martinkostolny accepted D11538: Added Konfigurator option to control bookmark search bar visibility.

Works nicely, thanks!

Mar 21 2018, 6:16 PM · Krusader
martinkostolny added a comment to D11444: Fixed jump-back actions in bookmark menu, improved separators.

Agreed with Rade about the missing displayed shortcuts. Otherwise it works nicely, thanks!

Mar 21 2018, 1:04 AM · Krusader
martinkostolny accepted D11525: Fix accidentally triggering menus.

Nice! I have to note that this only works without issue if it is applied along with D11523.

Mar 21 2018, 12:56 AM
martinkostolny accepted D11523: Key handling bug and a QoL improvement.

It seems to work nicely. Thanks!

Mar 21 2018, 12:50 AM
martinkostolny added a comment to D11222: Fix activating a found item with hash in URL inside search dialog..

Thank you both for the review :)

Mar 21 2018, 12:09 AM · Krusader
martinkostolny committed R167:7fab47a753e6: Merge branch 'search-dialog-enter' (authored by martinkostolny).
Merge branch 'search-dialog-enter'
Mar 21 2018, 12:08 AM
martinkostolny committed R167:325cd7c8c51d: Fix activating a found item with hash in URL inside search dialog. (authored by martinkostolny).
Fix activating a found item with hash in URL inside search dialog.
Mar 21 2018, 12:08 AM