martinkostolny (Martin Kostolný)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 11:37 PM (95 w, 4 d)
Availability
Available

Recent Activity

Today

martinkostolny added a comment to D9041: Ability to ignore defined files and directories from search results.

Hello! Have you, Martin, or anybody else tried the last diff? Is this the right approach to the problem? I've been using it since and technically there were no crashes with my use-cases.

Thu, Jan 18, 4:16 PM

Wed, Jan 10

martinkostolny committed R234:0532a2701870: added screenshots for new plasmoids (authored by martinkostolny).
added screenshots for new plasmoids
Wed, Jan 10, 11:59 PM
martinkostolny committed R885:c5a1a6ab123d: INSTALL file with install build & instructions added (authored by martinkostolny).
INSTALL file with install build & instructions added
Wed, Jan 10, 10:44 PM
martinkostolny committed R884:6c94e5a14a5b: .gitignore update (authored by martinkostolny).
.gitignore update
Wed, Jan 10, 10:28 PM
martinkostolny committed R884:41cf4067b90e: C++ plugin along with copied dbusmenuqt and appmenumodel updated (authored by martinkostolny).
C++ plugin along with copied dbusmenuqt and appmenumodel updated
Wed, Jan 10, 9:52 PM
martinkostolny committed R884:0d6581948725: license file added (authored by martinkostolny).
license file added
Wed, Jan 10, 4:59 PM
martinkostolny committed R885:2cbf5eda03e7: added license file (authored by martinkostolny).
added license file
Wed, Jan 10, 4:58 PM

Mon, Jan 8

martinkostolny committed R883:1508175: el translations added for active-window-control from original github project:.
el translations added for active-window-control from original github project:
Mon, Jan 8, 10:33 PM
martinkostolny committed R883:1508174: zh_TW translations added for redshift-control from original github project:.
zh_TW translations added for redshift-control from original github project:
Mon, Jan 8, 10:28 PM
martinkostolny committed R883:1508172: - missing zh_CN translations copied from original github projects:.
- missing zh_CN translations copied from original github projects:
Mon, Jan 8, 10:27 PM
martinkostolny committed R883:1508171: sr translations added for redshift-control from original github project:.
sr translations added for redshift-control from original github project:
Mon, Jan 8, 10:16 PM
martinkostolny committed R883:1508170: sr translations added for redshift-control from original github project:.
sr translations added for redshift-control from original github project:
Mon, Jan 8, 10:16 PM
martinkostolny committed R883:1508169: sr translations added for redshift-control from original github project:.
sr translations added for redshift-control from original github project:
Mon, Jan 8, 10:15 PM
martinkostolny committed R883:1508168: sr translations added for redshift-control from original github project:.
sr translations added for redshift-control from original github project:
Mon, Jan 8, 10:13 PM
martinkostolny committed R883:1508167: ru translations copied from original github projects:.
ru translations copied from original github projects:
Mon, Jan 8, 10:11 PM
martinkostolny committed R883:1508166: pl translations added for redshift-control from original github project:.
pl translations added for redshift-control from original github project:
Mon, Jan 8, 10:08 PM
martinkostolny committed R883:1508165: italian translations added for redshift-control from original github project:.
italian translations added for redshift-control from original github project:
Mon, Jan 8, 10:06 PM
martinkostolny committed R883:1508164: - most cz translations backported from original github projects:.
- most cz translations backported from original github projects:
Mon, Jan 8, 9:50 PM

Sun, Jan 7

martinkostolny committed R884:47810755bce5: fix Messages.sh (authored by martinkostolny).
fix Messages.sh
Sun, Jan 7, 11:04 PM
martinkostolny committed R884:8cc034b538ac: messages removed, Messages.sh moved to project-root (authored by martinkostolny).
messages removed, Messages.sh moved to project-root
Sun, Jan 7, 10:04 PM
martinkostolny committed R885:35a7e2d1d944: external-project-style translations removed, Messages.sh moved to project root (authored by martinkostolny).
external-project-style translations removed, Messages.sh moved to project root
Sun, Jan 7, 8:57 PM

Tue, Jan 2

martinkostolny added a comment to D9041: Ability to ignore defined files and directories from search results.

Thanks for the update! I've managed to make the input persistent. Please see attached diff (modification of yours) if it works :).

Tue, Jan 2, 1:18 PM

Tue, Dec 26

martinkostolny added a comment to D9041: Ability to ignore defined files and directories from search results.

Thanks for the update, Martin! And sorry it took me so long to dive in. I like it but I'd actually prefer the idea of Alex - keep all the settings in search dialog. I have modified your diff and made 2 screenshots.

Tue, Dec 26, 9:22 PM

Nov 29 2017

martinkostolny requested changes to D9041: Ability to ignore defined files and directories from search results.

Sorry, I've found a bug. During today Krusader use with your patch, there is reproducible crashing when using Synchronizer. When clicking "Compare" in Synchronizer dialog Krusader crashes. I'll have time to more closely look into that tomorrow.

Nov 29 2017, 1:09 PM

Nov 28 2017

martinkostolny accepted D9041: Ability to ignore defined files and directories from search results.

Hi! Thanks for your interest and code! I like it. Sometimes I also don't want to search in .git directories and this change will solve this, so this is great!

Nov 28 2017, 11:25 PM

Oct 7 2017

martinkostolny added a comment to D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc..

I hope you remembered to revert locally the commit.

Of course I didn't, sorry. But now I did. I reverted the KGlobalAccel commit, tested that previous bugs reappeared, then applied this patch and tested again - bugs are gone.

Oct 7 2017, 7:09 PM · Frameworks
martinkostolny committed R167:5b8621cd34b0: Fix mkdir and mkpath for krarc protocol (authored by martinkostolny).
Fix mkdir and mkpath for krarc protocol
Oct 7 2017, 12:13 AM
martinkostolny closed D7974: Fix mkdir and mkpath for krarc protocol.
Oct 7 2017, 12:12 AM · Krusader

Oct 6 2017

martinkostolny added a comment to D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc..

I've tested meta+shift+arrow, alt+shift+arrow, meta+shift+PrtSc and they are working for me, thanks! So far I didn't notice any regressions. I'll keep this version around and will report problem if I see one.
Unfortunately I'm unable to properly review the code itself since I have no knowledge in this area.

Oct 6 2017, 11:24 PM · Frameworks

Sep 24 2017

martinkostolny created D7974: Fix mkdir and mkpath for krarc protocol.
Sep 24 2017, 5:39 PM · Krusader

Sep 12 2017

martinkostolny added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Sorry, to be a bit late, but after updating to kwindowsystem 5.38, global shortcuts "meta+shift+<any_arrow_key>" and "alt+shift+<any_arrow_key>" stopped working on my system (Arch Linux). They can be configured no-problem (they are recognized and saved in configuration), but they do nothing afterwards. I'm writing it here because I've tracked the problem down to this commit. Is it reproducible on your side?

Sep 12 2017, 9:42 PM · Frameworks

Sep 9 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

I've noticed a regression after this push. Creation of new directory no longer focused the new directory. This should now be fixed in git with commit https://phabricator.kde.org/R167:ac22d0fc4412cc9a2f9130ba85184817c1667094. I didn't want to bother you with another review request. If there are another issues with this, I'll be happy to fix them.

Sep 9 2017, 3:19 PM · Krusader
martinkostolny committed R167:ac22d0fc4412: Fix for D7610 regression. Mkdir now focuses just created directory. (authored by martinkostolny).
Fix for D7610 regression. Mkdir now focuses just created directory.
Sep 9 2017, 3:14 PM
martinkostolny added a comment to D5734: Fix lister unintended selection while scrolling.

Thanks a lot for your thorough testing :).

Sep 9 2017, 2:38 PM · Krusader
martinkostolny committed R167:efd0e38a7a8c: Fix lister unintended selection while scrolling. (authored by martinkostolny).
Fix lister unintended selection while scrolling.
Sep 9 2017, 2:36 PM
martinkostolny closed D5734: Fix lister unintended selection while scrolling by committing R167:efd0e38a7a8c: Fix lister unintended selection while scrolling..
Sep 9 2017, 2:36 PM · Krusader

Sep 6 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

Thanks for testing. Committed without the commented code line mentioned by Toni, thanks for pointing that out!

Sep 6 2017, 12:22 AM · Krusader
martinkostolny committed R167:5e522c49b0f5: Support for "mkdir -p" re-added (authored by martinkostolny).
Support for "mkdir -p" re-added
Sep 6 2017, 12:19 AM
martinkostolny closed D7610: Support for "mkdir -p" re-added by committing R167:5e522c49b0f5: Support for "mkdir -p" re-added.
Sep 6 2017, 12:19 AM · Krusader

Aug 31 2017

martinkostolny updated the diff for D7610: Support for "mkdir -p" re-added.

Sorry, second iteration. Added support for absolute paths (starting with "/") - such path is resolved from root folder. Also works for remote filesystems. Tested on local fs and FTP.

Aug 31 2017, 10:42 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Toni, as always, thanks a lot for your testing!

Aug 31 2017, 8:37 PM · Krusader

Aug 29 2017

martinkostolny updated the summary of D7610: Support for "mkdir -p" re-added.
Aug 29 2017, 9:48 PM · Krusader
martinkostolny created D7610: Support for "mkdir -p" re-added.
Aug 29 2017, 9:42 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Thanks for testing, Toni! This is what I needed. Here is a fix for your findings :).

Aug 29 2017, 9:25 PM · Krusader

Aug 27 2017

martinkostolny accepted D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

Thanks Toni! :)

Aug 27 2017, 10:20 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Thanks for testing it out, Alex. Finally I've got to this. In order to find and address the scrolling issue - some refactoring has been done:

  • small code simplifications and deduplications throughout the lister.cpp (there is still room for further deduplications)
  • replaced new & delete char* cache in favour of safe QByteArray
  • removed constant updating of file state and position (updates only when search is in progress)
  • added tun of const
  • increased cache size -> which fixed issue with searching up the document (previously it found only some of supposed matches)
  • fixed scrolling issue
  • simplified code for remote file handling
Aug 27 2017, 10:17 PM · Krusader

Jul 6 2017

martinkostolny added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Sorry for my ignorance with the QDialog and memory leak issue, I've now learnt from it:). I believe the code now looks fine, and works. Although I'd rather remove the parent parameter (0) from new DiskUsageGUI call or replace with MAIN_VIEW like Alex was advising.

Jul 6 2017, 4:58 PM · Krusader

Jul 4 2017

martinkostolny added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 4 2017, 9:25 AM · Krusader

Jul 3 2017

martinkostolny accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Looks good to me and works. Thanks for your code! Please see one code comment.

Jul 3 2017, 5:10 AM · Krusader

May 29 2017

martinkostolny accepted D6010: Changes/Fixes for tab labels.

I definitely like this new way better. Thanks Alex!

May 29 2017, 1:27 PM

May 12 2017

martinkostolny committed R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item… (authored by martinkostolny).
Prevent focusing tab-bar when Krusader window is activated after previous item…
May 12 2017, 10:06 PM
martinkostolny closed D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename by committing R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item….
May 12 2017, 10:06 PM · Krusader
martinkostolny updated the diff for D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks for checking on this. I'm using your suggestion because I agree, it should be fixed closest to the source of troubles.

May 12 2017, 10:06 PM · Krusader

May 8 2017

martinkostolny accepted D5776: Show a lock icon for Locked tabs.

This is perfect! I also wanted to visualize the locked state but couldn't figure out how. This is a very elegant solution. Thanks!

May 8 2017, 8:23 PM
martinkostolny added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

And you don't have to do everything we say.

I know :), but this time I really didn't care that much.

May 8 2017, 7:22 PM · Krusader
martinkostolny committed R167:46f05d032be1: Fix loading a panel profile when existing panels are locked. (authored by martinkostolny).
Fix loading a panel profile when existing panels are locked.
May 8 2017, 7:07 PM
martinkostolny committed R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query… (authored by martinkostolny).
Add an option (persistent checkbox) in KrSearchDialog for adding a search query…
May 8 2017, 7:07 PM
martinkostolny closed D5744: Fix loading a panel profile with locked tabs by committing R167:46f05d032be1: Fix loading a panel profile when existing panels are locked..
May 8 2017, 7:07 PM · Krusader
martinkostolny closed D5735: Do not change clipboard while opening a searched file in KrSearchDialog by committing R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query….
May 8 2017, 7:07 PM · Krusader
martinkostolny created D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.
May 8 2017, 1:28 PM · Krusader
martinkostolny updated the diff for D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Thanks for feedback! Here is an update with the option.

May 8 2017, 9:57 AM · Krusader
martinkostolny updated the diff for D5744: Fix loading a panel profile with locked tabs.

My apologies, Alex, I must have missed your fix otherwise I'd test my workflow right away. Now I see You have fixed most of the issues. I've found only one edge-case. Loading a profile is reusing opened tabs, so if You already have a locked tab, it is locked before openUrl() is called. Here is the minimal exact steps to reproduce it:

  1. start fresh krusader (empty config)
    • we will focus on left panel only for this test
  2. go to e.g. Downloads
  3. save profile (e.g. "p1")
  4. go back to home folder and lock the tab
  5. load profile p1 -> You should see 2 tabs now instead of one
May 8 2017, 8:42 AM · Krusader

May 7 2017

martinkostolny created D5744: Fix loading a panel profile with locked tabs.
May 7 2017, 4:34 PM · Krusader
martinkostolny accepted D5714: Fix build with gcc 4.8.

Everything still seems to work just fine. Thanks for fixing older gcc compatibility!

May 7 2017, 1:45 PM
martinkostolny created D5735: Do not change clipboard while opening a searched file in KrSearchDialog.
May 7 2017, 1:14 AM · Krusader
martinkostolny created D5734: Fix lister unintended selection while scrolling.
May 7 2017, 12:47 AM · Krusader

Apr 30 2017

martinkostolny committed R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements (authored by martinkostolny).
KAuth integration in document saving - vol. 2 - various security improvements
Apr 30 2017, 11:40 AM
martinkostolny closed D5394: KAuth integration in document saving - vol. 2 by committing R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements.
Apr 30 2017, 11:39 AM · Frameworks, KTextEditor
martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

One more thing I've changed in the last diff:
When creating a new file in privileged directory, the file is then set to be readable by group and others. This is because kate wouldn't be able to read it later with regular user who managed to create it in the first place. I realize this is controversial so I will gladly remove this change if we agree on that. Probably the best approach would be to ask for permission to read it with another KAuth action, right?

Apr 30 2017, 12:32 AM · Frameworks, KTextEditor
martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Thanks for noticing the security issues! And sorry for the pause. Here is an updated diff which should ensure that QFile is using relative path. I've managed to reduce the use of absolute paths to this state - strace (saving privileged example2.txt file inside ~/Downloads):

chdir("/home/kotelnik/Downloads")       = 0
stat("example2.txt", {st_mode=S_IFREG|0640, st_size=1085659, ...}) = 0
getcwd("/home/kotelnik/Downloads", 4096) = 25
getpid()                                = 3343
open("/home/kotelnik/Downloads/example2.txt.TJ3343", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 10
fcntl(10, F_SETFD, FD_CLOEXEC)          = 0
lseek(10, 0, SEEK_SET)                  = 0
close(10)                               = 0
open("/tmp/kate.nS3280", O_RDONLY|O_CLOEXEC) = 10
fcntl(10, F_SETFD, FD_CLOEXEC)          = 0
fstat(10, {st_mode=S_IFREG|0600, st_size=1085661, ...}) = 0
open("example2.txt.TJ3343", O_RDWR|O_CREAT|O_CLOEXEC, 0666) = 11
[...]
stat("example2.txt", {st_mode=S_IFREG|0640, st_size=1085659, ...}) = 0
access("example2.txt", R_OK)            = 0
access("example2.txt", W_OK)            = 0
access("example2.txt", X_OK)            = -1 EACCES (Permission denied)
chmod("example2.txt.TJ3343", 0640)      = 0
fchown(11, 33, 33)                      = 0
rename("example2.txt.TJ3343", "example2.txt") = 0

One not-nice part in code is opening and immediately closing the QTemporaryFile (the only use of absolute path). Then tempFile is opened again with relative path and written to like before. I wanted to make use of the convenient way of creating unique temporary filename. Other suggestions are welcome :).

Apr 30 2017, 12:21 AM · Frameworks, KTextEditor

Apr 19 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything.

Apr 19 2017, 9:58 PM · Frameworks, KTextEditor
martinkostolny accepted D5493: New detailed tooltip for name column in panel view.

Very nice! I didn't find any issues. Thanks, Alex :).

Apr 19 2017, 3:34 PM

Apr 17 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Thanks for noticing all these security issues!

Apr 17 2017, 4:20 PM · Frameworks, KTextEditor

Apr 16 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Updated diff based on Fabian's advisory. Thanks, Fabian!

Apr 16 2017, 3:38 PM · Frameworks, KTextEditor

Apr 15 2017

martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

One more question - is it necessary to show the checksum to the user? I don't see what it would be good for, but I'm probably missing something.

Apr 15 2017, 5:04 PM · Frameworks, KTextEditor
martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

Sorry for answering after a longer time. I need to be sure I understand everything correctly:

Apr 15 2017, 4:56 PM · Frameworks, KTextEditor

Apr 12 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

Alex, thanks a lot for making the release and updating the corresponding wiki!

Apr 12 2017, 8:51 PM · Krusader

Apr 11 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've created a follow-up diff D5394 and added every subscriber from here. I hope it wasn't too invasive of me.

Apr 11 2017, 12:42 AM · Frameworks, KTextEditor
martinkostolny created D5394: KAuth integration in document saving - vol. 2.
Apr 11 2017, 12:37 AM · Frameworks, KTextEditor

Apr 8 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I like "Stiff Challenges" very much! Agreed, 2.6.0 version makes more sense.

Apr 8 2017, 6:38 PM · Krusader
martinkostolny added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for my late reaction. Yes, this is nicer and working. Thanks, Alex! To avoid waiting of each other: You do the commit :).

Apr 8 2017, 6:35 PM · Krusader

Apr 3 2017

martinkostolny updated the summary of D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:33 PM · Krusader
martinkostolny created D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:32 PM · Krusader

Apr 2 2017

martinkostolny committed R39:ae60880c5f9b: KAuth integration in document saving (authored by martinkostolny).
KAuth integration in document saving
Apr 2 2017, 2:34 PM
martinkostolny closed D4847: KAuth integration in document saving by committing R39:ae60880c5f9b: KAuth integration in document saving.
Apr 2 2017, 2:34 PM · Frameworks, KTextEditor

Mar 31 2017

martinkostolny accepted D5165: Avoiding root mode.

Sorry, for the late response. Yes, this is good, I like it. Thanks!

Mar 31 2017, 11:26 PM

Mar 29 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

Sure, no problem :).

Mar 29 2017, 12:30 PM · Frameworks, KTextEditor

Mar 28 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Updating diff with refinements based on David's insights, thanks David!

Mar 28 2017, 10:19 PM · Frameworks, KTextEditor

Mar 24 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Mar 24 2017, 6:52 AM · Krusader

Mar 21 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

it should work as it is now, or I am mistaken?

I believe the latest diff update is indeed making use of atomic rename. I will roughly summarize what the code currently does:

  1. First try to open QSaveFile, if succeeded -> finish writing as before the patch
  2. If opening QSaveFile fails KAuth action is called for creation of a temporary file in the same directory as the original target file
  3. Then writing to this file is performed as regular user (same as before the patch)
  4. Finally, second KAuth action is called to atomically rename the temporary file
Mar 21 2017, 5:48 PM · Frameworks, KTextEditor

Mar 15 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I know there is a lot of other stuff going on. So just to be sure: am I supposed to do something else - are we waiting for me?

Mar 15 2017, 5:09 PM · Frameworks, KTextEditor

Mar 10 2017

martinkostolny accepted D4994: Rework of checksum dialogs..

Very nice! Thanks Alex! :)

Mar 10 2017, 12:27 AM

Mar 9 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, no objections.

Mar 9 2017, 9:05 PM
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point! I was about to say that the target folder is in most cases non-writable without elevated privileges. But we can actually use KAuth action twice, for 2 simple jobs:

  1. Create temporary file right next to target file, set current user as owner, so it is writable without root privileges.
  2. And after storing file contents outside kauth helper binary. atomically rename the temporary file.
Mar 9 2017, 12:39 AM · KTextEditor, Frameworks

Mar 8 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a sorry for all the rookie mistakes. I tried to fix the problems You mentioned:

  • QT->Qt
  • get rid of useless streams
  • no more setting permissions and sync-to-disk when using QSaveFile
  • using of QMap::insert (should I use an initializer list instead?)
Mar 8 2017, 1:28 AM · KTextEditor, Frameworks

Mar 6 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a lot for all the thoughts and suggestions! I tried to work them in, but I need help with some of them.

Mar 6 2017, 10:57 PM · KTextEditor, Frameworks

Mar 5 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Understood and agreed, kauth_ktexteditor_helper it is :).

Mar 5 2017, 11:45 AM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful.

Mar 5 2017, 10:00 AM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point, thanks! I now the helper is really light-weight. Helper is now only moving a temporary file and setting permissions/owner.

Mar 5 2017, 1:27 AM · KTextEditor, Frameworks

Mar 3 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've learnt a few things about autotests (KTextEditor::EditorPrivate::unitTestMode() was really helpful, thanks!). I managed to create a test case, which allowed the code to go through KAuth action. But I was unsuccessful to finish it to my satisfaction - I couldn't come up with a solution where in case of unit testing KAuth dialog is not shown and just allows the execution. action.exectute(ExecutionMode::AuthorizeOnlyMode) will not help here since it does not really execute the action. I also tried to create "autotestsave" action alongside existing "save" action and set it to be always allowed. Then triggered it only from unit test. This worked well but I don't find it safe having such action available in non-testing runtime.

Mar 3 2017, 10:30 PM · KTextEditor, Frameworks