martinkostolny (Martin Kostolný)
User

Projects

Badges

User does not have any badges.
User Since
Mar 20 2016, 11:37 PM (49 w, 1 d)

Recent Activity

Yesterday

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

My big apologies, Wladimir, you were right that kdesu could not be found on my Arch linux because of the path differences You and Alex talked about. I've tested this patch on useractions instead of invoking root-mode, that's why it previously worked for me, stupid of me...

Mon, Feb 27, 7:05 PM
martinkostolny added a comment to D4828: Duplicated tab should not be locked.

For example me and a few friends of mine use it to keep some tabs in their locked path. When you select such locked tab and start browsing in it, you expect the tab to be duplicated and preserve the original selected tab. This is of course similar to selecting a tab, duplicating it and then browse. But with locked tab you can be sure you don't loose the tabs location. Of course it would be nice to have a visual difference between these two tab states (total commander appends * to such tab name) and a confirmation dialog whether I really want to close a locked tab. But I believe current state is good enough.

Mon, Feb 27, 5:27 PM · Krusader
martinkostolny created D4828: Duplicated tab should not be locked.
Mon, Feb 27, 4:45 PM · Krusader
martinkostolny accepted D4750: Entroducing... lazy panels.

So far I cannot find any regression. And since I'm many-tab-user I can really feel the speedup of Krusader startup, awesome, thanks Alex! :)

Mon, Feb 27, 4:31 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

This works as expected. Thanks!

Mon, Feb 27, 4:25 PM
martinkostolny accepted D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.
Mon, Feb 27, 4:12 PM
martinkostolny accepted D4747: Rework of size/space calculation.

Perfect, Alex, thanks! :)

Mon, Feb 27, 4:07 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Oh, good point, Toni! Thanks for making it through the long comments. I believe this will get eventually fixed in Kate but lets use kwrite again. At least until it is fixed.

Mon, Feb 27, 10:13 AM
martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree with Wladimir and Alex on this. I'm also fond of the third option: making root-mode unnecessary by providing support for elevating privileges for specific operations operations.

Mon, Feb 27, 9:43 AM

Fri, Feb 24

martinkostolny created D4775: Suggestion - newline ending after password to output.
Fri, Feb 24, 8:44 PM · Plasma
martinkostolny accepted D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Perfect! Although it would be nice (in future) to make sure this askpass program is installed (e.g. in INSTALL file?). I'll try to integrate the internal editor support for sudoedit and at the same time add the dependency.

Fri, Feb 24, 9:38 AM

Wed, Feb 22

martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, security is now better with this patch. It works on my Arch Linux. Thanks for taking care of this!

Wed, Feb 22, 11:15 PM

Tue, Feb 21

martinkostolny accepted D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.

Thanks! I didn't test it in Kubuntu but it still works fine on Arch.

Tue, Feb 21, 8:59 PM
martinkostolny accepted D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

This is perfect, thanks!

Tue, Feb 21, 12:18 AM

Tue, Feb 14

martinkostolny accepted D4610: Panel: Do not select .. in a filtered view if there are other entries.

Yes, the new behaviour makes definitely more sense. Thanks, Wladimir! :)

Tue, Feb 14, 10:24 PM
martinkostolny accepted D4609: Improved integration of (quick) search bar in panel.

Working very nicely, thanks! :-)

Tue, Feb 14, 8:06 PM
martinkostolny accepted D4512: Rework of vfile and KrPermHandler class.

That's a lot of work, thanks Alex! So far it is working nicely, I couldn't find any regressions.

Tue, Feb 14, 6:41 PM

Fri, Feb 10

martinkostolny accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Yes, that must have been it. It now works nicely, thanks for the patch! :)

Fri, Feb 10, 4:29 PM · Krusader

Thu, Feb 9

martinkostolny added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Alex have good points as well as You Wladimir about the simplicity of the previous code. I also agree now with the previous approach and sorry about the previous suggestion then.

Thu, Feb 9, 9:11 PM · Krusader

Wed, Feb 8

martinkostolny accepted D4146: ListPanel: don't go back in history if refresh failed.
Wed, Feb 8, 1:45 PM · Krusader
martinkostolny accepted D4420: #375894 - Use case-insensitive as default for text search.

I find these arguments good enough to set the default to case insensitive, like You proposed :).

Wed, Feb 8, 12:00 AM · Krusader

Sat, Feb 4

martinkostolny accepted D4427: Update "get involved" page to indicate how one can register.
Sat, Feb 4, 2:52 PM · Websites, Krusader
martinkostolny added a comment to D4420: #375894 - Use case-insensitive as default for text search.

The arguments about default case insensitivity in editors are convincing. But I'm heavy user of this search dialog and like the default case-sensitive setting which is on par with grep (like Alex just said). Maybe the best solution would be to make the setting persistent over Krusader restarts?

Sat, Feb 4, 2:49 PM · Krusader
martinkostolny accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Thanks!

Sat, Feb 4, 2:44 PM · Krusader
martinkostolny added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

I'd also say I don't like it that much. And maybe we don't want to duplicate every setting but just some of it - e.g. the one regarding KrView? My proposal is to create alternative KrView::restoreSettings method which would take another KrView reference as a parameter and load the settings directly from this given view. Any other suggestions? :)

Sat, Feb 4, 2:38 PM · Krusader
martinkostolny accepted D4417: #375831 - Sort empty file extensions correctly.

Agreed. Thanks a lot for your work! :)

Sat, Feb 4, 1:52 PM · Krusader

Sun, Jan 29

martinkostolny added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

About that F11 subject: Is it a change in the user interface of Krusader? :-?

I was also wondering that for a moment :-) but I believe Alex was talking about his own key bindings. It's still F8 by default in the code.

Sun, Jan 29, 9:23 AM

Jan 28 2017

martinkostolny accepted D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

Good improvement, thanks, Alex!

Jan 28 2017, 4:09 PM
martinkostolny accepted D4195: Changes in the installation documentation (2) - Web pages.

Ship it!

Jan 28 2017, 2:08 PM · Krusader, Websites
martinkostolny accepted D4194: Changes in the installation documentation (1) - INSTALL file.

Ship it! (Sorry for my late response)

Jan 28 2017, 1:59 PM · Websites, Krusader

Jan 16 2017

martinkostolny added a comment to D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

This look nice, almost perfect :)).

Jan 16 2017, 11:57 PM
martinkostolny committed R167:e8c4f66b1a4e: FIXED: [ 375135 ] segfault on viewing html files with Generic viewer (authored by martinkostolny).
FIXED: [ 375135 ] segfault on viewing html files with Generic viewer
Jan 16 2017, 9:08 PM

Jan 15 2017

martinkostolny accepted D4146: ListPanel: don't go back in history if refresh failed.

I'm definitely for this change! I don't like loosing the path when e.g. external disk is temporarily removed. Thanks!

Jan 15 2017, 8:40 PM · Krusader
martinkostolny accepted D4008: A warning note, like the formerly used ones, was added to the installation section. .

I understand the motivation behind the additional css now, so I'm also fine with your proposed changes. We can always adjust it later if we change our minds :).

Jan 15 2017, 3:35 PM · Krusader, Websites

Jan 10 2017

martinkostolny added a comment to D3994: add asynchronous vfs refresh.

Unfortunately I don't have this area studied enough yet to consult the direction. But I certainly can test your code and report issues:). So far I found some regarding refreshing:

  • external changes aren't reflected (I have to manual refresh Ctrl+R to see them)
  • undo action will not refresh view after it is done
Jan 10 2017, 9:44 PM · Krusader
martinkostolny added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

I like the idea about the installation note! But is it necessary to pull another css? How about leaving a plain paragraph to visually align with another paragraphs under rest of headings? Something like:

Jan 10 2017, 8:50 PM · Krusader, Websites
martinkostolny accepted D4071: Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode)..

I like these changes / fixes very much:). Thanks!

Jan 10 2017, 8:25 PM

Jan 3 2017

martinkostolny accepted D3938: VFS: cleaner code for refresh check on vfs operation without current directory.

Working nicely, thanks for the rework!

Jan 3 2017, 10:06 PM
martinkostolny accepted D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader.

It works, thanks! :)

Jan 3 2017, 7:53 PM · Krusader

Dec 18 2016

martinkostolny accepted D3722: Update the INSTALL file.
Dec 18 2016, 11:06 AM · Krusader

Dec 7 2016

martinkostolny added a comment to T3419: Rework of VFS.

Very nice, thanks for taking care of the KIO patch!

Dec 7 2016, 4:53 PM · Krusader
martinkostolny accepted D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

I like it, thanks! The start mode enum makes the code more understandable.

Dec 7 2016, 4:51 PM
martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

Agreed. I'm also not happy about the complexity. Now I realize, that reversing the mode is not such a good idea. So I'd at least remove F2 In Parallel option - this probably won't have much uses. I'd only be happy if F2 Queue was there when queueMode is off (in matter of additional feature to the original JobMan experience).

Dec 7 2016, 4:45 PM · Krusader

Dec 5 2016

martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

Actually that was intentional :). You started the jobs in queue mode, that's remembered, so they are performed in queue regardless of changed queueMode option. And it should work vice versa.

Dec 5 2016, 9:34 PM · Krusader

Dec 4 2016

martinkostolny added a comment to D3429: Browse Archives As Folders option applied to iso files.

comments dont belong into variable names :)

Agreed & fixed.

Dec 4 2016, 11:48 PM · Krusader
martinkostolny committed R167:f57edb20c4fa: Hard-code krarc.protocol mimetypes that were recently removed from protocol (authored by martinkostolny).
Hard-code krarc.protocol mimetypes that were recently removed from protocol
Dec 4 2016, 11:45 PM
martinkostolny closed D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol by committing R167:f57edb20c4fa: Hard-code krarc.protocol mimetypes that were recently removed from protocol.
Dec 4 2016, 11:45 PM · Krusader
martinkostolny committed R167:101091f3521f: Browse Archives As Folders option applied to iso files (authored by martinkostolny).
Browse Archives As Folders option applied to iso files
Dec 4 2016, 11:33 PM
martinkostolny closed D3429: Browse Archives As Folders option applied to iso files by committing R167:101091f3521f: Browse Archives As Folders option applied to iso files.
Dec 4 2016, 11:33 PM · Krusader

Dec 3 2016

martinkostolny updated the diff for D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol.

Just added another mime (application/vnd.rar) + code readability improved.

Dec 3 2016, 5:39 PM · Krusader
martinkostolny committed R167:fb60eda72097: Rename files inside archives (authored by martinkostolny).
Rename files inside archives
Dec 3 2016, 5:23 PM
martinkostolny closed D2614: First attempt to rename files inside archives by committing R167:fb60eda72097: Rename files inside archives.
Dec 3 2016, 5:23 PM · Krusader
martinkostolny added a comment to D2614: First attempt to rename files inside archives.

Tested another archives like deb, rpm and rar but none of them is write-supported by 7-zip. In fact 7-zip websites claim only unpack support for the rest of proprietary archive types I didn't test.

Dec 3 2016, 5:16 PM · Krusader

Dec 1 2016

martinkostolny retitled D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol from to Hard-code krarc.protocol mimetypes that were recently removed from protocol.
Dec 1 2016, 11:07 PM · Krusader
martinkostolny committed R167:0c4fb996a846: Re-add F2 Queue button to copy dialog (authored by martinkostolny).
Re-add F2 Queue button to copy dialog
Dec 1 2016, 5:22 PM
martinkostolny closed D3536: Re-add F2 Queue button to copy dialog by committing R167:0c4fb996a846: Re-add F2 Queue button to copy dialog.
Dec 1 2016, 5:22 PM · Krusader
martinkostolny updated the diff for D3536: Re-add F2 Queue button to copy dialog.

Changes in this diff:

  • added back Start Paused checkbox
  • renamed "queue" parameter to "reverseQueueMode"
  • renamed "queueBox" to "pauseBox"
  • added tooltips for F2 buttons
Dec 1 2016, 1:56 AM · Krusader

Nov 30 2016

martinkostolny updated the diff for D3536: Re-add F2 Queue button to copy dialog.

Diff updated:

  • compatibility after merging the manuallyPaused check
  • Run Immediately button textation
  • bool isQueueMode = _queueMode != reverseQueueMode;
Nov 30 2016, 1:05 AM · Krusader
martinkostolny committed R167:f5993e75ca4b: Do not automatically run manually paused job when other job in queue finishes. (authored by martinkostolny).
Do not automatically run manually paused job when other job in queue finishes.
Nov 30 2016, 12:50 AM
martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

If I see this right, the behavior is exactly the same as if you would enable/disable the "queue mode" before creating the job.

Yes, this is exactly what I intended. And I agree I'd have to add a tooltip. But I don't think it is complicated. It simply allows user to selectively choose to run new job in the other mode. I'll explain the intention later.

"F2 in parallel" doesn't do anything different if no jobs are currently running

That's true. Maybe it should be renamed to "F2 Run Immediately"?

this is less ambiguous

Yes, this is better, thanks!

It is impossible to create a paused job now if no other jobs are currently running. I think this was the main point of the old queue manager.

Yes, you are right about the impossibility to create the paused job. And maybe it can have some use-cases so I should add the checkbox back?

Nov 30 2016, 12:22 AM · Krusader

Nov 29 2016

martinkostolny added a comment to T3419: Rework of VFS.

Great work. thanks! Also thanks for fixing the focus in search modes etc.

Nov 29 2016, 7:26 AM · Krusader
martinkostolny retitled D3536: Re-add F2 Queue button to copy dialog from to Re-add F2 Queue button to copy dialog.
Nov 29 2016, 7:22 AM · Krusader

Nov 26 2016

martinkostolny accepted D3491: Fix compile warning in krArc.

Here on Arch (KF5.28) and Kubuntu 16.04 (KF5.18) the compilation now works with no warnings, thanks! Debian Stretch has KF5.22 so I suspect no problems there.

Nov 26 2016, 4:12 PM · Krusader

Nov 25 2016

martinkostolny added a comment to T3419: Rework of VFS.

Thanks for clarification! Now I see what the "Enqueue Operation" checkbox is really about. So every job added with the checkbox checked has to be unpaused manually to perform. The checkbox should probably be renamed to "Start Paused" but I'm unsure, too.

Nov 25 2016, 8:23 AM · Krusader

Nov 21 2016

martinkostolny added a comment to R167:e3fad5256a5c: Remove non-archive mimetypes from krarc archive mime type list.

Thanks for fixing the krarc protocol!

Nov 21 2016, 7:05 PM
martinkostolny added a comment to T3419: Rework of VFS.

Great work, Alex. Queuing is working perfectly, refreshing is fixed, and we have a nice job overview:). Many thanks for Your work!

Nov 21 2016, 6:44 PM · Krusader

Nov 20 2016

martinkostolny abandoned D3394: [vfs_rework] Do not forcibly focus to just refreshed listpanel.
Nov 20 2016, 11:39 PM · Krusader
martinkostolny added a comment to D3394: [vfs_rework] Do not forcibly focus to just refreshed listpanel.

people have a lot to thank to you :-)

Exactly. Thanks for doing it the right way! :)

Nov 20 2016, 11:39 PM · Krusader
martinkostolny retitled D3429: Browse Archives As Folders option applied to iso files from to Browse Archives As Folders option applied to iso files.
Nov 20 2016, 11:24 PM · Krusader

Nov 16 2016

martinkostolny added a comment to T3419: Rework of VFS.

I politely disagree. It is true that "unmanaged" corresponds to the the current behaviour- just start all jobs right away. But during testing i often had the situation that my system slows down a lot when more than two copy operations are working in parallel. And I believe most users will expect the queue behaviour.

Nov 16 2016, 11:51 PM · Krusader
martinkostolny retitled D3394: [vfs_rework] Do not forcibly focus to just refreshed listpanel from to [vfs_rework] Do not forcibly focus to just refreshed listpanel.
Nov 16 2016, 11:08 PM · Krusader

Nov 15 2016

martinkostolny committed R167:76a809ed3d7e: Fix re-asking password with some remote connections. Part of cleaning VFS (authored by martinkostolny).
Fix re-asking password with some remote connections. Part of cleaning VFS
Nov 15 2016, 11:16 PM
martinkostolny closed D3360: [vfs_rework] Fix re-asking password with some remote connections by committing R167:76a809ed3d7e: Fix re-asking password with some remote connections. Part of cleaning VFS.
Nov 15 2016, 11:16 PM · Krusader
martinkostolny added a comment to T3419: Rework of VFS.

Perfect! Thanks for all the fixes!

Nov 15 2016, 12:51 AM · Krusader
martinkostolny retitled D3360: [vfs_rework] Fix re-asking password with some remote connections from to [vfs_rework] Fix re-asking password with some remote connections.
Nov 15 2016, 12:02 AM · Krusader

Nov 14 2016

martinkostolny accepted D3353: Some fixes and simpifying startup settings..

Works well, thanks for this Alex!

Nov 14 2016, 10:35 PM

Nov 12 2016

martinkostolny added a comment to T3419: Rework of VFS.

Hi Alex! Thanks a lot for your fixes and advices!

Nov 12 2016, 4:20 PM · Krusader

Nov 7 2016

martinkostolny added a comment to T3419: Rework of VFS.

Very good, Alex thanks!

Nov 7 2016, 9:05 PM · Krusader
martinkostolny committed R167:cfd81da4e1ab: Fix unselecting externally deleted or renamed item. Part of cleaning VFS (authored by martinkostolny).
Fix unselecting externally deleted or renamed item. Part of cleaning VFS
Nov 7 2016, 8:33 PM
martinkostolny closed D3237: [vfs_rework] Fix unselecting externally deleted or renamed item by committing R167:cfd81da4e1ab: Fix unselecting externally deleted or renamed item. Part of cleaning VFS.
Nov 7 2016, 8:33 PM · Krusader

Nov 2 2016

martinkostolny abandoned D3208: [vfs_rework] Fixing scroll and focus jump when refreshing directory.

We better keep VFS clean.

Nov 2 2016, 10:43 PM · Krusader
martinkostolny added a comment to T3419: Rework of VFS.

Here is a new patch for the view :). Should address the external rename/remove. Again, don't hesitate to throw it away.
https://phabricator.kde.org/D3237

Nov 2 2016, 10:41 PM · Krusader
martinkostolny retitled D3237: [vfs_rework] Fix unselecting externally deleted or renamed item from to [vfs_rework] Fix unselecting externally deleted or renamed item.
Nov 2 2016, 10:39 PM · Krusader

Nov 1 2016

martinkostolny added a comment to T3419: Rework of VFS.

But I really think these are problems with the view, not the VFS.

You're probably right. Here are my thoughts that led me to my "solution". I think that the selective events for file creation and deletion should actually be provided by KDirWatch. Since this is not quite possible and we have to rely only on a dirty signal, I suspected the next layer (VFS) should handle that and emit granular changes to view. So view can only redraw what really changed.

Nov 1 2016, 9:16 PM · Krusader

Oct 30 2016

martinkostolny added a comment to T3419: Rework of VFS.

I've corrected a crash bug in my code and created a proper revision:
https://phabricator.kde.org/D3208
So please forgot the attachment in my previous post.

Oct 30 2016, 7:48 PM · Krusader
martinkostolny retitled D3208: [vfs_rework] Fixing scroll and focus jump when refreshing directory from to [vfs_rework] Fixing scroll and focus jump when refreshing directory.
Oct 30 2016, 7:47 PM · Krusader
martinkostolny added a comment to T3419: Rework of VFS.

OK, here is my first attempt for fixing the scroll jump and cursor move.

Oct 30 2016, 6:58 PM · Krusader

Oct 26 2016

martinkostolny added a comment to T3419: Rework of VFS.

Confirmed, free space info is now correctly refreshed, thanks Alex!

Oct 26 2016, 6:48 AM · Krusader

Oct 23 2016

martinkostolny added a comment to T3770: New Release.

Thanks a lot for making the new release a reality, Alex! You are doing a lot of work including bugzilla, so thanks again!

Oct 23 2016, 1:03 PM · Krusader

Oct 19 2016

martinkostolny added a comment to T3770: New Release.

I'm all for it! Will You take care of the release or should I? :)

Oct 19 2016, 9:36 PM · Krusader
martinkostolny added a comment to T3419: Rework of VFS.

I forgot to say that loosing current selection after rename is now truly fixed. Thanks!

Oct 19 2016, 7:08 AM · Krusader

Oct 18 2016

martinkostolny added a comment to T3419: Rework of VFS.

An example for a good branching model is here: http://nvie.com/posts/a-successful-git-branching-model/

Thanks for the useful link!

Oct 18 2016, 9:27 PM · Krusader

Oct 17 2016

martinkostolny added a comment to T3419: Rework of VFS.

It should be fixed now.

Now I can see no delays, thanks Alex!

Oct 17 2016, 10:48 PM · Krusader

Oct 16 2016

martinkostolny committed R167:b65632a153a3: Fix for diff. revision https://phabricator.kde.org/D2552 (authored by martinkostolny).
Fix for diff. revision https://phabricator.kde.org/D2552
Oct 16 2016, 10:14 PM
martinkostolny committed R167:e9ea9bc09ee2: Fix for diff. revision https://phabricator.kde.org/D2552 (authored by martinkostolny).
Fix for diff. revision https://phabricator.kde.org/D2552
Oct 16 2016, 10:08 PM

Oct 13 2016

martinkostolny added a comment to T3419: Rework of VFS.

You're right, now I'm now noticing that, too. It looks like it is slow even with e.g. 2 folders, so it looks like some kind of "fixed" delay when refreshing.

Oct 13 2016, 12:25 AM · Krusader

Oct 12 2016

martinkostolny added a comment to T3419: Rework of VFS.

Thanks a lot for this extensive work, Alex! I'll be using this branch as my default now.

Oct 12 2016, 1:20 PM · Krusader

Oct 10 2016

martinkostolny updated the diff for D2614: First attempt to rename files inside archives.

I just added:

  • checks if rename command is not empty and if exit code is a success
  • support for 7z archives
Oct 10 2016, 11:19 PM · Krusader
martinkostolny commandeered D2614: First attempt to rename files inside archives.

Thanks Davide, that (ERR_CANNOT_RENAME) works perfectly. I'll try to upload new diff with more checks.

Oct 10 2016, 11:14 PM · Krusader

Oct 9 2016

martinkostolny abandoned D2638: Update terminal emulator default value + provide a way to set a workdir explicitly.

Closing. (Automatic close by commit message didn't work this time)

Oct 9 2016, 7:19 PM · Krusader