martinkostolny (Martin Kostolný)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 11:37 PM (82 w, 6 d)
Availability
Available

Recent Activity

Sat, Oct 7

martinkostolny added a comment to D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc..

I hope you remembered to revert locally the commit.

Of course I didn't, sorry. But now I did. I reverted the KGlobalAccel commit, tested that previous bugs reappeared, then applied this patch and tested again - bugs are gone.

Sat, Oct 7, 7:09 PM · Frameworks
martinkostolny committed R167:5b8621cd34b0: Fix mkdir and mkpath for krarc protocol (authored by martinkostolny).
Fix mkdir and mkpath for krarc protocol
Sat, Oct 7, 12:13 AM
martinkostolny closed D7974: Fix mkdir and mkpath for krarc protocol.
Sat, Oct 7, 12:12 AM · Krusader

Fri, Oct 6

martinkostolny added a comment to D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc..

I've tested meta+shift+arrow, alt+shift+arrow, meta+shift+PrtSc and they are working for me, thanks! So far I didn't notice any regressions. I'll keep this version around and will report problem if I see one.
Unfortunately I'm unable to properly review the code itself since I have no knowledge in this area.

Fri, Oct 6, 11:24 PM · Frameworks

Sun, Sep 24

martinkostolny created D7974: Fix mkdir and mkpath for krarc protocol.
Sun, Sep 24, 5:39 PM · Krusader

Sep 12 2017

martinkostolny added a comment to D6233: KKeyServer: fix handling of KeypadModifier..

Sorry, to be a bit late, but after updating to kwindowsystem 5.38, global shortcuts "meta+shift+<any_arrow_key>" and "alt+shift+<any_arrow_key>" stopped working on my system (Arch Linux). They can be configured no-problem (they are recognized and saved in configuration), but they do nothing afterwards. I'm writing it here because I've tracked the problem down to this commit. Is it reproducible on your side?

Sep 12 2017, 9:42 PM · Frameworks

Sep 9 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

I've noticed a regression after this push. Creation of new directory no longer focused the new directory. This should now be fixed in git with commit https://phabricator.kde.org/R167:ac22d0fc4412cc9a2f9130ba85184817c1667094. I didn't want to bother you with another review request. If there are another issues with this, I'll be happy to fix them.

Sep 9 2017, 3:19 PM · Krusader
martinkostolny committed R167:ac22d0fc4412: Fix for D7610 regression. Mkdir now focuses just created directory. (authored by martinkostolny).
Fix for D7610 regression. Mkdir now focuses just created directory.
Sep 9 2017, 3:14 PM
martinkostolny added a comment to D5734: Fix lister unintended selection while scrolling.

Thanks a lot for your thorough testing :).

Sep 9 2017, 2:38 PM · Krusader
martinkostolny committed R167:efd0e38a7a8c: Fix lister unintended selection while scrolling. (authored by martinkostolny).
Fix lister unintended selection while scrolling.
Sep 9 2017, 2:36 PM
martinkostolny closed D5734: Fix lister unintended selection while scrolling by committing R167:efd0e38a7a8c: Fix lister unintended selection while scrolling..
Sep 9 2017, 2:36 PM · Krusader

Sep 6 2017

martinkostolny added a comment to D7610: Support for "mkdir -p" re-added.

Thanks for testing. Committed without the commented code line mentioned by Toni, thanks for pointing that out!

Sep 6 2017, 12:22 AM · Krusader
martinkostolny committed R167:5e522c49b0f5: Support for "mkdir -p" re-added (authored by martinkostolny).
Support for "mkdir -p" re-added
Sep 6 2017, 12:19 AM
martinkostolny closed D7610: Support for "mkdir -p" re-added by committing R167:5e522c49b0f5: Support for "mkdir -p" re-added.
Sep 6 2017, 12:19 AM · Krusader

Aug 31 2017

martinkostolny updated the diff for D7610: Support for "mkdir -p" re-added.

Sorry, second iteration. Added support for absolute paths (starting with "/") - such path is resolved from root folder. Also works for remote filesystems. Tested on local fs and FTP.

Aug 31 2017, 10:42 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Toni, as always, thanks a lot for your testing!

Aug 31 2017, 8:37 PM · Krusader

Aug 29 2017

martinkostolny updated the summary of D7610: Support for "mkdir -p" re-added.
Aug 29 2017, 9:48 PM · Krusader
martinkostolny created D7610: Support for "mkdir -p" re-added.
Aug 29 2017, 9:42 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Thanks for testing, Toni! This is what I needed. Here is a fix for your findings :).

Aug 29 2017, 9:25 PM · Krusader

Aug 27 2017

martinkostolny accepted D7557: Changes in the README to be better seen on https://phabricator.kde.org/source/krusader.

Thanks Toni! :)

Aug 27 2017, 10:20 PM · Krusader
martinkostolny updated the diff for D5734: Fix lister unintended selection while scrolling.

Thanks for testing it out, Alex. Finally I've got to this. In order to find and address the scrolling issue - some refactoring has been done:

  • small code simplifications and deduplications throughout the lister.cpp (there is still room for further deduplications)
  • replaced new & delete char* cache in favour of safe QByteArray
  • removed constant updating of file state and position (updates only when search is in progress)
  • added tun of const
  • increased cache size -> which fixed issue with searching up the document (previously it found only some of supposed matches)
  • fixed scrolling issue
  • simplified code for remote file handling
Aug 27 2017, 10:17 PM · Krusader

Jul 6 2017

martinkostolny added a comment to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Sorry for my ignorance with the QDialog and memory leak issue, I've now learnt from it:). I believe the code now looks fine, and works. Although I'd rather remove the parent parameter (0) from new DiskUsageGUI call or replace with MAIN_VIEW like Alex was advising.

Jul 6 2017, 4:58 PM · Krusader

Jul 4 2017

martinkostolny added inline comments to D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".
Jul 4 2017, 9:25 AM · Krusader

Jul 3 2017

martinkostolny accepted D6471: Patch for T2047 "Make "Disk Usage window" a regular window (if this takes too long, make it a modal window)".

Looks good to me and works. Thanks for your code! Please see one code comment.

Jul 3 2017, 5:10 AM · Krusader

May 29 2017

martinkostolny accepted D6010: Changes/Fixes for tab labels.

I definitely like this new way better. Thanks Alex!

May 29 2017, 1:27 PM

May 12 2017

martinkostolny committed R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item… (authored by martinkostolny).
Prevent focusing tab-bar when Krusader window is activated after previous item…
May 12 2017, 10:06 PM
martinkostolny closed D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename by committing R167:9617ba9c3f81: Prevent focusing tab-bar when Krusader window is activated after previous item….
May 12 2017, 10:06 PM · Krusader
martinkostolny updated the diff for D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.

Thanks for checking on this. I'm using your suggestion because I agree, it should be fixed closest to the source of troubles.

May 12 2017, 10:06 PM · Krusader

May 8 2017

martinkostolny accepted D5776: Show a lock icon for Locked tabs.

This is perfect! I also wanted to visualize the locked state but couldn't figure out how. This is a very elegant solution. Thanks!

May 8 2017, 8:23 PM
martinkostolny added a comment to D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

And you don't have to do everything we say.

I know :), but this time I really didn't care that much.

May 8 2017, 7:22 PM · Krusader
martinkostolny committed R167:46f05d032be1: Fix loading a panel profile when existing panels are locked. (authored by martinkostolny).
Fix loading a panel profile when existing panels are locked.
May 8 2017, 7:07 PM
martinkostolny committed R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query… (authored by martinkostolny).
Add an option (persistent checkbox) in KrSearchDialog for adding a search query…
May 8 2017, 7:07 PM
martinkostolny closed D5744: Fix loading a panel profile with locked tabs by committing R167:46f05d032be1: Fix loading a panel profile when existing panels are locked..
May 8 2017, 7:07 PM · Krusader
martinkostolny closed D5735: Do not change clipboard while opening a searched file in KrSearchDialog by committing R167:f03636000f03: Add an option (persistent checkbox) in KrSearchDialog for adding a search query….
May 8 2017, 7:07 PM · Krusader
martinkostolny created D5765: Prevent focusing tab-bar when Krusader window is activated after previous item rename.
May 8 2017, 1:28 PM · Krusader
martinkostolny updated the diff for D5735: Do not change clipboard while opening a searched file in KrSearchDialog.

Thanks for feedback! Here is an update with the option.

May 8 2017, 9:57 AM · Krusader
martinkostolny updated the diff for D5744: Fix loading a panel profile with locked tabs.

My apologies, Alex, I must have missed your fix otherwise I'd test my workflow right away. Now I see You have fixed most of the issues. I've found only one edge-case. Loading a profile is reusing opened tabs, so if You already have a locked tab, it is locked before openUrl() is called. Here is the minimal exact steps to reproduce it:

  1. start fresh krusader (empty config)
    • we will focus on left panel only for this test
  2. go to e.g. Downloads
  3. save profile (e.g. "p1")
  4. go back to home folder and lock the tab
  5. load profile p1 -> You should see 2 tabs now instead of one
May 8 2017, 8:42 AM · Krusader

May 7 2017

martinkostolny created D5744: Fix loading a panel profile with locked tabs.
May 7 2017, 4:34 PM · Krusader
martinkostolny accepted D5714: Fix build with gcc 4.8.

Everything still seems to work just fine. Thanks for fixing older gcc compatibility!

May 7 2017, 1:45 PM
martinkostolny created D5735: Do not change clipboard while opening a searched file in KrSearchDialog.
May 7 2017, 1:14 AM · Krusader
martinkostolny created D5734: Fix lister unintended selection while scrolling.
May 7 2017, 12:47 AM · Krusader

Apr 30 2017

martinkostolny committed R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements (authored by martinkostolny).
KAuth integration in document saving - vol. 2 - various security improvements
Apr 30 2017, 11:40 AM
martinkostolny closed D5394: KAuth integration in document saving - vol. 2 by committing R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements.
Apr 30 2017, 11:39 AM · Frameworks, KTextEditor
martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

One more thing I've changed in the last diff:
When creating a new file in privileged directory, the file is then set to be readable by group and others. This is because kate wouldn't be able to read it later with regular user who managed to create it in the first place. I realize this is controversial so I will gladly remove this change if we agree on that. Probably the best approach would be to ask for permission to read it with another KAuth action, right?

Apr 30 2017, 12:32 AM · Frameworks, KTextEditor
martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Thanks for noticing the security issues! And sorry for the pause. Here is an updated diff which should ensure that QFile is using relative path. I've managed to reduce the use of absolute paths to this state - strace (saving privileged example2.txt file inside ~/Downloads):

chdir("/home/kotelnik/Downloads")       = 0
stat("example2.txt", {st_mode=S_IFREG|0640, st_size=1085659, ...}) = 0
getcwd("/home/kotelnik/Downloads", 4096) = 25
getpid()                                = 3343
open("/home/kotelnik/Downloads/example2.txt.TJ3343", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 10
fcntl(10, F_SETFD, FD_CLOEXEC)          = 0
lseek(10, 0, SEEK_SET)                  = 0
close(10)                               = 0
open("/tmp/kate.nS3280", O_RDONLY|O_CLOEXEC) = 10
fcntl(10, F_SETFD, FD_CLOEXEC)          = 0
fstat(10, {st_mode=S_IFREG|0600, st_size=1085661, ...}) = 0
open("example2.txt.TJ3343", O_RDWR|O_CREAT|O_CLOEXEC, 0666) = 11
[...]
stat("example2.txt", {st_mode=S_IFREG|0640, st_size=1085659, ...}) = 0
access("example2.txt", R_OK)            = 0
access("example2.txt", W_OK)            = 0
access("example2.txt", X_OK)            = -1 EACCES (Permission denied)
chmod("example2.txt.TJ3343", 0640)      = 0
fchown(11, 33, 33)                      = 0
rename("example2.txt.TJ3343", "example2.txt") = 0

One not-nice part in code is opening and immediately closing the QTemporaryFile (the only use of absolute path). Then tempFile is opened again with relative path and written to like before. I wanted to make use of the convenient way of creating unique temporary filename. Other suggestions are welcome :).

Apr 30 2017, 12:21 AM · Frameworks, KTextEditor

Apr 19 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything.

Apr 19 2017, 9:58 PM · Frameworks, KTextEditor
martinkostolny accepted D5493: New detailed tooltip for name column in panel view.

Very nice! I didn't find any issues. Thanks, Alex :).

Apr 19 2017, 3:34 PM

Apr 17 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Thanks for noticing all these security issues!

Apr 17 2017, 4:20 PM · Frameworks, KTextEditor

Apr 16 2017

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Updated diff based on Fabian's advisory. Thanks, Fabian!

Apr 16 2017, 3:38 PM · Frameworks, KTextEditor

Apr 15 2017

martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

One more question - is it necessary to show the checksum to the user? I don't see what it would be good for, but I'm probably missing something.

Apr 15 2017, 5:04 PM · Frameworks, KTextEditor
martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

Sorry for answering after a longer time. I need to be sure I understand everything correctly:

Apr 15 2017, 4:56 PM · Frameworks, KTextEditor

Apr 12 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

Alex, thanks a lot for making the release and updating the corresponding wiki!

Apr 12 2017, 8:51 PM · Krusader

Apr 11 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've created a follow-up diff D5394 and added every subscriber from here. I hope it wasn't too invasive of me.

Apr 11 2017, 12:42 AM · KTextEditor, Frameworks
martinkostolny created D5394: KAuth integration in document saving - vol. 2.
Apr 11 2017, 12:37 AM · Frameworks, KTextEditor

Apr 8 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I like "Stiff Challenges" very much! Agreed, 2.6.0 version makes more sense.

Apr 8 2017, 6:38 PM · Krusader
martinkostolny added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for my late reaction. Yes, this is nicer and working. Thanks, Alex! To avoid waiting of each other: You do the commit :).

Apr 8 2017, 6:35 PM · Krusader

Apr 3 2017

martinkostolny updated the summary of D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:33 PM · Krusader
martinkostolny created D5292: Fix for crash when closing currently refreshing panel.
Apr 3 2017, 10:32 PM · Krusader

Apr 2 2017

martinkostolny committed R39:ae60880c5f9b: KAuth integration in document saving (authored by martinkostolny).
KAuth integration in document saving
Apr 2 2017, 2:34 PM
martinkostolny closed D4847: KAuth integration in document saving by committing R39:ae60880c5f9b: KAuth integration in document saving.
Apr 2 2017, 2:34 PM · KTextEditor, Frameworks

Mar 31 2017

martinkostolny accepted D5165: Avoiding root mode.

Sorry, for the late response. Yes, this is good, I like it. Thanks!

Mar 31 2017, 11:26 PM

Mar 29 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

Sure, no problem :).

Mar 29 2017, 12:30 PM · KTextEditor, Frameworks

Mar 28 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Updating diff with refinements based on David's insights, thanks David!

Mar 28 2017, 10:19 PM · KTextEditor, Frameworks

Mar 24 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Mar 24 2017, 6:52 AM · Krusader

Mar 21 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

it should work as it is now, or I am mistaken?

I believe the latest diff update is indeed making use of atomic rename. I will roughly summarize what the code currently does:

  1. First try to open QSaveFile, if succeeded -> finish writing as before the patch
  2. If opening QSaveFile fails KAuth action is called for creation of a temporary file in the same directory as the original target file
  3. Then writing to this file is performed as regular user (same as before the patch)
  4. Finally, second KAuth action is called to atomically rename the temporary file
Mar 21 2017, 5:48 PM · KTextEditor, Frameworks

Mar 15 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I know there is a lot of other stuff going on. So just to be sure: am I supposed to do something else - are we waiting for me?

Mar 15 2017, 5:09 PM · KTextEditor, Frameworks

Mar 10 2017

martinkostolny accepted D4994: Rework of checksum dialogs..

Very nice! Thanks Alex! :)

Mar 10 2017, 12:27 AM

Mar 9 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, no objections.

Mar 9 2017, 9:05 PM
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point! I was about to say that the target folder is in most cases non-writable without elevated privileges. But we can actually use KAuth action twice, for 2 simple jobs:

  1. Create temporary file right next to target file, set current user as owner, so it is writable without root privileges.
  2. And after storing file contents outside kauth helper binary. atomically rename the temporary file.
Mar 9 2017, 12:39 AM · KTextEditor, Frameworks

Mar 8 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a sorry for all the rookie mistakes. I tried to fix the problems You mentioned:

  • QT->Qt
  • get rid of useless streams
  • no more setting permissions and sync-to-disk when using QSaveFile
  • using of QMap::insert (should I use an initializer list instead?)
Mar 8 2017, 1:28 AM · KTextEditor, Frameworks

Mar 6 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a lot for all the thoughts and suggestions! I tried to work them in, but I need help with some of them.

Mar 6 2017, 10:57 PM · KTextEditor, Frameworks

Mar 5 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Understood and agreed, kauth_ktexteditor_helper it is :).

Mar 5 2017, 11:45 AM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful.

Mar 5 2017, 10:00 AM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point, thanks! I now the helper is really light-weight. Helper is now only moving a temporary file and setting permissions/owner.

Mar 5 2017, 1:27 AM · KTextEditor, Frameworks

Mar 3 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've learnt a few things about autotests (KTextEditor::EditorPrivate::unitTestMode() was really helpful, thanks!). I managed to create a test case, which allowed the code to go through KAuth action. But I was unsuccessful to finish it to my satisfaction - I couldn't come up with a solution where in case of unit testing KAuth dialog is not shown and just allows the execution. action.exectute(ExecutionMode::AuthorizeOnlyMode) will not help here since it does not really execute the action. I also tried to create "autotestsave" action alongside existing "save" action and set it to be always allowed. Then triggered it only from unit test. This worked well but I don't find it safe having such action available in non-testing runtime.

Mar 3 2017, 10:30 PM · KTextEditor, Frameworks

Mar 2 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

After reading though bug mentioned by Luigi and this QT bug (https://bugreports.qt.io/browse/QTBUG-56366) I'm not so convinced that we want to directly write to file in order to maintain owner, because we would loose atomicity of the save operation. I've updated the diff so at least group is restored to the previous one if owner cannot be changed. I think loosing group was the most painful outcome of QSaveFile design.

Mar 2 2017, 6:10 PM · KTextEditor, Frameworks
martinkostolny added a comment to D4847: KAuth integration in document saving.

I think that leaving it as it is is not a solution

In that case, I favour the second option (direct write to file).

Mar 2 2017, 2:28 PM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Next iteration, still without autotests, I need to study them more.

Mar 2 2017, 2:07 PM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks for all the feedback!

Mar 2 2017, 12:04 PM · KTextEditor, Frameworks

Mar 1 2017

martinkostolny committed R167:70bbac90cd0e: Duplicated tab should not be locked (authored by martinkostolny).
Duplicated tab should not be locked
Mar 1 2017, 11:30 AM
martinkostolny closed D4828: Duplicated tab should not be locked by committing R167:70bbac90cd0e: Duplicated tab should not be locked.
Mar 1 2017, 11:30 AM · Krusader
martinkostolny updated the diff for D4847: KAuth integration in document saving.

I once again updated the diff - I've only renamed 2 variables to better reflect what they mean:
readAction -> saveAction (I copied that one from tutorial page and forgot to rename)
dataToWrite -> dataToSave

Mar 1 2017, 9:56 AM · KTextEditor, Frameworks
martinkostolny updated the diff for D4847: KAuth integration in document saving.

I missed this one - thanks, Wladimir. Fixed.

Mar 1 2017, 9:10 AM · KTextEditor, Frameworks

Feb 28 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I value security over features.

Me too, so I tend to agree with removal of root-mode, but Wladimir already improved current state of Krusader security. So I say lets keep it for a little while. In the meantime I will work on an integration with KAuth for some actions. I just managed to integrate it in KTextEditor ( https://phabricator.kde.org/D4847 ), so one can now edit write-protected document in our internal editor being conveniently asked for password on save.

Feb 28 2017, 11:08 PM
martinkostolny created D4847: KAuth integration in document saving.
Feb 28 2017, 10:45 PM · KTextEditor, Frameworks

Feb 27 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

My big apologies, Wladimir, you were right that kdesu could not be found on my Arch linux because of the path differences You and Alex talked about. I've tested this patch on useractions instead of invoking root-mode, that's why it previously worked for me, stupid of me...

Feb 27 2017, 7:05 PM
martinkostolny added a comment to D4828: Duplicated tab should not be locked.

For example me and a few friends of mine use it to keep some tabs in their locked path. When you select such locked tab and start browsing in it, you expect the tab to be duplicated and preserve the original selected tab. This is of course similar to selecting a tab, duplicating it and then browse. But with locked tab you can be sure you don't loose the tabs location. Of course it would be nice to have a visual difference between these two tab states (total commander appends * to such tab name) and a confirmation dialog whether I really want to close a locked tab. But I believe current state is good enough.

Feb 27 2017, 5:27 PM · Krusader
martinkostolny created D4828: Duplicated tab should not be locked.
Feb 27 2017, 4:45 PM · Krusader
martinkostolny accepted D4750: Entroducing... lazy panels.

So far I cannot find any regression. And since I'm many-tab-user I can really feel the speedup of Krusader startup, awesome, thanks Alex! :)

Feb 27 2017, 4:31 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

This works as expected. Thanks!

Feb 27 2017, 4:25 PM
martinkostolny accepted D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.
Feb 27 2017, 4:12 PM
martinkostolny accepted D4747: Rework of size/space calculation.

Perfect, Alex, thanks! :)

Feb 27 2017, 4:07 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Oh, good point, Toni! Thanks for making it through the long comments. I believe this will get eventually fixed in Kate but lets use kwrite again. At least until it is fixed.

Feb 27 2017, 10:13 AM
martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree with Wladimir and Alex on this. I'm also fond of the third option: making root-mode unnecessary by providing support for elevating privileges for specific operations operations.

Feb 27 2017, 9:43 AM

Feb 24 2017

martinkostolny created D4775: Suggestion - newline ending after password to output.
Feb 24 2017, 8:44 PM · Plasma
martinkostolny accepted D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Perfect! Although it would be nice (in future) to make sure this askpass program is installed (e.g. in INSTALL file?). I'll try to integrate the internal editor support for sudoedit and at the same time add the dependency.

Feb 24 2017, 9:38 AM

Feb 22 2017

martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, security is now better with this patch. It works on my Arch Linux. Thanks for taking care of this!

Feb 22 2017, 11:15 PM

Feb 21 2017

martinkostolny accepted D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.

Thanks! I didn't test it in Kubuntu but it still works fine on Arch.

Feb 21 2017, 8:59 PM
martinkostolny accepted D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

This is perfect, thanks!

Feb 21 2017, 12:18 AM

Feb 14 2017

martinkostolny accepted D4610: Panel: Do not select .. in a filtered view if there are other entries.

Yes, the new behaviour makes definitely more sense. Thanks, Wladimir! :)

Feb 14 2017, 10:24 PM