martinkostolny (Martin Kostolný)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2016, 11:37 PM (57 w, 1 d)
Availability
Available

Recent Activity

Wed, Apr 19

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything.

Wed, Apr 19, 9:58 PM · Frameworks, KTextEditor
martinkostolny accepted D5493: New detailed tooltip for name column in panel view.

Very nice! I didn't find any issues. Thanks, Alex :).

Wed, Apr 19, 3:34 PM

Mon, Apr 17

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Thanks for noticing all these security issues!

Mon, Apr 17, 4:20 PM · Frameworks, KTextEditor

Sun, Apr 16

martinkostolny updated the diff for D5394: KAuth integration in document saving - vol. 2.

Updated diff based on Fabian's advisory. Thanks, Fabian!

Sun, Apr 16, 3:38 PM · Frameworks, KTextEditor

Sat, Apr 15

martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

One more question - is it necessary to show the checksum to the user? I don't see what it would be good for, but I'm probably missing something.

Sat, Apr 15, 5:04 PM · Frameworks, KTextEditor
martinkostolny added a comment to D5394: KAuth integration in document saving - vol. 2.

Sorry for answering after a longer time. I need to be sure I understand everything correctly:

Sat, Apr 15, 4:56 PM · Frameworks, KTextEditor

Wed, Apr 12

martinkostolny added a comment to T5716: New release: 2.6.0.

Alex, thanks a lot for making the release and updating the corresponding wiki!

Wed, Apr 12, 8:51 PM · Krusader

Tue, Apr 11

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've created a follow-up diff D5394 and added every subscriber from here. I hope it wasn't too invasive of me.

Tue, Apr 11, 12:42 AM · Frameworks, KTextEditor
martinkostolny created D5394: KAuth integration in document saving - vol. 2.
Tue, Apr 11, 12:37 AM · Frameworks, KTextEditor

Sat, Apr 8

martinkostolny added a comment to T5716: New release: 2.6.0.

I like "Stiff Challenges" very much! Agreed, 2.6.0 version makes more sense.

Sat, Apr 8, 6:38 PM · Krusader
martinkostolny added a comment to D5292: Fix for crash when closing currently refreshing panel.

Sorry for my late reaction. Yes, this is nicer and working. Thanks, Alex! To avoid waiting of each other: You do the commit :).

Sat, Apr 8, 6:35 PM · Krusader

Mon, Apr 3

martinkostolny updated the summary of D5292: Fix for crash when closing currently refreshing panel.
Mon, Apr 3, 10:33 PM · Krusader
martinkostolny created D5292: Fix for crash when closing currently refreshing panel.
Mon, Apr 3, 10:32 PM · Krusader

Sun, Apr 2

martinkostolny committed R39:ae60880c5f9b: KAuth integration in document saving (authored by martinkostolny).
KAuth integration in document saving
Sun, Apr 2, 2:34 PM
martinkostolny closed D4847: KAuth integration in document saving by committing R39:ae60880c5f9b: KAuth integration in document saving.
Sun, Apr 2, 2:34 PM · Frameworks, KTextEditor

Fri, Mar 31

martinkostolny accepted D5165: Avoiding root mode.

Sorry, for the late response. Yes, this is good, I like it. Thanks!

Fri, Mar 31, 11:26 PM

Wed, Mar 29

martinkostolny added a comment to D4847: KAuth integration in document saving.

Sure, no problem :).

Wed, Mar 29, 12:30 PM · Frameworks, KTextEditor

Tue, Mar 28

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Updating diff with refinements based on David's insights, thanks David!

Tue, Mar 28, 10:19 PM · Frameworks, KTextEditor

Mar 24 2017

martinkostolny added a comment to T5716: New release: 2.6.0.

I agree. Probably lame but how about "Job-Man Show"? :)

Mar 24 2017, 6:52 AM · Krusader

Mar 21 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

it should work as it is now, or I am mistaken?

I believe the latest diff update is indeed making use of atomic rename. I will roughly summarize what the code currently does:

  1. First try to open QSaveFile, if succeeded -> finish writing as before the patch
  2. If opening QSaveFile fails KAuth action is called for creation of a temporary file in the same directory as the original target file
  3. Then writing to this file is performed as regular user (same as before the patch)
  4. Finally, second KAuth action is called to atomically rename the temporary file
Mar 21 2017, 5:48 PM · Frameworks, KTextEditor

Mar 15 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I know there is a lot of other stuff going on. So just to be sure: am I supposed to do something else - are we waiting for me?

Mar 15 2017, 5:09 PM · Frameworks, KTextEditor

Mar 10 2017

martinkostolny accepted D4994: Rework of checksum dialogs..

Very nice! Thanks Alex! :)

Mar 10 2017, 12:27 AM

Mar 9 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, no objections.

Mar 9 2017, 9:05 PM
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point! I was about to say that the target folder is in most cases non-writable without elevated privileges. But we can actually use KAuth action twice, for 2 simple jobs:

  1. Create temporary file right next to target file, set current user as owner, so it is writable without root privileges.
  2. And after storing file contents outside kauth helper binary. atomically rename the temporary file.
Mar 9 2017, 12:39 AM · Frameworks, KTextEditor

Mar 8 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a sorry for all the rookie mistakes. I tried to fix the problems You mentioned:

  • QT->Qt
  • get rid of useless streams
  • no more setting permissions and sync-to-disk when using QSaveFile
  • using of QMap::insert (should I use an initializer list instead?)
Mar 8 2017, 1:28 AM · Frameworks, KTextEditor

Mar 6 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks a lot for all the thoughts and suggestions! I tried to work them in, but I need help with some of them.

Mar 6 2017, 10:57 PM · Frameworks, KTextEditor

Mar 5 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

Understood and agreed, kauth_ktexteditor_helper it is :).

Mar 5 2017, 11:45 AM · Frameworks, KTextEditor
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks for your guidance and for having the patience with me. QScopedPointer was indeed very useful.

Mar 5 2017, 10:00 AM · Frameworks, KTextEditor
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Good point, thanks! I now the helper is really light-weight. Helper is now only moving a temporary file and setting permissions/owner.

Mar 5 2017, 1:27 AM · Frameworks, KTextEditor

Mar 3 2017

martinkostolny added a comment to D4847: KAuth integration in document saving.

I've learnt a few things about autotests (KTextEditor::EditorPrivate::unitTestMode() was really helpful, thanks!). I managed to create a test case, which allowed the code to go through KAuth action. But I was unsuccessful to finish it to my satisfaction - I couldn't come up with a solution where in case of unit testing KAuth dialog is not shown and just allows the execution. action.exectute(ExecutionMode::AuthorizeOnlyMode) will not help here since it does not really execute the action. I also tried to create "autotestsave" action alongside existing "save" action and set it to be always allowed. Then triggered it only from unit test. This worked well but I don't find it safe having such action available in non-testing runtime.

Mar 3 2017, 10:30 PM · Frameworks, KTextEditor

Mar 2 2017

martinkostolny updated the diff for D4847: KAuth integration in document saving.

After reading though bug mentioned by Luigi and this QT bug (https://bugreports.qt.io/browse/QTBUG-56366) I'm not so convinced that we want to directly write to file in order to maintain owner, because we would loose atomicity of the save operation. I've updated the diff so at least group is restored to the previous one if owner cannot be changed. I think loosing group was the most painful outcome of QSaveFile design.

Mar 2 2017, 6:10 PM · Frameworks, KTextEditor
martinkostolny added a comment to D4847: KAuth integration in document saving.

I think that leaving it as it is is not a solution

In that case, I favour the second option (direct write to file).

Mar 2 2017, 2:28 PM · Frameworks, KTextEditor
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Next iteration, still without autotests, I need to study them more.

Mar 2 2017, 2:07 PM · Frameworks, KTextEditor
martinkostolny updated the diff for D4847: KAuth integration in document saving.

Thanks for all the feedback!

Mar 2 2017, 12:04 PM · Frameworks, KTextEditor

Mar 1 2017

martinkostolny committed R167:70bbac90cd0e: Duplicated tab should not be locked (authored by martinkostolny).
Duplicated tab should not be locked
Mar 1 2017, 11:30 AM
martinkostolny closed D4828: Duplicated tab should not be locked by committing R167:70bbac90cd0e: Duplicated tab should not be locked.
Mar 1 2017, 11:30 AM · Krusader
martinkostolny updated the diff for D4847: KAuth integration in document saving.

I once again updated the diff - I've only renamed 2 variables to better reflect what they mean:
readAction -> saveAction (I copied that one from tutorial page and forgot to rename)
dataToWrite -> dataToSave

Mar 1 2017, 9:56 AM · Frameworks, KTextEditor
martinkostolny updated the diff for D4847: KAuth integration in document saving.

I missed this one - thanks, Wladimir. Fixed.

Mar 1 2017, 9:10 AM · Frameworks, KTextEditor

Feb 28 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I value security over features.

Me too, so I tend to agree with removal of root-mode, but Wladimir already improved current state of Krusader security. So I say lets keep it for a little while. In the meantime I will work on an integration with KAuth for some actions. I just managed to integrate it in KTextEditor ( https://phabricator.kde.org/D4847 ), so one can now edit write-protected document in our internal editor being conveniently asked for password on save.

Feb 28 2017, 11:08 PM
martinkostolny created D4847: KAuth integration in document saving.
Feb 28 2017, 10:45 PM · Frameworks, KTextEditor

Feb 27 2017

martinkostolny added a comment to D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

My big apologies, Wladimir, you were right that kdesu could not be found on my Arch linux because of the path differences You and Alex talked about. I've tested this patch on useractions instead of invoking root-mode, that's why it previously worked for me, stupid of me...

Feb 27 2017, 7:05 PM
martinkostolny added a comment to D4828: Duplicated tab should not be locked.

For example me and a few friends of mine use it to keep some tabs in their locked path. When you select such locked tab and start browsing in it, you expect the tab to be duplicated and preserve the original selected tab. This is of course similar to selecting a tab, duplicating it and then browse. But with locked tab you can be sure you don't loose the tabs location. Of course it would be nice to have a visual difference between these two tab states (total commander appends * to such tab name) and a confirmation dialog whether I really want to close a locked tab. But I believe current state is good enough.

Feb 27 2017, 5:27 PM · Krusader
martinkostolny created D4828: Duplicated tab should not be locked.
Feb 27 2017, 4:45 PM · Krusader
martinkostolny accepted D4750: Entroducing... lazy panels.

So far I cannot find any regression. And since I'm many-tab-user I can really feel the speedup of Krusader startup, awesome, thanks Alex! :)

Feb 27 2017, 4:31 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

This works as expected. Thanks!

Feb 27 2017, 4:25 PM
martinkostolny accepted D4734: [SECURITY] Do not configure Krusader path, this is unnecessary.
Feb 27 2017, 4:12 PM
martinkostolny accepted D4747: Rework of size/space calculation.

Perfect, Alex, thanks! :)

Feb 27 2017, 4:07 PM
martinkostolny added a comment to D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Oh, good point, Toni! Thanks for making it through the long comments. I believe this will get eventually fixed in Kate but lets use kwrite again. At least until it is fixed.

Feb 27 2017, 10:13 AM
martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree with Wladimir and Alex on this. I'm also fond of the third option: making root-mode unnecessary by providing support for elevating privileges for specific operations operations.

Feb 27 2017, 9:43 AM

Feb 24 2017

martinkostolny created D4775: Suggestion - newline ending after password to output.
Feb 24 2017, 8:44 PM · Plasma
martinkostolny accepted D4738: [SECURITY] Change suggested command for "edit as root" user action to a more secure alternative.

Perfect! Although it would be nice (in future) to make sure this askpass program is installed (e.g. in INSTALL file?). I'll try to integrate the internal editor support for sudoedit and at the same time add the dependency.

Feb 24 2017, 9:38 AM

Feb 22 2017

martinkostolny accepted D4725: [SECURITY] Do not configure kdesu path and remove kdesudo support again.

I agree, security is now better with this patch. It works on my Arch Linux. Thanks for taking care of this!

Feb 22 2017, 11:15 PM

Feb 21 2017

martinkostolny accepted D4645: Automatically configure kdesu or kdesudo, document these tools and kde-cli-tools as optional dependencies.

Thanks! I didn't test it in Kubuntu but it still works fine on Arch.

Feb 21 2017, 8:59 PM
martinkostolny accepted D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

This is perfect, thanks!

Feb 21 2017, 12:18 AM

Feb 14 2017

martinkostolny accepted D4610: Panel: Do not select .. in a filtered view if there are other entries.

Yes, the new behaviour makes definitely more sense. Thanks, Wladimir! :)

Feb 14 2017, 10:24 PM
martinkostolny accepted D4609: Improved integration of (quick) search bar in panel.

Working very nicely, thanks! :-)

Feb 14 2017, 8:06 PM
martinkostolny accepted D4512: Rework of vfile and KrPermHandler class.

That's a lot of work, thanks Alex! So far it is working nicely, I couldn't find any regressions.

Feb 14 2017, 6:41 PM

Feb 10 2017

martinkostolny accepted D4418: #314258 - Duplicate tab settings when duplicating tabs.

Yes, that must have been it. It now works nicely, thanks for the patch! :)

Feb 10 2017, 4:29 PM · Krusader

Feb 9 2017

martinkostolny added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

Alex have good points as well as You Wladimir about the simplicity of the previous code. I also agree now with the previous approach and sorry about the previous suggestion then.

Feb 9 2017, 9:11 PM · Krusader

Feb 8 2017

martinkostolny accepted D4146: ListPanel: don't go back in history if refresh failed.
Feb 8 2017, 1:45 PM · Krusader
martinkostolny accepted D4420: #375894 - Use case-insensitive as default for text search.

I find these arguments good enough to set the default to case insensitive, like You proposed :).

Feb 8 2017, 12:00 AM · Krusader

Feb 4 2017

martinkostolny accepted D4427: Update "get involved" page to indicate how one can register.
Feb 4 2017, 2:52 PM · Websites, Krusader
martinkostolny added a comment to D4420: #375894 - Use case-insensitive as default for text search.

The arguments about default case insensitivity in editors are convincing. But I'm heavy user of this search dialog and like the default case-sensitive setting which is on par with grep (like Alex just said). Maybe the best solution would be to make the setting persistent over Krusader restarts?

Feb 4 2017, 2:49 PM · Krusader
martinkostolny accepted D4419: #375830 - Don't send SIGINT to terminal emulator unnecessarily.

Thanks!

Feb 4 2017, 2:44 PM · Krusader
martinkostolny added a comment to D4418: #314258 - Duplicate tab settings when duplicating tabs.

I'd also say I don't like it that much. And maybe we don't want to duplicate every setting but just some of it - e.g. the one regarding KrView? My proposal is to create alternative KrView::restoreSettings method which would take another KrView reference as a parameter and load the settings directly from this given view. Any other suggestions? :)

Feb 4 2017, 2:38 PM · Krusader
martinkostolny accepted D4417: #375831 - Sort empty file extensions correctly.

Agreed. Thanks a lot for your work! :)

Feb 4 2017, 1:52 PM · Krusader

Jan 29 2017

martinkostolny added a comment to D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

About that F11 subject: Is it a change in the user interface of Krusader? :-?

I was also wondering that for a moment :-) but I believe Alex was talking about his own key bindings. It's still F8 by default in the code.

Jan 29 2017, 9:23 AM

Jan 28 2017

martinkostolny accepted D4316: Panel/VFS: Rework of deletion/moveToTrash/virtualRemove of files and directories.

Good improvement, thanks, Alex!

Jan 28 2017, 4:09 PM
martinkostolny accepted D4195: Changes in the installation documentation (2) - Web pages.

Ship it!

Jan 28 2017, 2:08 PM · Krusader, Websites
martinkostolny accepted D4194: Changes in the installation documentation (1) - INSTALL file.

Ship it! (Sorry for my late response)

Jan 28 2017, 1:59 PM · Websites, Krusader

Jan 16 2017

martinkostolny added a comment to D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

This look nice, almost perfect :)).

Jan 16 2017, 11:57 PM
martinkostolny committed R167:e8c4f66b1a4e: FIXED: [ 375135 ] segfault on viewing html files with Generic viewer (authored by martinkostolny).
FIXED: [ 375135 ] segfault on viewing html files with Generic viewer
Jan 16 2017, 9:08 PM

Jan 15 2017

martinkostolny accepted D4146: ListPanel: don't go back in history if refresh failed.

I'm definitely for this change! I don't like loosing the path when e.g. external disk is temporarily removed. Thanks!

Jan 15 2017, 8:40 PM · Krusader
martinkostolny accepted D4008: A warning note, like the formerly used ones, was added to the installation section. .

I understand the motivation behind the additional css now, so I'm also fine with your proposed changes. We can always adjust it later if we change our minds :).

Jan 15 2017, 3:35 PM · Krusader, Websites

Jan 10 2017

martinkostolny added a comment to D3994: add asynchronous vfs refresh.

Unfortunately I don't have this area studied enough yet to consult the direction. But I certainly can test your code and report issues:). So far I found some regarding refreshing:

  • external changes aren't reflected (I have to manual refresh Ctrl+R to see them)
  • undo action will not refresh view after it is done
Jan 10 2017, 9:44 PM · Krusader
martinkostolny added a comment to D4008: A warning note, like the formerly used ones, was added to the installation section. .

I like the idea about the installation note! But is it necessary to pull another css? How about leaving a plain paragraph to visually align with another paragraphs under rest of headings? Something like:

Jan 10 2017, 8:50 PM · Krusader, Websites
martinkostolny accepted D4071: Rework of behaviour of actions for embedded terminal (splitter mode and fullscreen mode)..

I like these changes / fixes very much:). Thanks!

Jan 10 2017, 8:25 PM

Jan 3 2017

martinkostolny accepted D3938: VFS: cleaner code for refresh check on vfs operation without current directory.

Working nicely, thanks for the rework!

Jan 3 2017, 10:06 PM
martinkostolny accepted D3884: Make KrDebugLogger (and so the e.g. /tmp/krdebug trace file) usable by any file of Krusader.

It works, thanks! :)

Jan 3 2017, 7:53 PM · Krusader

Dec 18 2016

martinkostolny accepted D3722: Update the INSTALL file.
Dec 18 2016, 11:06 AM · Krusader

Dec 7 2016

martinkostolny added a comment to T3419: Rework of VFS.

Very nice, thanks for taking care of the KIO patch!

Dec 7 2016, 4:53 PM · Krusader
martinkostolny accepted D3611: Rework of job start behaviour. With new field for forcing enqueue, start or delay..

I like it, thanks! The start mode enum makes the code more understandable.

Dec 7 2016, 4:51 PM
martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

Agreed. I'm also not happy about the complexity. Now I realize, that reversing the mode is not such a good idea. So I'd at least remove F2 In Parallel option - this probably won't have much uses. I'd only be happy if F2 Queue was there when queueMode is off (in matter of additional feature to the original JobMan experience).

Dec 7 2016, 4:45 PM · Krusader

Dec 5 2016

martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

Actually that was intentional :). You started the jobs in queue mode, that's remembered, so they are performed in queue regardless of changed queueMode option. And it should work vice versa.

Dec 5 2016, 9:34 PM · Krusader

Dec 4 2016

martinkostolny added a comment to D3429: Browse Archives As Folders option applied to iso files.

comments dont belong into variable names :)

Agreed & fixed.

Dec 4 2016, 11:48 PM · Krusader
martinkostolny committed R167:f57edb20c4fa: Hard-code krarc.protocol mimetypes that were recently removed from protocol (authored by martinkostolny).
Hard-code krarc.protocol mimetypes that were recently removed from protocol
Dec 4 2016, 11:45 PM
martinkostolny closed D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol by committing R167:f57edb20c4fa: Hard-code krarc.protocol mimetypes that were recently removed from protocol.
Dec 4 2016, 11:45 PM · Krusader
martinkostolny committed R167:101091f3521f: Browse Archives As Folders option applied to iso files (authored by martinkostolny).
Browse Archives As Folders option applied to iso files
Dec 4 2016, 11:33 PM
martinkostolny closed D3429: Browse Archives As Folders option applied to iso files by committing R167:101091f3521f: Browse Archives As Folders option applied to iso files.
Dec 4 2016, 11:33 PM · Krusader

Dec 3 2016

martinkostolny updated the diff for D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol.

Just added another mime (application/vnd.rar) + code readability improved.

Dec 3 2016, 5:39 PM · Krusader
martinkostolny committed R167:fb60eda72097: Rename files inside archives (authored by martinkostolny).
Rename files inside archives
Dec 3 2016, 5:23 PM
martinkostolny closed D2614: First attempt to rename files inside archives by committing R167:fb60eda72097: Rename files inside archives.
Dec 3 2016, 5:23 PM · Krusader
martinkostolny added a comment to D2614: First attempt to rename files inside archives.

Tested another archives like deb, rpm and rar but none of them is write-supported by 7-zip. In fact 7-zip websites claim only unpack support for the rest of proprietary archive types I didn't test.

Dec 3 2016, 5:16 PM · Krusader

Dec 1 2016

martinkostolny retitled D3566: Hard-code krarc.protocol mimetypes that were recently removed from protocol from to Hard-code krarc.protocol mimetypes that were recently removed from protocol.
Dec 1 2016, 11:07 PM · Krusader
martinkostolny committed R167:0c4fb996a846: Re-add F2 Queue button to copy dialog (authored by martinkostolny).
Re-add F2 Queue button to copy dialog
Dec 1 2016, 5:22 PM
martinkostolny closed D3536: Re-add F2 Queue button to copy dialog by committing R167:0c4fb996a846: Re-add F2 Queue button to copy dialog.
Dec 1 2016, 5:22 PM · Krusader
martinkostolny updated the diff for D3536: Re-add F2 Queue button to copy dialog.

Changes in this diff:

  • added back Start Paused checkbox
  • renamed "queue" parameter to "reverseQueueMode"
  • renamed "queueBox" to "pauseBox"
  • added tooltips for F2 buttons
Dec 1 2016, 1:56 AM · Krusader

Nov 30 2016

martinkostolny updated the diff for D3536: Re-add F2 Queue button to copy dialog.

Diff updated:

  • compatibility after merging the manuallyPaused check
  • Run Immediately button textation
  • bool isQueueMode = _queueMode != reverseQueueMode;
Nov 30 2016, 1:05 AM · Krusader
martinkostolny committed R167:f5993e75ca4b: Do not automatically run manually paused job when other job in queue finishes. (authored by martinkostolny).
Do not automatically run manually paused job when other job in queue finishes.
Nov 30 2016, 12:50 AM
martinkostolny added a comment to D3536: Re-add F2 Queue button to copy dialog.

If I see this right, the behavior is exactly the same as if you would enable/disable the "queue mode" before creating the job.

Yes, this is exactly what I intended. And I agree I'd have to add a tooltip. But I don't think it is complicated. It simply allows user to selectively choose to run new job in the other mode. I'll explain the intention later.

"F2 in parallel" doesn't do anything different if no jobs are currently running

That's true. Maybe it should be renamed to "F2 Run Immediately"?

this is less ambiguous

Yes, this is better, thanks!

It is impossible to create a paused job now if no other jobs are currently running. I think this was the main point of the old queue manager.

Yes, you are right about the impossibility to create the paused job. And maybe it can have some use-cases so I should add the checkbox back?

Nov 30 2016, 12:22 AM · Krusader