As discussed in D11624, I'm fixing the issue with not closing bookmark menu.
- Group Reviewers
- R167:61a46a181598: Fixed the issue with jump back actions not closing bookmark menu when triggered
Test jump back actions in bookmark menu triggered by mouse, keyboard, search.
Works nice, thanks!
Please see my code comment.
There is a possibility to use a UniqueConnection instead of disconnect & connect. But we would need to create a standard method for closing the popup (named e.g. KrBookmarkHandler::slotCloseBookmarkPopup) instead of slotTriggered lambda. Maybe it could also be then re-used in KrBookmarkHandler::slotActivated. Then we could just call here this:
connect(action, &QAction::triggered, this, &KrBookmarkHandler::slotCloseBookmarkPopup, Qt::UniqueConnection);
But it's just a suggestion.