Released v2.7.0
ClosedPublic

Authored by nmel on May 8 2018, 6:31 AM.

Details

Summary

Preparing to release on May 13th.

Test Plan

Check if anything else should be updated.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nmel requested review of this revision.May 8 2018, 6:31 AM
nmel created this revision.
asensi added a comment.May 8 2018, 5:34 PM

Check if anything else should be updated.

Thanks, Nikita! Maybe Yuri wants to change

doc-extras/ChangeLog

Except the doc changelog mentioned by Toni I haven't found any obvious missing pieces. Thanks Nikita!

This revision is now accepted and ready to land.May 8 2018, 5:52 PM
yurchor accepted this revision as: yurchor.May 8 2018, 6:51 PM
yurchor added a subscriber: yurchor.

Check if anything else should be updated.

Thanks, Nikita! Maybe Yuri wants to change

doc-extras/ChangeLog

Should I do it separately or is it suitable for this commit?

The list of changes for the reference:

2.7.0 "Peace of Mind"

Date: 2018-05-13

CHANGED: Updated release information in docs
CHANGED: Updated ChangeLog, NEWS and Features page with v2.7 changes
FIXED: Changes in several files because, by default, F2 renames and F9 opens a terminal window
FIXED: Cleaned up old auxiliary files, updated references and fixed layout in docs
ADDED: Add new icon theme option to Konfigurator docs
CHANGED: Update the docs according to keybinding changes
ADDED: bookmark quick search (type symbols in bookmark menu to activate)
ADDED: Add docs for the new Konfigurator option 'Search in special items'
CHANGED: Updated copyright years and release info in docs
CHANGED: Updated and standardized FDL license headers
CHANGED: Updated credits in docbook
ADDED: Add the new option to Konfigurator docs
ADDED: Document new features: tab pinning and the Open MountMan menu item
ADDED: More updates to the search dialog docs
ADDED: Add new search excluding options to the docs
ADDED: Add new option for the Right arrow key to the docs
CHANGED: Follow the renaming of popup panel in docs
FIXED: Fix menu-command.docbook (patch by Christoph)
FIXED: Fix shortcuts (inspired by Christoph's work)
FIXED: Fix shortcuts (patch by Christoph) + minor cleanup
CHANGED: Update man page
CHANGED: Add missing docs for an option in Konfigurator
ADDED: Add docs on the new 'Show Tab Bar on single tab' option
ADDED: Add new Konfigurator 'Always show current item' item to the docs
CHANGED: Minor updates for the man page

2.6.0 "Stiff Challenges"

Date: 2017-04-12

FIXED: BUG #322915 (Sync the docs with katepart)
FIXED: Fix terminology in the usage of KDE
CHANGED: Remove Space for calculating dir sizes from docs
CHANGED: Remove krusader-news ML from docs
FIXED: fix gui strings (thanks to Burkhard Lück)
FIXED: branding: for KDE -> by KDE
CHANGED: Sync docs with code (1 screenshot still need to be replaced)
CHANGED: Do not bother previous maintainer
FIXED: Fix credits
FIXED: The INSTALL file was updated after a Kubuntu 16.10 installation. The install.docbook was corrected to avoid seeing the text krusader--profile
FIXED: Sync docs with new installation instructions
CHANGED: Minor rebranding in docs
ADDED: Add some documentation on the JobMan
CHANGED: Replace kde-files.org with store.kde.org in docs
CHANGED: Major cleanup from old links in docs
FIXED: remove obsolete entities reporting.bugs + updating.documentation, commented and not used
CHANGED: Update Konfigurator start page documentation
FIXED: Fix minor typos in docs

nmel added a comment.May 9 2018, 3:35 AM

Thanks for checking, guys!

Should I do it separately or is it suitable for this commit?

Could you please do it in a separate commit before Saturday?

The list of changes for the reference:

It looks good to me.

nmel added a comment.May 9 2018, 5:12 AM

Yuri, I've built a tarball for testing purposes yesterday. It compiles ok, however there are some localization warnings like

I/O warning : failed to load external entity "/usr/share/kf5/kdoctools/customization/xsl/pt-BR.xml"
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" localization of "footer-doc-teamname" exists; using "en".

The full output is here.
The tarball is here, sha1 f4c74c9b905ca576dbd74bfee1a9ba921f8affdb.

Can you check if it's easy to fix?

In D12753#259885, @nmel wrote:

Yuri, I've built a tarball for testing purposes yesterday. It compiles ok, however there are some localization warnings like

I/O warning : failed to load external entity "/usr/share/kf5/kdoctools/customization/xsl/pt-BR.xml"
No "pt_br" localization of "footer-doc-comment" exists; using "en".
No "pt_br" localization of "footer-doc-feedback" exists; using "en".
No "pt_br" localization of "footer-doc-teamname" exists; using "en".

The full output is here.
The tarball is here, sha1 f4c74c9b905ca576dbd74bfee1a9ba921f8affdb.

Can you check if it's easy to fix?

It is a bug due to docbook xsl file naming. It is safe to leave this as is (the compiled docs are usable, they are just warnings). On the other hand, the current Brazilian Portuguese docs are old and cannot be fixed easily in situ, we can exclude it from translation (I can remove it from Subversion) if you need cleanness of the compilation process.

More on this:

https://bugs.kde.org/show_bug.cgi?id=357428

nmel added a comment.May 9 2018, 6:51 AM

On the other hand, the current Brazilian Portuguese docs are old and cannot be fixed easily in situ, we can exclude it from translation (I can remove it from Subversion) if you need cleanness of the compilation process.

I checked the status of the pt_br docs by comparing with source doc change history in git. It appears they are about 2 years old (pre-2.5.0 time). They are outdated indeed. IMO, they should be dropped as unsupported and outdated otherwise the doc will hide new features and changes we put there. What others think?

Removing from SVN sounds a bit harsh. What if someone would like to pick the translation up? Can we just tag it as incomplete so that it won't be downloaded by the tarball script? BTW, I checked that if I just remove krusader-2.7.0/po/pt_BR/docs, the app compiles safely without the translation. Should we go this way? Yuri, please advise.

In D12753#259895, @nmel wrote:

On the other hand, the current Brazilian Portuguese docs are old and cannot be fixed easily in situ, we can exclude it from translation (I can remove it from Subversion) if you need cleanness of the compilation process.

I checked the status of the pt_br docs by comparing with source doc change history in git. It appears they are about 2 years old (pre-2.5.0 time). They are outdated indeed. IMO, they should be dropped as unsupported and outdated otherwise the doc will hide new features and changes we put there. What others think?

Removing from SVN sounds a bit harsh. What if someone would like to pick the translation up? Can we just tag it as incomplete so that it won't be downloaded by the tarball script? BTW, I checked that if I just remove krusader-2.7.0/po/pt_BR/docs, the app compiles safely without the translation. Should we go this way? Yuri, please advise.

I meant that I just remove the generated index.docbook, not the translation POs. No harm to the translation. Just deactivate it on docs.kde.org and in the Krusader tarballs. Anybody who wants to update the translation can do this from the current point, then use the usual translation scripting to re-generate index.docbook.

nmel added a comment.May 9 2018, 7:10 AM

I meant that I just remove the generated index.docbook, not the translation POs. No harm to the translation. Just deactivate it on docs.kde.org and in the Krusader tarballs. Anybody who wants to update the translation can do this from the current point, then use the usual translation scripting to re-generate index.docbook.

I support this way.
Martin, Toni — what's your opinion?

I agree, too. Thanks, Yuri!

asensi accepted this revision as: asensi.May 9 2018, 7:36 PM

I accept the proposal. Thanks, Yuri and Nikita!

This revision was automatically updated to reflect the committed changes.