Details
- Reviewers
nmel martinkostolny - Group Reviewers
Krusader - Commits
- R938:3d5726caeedc: Updated some descriptions, web links, names, author and thanks lists
Diff Detail
- Repository
- R938 Krusader Website
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Thanks for the updates, Toni!
because of pending changes and related ones
Could you please rephrase? It's unclear what you mean.
| get-involved/contributors/index.html | ||
|---|---|---|
| 81–85 |
laying down the foundations | |
| 84 | Bad URL: Wikipedia does not have an article with this exact name It's redirecting to http://midnight-commander.org/ for me. Should we specify the direct link?
borrowed | |
| index.html | ||
| 55 | Same here. | |
Some changes (proposed by Nikita Melnichenko) were made:
Could you please rephrase?
I've rephrased it, now it's longer but that doesn't matter a lot :-)
laying down the foundations
I would leave it as it was, as it also looks like "lay foundations" is more used:
https://www.google.com/search?q="lay"*foundations+site%3Anytimes.com
borrowed
it's a idiom
:-) It's an idiom that people see in movies, being used by people who steal but doesn't want to use that word :-), fortunately Krusader stole nothing.
The links about Norton Commander and Midnight Commander were changed.
Indeed. Maybe something like "Updated descriptions, author and thanks lists". This is what you did, isn't it?
laying down the foundations
I would leave it as it was, as it also looks like "lay foundations" is more used:
https://www.google.com/search?q="lay"*foundations+site%3Anytimes.com
No problem.
borrowed
it's a idiom:-) It's an idiom that people see in movies, being used by people who steal but doesn't want to use that word :-), fortunately Krusader stole nothing.
I looked in a dictionary, it doesn't seem to have this negative accent you're talking about. I'm not an expert in English though. Just felt a bit unnatural about copy. I don't mind leaving as is.
The links about Norton Commander and Midnight Commander were changed.
Thanks!
Indeed. Maybe something like "Updated descriptions, author and thanks lists". This is what you did, isn't it?
Thanks, Nikita! That's probably better. Because some names were also changed years ago (e.g. "KDE" became "KDE Plasma"), and some web links were also updated, just in case I will change the description to "Updated some descriptions, web links, names, author and thanks lists".
The commit is available for viewing at https://commits.kde.org/websites/krusader-org/3d5726caeedc4fd544751202eb9e0f5930cfb218