Fix activating a found item with hash in URL inside search dialog.
ClosedPublic

Authored by martinkostolny on Mar 11 2018, 1:33 AM.

Details

Summary

When searched item has '#' in its URL and is activated (by pressing enter)
it should be shown inside its folder. But instead only folder before '#'
is shown. This patch should fix the issue.

Test Plan
  1. create folder '#subfolder' and place a file in it
  2. go inside this new folder and search for files (Ctrl+s) with Search Dialog
  3. choose found file and press enter

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinkostolny requested review of this revision.Mar 11 2018, 1:33 AM
martinkostolny created this revision.
asensi accepted this revision as: asensi.Mar 11 2018, 6:48 PM
asensi added a subscriber: asensi.

Thank you, Martin! For my part, my performed tests (using Kubuntu 17.10) went alright:

  • create folder '#subfolder' (or 'sub#folder', or 'subfolder #') and place files in it
  • go inside this new folder and search for files (Ctrl+s) with Search Dialog
  • choose a file that was found, and click on it (or press enter)

Other people can do their checks :-)

This revision is now accepted and ready to land.Mar 11 2018, 6:48 PM
nmel accepted this revision.Mar 20 2018, 7:17 AM
nmel added a subscriber: nmel.

Thanks for the fix. Please merge into master.

This revision was automatically updated to reflect the committed changes.

Thank you both for the review :)