use the new install_package form
ClosedPublic

Authored by mart on Mar 21 2018, 12:27 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R115:28c54b9851f6: use the new install_package form
Summary

plasmoids can now be used also from binary resource files rcc
which makes a bit of difference in startup times especially on
devices with low storage
use the new macro to generate and install the rcc

Test Plan

still works

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Mar 21 2018, 12:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2018, 12:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mar 21 2018, 12:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 1:11 PM
This revision was automatically updated to reflect the committed changes.

Sorry to be late on this. I cannot compile plasma-pa anymore after this change with error:

Scanning dependencies of target org.kde.plasma.volume-plasmoids-contents-rcc
make[2]: *** No rule to make target 'applet/org.kde.plasma.volume-contents.rcc', needed by 'applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:191: applet/CMakeFiles/org.kde.plasma.volume-plasmoids-contents-rcc.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Same goes for plasma-nm after similar change. I'm using kdesrc-build environment. Is there something I may be doing wrong?

Is there something I may be doing wrong?

I can see now that this change was applied and then reverted all over the plasma repositories so these are probably 2 leftovers. Sorry for the fuzz.

Last info: on my side everything seems to compile and work just fine now. Thanks for your work! :)