Panel: fixed invisible column issue
ClosedPublic

Authored by nmel on Apr 19 2018, 6:02 AM.

Details

Summary

FIXED: Panel columns may become invisible when settings are restored from config

After going through several version upgrades some of columns in panels
became invisible for some reason (debugging shows size = 0).
The column state is saved to config and restored each time Krusader loads,
so it was impossible to fix this without killing the krusaderrc file.

Test Plan

Check if Krusader loads column settings as before.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nmel requested review of this revision.Apr 19 2018, 6:02 AM
nmel created this revision.

In case you are eager to repro the problem I faced, here is excerpt from my config:

To repro, you need to replace this section in your config and also replace Saved State in any tab sections like [Startup][Left Tab Bar][Tabs][Tab0][View] with the state from excerpt.

It's optional - I don't expect the problem I have to be widespread. I don't know when and how I get this state in my config.

asensi added a subscriber: asensi.Apr 19 2018, 10:20 AM

Hello! I can't reproduce the "fixed invisible column" issue, so I attach some screenshots and "krusaderrc" files, if it may help:

The krusaderrc initial file, without any change:

A screenshot of Krusader (the present diff was not applied) without having made any change in the krusaderrc file. Note: Adding later the KrInterDetailedView section did not have any effect.

The krusaderrc file, after changing the [Startup][Right Tab Bar][Tabs][Tab0][View] section, and adding a KrInterDetailedView section:

A screenshot of Krusader (the present diff was not applied) after changing the [Startup][Right Tab Bar][Tabs][Tab0][View] section, and adding a KrInterDetailedView section:

Thanks!

nmel added a comment.Apr 19 2018, 9:06 PM

Hi Toni,

Thanks a lot for testing and sorry for the confusion. Seems like only setting Saved State is not enough. Your configs don't repro the issue on my side too.

I've removed personal info from my config and tested it on Ubuntu VM - I can repro:


Can you check this one?

Using Ubuntu 18.04 daily build: I could reproduce the problem, and it was solved by the patch made by Nikita. Thanks, Nikita!

martinkostolny accepted this revision.Apr 20 2018, 11:37 PM
martinkostolny added a subscriber: martinkostolny.

Same here, replicated with attached krusaderrc. And it no longer happens with this patch. Thanks, Nikita! :)

This revision is now accepted and ready to land.Apr 20 2018, 11:37 PM
asensi accepted this revision.Apr 21 2018, 6:41 AM
This revision was automatically updated to reflect the committed changes.