rade (Rade Deguerre)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 1 2018, 9:33 PM (81 w, 1 d)
Availability
Available

Recent Activity

Apr 8 2018

rade accepted D11898: Implemented bookmark quick search.
Apr 8 2018, 8:31 PM · Krusader
rade added a comment to D11898: Implemented bookmark quick search.
In D11898#242741, @nmel wrote:

I assume Martin and Rade are also fine with merging this branch. We tested it a lot during the development stage.

Apr 8 2018, 8:30 PM · Krusader

Apr 4 2018

rade added a comment to D11906: Fix casesensitive search for quicksearch-bookmark.

later I have compiled and installed Krusader, but the behavior seems to be the same (e.g. when typing 'H' it doesn't match the bookmark 'HamBurglar'). Is there any other step that must be taken?

Apr 4 2018, 12:38 PM · Krusader
rade added a comment to D11903: Fix multirename shortcut.
In D11903#239525, @nmel wrote:
Apr 4 2018, 10:33 AM · Krusader
rade added a comment to D11906: Fix casesensitive search for quicksearch-bookmark.
In D11906#239529, @nmel wrote:

Do you mind sending format-patch from the top of the branch? Thanks!

Apr 4 2018, 9:41 AM · Krusader
rade updated the diff for D11906: Fix casesensitive search for quicksearch-bookmark.

merge with latest commit

Apr 4 2018, 9:41 AM · Krusader

Apr 3 2018

rade added a comment to D11903: Fix multirename shortcut.

Thanks, Rade, for the fix :).

Apr 3 2018, 9:42 PM · Krusader
rade updated the summary of D11906: Fix casesensitive search for quicksearch-bookmark.
Apr 3 2018, 6:00 PM · Krusader
rade updated the summary of D11906: Fix casesensitive search for quicksearch-bookmark.
Apr 3 2018, 5:59 PM · Krusader
rade added a comment to D11898: Implemented bookmark quick search.

If a user has opened his bookmark menu, he has a bookmark named "Documents"
and he presses Shift+D... nothing happens.

Good catch! I have created a fix for that here D11906

Apr 3 2018, 5:58 PM · Krusader
rade requested review of D11906: Fix casesensitive search for quicksearch-bookmark.
Apr 3 2018, 5:56 PM · Krusader
rade requested review of D11903: Fix multirename shortcut.
Apr 3 2018, 12:15 PM · Krusader

Apr 2 2018

rade abandoned D11790: Fix accidental triggering of reset in parent menu.
Apr 2 2018, 1:08 AM
rade accepted D11829: Fixed bugs in bookmark search that appear after exiting from submenu.

First off I'm marking the revision as accepted as either you agree with my points below and apply the patch which obviously I would agree with, or you don't agree and keep it as is which is also fine.
Either way this is a really good patch.
Thanks again for figuring out how to fix this issue!

Apr 2 2018, 1:02 AM · Krusader

Apr 1 2018

rade requested changes to D11829: Fixed bugs in bookmark search that appear after exiting from submenu.

another QCloseEvent event for the submenu after ~200ms through QTimer
after which the active item is reset.

Can't have been easy figuring out that out!
Have we been extremely unlucky running in to three different Qt5 bugs developing this feature or is Qt5 just this buggy?

Apr 1 2018, 1:03 PM · Krusader

Mar 29 2018

rade updated the diff for D11622: Fix regression in "Open in new tab" behaviour.

Seems you were right about the jump back being reset martin. I feel into the trap of since I 'knew' it wasn't being reset since my code wasn't calling setjumpback and my cursory (and faulty) test passed and seemed to confirm it wasn't being reset then all was fine and dandy.

Mar 29 2018, 8:51 PM
rade updated the diff for D11790: Fix accidental triggering of reset in parent menu.

Accidentally submitted the previous to last revision.

Mar 29 2018, 8:15 PM
rade updated the test plan for D11790: Fix accidental triggering of reset in parent menu.
Mar 29 2018, 8:11 PM
rade requested review of D11790: Fix accidental triggering of reset in parent menu.
Mar 29 2018, 8:10 PM
rade added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..
// removing action from previous menu is necessary 
// otherwise it wouldn't be displayed in currently populating menu
Mar 29 2018, 7:10 PM · Krusader

Mar 27 2018

rade added a comment to D11731: Fix disappearing searchbar when bookmark menu is opened for another tab..

This issue was closed just as I was commenting... Might be too late now but I just wanted to add that it might be a good idea to add a comment explaining the reason why we are removing quickssearchaction from the old menu as that is not really obvious by just reading the code.

Mar 27 2018, 9:54 PM · Krusader

Mar 25 2018

rade accepted D11624: Prevent quicksearch from searching special bookmarks.

Other then the issue martin pointed out it looks good!

Mar 25 2018, 8:51 PM
rade added inline comments to D11622: Fix regression in "Open in new tab" behaviour.
Mar 25 2018, 8:39 PM
rade added inline comments to D11622: Fix regression in "Open in new tab" behaviour.
Mar 25 2018, 8:30 PM
rade updated the diff for D11622: Fix regression in "Open in new tab" behaviour.

Updated the code so that start calls openUrl.

Mar 25 2018, 8:24 PM

Mar 24 2018

rade removed reviewers for D11622: Fix regression in "Open in new tab" behaviour: nmel, martinkostolny.
Mar 24 2018, 8:38 PM
rade added a comment to D11624: Prevent quicksearch from searching special bookmarks.
In D11624#233198, @nmel wrote:
In D11624#233131, @rade wrote:

Given Rade's points, I see that it may be useful for some people, so I suggest we add another config option "Search in special items" for this feature and stop arguing. My only ask is to leave it off by default.

Sounds good to me. Would you mind doing the patch for it though? I'm not really sure how the config code works, and you seem to have a good grasp of it.

Yep, no problem.

Mar 24 2018, 8:37 PM
rade added a reviewer for D11622: Fix regression in "Open in new tab" behaviour: martinkostolny.
Mar 24 2018, 8:35 PM
rade added a reviewer for D11622: Fix regression in "Open in new tab" behaviour: nmel.
Mar 24 2018, 8:34 PM
rade updated the diff for D11622: Fix regression in "Open in new tab" behaviour.

I changed the local path behaviour, even though I don't think this code could be called with a remote path, there is no reason why it shouldn't be able to handle it.

Mar 24 2018, 8:34 PM
rade added a comment to D11623: Add set jump back et al. to specialbookmarks to fix right click bug.

right clicking on them just closes the menu

Right click actually executes the action currently. I think this is standard behavior for menus.

It didn't use to be standard behaviour for this menu, it used to be that right clicking on them you got the same options as you get when right clicking on trash et al. AFIK it's not consistent with other menus either. The only menu I could find where right clicking doesn't give you a pop up is "Useractions" and there right clicking simply does nothing. I could find no menus where right clicking executes the action, nor would a user expect right clicking to trigger the action.

Mar 24 2018, 8:20 PM · Krusader
rade added a comment to D11624: Prevent quicksearch from searching special bookmarks.

Given Rade's points, I see that it may be useful for some people, so I suggest we add another config option "Search in special items" for this feature and stop arguing. My only ask is to leave it off by default.

Mar 24 2018, 7:21 PM

Mar 23 2018

rade updated the diff for D11624: Prevent quicksearch from searching special bookmarks.

fixed whitespace

Mar 23 2018, 9:02 PM
rade updated the summary of D11624: Prevent quicksearch from searching special bookmarks.
Mar 23 2018, 8:24 PM
rade requested review of D11624: Prevent quicksearch from searching special bookmarks.
Mar 23 2018, 8:22 PM
rade requested review of D11623: Add set jump back et al. to specialbookmarks to fix right click bug.
Mar 23 2018, 8:09 PM · Krusader
rade requested review of D11622: Fix regression in "Open in new tab" behaviour.
Mar 23 2018, 7:46 PM
rade added a comment to D11525: Fix accidentally triggering menus.
In D11525#231295, @nmel wrote:

For git format-patch, please only do it once your code is accepted — just attach it here like in this example:


Phabricator doesn't seem to understand this way — when I download raw diff from here, it's just has diff --git ... without From or other fields.

Mar 23 2018, 6:53 PM
rade added inline comments to D11525: Fix accidentally triggering menus.
Mar 23 2018, 6:49 PM
rade updated the diff for D11525: Fix accidentally triggering menus.

Changed return code so that we return true, even if we couldn't find a matching bookmark or folder

Mar 23 2018, 6:47 PM

Mar 21 2018

rade accepted D11538: Added Konfigurator option to control bookmark search bar visibility.

Looks good!
When looking through the menu I discovered a bug though but that is unrelated to this code.

Mar 21 2018, 4:11 PM · Krusader
rade added inline comments to D11525: Fix accidentally triggering menus.
Mar 21 2018, 2:27 PM
rade updated the diff for D11525: Fix accidentally triggering menus.

I have changed to using git format-patch, and phabricator doesn't like one file with several diffs in it apparently so I made them into one full diff.

Mar 21 2018, 2:16 PM
rade updated the diff for D11525: Fix accidentally triggering menus.

Added return statement from D11521 and renamed firstMatch

Mar 21 2018, 2:07 PM
rade abandoned D11443: Fixed various bugs related to quicksearch handling of folders.

I split this into separate reviews per nmels request.

Mar 21 2018, 12:51 PM · Krusader
rade abandoned D11521: Return statments fix.
In D11521#230503, @nmel wrote:

I'm confused regarding how to apply this as returns has been partially covered by D11525 (except for the break replacement). Do you want to include it there?

Mar 21 2018, 12:46 PM
rade added a comment to D11523: Key handling bug and a QoL improvement.

It seems to work nicely. Thanks!

Consider what to do when the user enters non printable character

I'm not sure about the tab key and non-printable characters. I'd probably filter them all out but I may be wrong about this.

Mar 21 2018, 12:12 PM
rade updated the diff for D11523: Key handling bug and a QoL improvement.

removed the extra newline.

Mar 21 2018, 12:08 PM
rade added a comment to D11444: Fixed jump-back actions in bookmark menu, improved separators.

You could add back the the shortcut text only using
´´´

QString shortcutText = sourceAction->shortcut().toString();

´´´

Mar 21 2018, 11:42 AM · Krusader

Mar 20 2018

rade added inline comments to D11525: Fix accidentally triggering menus.
Mar 20 2018, 11:23 PM
rade added inline comments to D11443: Fixed various bugs related to quicksearch handling of folders.
Mar 20 2018, 9:12 PM · Krusader
rade added inline comments to D11444: Fixed jump-back actions in bookmark menu, improved separators.
Mar 20 2018, 7:09 PM · Krusader
rade requested changes to D11444: Fixed jump-back actions in bookmark menu, improved separators.

Read through the code and it looks good.
One 'problem' though is that the shortcut 'Ctrl+j' and 'Ctrl+shift+j' used to be displayed next to jump back point and set jump back point the same way they still are in the go menu. That should probably be fixed.

Mar 20 2018, 7:08 PM · Krusader
rade updated the diff for D11523: Key handling bug and a QoL improvement.

fixed minor error

Mar 20 2018, 6:58 PM
rade requested review of D11525: Fix accidentally triggering menus.
Mar 20 2018, 6:54 PM
rade requested review of D11523: Key handling bug and a QoL improvement.
Mar 20 2018, 6:36 PM
rade requested review of D11521: Return statments fix.
Mar 20 2018, 6:15 PM
rade added a comment to D11443: Fixed various bugs related to quicksearch handling of folders.

I agree that splitting it in to 3 commits is the right move and I'll try to do this later today if I can find the time.

Mar 20 2018, 10:36 AM · Krusader

Mar 18 2018

rade updated the diff for D11443: Fixed various bugs related to quicksearch handling of folders.

I've added support for the left arrow key closing menus. It works in all menus even the main one. I would argue that this is what is expected behaviour though. E.g if I'm three levels into submenus and want to close all of them I want to press leftarrow, leftarrow, leftarrow and _not_ have to press leftarrow, leftarrow, escape.

Mar 18 2018, 11:38 PM · Krusader
rade added a comment to D11443: Fixed various bugs related to quicksearch handling of folders.

It's not complex but it doesn't handle all the cases. For example, move krusader close to the right side of the screen and invoke bookmark menu, then search for a folder. Your submenu is not on the correct position.

Mar 18 2018, 9:08 PM · Krusader
rade updated the diff for D11443: Fixed various bugs related to quicksearch handling of folders.

I accidentally broke the accelerator key functionality by always returning true if we had gotten a match, even on the first run. Fixed that. Incidentally this is a good example of why it's important to return the correct value.

Mar 18 2018, 7:14 PM · Krusader
rade added a comment to D11443: Fixed various bugs related to quicksearch handling of folders.
In D11443#228341, @nmel wrote:
Mar 18 2018, 7:03 PM · Krusader
rade updated the diff for D11443: Fixed various bugs related to quicksearch handling of folders.

I have updated the submenu placement code so it is now correct.

Mar 18 2018, 6:36 PM · Krusader
rade updated the summary of D11443: Fixed various bugs related to quicksearch handling of folders.
Mar 18 2018, 1:14 AM · Krusader
rade requested review of D11443: Fixed various bugs related to quicksearch handling of folders.
Mar 18 2018, 1:11 AM · Krusader
rade added a comment to D11383: Replaced underline hack with bold highlighting in the bookmark search.

I've found one problem corner case with bookmark folders:

Mar 18 2018, 12:26 AM · Krusader

Mar 17 2018

rade added a comment to D11383: Replaced underline hack with bold highlighting in the bookmark search.

Good to hear. However it's definitely not present on the man page that shipped with my distro. Dunno if it's a recent addition to the man page, or if my distro removed it for some reason.

--left <path>
    start left panel at <path>
Mar 17 2018, 10:01 PM · Krusader
rade accepted D11383: Replaced underline hack with bold highlighting in the bookmark search.

Looks great!

Mar 17 2018, 9:43 PM · Krusader
rade requested changes to D11383: Replaced underline hack with bold highlighting in the bookmark search.

This looks good. I would just recommend some minor changes.

Mar 17 2018, 1:10 PM · Krusader

Mar 13 2018

rade accepted D11224: Added quick search bar to the bookmark menu + various fixes.

I don't agree that having the QLineEdit pop in just so that one extra bookmark can be displayed before typing is worth it. But either way works fine. Having it be an option as you suggested would be nice, but not really all that important. Especially as I think almost nobody will ever discover that there is an option for it.

Mar 13 2018, 10:40 PM · Krusader

Mar 12 2018

rade requested changes to D11224: Added quick search bar to the bookmark menu + various fixes.

Thanks for looking into QWidgetAction, and the code!

Mar 12 2018, 12:03 AM · Krusader

Mar 7 2018

rade updated the diff for D10954: Add back search as you type too the bookmark menu.

Thanks for reviewing my code again.

Mar 7 2018, 12:09 AM · Krusader

Mar 4 2018

rade updated the diff for D10954: Add back search as you type too the bookmark menu.

fixed misplaced else.

Mar 4 2018, 1:25 AM · Krusader
rade updated the diff for D10954: Add back search as you type too the bookmark menu.

I have updated the code. Sorry for the large amount of changes, if requested I can submit the small style fixes and the large code revision separately. I have tried to follow the coding standard this time, hopefully I haven't missed anything.

Mar 4 2018, 1:17 AM · Krusader

Mar 1 2018

rade updated the summary of D10954: Add back search as you type too the bookmark menu.
Mar 1 2018, 10:32 PM · Krusader
rade requested review of D10954: Add back search as you type too the bookmark menu.
Mar 1 2018, 9:56 PM · Krusader