Updated credits, copyrights, license headers in code and docs
ClosedPublic

Authored by nmel on Mar 29 2018, 6:41 AM.

Details

Summary

Updated copyright of Krusader Krew in standard GPL headers

Updated GPL headers according to the latest standards
See gpl-howto.

Replaced old license headers with fresh GPL headers

Fixed broken author names or emails

Updated and improved credits in supplemental files

Updated credits in the About dialog

Updated credits in docbook

Updated and standardized FDL license headers

Updated copyright years and release info in docs

Test Plan

Most changes are done by a script, so please verify it's not doing any harm.
Most changes are done in comments or supplementary files, only main.cpp has code changes (About dialog).

  • Compile and verify About dialog.
  • Build Documentation and check index, credits and man file for correctness.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nmel created this revision.Mar 29 2018, 6:41 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald TranscriptMar 29 2018, 6:41 AM
nmel requested review of this revision.Mar 29 2018, 6:41 AM
nmel added a reviewer: yurchor.

Sorry for the large change.

This is a first step in administrative preparing the project for the release. I decided to submit this early because it may be difficult to find a time for review, so I don't want this to block the release later. Please take your time.

I tried to be precise in updating credits and copyrights — feel free to let me know if you find any discrepancies.

I wasn't able to compile docbook (only man page) to do a visual verification — Yuri, please educate us how to compile and view a git version.

nmel edited the summary of this revision. (Show Details)Mar 29 2018, 6:56 AM
yurchor accepted this revision as: yurchor.Mar 29 2018, 12:18 PM
This revision is now accepted and ready to land.Mar 29 2018, 12:18 PM
nmel added a comment.Mar 31 2018, 3:32 AM

Thanks Yuri!
I'm still interested in this:

In D11777#236215, @nmel wrote:

I wasn't able to compile docbook (only man page) to do a visual verification — Yuri, please educate us how to compile and view a git version.

To everyone else: please let me know if you plan to review this or not. I will wait if needed. If I get no response, I'll submit this early next week.

In D11777#237363, @nmel wrote:

I wasn't able to compile docbook (only man page) to do a visual verification — Yuri, please educate us how to compile and view a git version.

First,

checkXML5 index.docbook

then

meinproc5 index.docbook

This should be enough to be sure that everything's in its right place (CSS will be applied in KHelpCenter itself and PDF will be generated on docs.kde.org on the next Thursday after the changes pushed to git).

I was not sure about the question: when you compile krusader, the documentation is compiled too. If you install it in the usual locations, khelpcenter will show it as usual.

nmel added a comment.Apr 1 2018, 6:48 AM

Thanks Yuri!

I was not sure about the question: when you compile krusader, the documentation is compiled too. If you install it in the usual locations, khelpcenter will show it as usual.

The thing is that I don't want to do a raw make install under root as it will interfere with a package manager. Are you talking about installing to some user folder?

I'd like to know a way to browse docs from a dev environment or at least temporary override docs without elevated privileges. What Yuri suggested addresses this desire to a certain extent. If someone has a way to include CSS, please let me know.

In D11777#237997, @nmel wrote:

If someone has a way to include CSS, please let me know.

It can be done by a simple replacement. Example:

perl -pi -e 's!help:/!file:///usr/share/doc/HTML/en/!g' *.html
martinkostolny accepted this revision.Apr 1 2018, 2:11 PM
martinkostolny added a subscriber: martinkostolny.

Thanks Nikita for unifying the comments and docs!

I haven't found any issues.

For installing Krusader I use kdesrc-build environment. https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source
...currently I use the whole KDE like this but it has its shortcomings. Anyway it is perfectly possible to use it on select applications like Krusader.

nmel added a comment.Apr 3 2018, 3:09 AM

I haven't heard of kdesrc-build before, thanks for the pointers, Martin!

This revision was automatically updated to reflect the committed changes.