[RFC] Add support for changing volume label.
Needs ReviewPublic

Authored by chinmoyr on Mar 26 2019, 1:53 PM.

Details

Reviewers
bruns
broulik
Group Reviewers
Frameworks
Summary

Is this the right approach to take?

Diff Detail

Repository
R245 Solid
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10152
Build 10170: arc lint + arc unit
chinmoyr created this revision.Mar 26 2019, 1:53 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 26 2019, 1:53 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chinmoyr requested review of this revision.Mar 26 2019, 1:53 PM

The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward.

bruns added a comment.Mar 26 2019, 6:12 PM

This definitely should be part of the StorageVolume interface.

ngraham added a subscriber: ngraham.Jun 5 2019, 2:38 PM

Ping, any update on this?

clel added a subscriber: clel.Aug 9 2020, 5:19 PM

Another ping after over one year without action. Maybe the state of this issue is not really clear or the original author does not have time to implement the advise to their question. Still hopefully this can get continued soon, either way. @chinmoyr @broulik @bruns