- User Since
- Dec 3 2016, 5:11 PM (173 w, 16 h)
Mon, Mar 16
Wed, Mar 4
Still want to see that round-trip.
looks good to me.
Tue, Mar 3
STD3 also forbids domain labels ending in dash, so can you add a test for smb://[fe80::]/ too? You'll need to adjust your code
Looks good, but testing should be extended. I suggest:
Feb 18 2020
Yes, it's been supported for years.
Dec 14 2019
Sep 17 2019
This really needs to be fixed in Qt. 5.13.1 has an overhaul of the system, please make sure that the patch is still required there and does not make things worse.
Aug 23 2019
QFile::copy already implements FICLONE, sendfile() and Darwin's clonefile().
Jun 16 2019
Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match.
Jun 5 2019
Is anyone working on the ability to open a new profile? I ask this because I had a shortcut assigned to open a root shell (Ctrl+Alt+R) and was quite surprised to find out that it didn't work anynore with no way to get it back. This is not the same as opening a new tab and switching profiles, since that won't change the command that was started.
May 24 2019
As for truncating UTF-8 multibyte sequences in the middle, when you convert back using QFile::decodeName, it'll be nonsensical. But I don't think it really matters since you're truncating and using the display string anyway, so you're already losing data. This wasn't a recoverable conversion anyway.
I cringe a little when you apply QFile to a URL, but this is probably safe enough.
Feb 24 2019
This new backtrace *is* a stuck application. Please report the issue to Mesa (dri/i965). Cc me, I can walk three paces in the office to the Mesa devs and help them figure out what's happening.
I repeat: there's no indication in the backtrace that it is stuck. What's your evidence that it is? You wrote an application that shows nothing and never exits. Now it showed nothing and didn't exit. That's not stuck, that's the expected behaviour.
This last backtrace does not show anything stuck. Thread 1 was actively running, in fact (it's inside of malloc).
Feb 23 2019
The patch is innocuous. I don't see *how* it can solve anything, though, because I don;'t know what DrKonqu::cleanup does.
Feb 20 2019
It looks good to me.
Much better, thanks.
Feb 19 2019
Dec 29 2018
qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip the .0 release and upgrade.
Jul 25 2018
Jul 24 2018
Quickly checking on openSUSE Tumbleweed
This is indeed Forever. How did it get there?
Can you print the contents of the timer object inside tryLock()?
Quick testing via gdb:
Apr 8 2018
Feb 3 2018
That doesn't make sense. There's QFile::encodeName in the code.
The patch that I can see accomplishes what the description says it should do. And I agree with the idea of the patch.
Why do you ask for a rewview then not wait for the review?
Aug 8 2017
Jul 15 2017
This class isn't hooked up to anything. It's technically correct as an FD sender and receiver. What I want to see is how you use it, because that's extremely important to get right.
Jul 3 2017
Qt 5.10 will have QFileInfo::birthTime too.
May 30 2017
Makes sense to work around older versions of Qt without the fix.
May 29 2017
Dec 16 2016
More information on this Windows behaviour: