[WIP]Show more details in warning dialog shown before starting a privileged operation
Changes PlannedPublic

Authored by chinmoyr on Jun 13 2019, 4:13 PM.

Details

Reviewers
dfaure
Group Reviewers
VDG
Frameworks
Summary

Currently it uses the dialog from D21782 to provide the current action being performed, the source file and any
action specific detail.

The initial plan was to show all the files needing elevated privileges but due to KIO jobs processing one file at
a time only limited info could be provided. There's also the option for determing this during the stat phase but it
caused my VM to slow down to a crawl. Any more ideas here?

Diff Detail

Repository
R241 KIO
Branch
warn
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12780
Build 12798: arc lint + arc unit
chinmoyr created this revision.Jun 13 2019, 4:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 13 2019, 4:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chinmoyr requested review of this revision.Jun 13 2019, 4:13 PM

Thanks! Is this for T8075?

Thanks! Is this for T8075?

Yes it is.

Totally awesome :)

chinmoyr planned changes to this revision.Jun 15 2019, 8:08 AM

TODO

  • Change the UI of the warning dialog
  • We still need more details
dfaure requested changes to this revision.Sat, Jun 22, 8:25 AM
dfaure added inline comments.
src/core/slavebase.cpp
1511

INF is for one-way information, isn't it? Why isn't this MSG_ like the one above?

src/core/slavebase.h
964

Missing "m" prefix like the other members, but wait.... isn't this BIC? Adding a new member to an exported class certainly is. This needs to go into the SlaveBasePrivate class instead.

src/ioslaves/file/file_unix.cpp
85

all those { ... } braces are unnecessary in this switch, which doesn't define any new variables