ossi (Oswald Buddenhagen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 8 2015, 5:33 PM (205 w, 6 d)
Availability
Available

Recent Activity

Sat, Aug 24

ossi added a comment to D17737: [CopyJob] Create clones in btrf/xfs mount.

QFile::copy already implements FICLONE, sendfile() and Darwin's clonefile().

Sat, Aug 24, 4:02 AM · Frameworks

Feb 23 2019

ossi updated subscribers of D18245: Create QApplication in a scope to work around possible deadlock.

the patch definitely looks like a hack, but i'll leave the final judgment on that to thiago.

Feb 23 2019, 10:54 AM · Plasma

Jan 24 2019

ossi accepted D11236: [KCrash] Establish socket to allow change of ptracer.

here too, it should be "ancestor" not "parent" for extra correctness.
amending the code comment is optional, too.

Jan 24 2019, 11:21 AM · Frameworks
ossi accepted D11235: Request change of ptrace scope from KCrash.

note that for extra correctness it should be "ancestor" not "parent".

Jan 24 2019, 11:14 AM · Plasma

Jan 21 2019

ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

i said "3rd line", not "3rd case". it's about the ancestry; see the other change.

Jan 21 2019, 12:24 PM · Frameworks

Jan 17 2019

ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

the 3rd line is still wrong ...

Jan 17 2019, 5:22 PM · Frameworks
ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

right, threads, i didn't think of that. i suppose it might make sense to pthread_kill() from within kcrash to freeze the other threads, but that will be non-atomic, and i wonder whether it wouldn't have undesirable interactions with the attached debugger and/or exiting the process.

Jan 17 2019, 2:37 PM · Frameworks
ossi added inline comments to D11236: [KCrash] Establish socket to allow change of ptracer.
Jan 17 2019, 1:28 PM · Frameworks
ossi added a comment to D11235: Request change of ptrace scope from KCrash.

What do you mean? The (internal) debugger is a child of the debuggee.

Jan 17 2019, 1:24 PM · Plasma
ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

commit message inverted here as well.

Jan 17 2019, 12:10 PM · Frameworks
ossi added a comment to D11235: Request change of ptrace scope from KCrash.

you got the parent-child ordering wrong in the commit message. ^^

Jan 17 2019, 12:07 PM · Plasma

Jan 16 2019

ossi added a comment to D11235: Request change of ptrace scope from KCrash.

will also need to wait for commit message update, like the other change.

Jan 16 2019, 4:33 PM · Plasma
ossi requested changes to D11235: Request change of ptrace scope from KCrash.
Jan 16 2019, 3:52 PM · Plasma
ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

Actually the point I removed does not seem to be true any longer. I'm almost certain, that the prctrl(PR_SET_PTRACER, ...) was not required until some time ago when starting DrKonqi as a fork. But now the internal backtrace is not working without. I cannot tell, when that started (currently using kernel 4.20).

Jan 16 2019, 3:36 PM · Frameworks
ossi requested changes to D11235: Request change of ptrace scope from KCrash.

mark handled issues as done here as well.

Jan 16 2019, 11:00 AM · Plasma
ossi requested changes to D11236: [KCrash] Establish socket to allow change of ptracer.

mostly minor issues left.

Jan 16 2019, 10:49 AM · Frameworks

Jan 15 2019

ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.
In D11236#393789, @ossi wrote:

detaching via double fork() "protects" the child process,

Jan 15 2019, 7:25 PM · Frameworks
ossi added a comment to D11236: [KCrash] Establish socket to allow change of ptracer.

Actually it's only the internal process that creates the backtraces, that is a descendant of DrKonqi. All debuggers that are launched via the "Debug" button are processes on their own (to remain alive, even if DrKonqi already quit).

Jan 15 2019, 6:27 PM · Frameworks

Jan 14 2019

ossi requested changes to D11235: Request change of ptrace scope from KCrash.
Jan 14 2019, 4:41 PM · Plasma
ossi requested changes to D11236: [KCrash] Establish socket to allow change of ptracer.

yay, i finally have "some" time for this. ^^

Jan 14 2019, 4:39 PM · Frameworks

Jun 3 2018

ossi added a comment to D12745: Unify API for file descriptor sharing.

\o/
;)

Jun 3 2018, 10:07 AM · Frameworks

May 28 2018

ossi added inline comments to D12291: Accept file descriptor only from root owned process.
May 28 2018, 8:00 AM · Frameworks

May 27 2018

ossi added inline comments to D12291: Accept file descriptor only from root owned process.
May 27 2018, 10:31 PM · Frameworks
ossi added inline comments to D12291: Accept file descriptor only from root owned process.
May 27 2018, 11:50 AM · Frameworks
ossi accepted D12291: Accept file descriptor only from root owned process.
May 27 2018, 11:48 AM · Frameworks
ossi accepted D12745: Unify API for file descriptor sharing.
May 27 2018, 11:28 AM · Frameworks
ossi added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

this dependency tree is a mess. please remove deps to abandoned changes or unabandon what you actually still need, and linearize the history.

May 27 2018, 11:10 AM · Frameworks
ossi accepted D12744: Add null pointer check when creating SocketAddress.
May 27 2018, 11:04 AM · Frameworks
ossi accepted D10410: Move task of cleaning up socket file to FdReceiver.

note that the commit message needs a minor adjustment now.

May 27 2018, 11:00 AM · Frameworks
ossi added a comment to D12745: Unify API for file descriptor sharing.

but so does using raw pointers. as the stl is available here anyway, it seems like the preferable abstraction layer.

May 27 2018, 10:32 AM · Frameworks
ossi added a comment to D12745: Unify API for file descriptor sharing.

why aren't you standardizing on std::string? that's cleaner than raw char pointers.
i know we discussed this before to some degree, but i don't remember the particulars.

May 27 2018, 10:12 AM · Frameworks
ossi requested changes to D12744: Add null pointer check when creating SocketAddress.
May 27 2018, 10:09 AM · Frameworks
ossi accepted D10411: Create socket file in user's runtime directory.
May 27 2018, 10:00 AM · Frameworks
ossi requested changes to D10410: Move task of cleaning up socket file to FdReceiver.

did you make sure that this is the only place where SocketAddress is used?

May 27 2018, 9:59 AM · Frameworks

May 6 2018

ossi added a comment to D12291: Accept file descriptor only from root owned process.

as i certainly mentioned somewhere else already, this is redundant with putting the socket in a safe place. but fair enough ...

May 6 2018, 9:36 AM · Frameworks
ossi requested changes to D10273: Create proper SocketAddress.

note that there are also unaddressed comments from previous rounds.

May 6 2018, 9:28 AM · Frameworks
ossi accepted D10409: In linux don't use abstract socket to share file descriptor.
May 6 2018, 9:17 AM · Frameworks
ossi requested changes to D10410: Move task of cleaning up socket file to FdReceiver.

still needs update

May 6 2018, 9:16 AM · Frameworks
ossi accepted D10411: Create socket file in user's runtime directory.
May 6 2018, 9:14 AM · Frameworks

Mar 4 2018

ossi added a comment to D10409: In linux don't use abstract socket to share file descriptor.

not sure why; the changes are semantically separate.

Mar 4 2018, 12:24 PM · Frameworks
ossi added a comment to D10409: In linux don't use abstract socket to share file descriptor.

that contradicts the comments i added to both reviews.

Mar 4 2018, 12:10 PM · Frameworks
ossi added a comment to D10409: In linux don't use abstract socket to share file descriptor.

the idea is that you can do directory-based access controls on file-based sockets, while the abstract namespace has no controls.
otoh, only linux has the abstract namespace, and it supports peer credential verification as well, so this doesn't actually add any security afaict.
arguably, the patch still makes sense from a maintenance perspective, removing a redundant code path.
fwiw, i'd re-order this patch before the other one - it makes for smaller patches to first remove code and then refactor only what's left.

Mar 4 2018, 12:01 PM · Frameworks
ossi added inline comments to D10273: Create proper SocketAddress.
Mar 4 2018, 11:55 AM · Frameworks
ossi added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

looks good, though technically speaking this still fixes two separate issues.

Mar 4 2018, 11:46 AM · Frameworks
ossi added inline comments to D10410: Move task of cleaning up socket file to FdReceiver.
Mar 4 2018, 11:34 AM · Frameworks
ossi added inline comments to D10410: Move task of cleaning up socket file to FdReceiver.
Mar 4 2018, 11:31 AM · Frameworks

Feb 27 2018

ossi added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

But i'm not sure if thats feasible.

Feb 27 2018, 9:09 PM · Baloo, Frameworks

Feb 3 2018

ossi added inline comments to D10273: Create proper SocketAddress.
Feb 3 2018, 5:15 PM · Frameworks
ossi added inline comments to D10273: Create proper SocketAddress.
Feb 3 2018, 3:34 PM · Frameworks
ossi added inline comments to D10273: Create proper SocketAddress.
Feb 3 2018, 2:59 PM · Frameworks
ossi added inline comments to D10273: Create proper SocketAddress.
Feb 3 2018, 2:48 PM · Frameworks
ossi added inline comments to D10273: Create proper SocketAddress.
Feb 3 2018, 2:19 PM · Frameworks
ossi added a comment to D9966: [KIO] Fix issues with sharing of file descriptor.

Thiago: now it's ready for your review ;)

Feb 3 2018, 11:45 AM · Frameworks

Dec 3 2017

ossi added a comment to D8532: [WIP] Restrict file extractor with Seccomp.

you *really* should use a whitelist. it's ok if that breaks some 3rdparty extractor; you'll get a bug report which you can properly evaluate.
you could go totally overboard and assign fine-grained syscall capabilities to individual extractors, but i can't really think of legitimate reasons why that would be necessary in this context.

Dec 3 2017, 2:10 PM · Baloo, Frameworks
ossi added inline comments to D8254: Make file ioslave backend on removeables are user-frendly on linux.
Dec 3 2017, 1:58 PM · Frameworks

Aug 8 2017

ossi committed R32:1a2a6012d41f: KConfig* API overhaul. only cosmetics, so don't panic. (authored by ossi).
KConfig* API overhaul. only cosmetics, so don't panic.
Aug 8 2017, 2:57 PM
ossi committed R32:17423605ca7a: k3process-- (authored by ossi).
k3process--
Aug 8 2017, 2:54 PM

Mar 17 2017

ossi added a comment to D4975: Prevent misdetection of EOF on Linux.

yeah, but without knowing the root cause, your fix may be just wrong, or at least the comment/commit message may be misleading.
also, https://community.kde.org/Policies/Commit_Policy#Don.27t_commit_code_you_don.27t_understand

Mar 17 2017, 11:09 PM · Frameworks
ossi added a comment to D4975: Prevent misdetection of EOF on Linux.

first try googling it; maybe there is even a response on stackoverflow (as so often happens).
then try posting it yourself to stackoverflow.
dunno whether such questions are welcome on the linux-kernel list, but if not, there might be other lists where it would fit.

Mar 17 2017, 10:46 PM · Frameworks
ossi added a comment to D4975: Prevent misdetection of EOF on Linux.

please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path).
if this is a bug, does it actually affect released versions which are not being "upgraded away" on short notice? i wouldn't want a workaround for a bug that had a very short life span.

Mar 17 2017, 5:03 PM · Frameworks

Sep 10 2016

ossi committed R172:9dc7b32d49e6: KConfig* API overhaul. only cosmetics, so don't panic. (authored by ossi).
KConfig* API overhaul. only cosmetics, so don't panic.
Sep 10 2016, 6:04 AM
ossi committed R172:2d2c68c12f9d: unbreak precommand invocation. CCMAIL: tomalbers@kde.nl (authored by ossi).
unbreak precommand invocation. CCMAIL: tomalbers@kde.nl
Sep 10 2016, 5:57 AM
ossi committed R173:9dc7b32d49e6: KConfig* API overhaul. only cosmetics, so don't panic. (authored by ossi).
KConfig* API overhaul. only cosmetics, so don't panic.
Sep 10 2016, 5:54 AM
ossi committed R172:541030394329: KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO… (authored by ossi).
KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO…
Sep 10 2016, 5:53 AM
ossi committed R108:47eb94cc7307: make scripts executable (authored by ossi).
make scripts executable
Sep 10 2016, 5:49 AM
ossi committed R173:2d2c68c12f9d: unbreak precommand invocation. CCMAIL: tomalbers@kde.nl (authored by ossi).
unbreak precommand invocation. CCMAIL: tomalbers@kde.nl
Sep 10 2016, 5:48 AM
ossi committed R108:5a2cfe04febc: configure in the right config group ... (authored by ossi).
configure in the right config group ...
Sep 10 2016, 5:47 AM
ossi committed R173:541030394329: KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO… (authored by ossi).
KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO…
Sep 10 2016, 5:44 AM
ossi committed R108:daf434231384: KConfig* API overhaul. only cosmetics, so don't panic. (authored by ossi).
KConfig* API overhaul. only cosmetics, so don't panic.
Sep 10 2016, 5:38 AM
ossi committed R108:5a03564c00c5: add some kde3support following k3proc move (authored by ossi).
add some kde3support following k3proc move
Sep 10 2016, 5:38 AM
ossi committed R108:6bed698bf475: k3process-- (authored by ossi).
k3process--
Sep 10 2016, 5:35 AM
ossi committed R108:a0db520a7532: KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO… (authored by ossi).
KProcess -> K3Process KShellProcess -> K3ShellProcess KProcIO -> K3ProcIO…
Sep 10 2016, 5:31 AM
ossi committed R172:d1ad99d51998: if (foo) delete[] foo; -> delete[] foo; (authored by ossi).
if (foo) delete[] foo; -> delete[] foo;
Sep 10 2016, 5:27 AM
ossi committed R172:29121aca09fb: fixing/sanitizing/unifying/reformatting kerberos checks (authored by ossi).
fixing/sanitizing/unifying/reformatting kerberos checks
Sep 10 2016, 5:27 AM
ossi committed R173:d1ad99d51998: if (foo) delete[] foo; -> delete[] foo; (authored by ossi).
if (foo) delete[] foo; -> delete[] foo;
Sep 10 2016, 5:06 AM
ossi committed R173:29121aca09fb: fixing/sanitizing/unifying/reformatting kerberos checks (authored by ossi).
fixing/sanitizing/unifying/reformatting kerberos checks
Sep 10 2016, 5:05 AM
ossi committed R106:591a39628bf7: adjust to INSTALLed permissions (authored by ossi).
adjust to INSTALLed permissions
Sep 10 2016, 3:54 AM
ossi committed R106:4c485907ea52: adjust to INSTALLed permissions (authored by ossi).
adjust to INSTALLed permissions
Sep 10 2016, 3:54 AM
ossi committed R106:b4ccdb3ff6c6: actually install the .desktop files as executables (authored by ossi).
actually install the .desktop files as executables
Sep 10 2016, 3:52 AM