[WIP] Add a kded module infra for fuse mount services
AbandonedPublic
Actions

Authored by chinmoyr on Jul 24 2019, 6:41 AM.

Details

Reviewers: None

Summary

This module watches the install directories of kded modules and curates a list of modules having plugin Category=MountService.
This list will be used by a kio kcm which will allow users to configure mount service for remote protocol.
Once loaded this module can be used in KIOSlave::listDir to mount the url and in KRun::resolveUrls to convert the
remote URL to local URL.

Diff Detail

Repository

R241 KIO

Branch

monitorprotocol

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14367
Build 14385: arc lint + arc unit

chinmoyr created this revision.Jul 24 2019, 6:41 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 24 2019, 6:41 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

chinmoyr requested review of this revision.Jul 24 2019, 6:41 AM

Harbormaster completed remote builds in B14356: Diff 62453.Jul 24 2019, 6:41 AM

Added KRun changes

Harbormaster completed remote builds in B14367: Diff 62469.Jul 24 2019, 12:46 PM

andriusr added a subscriber: andriusr.Jul 25 2019, 5:59 PM

andriusr added inline comments.

src/CMakeLists.txt
19	should we restrict platforms here? (e.g.: NOT WIN32, NOT ANDROID). There are fuse wrappers such as winfsp's or dokany's, but possibly those should not work there.

chinmoyr abandoned this revision.Aug 6 2019, 9:41 AM

What?

In D22708#507449, @ngraham wrote:

What?

Don't worry, all is fine. I've taken over Chinmoy's work on this for now. We agreed on a better way to go about integrating KIOFuse into KIO.

Oh good. :) Is there anywhere I can follow the progress?

In D22708#516128, @ngraham wrote:

Oh good. :) Is there anywhere I can follow the progress?

All my work goes on KIOFuse goes into review here:
https://gitlab.com/Vogtinator/kio-fuse/merge_requests

Sometimes I need to upload diffs upstream to KIO to fix bugs or for integrating KIOFuse into KIO. Those can be followed via my phabricator diffs. I have some (i.e. KIO bug fixes) that I would like to get into 5.62, but no one is able to review/approve my KIO changes atm...

Also feel free to pop by #kde-fm for discussions or if you want to ask a question.

In D22708#516131, @feverfew wrote:

In D22708#516128, @ngraham wrote:

Oh good. :) Is there anywhere I can follow the progress?

All my work goes on KIOFuse goes into review here:
https://gitlab.com/Vogtinator/kio-fuse/merge_requests

Thanks!

Sometimes I need to upload diffs upstream to KIO to fix bugs or for integrating KIOFuse into KIO. Those can be followed via my phabricator diffs. I have some (i.e. KIO bug fixes) that I would like to get into 5.62, but no one is able to review/approve my KIO changes atm...

I'll see if I can get some attention on them.

Also feel free to pop by #kde-fm for discussions or if you want to ask a question.

It kicks me out for not having a registered nickname even though I totally do and am using it. If it's not necessary anymore, it might be nice to remove that restriction.

In D22708#516132, @ngraham wrote:

In D22708#516131, @feverfew wrote:

In D22708#516128, @ngraham wrote:

Also feel free to pop by #kde-fm for discussions or if you want to ask a question.

It kicks me out for not having a registered nickname even though I totally do and am using it. If it's not necessary anymore, it might be nice to remove that restriction.

Yeah I've had problems accessing that channel via matrix unless I used Konversation.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
M		src/core/kdiskfreespaceinfo.cpp (2 lines)
M		src/ioslaves/file/file.cpp (2 lines)
M		src/ioslaves/file/file_unix.cpp (2 lines)
M		src/kcms/kio/CMakeLists.txt (11 lines)
A	M	src/kcms/kio/fusemanager.h (87 lines)
A	M	src/kcms/kio/fusemanager.cpp (256 lines)
A	M	src/kcms/kio/fusemanager.desktop (17 lines)
A	M	src/kcms/kio/fusemanager.ui (103 lines)
A	M	src/kcms/kio/fuseserviceselector.ui (64 lines)
M		src/kcms/kio/main.cpp (2 lines)
A	M	src/mountserviced/CMakeLists.txt (19 lines)
A	M	src/mountserviced/mountservicemanager.h (57 lines)
A	M	src/mountserviced/mountservicemanager.cpp (158 lines)
A	M	src/mountserviced/mountservicemanager.desktop (9 lines)
A	M	src/mountserviced/org.kde.kio.MountServiceManager.xml (18 lines)
M		src/widgets/CMakeLists.txt (1 line)
M		src/widgets/krun.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62453	6788a0d		Jul 24 2019, 6:41 AM	★	★
Diff 2	62469	6788a0d	Added KRun changes	Jul 24 2019, 12:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d88521a9f5c1	da9024ae05b1	6788a0db3234	Chinmoy Ranjan Pradhan	[WIP] Add a kded module infra for fuse mount services (Show More…)	Jul 19 2019, 11:11 AM

[WIP] Add a kded module infra for fuse mount servicesAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 62469

src/CMakeLists.txt

src/core/kdiskfreespaceinfo.cpp

src/ioslaves/file/file.cpp

src/ioslaves/file/file_unix.cpp

src/kcms/kio/CMakeLists.txt

src/kcms/kio/fusemanager.h

src/kcms/kio/fusemanager.cpp

src/kcms/kio/fusemanager.desktop

src/kcms/kio/fusemanager.ui

src/kcms/kio/fuseserviceselector.ui

src/kcms/kio/main.cpp

src/mountserviced/CMakeLists.txt

src/mountserviced/mountservicemanager.h

src/mountserviced/mountservicemanager.cpp

src/mountserviced/mountservicemanager.desktop

src/mountserviced/org.kde.kio.MountServiceManager.xml

src/widgets/CMakeLists.txt

src/widgets/krun.cpp

[WIP] Add a kded module infra for fuse mount services
AbandonedPublic
Actions

Revision Contents
Changeset List