Rebased on master.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Nov 2 2021
Apr 17 2020
Dec 24 2019
In D21783#581781, @dfaure wrote:@chinmoyr This change also breaks the corresponding unittest in CI, please take a look.
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/testReport/junit/projectroot/autotests/kiocore_privilegejobtest/
Dec 22 2019
Dec 18 2019
updated kf5 version.
Dec 7 2019
Rebased, compiled and tested. Changes work as expected.
Double checked file_unix.cpp. Would be a shame if it happens yet again.
Dec 6 2019
Addressed the issues.
Annotated code to be removed in KF6.
My build env is outdated so I couldn't compile the new depracation macro. Copied as it is.
Dec 4 2019
Addressed the issues.
Oct 15 2019
Addressed the comments.
Aug 28 2019
Aug 26 2019
Aug 23 2019
Aug 16 2019
Addressed comments.
Aug 15 2019
Aug 6 2019
Jul 24 2019
Added KRun changes
Jul 19 2019
Jun 22 2019
In D14467#483848, @bcooksley wrote:It would appear that the commit of this change disturbed somethng with FreeBSD builds - see https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/135/
Could someone take a look into that please?
Jun 21 2019
Updated the implementation.
Thanks for your help!
"More Details" -> "Details"
Separated (l)chown since it's to be done with elavated privileges.
Addresed the issues.
Jun 20 2019
Thanks @maltek. I've fixed all the issues.
Jun 19 2019
Jun 15 2019
TODO
- Change the UI of the warning dialog
- We still need more details
Jun 14 2019
Jun 13 2019
Updated frameworks version.
In D14467#479223, @ngraham wrote:@mgerstner How is this looking now? Yea/nay?
In D21782#479190, @GB_2 wrote:I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
In D21783#479187, @ngraham wrote:Thanks! Is this for T8075?
Fix typo
Jun 7 2019
use seteuid to make the logic for rename work
Jun 6 2019
- int -> ActionType
- separated the logic in dropPrivileges() to two parts
- accepting mode argument in mkdir
- used *at() functions
- minor cosmetic changes
May 27 2019
May 21 2019
May 14 2019
May 13 2019
May 12 2019
May 5 2019
Apr 5 2019
Mar 26 2019
The issue here is the placement of code. There are no API for changing any volume attributes so adding the changeLabel() method here feels awkward.
Mar 20 2019
Mar 17 2019
I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry.
Mar 15 2019
Removed unused headers.
Mar 14 2019
Issues fixed.
Mar 13 2019
Moved to kdegraphics-thumbnailer.
Got rid of operator>>(). Now reading the entire file-block header and extracting the length from raw bytes.
Used QByteArrays instead of static char arrays.
Fixed some minor issues.
Mar 12 2019
Mar 10 2019
Update summary
Changed m_bFileWriteInProgress -> m_bFileCopyInProgress
Mar 9 2019
In D7571#427773, @elvisangelaccio wrote:@chinmoyr Is this patch going to be replaced by another one, or is it not needed anymore?