URL of a website can exceed 255 characters. Consequently we cannot create a link to such URL.
In such cases try to truncate the filename to 255 characters.
BUG: 342247
Details
Details
- Reviewers
dfaure ngraham - Commits
- R241:092beaf6fbab: Truncate long filname before creating a link
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This has several issues:
- 255 is only a typical value, it can be more or less, see https://en.wikipedia.org/wiki/Comparison_of_file_systems#Limits
- exFAT can store 255 UTF-16 characters
- eCryptFS can only use ~140 bytes (remainder is used for mangling/prefix)
- for most FS on Linux, 255 is in bytes, not characters
Comment Actions
The first issue is solved by the use of NAME_MAX (the code doesn't actually hardcode 255), but indeed those are bytes, so this has to use QFile::encodeName() (to get to QByteArray), truncate, then QFile::decodeName() (to get back to QString). But what if this cuts in the middle of a utf-8 sequence....