ahartmetz (Andreas Hartmetz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2015, 6:21 PM (226 w, 6 d)
Availability
Available

Recent Activity

Apr 13 2019

ahartmetz requested review of D20518: Enable multi-tab-only shortcuts after restoring a multi-tab session from session management.
Apr 13 2019, 9:46 PM · Konsole

Oct 31 2018

ahartmetz accepted D16550: [ksmserver] Fix session restore check.

This fixes session restore for me.

Oct 31 2018, 5:11 PM · Plasma

Sep 27 2018

ahartmetz committed R119:cb52b2badb4c: Fix another auto QStringBuilder crash (access to destroyed temporary) (authored by ahartmetz).
Fix another auto QStringBuilder crash (access to destroyed temporary)
Sep 27 2018, 6:01 PM
ahartmetz committed R119:b39d9ede8deb: [Baloo KCM] Build fix. Missing opening brace. (authored by smithjd).
[Baloo KCM] Build fix. Missing opening brace.
Sep 27 2018, 6:01 PM
ahartmetz committed R119:226c914040ad: baloo kcm: Fix duplicate paths in config file. (authored by smithjd).
baloo kcm: Fix duplicate paths in config file.
Sep 27 2018, 6:01 PM

Sep 6 2018

ahartmetz committed R44:23dc89061a33: Add include that is missing when using QtWebEngine 5.12 (authored by ahartmetz).
Add include that is missing when using QtWebEngine 5.12
Sep 6 2018, 9:00 PM

Aug 30 2018

ahartmetz updated subscribers of D14922: Assert if trying to use a KCatalog without a QCoreApplication.

@kwin

Aug 30 2018, 10:27 AM · Frameworks
ahartmetz added a comment to D14922: Assert if trying to use a KCatalog without a QCoreApplication.

This change makes kwin_x11 crash on startup. Please fix kwin or degrade this to a warning.

Aug 30 2018, 9:47 AM · Frameworks

Aug 3 2018

ahartmetz committed R319:76b8b8d71d17: Don't pollute the environment inside Konsole with QT_NO_GLIB (authored by ahartmetz).
Don't pollute the environment inside Konsole with QT_NO_GLIB
Aug 3 2018, 11:22 AM
ahartmetz closed D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 3 2018, 11:22 AM · Konsole
ahartmetz added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

OK, I've tested it, the fix that this amends still works as well.

Aug 3 2018, 11:04 AM · Konsole

Aug 2 2018

ahartmetz added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

@sandsmark , it would be good to retest if your fix still works after this. IIRC QApplication does not lazily initialize the event loop though.

Aug 2 2018, 4:59 PM · Konsole
ahartmetz updated the test plan for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 2 2018, 1:26 PM · Konsole
ahartmetz added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: Konsole.
Aug 2 2018, 1:24 PM · Konsole
ahartmetz added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: hindenburg.
Aug 2 2018, 1:19 PM · Konsole
ahartmetz requested review of D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 2 2018, 1:17 PM · Konsole

Jul 23 2018

ahartmetz committed R119:e99778b93f40: Revert last commit in two cases - don't compare two char pointers (authored by ahartmetz).
Revert last commit in two cases - don't compare two char pointers
Jul 23 2018, 10:46 AM

Jul 6 2018

ahartmetz committed R165:5d629ebb3087: Fix a crash due to access of temporary object (authored by ahartmetz).
Fix a crash due to access of temporary object
Jul 6 2018, 9:47 AM

Jun 8 2018

ahartmetz accepted D13435: Remove verbose debugging statement.

There are many more plain qDebug()s in this module, but this one seems to produce the most noise...

Jun 8 2018, 7:24 PM · Plasma

Mar 30 2018

ahartmetz committed R241:eb769901814f: Fix build with recent Qt5 versions (authored by ahartmetz).
Fix build with recent Qt5 versions
Mar 30 2018, 1:40 PM

Dec 18 2017

ahartmetz committed R738:e37362d59381: Small comment and formatting fixes (authored by ahartmetz).
Small comment and formatting fixes
Dec 18 2017, 3:40 PM
ahartmetz committed R738:97bbec6130c4: Change variable names to follow Transceiver -> Connection rename, #2 (authored by ahartmetz).
Change variable names to follow Transceiver -> Connection rename, #2
Dec 18 2017, 3:39 PM
ahartmetz committed R738:34888b52dbcb: Message: rearrange some getters and setters (authored by ahartmetz).
Message: rearrange some getters and setters
Dec 18 2017, 3:39 PM
ahartmetz committed R738:370ab799d5aa: Change variable names to follow Transceiver -> Connection rename (authored by ahartmetz).
Change variable names to follow Transceiver -> Connection rename
Dec 18 2017, 1:55 PM

Nov 27 2017

ahartmetz committed R165:8a7c66ec1d3d: Prevent index out of range in case of empty or malformed filename (authored by ahartmetz).
Prevent index out of range in case of empty or malformed filename
Nov 27 2017, 9:38 PM
ahartmetz closed D8968: Prevent index out of range in case of empty or malformed filename.
Nov 27 2017, 9:38 PM · KDE PIM
ahartmetz updated the diff for D8968: Prevent index out of range in case of empty or malformed filename.

Change base revision

Nov 27 2017, 9:36 PM · KDE PIM
ahartmetz updated the diff for D8968: Prevent index out of range in case of empty or malformed filename.

Change second index check to >0

Nov 27 2017, 9:24 PM · KDE PIM
ahartmetz committed R241:95d11df88d61: Don't repeat constant values in comments (authored by ahartmetz).
Don't repeat constant values in comments
Nov 27 2017, 9:01 PM

Nov 23 2017

ahartmetz added inline comments to D8968: Prevent index out of range in case of empty or malformed filename.
Nov 23 2017, 5:19 PM · KDE PIM
ahartmetz added reviewers for D8968: Prevent index out of range in case of empty or malformed filename: KDE PIM, dvratil.
Nov 23 2017, 2:57 PM · KDE PIM
ahartmetz added a comment to D8968: Prevent index out of range in case of empty or malformed filename.

Maybe it is better to return an empty string in this case but I don't know. Otherwise I might thave pushed this directly. In the case of my missing file, the returned string was the name of the folder <file_db_data>/00/, which generates an error message that the file it tried to open is actually a folder...

Nov 23 2017, 2:56 PM · KDE PIM
ahartmetz created D8968: Prevent index out of range in case of empty or malformed filename.
Nov 23 2017, 2:53 PM · KDE PIM

Nov 12 2017

ahartmetz committed R39:f0e3e3da5f94: Remove unused member variable (authored by ahartmetz).
Remove unused member variable
Nov 12 2017, 4:41 PM

Oct 17 2017

ahartmetz committed R738:7a2085ea90e6: Rename directory to "connection" in tests, too. (authored by ahartmetz).
Rename directory to "connection" in tests, too.
Oct 17 2017, 8:51 PM
ahartmetz committed R738:2fa72b2cf173: Complete the big Transceiver -> Connection rename (authored by ahartmetz).
Complete the big Transceiver -> Connection rename
Oct 17 2017, 1:13 PM
ahartmetz committed R738:8a8cf1a92c57: Rename everything with Connection to Transport (authored by ahartmetz).
Rename everything with Connection to Transport
Oct 17 2017, 1:13 PM
ahartmetz committed R738:b814d283b725: Rename AuthNegotiator -> AuthClient and move file to where it's used (authored by ahartmetz).
Rename AuthNegotiator -> AuthClient and move file to where it's used
Oct 17 2017, 1:13 PM
ahartmetz committed R738:d338d163b762: Remove unused auth related file (authored by ahartmetz).
Remove unused auth related file
Oct 17 2017, 1:13 PM
ahartmetz committed R738:65979b37f3de: Rename ConnectionInfo -> ConnectAddress (authored by ahartmetz).
Rename ConnectionInfo -> ConnectAddress
Oct 17 2017, 1:13 PM
ahartmetz committed R738:cec551209edf: Remove unused friend declaration (authored by ahartmetz).
Remove unused friend declaration
Oct 17 2017, 1:13 PM
ahartmetz committed R738:dae1b72a0aa9: Add provision for exclusively using event loop integration... (authored by ahartmetz).
Add provision for exclusively using event loop integration...
Oct 17 2017, 1:13 PM
ahartmetz committed R738:10bb7922daee: Unify names of "event handler style" virtual methods. (authored by ahartmetz).
Unify names of "event handler style" virtual methods.
Oct 17 2017, 1:13 PM
ahartmetz committed R738:62a9bc036516: Shut up gcc's fallthrough warning here (authored by ahartmetz).
Shut up gcc's fallthrough warning here
Oct 17 2017, 1:13 PM
ahartmetz committed R738:38c90738e036: Fix peek data methods in Arguments::Writer (authored by ahartmetz).
Fix peek data methods in Arguments::Writer
Oct 17 2017, 1:13 PM
ahartmetz committed R738:b60cfc31a99d: Add a class for integration into foreign event loops. (authored by ahartmetz).
Add a class for integration into foreign event loops.
Oct 17 2017, 1:13 PM
ahartmetz committed R738:1b3b2dd62242: Remove pollDescriptor() methods (authored by ahartmetz).
Remove pollDescriptor() methods
Oct 17 2017, 1:13 PM

Sep 7 2017

ahartmetz committed R738:4058f7483dd8: Fix and unify _WIN32 ifdefs (authored by ahartmetz).
Fix and unify _WIN32 ifdefs
Sep 7 2017, 8:36 PM
ahartmetz committed R738:5a40858ee071: Add forgotten license headers to three new files. (authored by ahartmetz).
Add forgotten license headers to three new files.
Sep 7 2017, 8:36 PM

Sep 6 2017

ahartmetz committed R738:d50d6884b7a2: Cleanly define maximum lengths and add more checks for them (authored by ahartmetz).
Cleanly define maximum lengths and add more checks for them
Sep 6 2017, 6:50 PM
ahartmetz committed R738:a5222b01d25f: Set an error code in case of error (authored by ahartmetz).
Set an error code in case of error
Sep 6 2017, 6:50 PM
ahartmetz committed R738:38c315834bd2: Fix two errors in error handling that partially cancelled out... (authored by ahartmetz).
Fix two errors in error handling that partially cancelled out...
Sep 6 2017, 6:50 PM
ahartmetz committed R738:c43abd086251: Writer: check that aggregates are open before closing them (authored by ahartmetz).
Writer: check that aggregates are open before closing them
Sep 6 2017, 6:50 PM
ahartmetz committed R738:61310f627f6e: Don't touch the interface header when not setting an interface (authored by ahartmetz).
Don't touch the interface header when not setting an interface
Sep 6 2017, 6:50 PM
ahartmetz committed R738:f136673501f7: Fix array length checks while writing (authored by ahartmetz).
Fix array length checks while writing
Sep 6 2017, 6:50 PM
ahartmetz committed R738:43d5a4856de3: Better variable names for Timer testTriggerOnlyOncePerDispatch() (authored by ahartmetz).
Better variable names for Timer testTriggerOnlyOncePerDispatch()
Sep 6 2017, 6:50 PM
ahartmetz committed R738:264a4369a8df: EventDispatcher: fix a few tricky cases regarding Timers (authored by ahartmetz).
EventDispatcher: fix a few tricky cases regarding Timers
Sep 6 2017, 6:50 PM
ahartmetz committed R738:382acb941e1b: Include what you use for MallocCache (authored by ahartmetz).
Include what you use for MallocCache
Sep 6 2017, 6:50 PM
ahartmetz committed R738:564b16e5c0ad: Reader / Writer: Fix use after free / double delete... (authored by ahartmetz).
Reader / Writer: Fix use after free / double delete...
Sep 6 2017, 6:50 PM
ahartmetz committed R738:f5da316df14d: Implement isAligned() without using alignmentLog2() (authored by ahartmetz).
Implement isAligned() without using alignmentLog2()
Sep 6 2017, 6:50 PM
ahartmetz committed R738:0b9b446e5c6a: Split out Arguments::Reader and ...::Writer into their own files. (authored by ahartmetz).
Split out Arguments::Reader and ...::Writer into their own files.
Sep 6 2017, 6:50 PM

Sep 1 2017

ahartmetz committed R165:eadda1d97e2b: Fix typos of "orphan" (authored by ahartmetz).
Fix typos of "orphan"
Sep 1 2017, 7:51 PM

Aug 8 2017

ahartmetz committed R32:5d18fbdc6a20: link with gold (authored by ahartmetz).
link with gold
Aug 8 2017, 3:54 PM
ahartmetz committed R32:b2643b7c1e01: link with gold (authored by ahartmetz).
link with gold
Aug 8 2017, 3:30 PM

Apr 7 2017

ahartmetz committed R108:90a33a4bc289: Fix two more const / non-const iterator mismatches. (authored by ahartmetz).
Fix two more const / non-const iterator mismatches.
Apr 7 2017, 6:39 PM
ahartmetz committed R108:0fa4c27c66ba: Fix build: Compare non-const iterator with non-const iterator (authored by ahartmetz).
Fix build: Compare non-const iterator with non-const iterator
Apr 7 2017, 5:38 PM

Mar 20 2017

ahartmetz committed R738:04193460bea1: Arguments::Reader: actually use MallocCache everywhere. (authored by ahartmetz).
Arguments::Reader: actually use MallocCache everywhere.
Mar 20 2017, 12:07 PM
ahartmetz committed R738:b1c9e51dd1d9: Allow getting the maximum known signature *and* the current positon. (authored by ahartmetz).
Allow getting the maximum known signature *and* the current positon.
Mar 20 2017, 12:07 PM

Mar 19 2017

ahartmetz committed R738:ba97c0b73140: Add Arguments::isByteSwapped() accessor. (authored by ahartmetz).
Add Arguments::isByteSwapped() accessor.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:1faef9e50be3: Add Writer::peekSerializedData(), a temporary view of the data. (authored by ahartmetz).
Add Writer::peekSerializedData(), a temporary view of the data.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:f2cfbb5f9010: Use a small vector optimization for the aggregate stack. (authored by ahartmetz).
Use a small vector optimization for the aggregate stack.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:aa79240951fd: Use MallocCache also for Reader::Private. (authored by ahartmetz).
Use MallocCache also for Reader::Private.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:611c299c9390: Use the right MT primitive for the atomic serial picker. (authored by ahartmetz).
Use the right MT primitive for the atomic serial picker.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:edfa37e45b35: Make the often called QueuedDataInfo ctor constexpr. (authored by ahartmetz).
Make the often called QueuedDataInfo ctor constexpr.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:700b15f28175: Fix "NeedMoreData" testing. It was broken due to an API change. (authored by ahartmetz).
Fix "NeedMoreData" testing. It was broken due to an API change.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:a78f45a9bc70: WIP enable file descriptor passing in Message and Arguments. (authored by ahartmetz).
WIP enable file descriptor passing in Message and Arguments.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:9a1c9388e5ca: Remove a member variable that has been made obsolete earlier. (authored by ahartmetz).
Remove a member variable that has been made obsolete earlier.
Mar 19 2017, 5:27 PM
ahartmetz committed R738:d2145157448b: Avoid passing an object here, somehow creating it costs cycles. (authored by ahartmetz).
Avoid passing an object here, somehow creating it costs cycles.
Mar 19 2017, 5:26 PM

Mar 16 2017

ahartmetz committed R738:7ecd30cd1b21: Remove protected visibility, it seems to trigger a linker bug. (authored by ahartmetz).
Remove protected visibility, it seems to trigger a linker bug.
Mar 16 2017, 8:46 PM
ahartmetz committed R738:1dc801590333: WIP: Enable file descriptor passing in socket/connection code. (authored by ahartmetz).
WIP: Enable file descriptor passing in socket/connection code.
Mar 16 2017, 8:46 PM
ahartmetz committed R738:8a024aa690f1: Add a performance hack for writing variable message headers. (authored by ahartmetz).
Add a performance hack for writing variable message headers.
Mar 16 2017, 8:46 PM
ahartmetz committed R738:64f41cb31122: Arguments r/w: always set an error when going into invalid state. (authored by ahartmetz).
Arguments r/w: always set an error when going into invalid state.
Mar 16 2017, 8:46 PM
ahartmetz committed R738:c0ede5df2844: WIP: Serialize directly if there is no need to do otherwise. (authored by ahartmetz).
WIP: Serialize directly if there is no need to do otherwise.
Mar 16 2017, 8:46 PM
ahartmetz committed R738:bf5d5f633043: WIP minimally copying Message serialization / deserialization (authored by ahartmetz).
WIP minimally copying Message serialization / deserialization
Mar 16 2017, 8:46 PM
ahartmetz committed R738:e5225995f43e: Remove an accidentally not previously removed data member. (authored by ahartmetz).
Remove an accidentally not previously removed data member.
Mar 16 2017, 8:46 PM

Feb 25 2017

ahartmetz committed R181:323e2d5b4324: Fix build (authored by ahartmetz).
Fix build
Feb 25 2017, 9:12 PM

Feb 3 2017

ahartmetz committed R165:2803bf075f8d: Fix a crash due to mutating a container while iterating. (authored by ahartmetz).
Fix a crash due to mutating a container while iterating.
Feb 3 2017, 1:20 PM

Jan 10 2017

ahartmetz added a comment to D4060: kio: Ensure user certificate directory has been created before storing certs to it.

Looks like a stupid mistake on my part, thanks for the fix.

Jan 10 2017, 9:32 PM · Frameworks

Sep 30 2016

ahartmetz committed R40:97116ac0a3ac: Session chooser: Ensure no unnecessary horizontal scroll bar. (authored by ahartmetz).
Session chooser: Ensure no unnecessary horizontal scroll bar.
Sep 30 2016, 5:45 PM
ahartmetz committed R40:d664483ac5e5: Session chooser: Ensure no unnecessary horizontal scroll bar. (authored by ahartmetz).
Session chooser: Ensure no unnecessary horizontal scroll bar.
Sep 30 2016, 5:44 PM
ahartmetz added a comment to D2897: Session chooser: Ensure no unnecessary horizontal scroll bar..

Session chooser before:

Sep 30 2016, 5:33 PM
ahartmetz added reviewers for D2897: Session chooser: Ensure no unnecessary horizontal scroll bar.: cullmann, dhaumann, lueck.
Sep 30 2016, 5:27 PM
ahartmetz retitled D2897: Session chooser: Ensure no unnecessary horizontal scroll bar. from to Session chooser: Ensure no unnecessary horizontal scroll bar..
Sep 30 2016, 5:26 PM

Sep 10 2016

ahartmetz committed R172:c5ab942db7a9: compile (authored by ahartmetz).
compile
Sep 10 2016, 6:39 AM
ahartmetz committed R172:6c84dfd30db1: link with gold (authored by ahartmetz).
link with gold
Sep 10 2016, 6:38 AM
ahartmetz committed R172:a0a5bb616e37: link with gold (authored by ahartmetz).
link with gold
Sep 10 2016, 6:38 AM
ahartmetz committed R172:21d7ace9863b: link with gold (authored by ahartmetz).
link with gold
Sep 10 2016, 6:37 AM
ahartmetz committed R172:1dc8a73fa047: link with gold (undefined references to QApplication::...) (authored by ahartmetz).
link with gold (undefined references to QApplication::...)
Sep 10 2016, 6:37 AM
ahartmetz committed R173:c5ab942db7a9: compile (authored by ahartmetz).
compile
Sep 10 2016, 6:32 AM
ahartmetz committed R173:6c84dfd30db1: link with gold (authored by ahartmetz).
link with gold
Sep 10 2016, 6:30 AM