ahartmetz (Andreas Hartmetz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2015, 6:21 PM (261 w, 4 d)
Availability
Available

Recent Activity

Mon, Feb 3

ahartmetz added a comment to T11627: Improve KIO asynchronicity.

You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It is especially useful for looking at latency problems.
https://cgit.kde.org/dferry.git/

It seriously lacks documentation, not even a README.

I have been using Bustle for dbus monitoring.

Mon, Feb 3, 2:59 PM · Dolphin, Frameworks
ahartmetz added a comment to T11627: Improve KIO asynchronicity.

You may want to look at the DBus part of this with dfer-monitor, a tool I have written. It is especially useful for looking at latency problems.
https://cgit.kde.org/dferry.git/

Mon, Feb 3, 2:45 PM · Dolphin, Frameworks

Jan 21 2020

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

@fvogt Yeah thanks, that made more sense than you spoon-feeding me the information for the commit message ;)

Jan 21 2020, 11:10 AM · Plasma

Jan 16 2020

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

So what do we do here? The Qt bug has been fixed but still I'm not sure what should be done about the environment variables.

Jan 16 2020, 7:55 PM · Plasma

Dec 29 2019

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Thanks for following up!

I'll open a Qt bug and see how it goes.

Can you link it please.

Dec 29 2019, 9:12 PM · Plasma

Dec 28 2019

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Can forcing bigger font DPI make things better?

Dec 28 2019, 11:24 PM · Plasma
ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

It's probably okay to still say that scaling is enabled "in general" but for scaling <2, and why not, maybe even greater, hinting should not be inhibited. The screen is still made of pixels. Qt is not going to be able to throw out all the hinting and subpixel code like Apple did, because it still needs to be supported for non-Retina screens anyway, for a long time. I'll open a Qt bug and see how it goes.

Dec 28 2019, 4:35 PM · Plasma
ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

I think I see the problem. You pay for the possibility to have scaling with unhinted fonts. I am pretty sure that that isn't an acceptable way of handling it. Most Linux desktop fonts are intended to be used with some hinting (slight hinting usually?). QHighDpiScaling::isActive() returns true even when the scale factor is 1.0 as in my case. Looks like a Qt bug to me.

Dec 28 2019, 4:23 PM · Plasma

Dec 24 2019

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Just to make this extra clear, I have nothing against auto-scaling. There is probably a KCM to set it however I want if I don't like the default. My problem is with blurry and in some cases ("-=") disfigured font rendering. That should never happen regardless of physical and logical DPI (though no subpixel rendering and maybe no hinting might be fine at >= 2.0 scaling). With this patch, it looks like with Qt 5.13 on not very high DPI screens, i.e. it looks nice. I don't own a really high DPI screen so far.

Dec 24 2019, 9:58 PM · Plasma

Dec 23 2019

ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Test with qputenv(QT_ENABLE_HIGHDPI_SCALING, "1") it's especially for 5.14+

Dec 23 2019, 2:09 PM · Plasma
ahartmetz updated the test plan for D26185: Also disable automatic scaling on Qt >= 5.14.
Dec 23 2019, 12:25 PM · Plasma
ahartmetz updated the summary of D26185: Also disable automatic scaling on Qt >= 5.14.
Dec 23 2019, 12:05 PM · Plasma
ahartmetz added a comment to D26185: Also disable automatic scaling on Qt >= 5.14.

Compiled against Qt 5.14 before this change:

Dec 23 2019, 11:58 AM · Plasma
ahartmetz requested review of D26185: Also disable automatic scaling on Qt >= 5.14.
Dec 23 2019, 11:56 AM · Plasma

Nov 28 2019

ahartmetz committed R108:f3a9daaa4f9e: Fix build: remove call to removed method (authored by ahartmetz).
Fix build: remove call to removed method
Nov 28 2019, 2:00 PM

Oct 12 2019

ahartmetz committed R738:c013722fd061: Have a user-defined assignment operator to go with the copy constructor (authored by ahartmetz).
Have a user-defined assignment operator to go with the copy constructor
Oct 12 2019, 1:54 PM

Aug 22 2019

ahartmetz committed R738:0f9d32b34468: Test and fix error propagation through a whole message roundtrip (authored by ahartmetz).
Test and fix error propagation through a whole message roundtrip
Aug 22 2019, 11:51 AM
ahartmetz committed R738:8c4ad1f3759c: Eliminate a copy of Arguments during connection setup (authored by ahartmetz).
Eliminate a copy of Arguments during connection setup
Aug 22 2019, 11:51 AM
ahartmetz committed R738:0d067e441291: Test the headers part of Message assignment (authored by ahartmetz).
Test the headers part of Message assignment
Aug 22 2019, 11:51 AM
ahartmetz committed R738:dc88e2a06cfc: Cleanly separate those bits in the bitfield (authored by ahartmetz).
Cleanly separate those bits in the bitfield
Aug 22 2019, 11:51 AM
ahartmetz committed R738:f5f8b3546529: Use Connection * in IMessageReceiver::handleSpontaneousMessageReceived() (authored by ahartmetz).
Use Connection * in IMessageReceiver::handleSpontaneousMessageReceived()
Aug 22 2019, 11:51 AM
ahartmetz committed R738:560cf3537ea7: Use new interface when old monitoring interface is disabled (authored by ahartmetz).
Use new interface when old monitoring interface is disabled
Aug 22 2019, 11:51 AM
ahartmetz committed R738:5196eb28c1c9: analyzer: only try to find interface names for numeric addresses (authored by ahartmetz).
analyzer: only try to find interface names for numeric addresses
Aug 22 2019, 11:51 AM
ahartmetz committed R738:bcf8f2669b67: Refine Server error handling - handle EINTR, don't close due to error (authored by ahartmetz).
Refine Server error handling - handle EINTR, don't close due to error
Aug 22 2019, 11:51 AM
ahartmetz committed R738:c083d4535078: Avoid a small amount of unnecessary work here (authored by ahartmetz).
Avoid a small amount of unnecessary work here
Aug 22 2019, 11:51 AM
ahartmetz committed R738:f1b6d4f79579: Test the Server class (authored by ahartmetz).
Test the Server class
Aug 22 2019, 11:51 AM
ahartmetz committed R738:83d2435f0cac: Enable watching of Connection state (authored by ahartmetz).
Enable watching of Connection state
Aug 22 2019, 11:51 AM
ahartmetz committed R738:34eeed6971e4: Nice to have: ensure that the hello message has serial 1 (authored by ahartmetz).
Nice to have: ensure that the hello message has serial 1
Aug 22 2019, 11:51 AM
ahartmetz committed R738:405adbffd6bc: Use member default initalization for ConnectionPrivate (authored by ahartmetz).
Use member default initalization for ConnectionPrivate
Aug 22 2019, 11:51 AM
ahartmetz committed R738:7fb065d4bdfd: Copy n-1 times, move the last time - saves a copy (authored by ahartmetz).
Copy n-1 times, move the last time - saves a copy
Aug 22 2019, 11:51 AM
ahartmetz committed R738:e53aef7cc742: Connection: fix link from private to public instance when moving (authored by ahartmetz).
Connection: fix link from private to public instance when moving
Aug 22 2019, 11:51 AM
ahartmetz committed R738:29672dda8a36: Make this dummy interface name valid according to spec (authored by ahartmetz).
Make this dummy interface name valid according to spec
Aug 22 2019, 11:51 AM
ahartmetz committed R738:b4644e098186: Add Connection * to IMessageReceiver method arguments (authored by ahartmetz).
Add Connection * to IMessageReceiver method arguments
Aug 22 2019, 11:51 AM
ahartmetz committed R738:b271d30f62b1: Fix build break due to a new compiler warning and -Werror (authored by ahartmetz).
Fix build break due to a new compiler warning and -Werror
Aug 22 2019, 11:51 AM
ahartmetz committed R738:afce71f66096: Complete support for message flags (authored by ahartmetz).
Complete support for message flags
Aug 22 2019, 11:51 AM
ahartmetz committed R738:ab9000128e3f: Remove obsolete friend declarations (authored by ahartmetz).
Remove obsolete friend declarations
Aug 22 2019, 11:51 AM
ahartmetz committed R738:47cf8ff34d3b: Make handling of Message sending / serialized state more robust (authored by ahartmetz).
Make handling of Message sending / serialized state more robust
Aug 22 2019, 11:51 AM
ahartmetz committed R738:7944aab9e865: Fix two crashes in EventDispatcher destructor (authored by ahartmetz).
Fix two crashes in EventDispatcher destructor
Aug 22 2019, 11:51 AM
ahartmetz committed R738:c6747efea6df: Make Connection movable (authored by ahartmetz).
Make Connection movable
Aug 22 2019, 11:51 AM
ahartmetz committed R738:43f17dccb49f: Really fix socket path passing in local socket code (authored by ahartmetz).
Really fix socket path passing in local socket code
Aug 22 2019, 11:51 AM
ahartmetz committed R738:062d86d54025: Proper server support - support accepting more than one client (authored by ahartmetz).
Proper server support - support accepting more than one client
Aug 22 2019, 11:51 AM
ahartmetz committed R738:fc64f9c5b4fe: Add missing pieces and tests for file descriptor passing (authored by ahartmetz).
Add missing pieces and tests for file descriptor passing
Aug 22 2019, 11:51 AM
ahartmetz committed R738:adf57ea5c065: PendingReplyPrivate: initialize all member variables (authored by ahartmetz).
PendingReplyPrivate: initialize all member variables
Aug 22 2019, 11:51 AM
ahartmetz committed R738:66595c8398bf: Add PendingReply::isNull() (authored by ahartmetz).
Add PendingReply::isNull()
Aug 22 2019, 11:51 AM
ahartmetz committed R738:74df67a7fd2c: Maybe a null PendingReply isn't an error - anyway, don't crash (authored by ahartmetz).
Maybe a null PendingReply isn't an error - anyway, don't crash
Aug 22 2019, 11:51 AM
ahartmetz committed R738:d7ce0b8f2d87: Connection: Only assign serials to messages that don't have one yet (authored by ahartmetz).
Connection: Only assign serials to messages that don't have one yet
Aug 22 2019, 11:51 AM
ahartmetz committed R738:90908f7a67b4: Remove debug spam (authored by ahartmetz).
Remove debug spam
Aug 22 2019, 11:51 AM
ahartmetz committed R738:17921ec1c3f8: Connection: rework authentication and registration (authored by ahartmetz).
Connection: rework authentication and registration
Aug 22 2019, 11:51 AM
ahartmetz committed R738:be13c89166fb: AuthClient: avoid deadlock when connection closes at the wrong time (authored by ahartmetz).
AuthClient: avoid deadlock when connection closes at the wrong time
Aug 22 2019, 11:51 AM
ahartmetz committed R738:3f5eabce5c48: Connection: add close(). Sometimes useful. (authored by ahartmetz).
Connection: add close(). Sometimes useful.
Aug 22 2019, 11:51 AM
ahartmetz committed R738:d93934729391: Add Connection::waitForConnectionEstablished() (authored by ahartmetz).
Add Connection::waitForConnectionEstablished()
Aug 22 2019, 11:51 AM
ahartmetz committed R738:d509f2657476: Remove all "using namespace std;" (authored by ahartmetz).
Remove all "using namespace std;"
Aug 22 2019, 11:51 AM
ahartmetz committed R738:6a9521f4ff3c: Complete and refine ConnectAddress (authored by ahartmetz).
Complete and refine ConnectAddress
Aug 22 2019, 11:51 AM
ahartmetz committed R738:96ad17ccf203: Remove some debug output (authored by ahartmetz).
Remove some debug output
Aug 22 2019, 11:51 AM
ahartmetz committed R738:b2a02eab1b85: Allow patching of serial on an already serialized Message (authored by ahartmetz).
Allow patching of serial on an already serialized Message
Aug 22 2019, 11:51 AM
ahartmetz committed R738:f965f3445f9e: LocalSocket: take null-terminator of socket path into account (authored by ahartmetz).
LocalSocket: take null-terminator of socket path into account
Aug 22 2019, 11:51 AM
ahartmetz committed R738:d2fe36179e1b: Adjust Message state handling to better fit what actually happens (authored by ahartmetz).
Adjust Message state handling to better fit what actually happens
Aug 22 2019, 11:51 AM

Apr 13 2019

ahartmetz requested review of D20518: Enable multi-tab-only shortcuts after restoring a multi-tab session from session management.
Apr 13 2019, 9:46 PM · Konsole

Oct 31 2018

ahartmetz accepted D16550: [ksmserver] Fix session restore check.

This fixes session restore for me.

Oct 31 2018, 5:11 PM · Plasma

Sep 27 2018

ahartmetz committed R119:cb52b2badb4c: Fix another auto QStringBuilder crash (access to destroyed temporary) (authored by ahartmetz).
Fix another auto QStringBuilder crash (access to destroyed temporary)
Sep 27 2018, 6:01 PM
ahartmetz committed R119:b39d9ede8deb: [Baloo KCM] Build fix. Missing opening brace. (authored by smithjd).
[Baloo KCM] Build fix. Missing opening brace.
Sep 27 2018, 6:01 PM
ahartmetz committed R119:226c914040ad: baloo kcm: Fix duplicate paths in config file. (authored by smithjd).
baloo kcm: Fix duplicate paths in config file.
Sep 27 2018, 6:01 PM

Sep 6 2018

ahartmetz committed R44:23dc89061a33: Add include that is missing when using QtWebEngine 5.12 (authored by ahartmetz).
Add include that is missing when using QtWebEngine 5.12
Sep 6 2018, 9:00 PM

Aug 30 2018

ahartmetz updated subscribers of D14922: Assert if trying to use a KCatalog without a QCoreApplication.

@kwin

Aug 30 2018, 10:27 AM · Frameworks
ahartmetz added a comment to D14922: Assert if trying to use a KCatalog without a QCoreApplication.

This change makes kwin_x11 crash on startup. Please fix kwin or degrade this to a warning.

Aug 30 2018, 9:47 AM · Frameworks

Aug 3 2018

ahartmetz committed R319:76b8b8d71d17: Don't pollute the environment inside Konsole with QT_NO_GLIB (authored by ahartmetz).
Don't pollute the environment inside Konsole with QT_NO_GLIB
Aug 3 2018, 11:22 AM
ahartmetz closed D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 3 2018, 11:22 AM · Konsole
ahartmetz added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

OK, I've tested it, the fix that this amends still works as well.

Aug 3 2018, 11:04 AM · Konsole

Aug 2 2018

ahartmetz added a comment to D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.

@sandsmark , it would be good to retest if your fix still works after this. IIRC QApplication does not lazily initialize the event loop though.

Aug 2 2018, 4:59 PM · Konsole
ahartmetz updated the test plan for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 2 2018, 1:26 PM · Konsole
ahartmetz added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: Konsole.
Aug 2 2018, 1:24 PM · Konsole
ahartmetz added a reviewer for D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB: hindenburg.
Aug 2 2018, 1:19 PM · Konsole
ahartmetz requested review of D14558: Don't pollute the environment inside Konsole with QT_NO_GLIB.
Aug 2 2018, 1:17 PM · Konsole

Jul 23 2018

ahartmetz committed R119:e99778b93f40: Revert last commit in two cases - don't compare two char pointers (authored by ahartmetz).
Revert last commit in two cases - don't compare two char pointers
Jul 23 2018, 10:46 AM

Jul 6 2018

ahartmetz committed R165:5d629ebb3087: Fix a crash due to access of temporary object (authored by ahartmetz).
Fix a crash due to access of temporary object
Jul 6 2018, 9:47 AM

Jun 8 2018

ahartmetz accepted D13435: Remove verbose debugging statement.

There are many more plain qDebug()s in this module, but this one seems to produce the most noise...

Jun 8 2018, 7:24 PM · Plasma

Mar 30 2018

ahartmetz committed R241:eb769901814f: Fix build with recent Qt5 versions (authored by ahartmetz).
Fix build with recent Qt5 versions
Mar 30 2018, 1:40 PM

Dec 18 2017

ahartmetz committed R738:e37362d59381: Small comment and formatting fixes (authored by ahartmetz).
Small comment and formatting fixes
Dec 18 2017, 3:40 PM
ahartmetz committed R738:97bbec6130c4: Change variable names to follow Transceiver -> Connection rename, #2 (authored by ahartmetz).
Change variable names to follow Transceiver -> Connection rename, #2
Dec 18 2017, 3:39 PM
ahartmetz committed R738:34888b52dbcb: Message: rearrange some getters and setters (authored by ahartmetz).
Message: rearrange some getters and setters
Dec 18 2017, 3:39 PM
ahartmetz committed R738:370ab799d5aa: Change variable names to follow Transceiver -> Connection rename (authored by ahartmetz).
Change variable names to follow Transceiver -> Connection rename
Dec 18 2017, 1:55 PM

Nov 27 2017

ahartmetz committed R165:8a7c66ec1d3d: Prevent index out of range in case of empty or malformed filename (authored by ahartmetz).
Prevent index out of range in case of empty or malformed filename
Nov 27 2017, 9:38 PM
ahartmetz closed D8968: Prevent index out of range in case of empty or malformed filename.
Nov 27 2017, 9:38 PM · KDE PIM
ahartmetz updated the diff for D8968: Prevent index out of range in case of empty or malformed filename.

Change base revision

Nov 27 2017, 9:36 PM · KDE PIM
ahartmetz updated the diff for D8968: Prevent index out of range in case of empty or malformed filename.

Change second index check to >0

Nov 27 2017, 9:24 PM · KDE PIM
ahartmetz committed R241:95d11df88d61: Don't repeat constant values in comments (authored by ahartmetz).
Don't repeat constant values in comments
Nov 27 2017, 9:01 PM

Nov 23 2017

ahartmetz added inline comments to D8968: Prevent index out of range in case of empty or malformed filename.
Nov 23 2017, 5:19 PM · KDE PIM
ahartmetz added reviewers for D8968: Prevent index out of range in case of empty or malformed filename: KDE PIM, dvratil.
Nov 23 2017, 2:57 PM · KDE PIM
ahartmetz added a comment to D8968: Prevent index out of range in case of empty or malformed filename.

Maybe it is better to return an empty string in this case but I don't know. Otherwise I might thave pushed this directly. In the case of my missing file, the returned string was the name of the folder <file_db_data>/00/, which generates an error message that the file it tried to open is actually a folder...

Nov 23 2017, 2:56 PM · KDE PIM
ahartmetz created D8968: Prevent index out of range in case of empty or malformed filename.
Nov 23 2017, 2:53 PM · KDE PIM

Nov 12 2017

ahartmetz committed R39:f0e3e3da5f94: Remove unused member variable (authored by ahartmetz).
Remove unused member variable
Nov 12 2017, 4:41 PM

Oct 17 2017

ahartmetz committed R738:7a2085ea90e6: Rename directory to "connection" in tests, too. (authored by ahartmetz).
Rename directory to "connection" in tests, too.
Oct 17 2017, 8:51 PM
ahartmetz committed R738:2fa72b2cf173: Complete the big Transceiver -> Connection rename (authored by ahartmetz).
Complete the big Transceiver -> Connection rename
Oct 17 2017, 1:13 PM
ahartmetz committed R738:8a8cf1a92c57: Rename everything with Connection to Transport (authored by ahartmetz).
Rename everything with Connection to Transport
Oct 17 2017, 1:13 PM
ahartmetz committed R738:b814d283b725: Rename AuthNegotiator -> AuthClient and move file to where it's used (authored by ahartmetz).
Rename AuthNegotiator -> AuthClient and move file to where it's used
Oct 17 2017, 1:13 PM
ahartmetz committed R738:d338d163b762: Remove unused auth related file (authored by ahartmetz).
Remove unused auth related file
Oct 17 2017, 1:13 PM
ahartmetz committed R738:65979b37f3de: Rename ConnectionInfo -> ConnectAddress (authored by ahartmetz).
Rename ConnectionInfo -> ConnectAddress
Oct 17 2017, 1:13 PM
ahartmetz committed R738:cec551209edf: Remove unused friend declaration (authored by ahartmetz).
Remove unused friend declaration
Oct 17 2017, 1:13 PM
ahartmetz committed R738:dae1b72a0aa9: Add provision for exclusively using event loop integration... (authored by ahartmetz).
Add provision for exclusively using event loop integration...
Oct 17 2017, 1:13 PM
ahartmetz committed R738:10bb7922daee: Unify names of "event handler style" virtual methods. (authored by ahartmetz).
Unify names of "event handler style" virtual methods.
Oct 17 2017, 1:13 PM