Don't pollute the environment inside Konsole with QT_NO_GLIB
ClosedPublic

Authored by ahartmetz on Thu, Aug 2, 1:17 PM.

Details

Summary

Fixes a regression from ac59cc7e007a3ef73a07.
LibreOffice Writer, for example, will hang during startup when
QT_NO_GLIB is set. It uses GLib and has KDE integration.

Test Plan

In a shell, set QT_NO_GLIB to a string, or an empty string, or
unset it. Run konsole from that shell, check that QT_NO_GLIB in
the new shell inside konsole has the same value as in the
launching shell.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahartmetz created this revision.Thu, Aug 2, 1:17 PM
Restricted Application added a project: Konsole. · View Herald TranscriptThu, Aug 2, 1:17 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ahartmetz requested review of this revision.Thu, Aug 2, 1:17 PM
ahartmetz edited the test plan for this revision. (Show Details)Thu, Aug 2, 1:24 PM
ahartmetz added a reviewer: Konsole.
ahartmetz edited the test plan for this revision. (Show Details)

@sandsmark , it would be good to retest if your fix still works after this. IIRC QApplication does not lazily initialize the event loop though.

dfaure accepted this revision.Thu, Aug 2, 6:05 PM
dfaure added a subscriber: dfaure.

Ah, I was really wondering what I did wrong to suddenly get QT_NO_GLIB... (I normally only set it when using helgrind or thread-sanitizer....). Thanks for the fix!

This revision is now accepted and ready to land.Thu, Aug 2, 6:05 PM

OK, I've tested it, the fix that this amends still works as well.

This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Fri, Aug 3, 1:52 PM

Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.

Thanks for the fix! BTW for future reference, the preferred workflow for bugfixes is to commit to the stable branch (Applications/18.08` in this case) and then merge to master, rather than cherry-picking to the stable branch after first landing on master.

For Konsole, I've always done the reverse - I'd rather the stable branches were actually stable, so test in master first.

I meant just as a merging strategy. This patch landed in both branches, after all--not just master.

dfaure added a comment.Sat, Aug 4, 8:48 AM

Ah, that's because I backported it (from master, using cherry-pick), I thought it was just a mistake that it didn't land in the stable branch.