Feed Advanced Search

Mar 21 2018

heikobecker added a comment to D11560: Don't install (empty) icon dirs for python plugins.

Distro packaging systems may disallow empty dirs and it seems the icons are bundled in resource files already. Not entirely sure this is the right thing to do though.

Mar 21 2018, 7:16 PM
heikobecker requested review of D11560: Don't install (empty) icon dirs for python plugins.
Mar 21 2018, 7:12 PM
heikobecker added a comment to T8163: Please add dependencies for amarok.
> In regards to FreeBSD, is it possible to get MySQL Embedded made available @adridg?

mysql56-server is now installed (on all but vm1, as that one has a runing pkg process).

Mar 21 2018, 8:00 AM · build.kde.org, Windows, FreeBSD
heikobecker added a comment to T8163: Please add dependencies for amarok.

For Linux it looks like you have a build regression which needs to be fixed.

Additionally it cannot seem to find MySQL properly, even though it is definitely there (Akonadi and Qt use it) so that needs checking as well.

Mar 21 2018, 7:59 AM · build.kde.org, Windows, FreeBSD

Mar 20 2018

heikobecker committed R364:aa05cf19f297: Increase version for next Applications release (authored by heikobecker).
Increase version for next Applications release
Mar 20 2018, 10:04 PM
heikobecker committed R181:7ed12eacf370: FindMySQL: Only use mysql_config's output if there's no error (authored by heikobecker).
FindMySQL: Only use mysql_config's output if there's no error
Mar 20 2018, 6:22 PM
heikobecker committed R181:2ed5151687b4: Declare constructors with one parameter explicit (authored by heikobecker).
Declare constructors with one parameter explicit
Mar 20 2018, 6:22 PM
heikobecker committed R181:7371bc579fdf: Use Q_ENUM instead of Q_ENUMS (authored by heikobecker).
Use Q_ENUM instead of Q_ENUMS
Mar 20 2018, 6:22 PM
heikobecker committed R181:b34c5189d73f: Use QChar when adding single characters to QString (authored by heikobecker).
Use QChar when adding single characters to QString
Mar 20 2018, 6:22 PM
heikobecker committed R181:33512b4a2b9f: README: KDE is the community (authored by heikobecker).
README: KDE is the community
Mar 20 2018, 6:22 PM
heikobecker committed R181:b47fbe3522b0: INSTALL: Update link, use https (authored by heikobecker).
INSTALL: Update link, use https
Mar 20 2018, 6:22 PM
heikobecker committed R856:5846f3bfed56: Install firefox's native messaging host to LIBDIR (authored by heikobecker).
Install firefox's native messaging host to LIBDIR
Mar 20 2018, 2:48 PM
heikobecker closed D11498: Install firefox's native messaging host to LIBDIR.
Mar 20 2018, 2:47 PM · Plasma

Mar 19 2018

heikobecker requested review of D11498: Install firefox's native messaging host to LIBDIR.
Mar 19 2018, 6:15 PM · Plasma

Mar 18 2018

heikobecker added a comment to D11349: Reactivate wikipedia applet.

The method is only available since kpackage-5.42.0.

Mar 18 2018, 7:19 PM · Amarok

Mar 17 2018

heikobecker committed R181:19651220e50d: README: Update dependencies (authored by heikobecker).
README: Update dependencies
Mar 17 2018, 8:30 AM

Mar 16 2018

heikobecker requested review of D11394: Also add libmysqld-devel for Amarok to the SUSE Qt 5.9 image.
Mar 16 2018, 7:05 PM

Mar 15 2018

heikobecker committed R181:b8934ac4b9f2: Rewrite FindMtp in a more modern way (authored by heikobecker).
Rewrite FindMtp in a more modern way
Mar 15 2018, 7:21 PM
heikobecker committed R181:1aac4989f2c0: Import FindMySQL from kdb (authored by heikobecker).
Import FindMySQL from kdb
Mar 15 2018, 7:21 PM
heikobecker committed R181:5378b98d98d2: Don't duplicate work of KAboutData::setupCommandLine() (authored by heikobecker).
Don't duplicate work of KAboutData::setupCommandLine()
Mar 15 2018, 7:21 PM

Mar 14 2018

heikobecker committed R181:4700309ebb0b: Use libmygpo-qt's imported target (authored by heikobecker).
Use libmygpo-qt's imported target
Mar 14 2018, 11:38 PM
heikobecker committed R181:88fcebd529a4: Don't include <QtModule/QtClas> or <QtModule> (authored by heikobecker).
Don't include <QtModule/QtClas> or <QtModule>
Mar 14 2018, 6:45 PM

Mar 12 2018

heikobecker committed R181:17be8e8364f6: Use Q_OBJECT macro for classes inheriting QObject (authored by heikobecker).
Use Q_OBJECT macro for classes inheriting QObject
Mar 12 2018, 8:55 PM
heikobecker added a comment to D11230: Also add gtest for Amarok to the SUSE Qt 5.9 image.

If it won't let you, please let me know.

Mar 12 2018, 6:02 AM

Mar 11 2018

heikobecker committed R181:21e9356387e9: Another QUrl fix (authored by malteveerman).
Another QUrl fix
Mar 11 2018, 9:35 PM
heikobecker closed D11169: Another QUrl fix.
Mar 11 2018, 9:35 PM · Amarok
heikobecker committed R181:3a6e4c370d8c: Don't include <QtModule/QtClass> (authored by heikobecker).
Don't include <QtModule/QtClass>
Mar 11 2018, 9:35 PM
heikobecker committed R181:e875fad03bd8: Remove deprecated Encoding=UTF-8 from desktop files (authored by heikobecker).
Remove deprecated Encoding=UTF-8 from desktop files
Mar 11 2018, 9:35 PM
heikobecker committed R181:1c32b6649960: Remove old Qt version check (authored by heikobecker).
Remove old Qt version check
Mar 11 2018, 9:35 PM
heikobecker accepted D11169: Another QUrl fix.
Mar 11 2018, 9:34 PM · Amarok
heikobecker closed D11248: Use QTEST_GUILESS_MAIN.
Mar 11 2018, 9:10 PM · KProperty
heikobecker committed R13:d3c8db5741b9: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Mar 11 2018, 9:00 PM
heikobecker accepted D11239: Fix build with Qt 5.11.
Mar 11 2018, 8:10 PM · Amarok
heikobecker requested review of D11248: Use QTEST_GUILESS_MAIN.
Mar 11 2018, 8:08 PM · KProperty
heikobecker committed R181:c07d789f5736: Fix typo in previous commit (authored by heikobecker).
Fix typo in previous commit
Mar 11 2018, 3:36 PM
heikobecker committed R181:aa26454b189a: Link the mysqlecollection to OpenSSL on FreeBSD (authored by heikobecker).
Link the mysqlecollection to OpenSSL on FreeBSD
Mar 11 2018, 3:27 PM
heikobecker committed R181:cc63240a9991: Use non-deprecated variables from KDEInstallDirs (authored by heikobecker).
Use non-deprecated variables from KDEInstallDirs
Mar 11 2018, 3:27 PM
heikobecker added a reviewer for D11230: Also add gtest for Amarok to the SUSE Qt 5.9 image: Sysadmin.
Mar 11 2018, 2:26 PM
heikobecker requested review of D11230: Also add gtest for Amarok to the SUSE Qt 5.9 image.
Mar 11 2018, 12:44 PM

Mar 9 2018

heikobecker committed R181:13354e579e77: FindGooglemock: Add PATH_SUFFIX to find it on openSUSE (authored by heikobecker).
FindGooglemock: Add PATH_SUFFIX to find it on openSUSE
Mar 9 2018, 5:34 PM
heikobecker committed R181:f926db536113: Drop KDE4_foo variables and paths (authored by heikobecker).
Drop KDE4_foo variables and paths
Mar 9 2018, 4:56 PM
heikobecker committed R181:949b64bae56e: Remove PHONON_INCLUDES (authored by heikobecker).
Remove PHONON_INCLUDES
Mar 9 2018, 4:56 PM
heikobecker committed R181:01be34c77b50: Remove unused cmake modules (authored by heikobecker).
Remove unused cmake modules
Mar 9 2018, 4:56 PM
heikobecker committed R181:caf9d135f33d: Use an imported target for the thread library (authored by heikobecker).
Use an imported target for the thread library
Mar 9 2018, 4:56 PM
heikobecker added a comment to D11170: Use new kpackage_install_bundled_package macro.

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Mar 9 2018, 4:52 PM

Mar 8 2018

heikobecker committed R181:f36d863b7d6f: Add a FindFFTW.cmake (authored by heikobecker).
Add a FindFFTW.cmake
Mar 8 2018, 10:30 PM
heikobecker added a reverting change for R181:8bbedb7724dd: Temporarily check for taglib last: R181:1df624bff881: Revert "Temporarily check for taglib last".
Mar 8 2018, 10:30 PM
heikobecker committed R181:1df624bff881: Revert "Temporarily check for taglib last" (authored by heikobecker).
Revert "Temporarily check for taglib last"
Mar 8 2018, 10:30 PM
heikobecker added a comment to T8163: Please add dependencies for amarok.

Moved the taglib check to the end, although it still doesn't go through completely I can tell a bit more:

Mar 8 2018, 8:14 PM · build.kde.org, Windows, FreeBSD
heikobecker committed R181:8bbedb7724dd: Temporarily check for taglib last (authored by heikobecker).
Temporarily check for taglib last
Mar 8 2018, 7:45 PM
heikobecker created T8163: Please add dependencies for amarok.
Mar 8 2018, 9:47 AM · build.kde.org, Windows, FreeBSD

Mar 7 2018

heikobecker committed R247:68f339a1d473: There's no unstable kdelibs4 based branch for amarok anymore (authored by heikobecker).
There's no unstable kdelibs4 based branch for amarok anymore
Mar 7 2018, 11:29 PM
heikobecker committed R247:92003ed50eed: Update branches for amarok (authored by heikobecker).
Update branches for amarok
Mar 7 2018, 11:29 PM
heikobecker committed R499:82b1f067a6e3: Add amarok (authored by heikobecker).
Add amarok
Mar 7 2018, 11:01 PM
heikobecker committed R181:f047cd8219d9: Fix build with gcc6 (authored by heikobecker).
Fix build with gcc6
Mar 7 2018, 10:28 PM
heikobecker committed R181:187a39906784: Merge remote-tracking branch 'origin/kf5' (authored by heikobecker).
Merge remote-tracking branch 'origin/kf5'
Mar 7 2018, 10:19 PM
heikobecker committed R152:628aed667341: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Mar 7 2018, 5:45 PM
heikobecker committed R149:514ed1dd9ef8: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Mar 7 2018, 5:41 PM

Mar 6 2018

heikobecker closed T2698: Tests for KF5 version as Resolved.

Fixed with df9fc58c8ac5ea2c8ed64f8d15ee87bab1af6681

Mar 6 2018, 10:15 PM · Amarok
heikobecker committed R572:26dc0de2251c: amarok2.rb: Use require_relative (authored by heikobecker).
amarok2.rb: Use require_relative
Mar 6 2018, 9:51 PM
heikobecker committed R181:a452887991a9: RELEASE_HOWTO: Update it a bit (authored by heikobecker).
RELEASE_HOWTO: Update it a bit
Mar 6 2018, 9:37 PM
heikobecker committed R181:387531d3645e: Bump plugin version (authored by heikobecker).
Bump plugin version
Mar 6 2018, 9:37 PM
heikobecker committed R181:1ffd9fdd9af1: Bump version to 2.9.0 (authored by heikobecker).
Bump version to 2.9.0
Mar 6 2018, 9:37 PM

Mar 5 2018

heikobecker committed R181:e69d524ac66f: Use QTEST_GUILESS_MAIN where possible (authored by heikobecker).
Use QTEST_GUILESS_MAIN where possible
Mar 5 2018, 10:26 PM

Mar 4 2018

heikobecker added a comment to T8119: fix crash when some external APIs fail.

Does the services still work for you? The site seems pretty disfunctional, at least if you need to register as a new user first, which makes it impossible for me to test your patch.

Mar 4 2018, 7:11 PM · Amarok
heikobecker committed R181:8d092eb902de: Import FindFFmpeg from kfilemetadata (authored by heikobecker).
Import FindFFmpeg from kfilemetadata
Mar 4 2018, 3:17 PM
heikobecker committed R181:5f00aa49959f: Use Q_FALLTHROUGH to fix the build with gcc-6 (authored by heikobecker).
Use Q_FALLTHROUGH to fix the build with gcc-6
Mar 4 2018, 3:17 PM

Mar 1 2018

heikobecker added a watcher for Amarok: heikobecker.
Mar 1 2018, 9:48 AM

Feb 28 2018

heikobecker added a comment to D10923: Make Webkit optional.

Is this patch meant for master? Because the branch is "webkit-optional".

Feb 28 2018, 6:25 PM · Amarok
heikobecker requested review of D10924: Disable Discogs and Google cover search temporarily.
Feb 28 2018, 6:20 PM · Amarok
heikobecker requested review of D10923: Make Webkit optional.
Feb 28 2018, 6:17 PM · Amarok
heikobecker committed R181:00c931152589: Fix some typos (authored by heikobecker).
Fix some typos
Feb 28 2018, 6:13 PM

Feb 25 2018

heikobecker committed R105:1797938df560: Remove manual call to cmake_policy(SET CMP0063 NEW) (authored by heikobecker).
Remove manual call to cmake_policy(SET CMP0063 NEW)
Feb 25 2018, 10:22 AM
heikobecker committed R105:f9064eef946b: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.12'
Feb 25 2018, 10:22 AM
heikobecker committed R105:94dd449aa185: Silence CMake policy CMP0063 warning (authored by heikobecker).
Silence CMake policy CMP0063 warning
Feb 25 2018, 10:19 AM

Feb 24 2018

heikobecker committed R181:0b3fb2bef326: Fix detection of Qt's glib event loop (authored by heikobecker).
Fix detection of Qt's glib event loop
Feb 24 2018, 4:35 PM
heikobecker committed R181:8964b59b2805: CMakeLists.txt: Simplify (authored by heikobecker).
CMakeLists.txt: Simplify
Feb 24 2018, 4:35 PM
heikobecker committed R181:d33e1f853f5b: Move FindX11 to top-level CMakeLists.txt (authored by heikobecker).
Move FindX11 to top-level CMakeLists.txt
Feb 24 2018, 4:35 PM
heikobecker committed R181:68af1b6ba9a9: cmake_minimum_required should be at the top of CMakeLists.txt (authored by heikobecker).
cmake_minimum_required should be at the top of CMakeLists.txt
Feb 24 2018, 4:35 PM
heikobecker committed R181:b36ec71f8e0f: Silence cmake policy warning CMP0063 more elegantly (authored by heikobecker).
Silence cmake policy warning CMP0063 more elegantly
Feb 24 2018, 4:35 PM

Feb 21 2018

heikobecker added a comment to D10708: New context area.

Analyzer should work as well, if you are using the gstreamer phonon backend. Vlc backend doesn't work unfortunately.

Feb 21 2018, 10:03 PM · Amarok
heikobecker added a comment to D10708: New context area.

FWIW: It builds and Albums, Current Track and Lyrics work.

Feb 21 2018, 9:54 PM · Amarok
heikobecker committed R181:24eb247789a2: Merge remote-tracking branch 'origin/master' into kf5 (authored by heikobecker).
Merge remote-tracking branch 'origin/master' into kf5
Feb 21 2018, 8:22 PM
heikobecker committed R181:49c6c31638d3: add .arcconfig (authored by kpiwowarski).
add .arcconfig
Feb 21 2018, 8:07 PM
heikobecker closed D10699: add .arcconfig.
Feb 21 2018, 8:07 PM · Amarok
heikobecker accepted D10699: add .arcconfig.

This can even go to master.

Feb 21 2018, 8:07 PM · Amarok

Feb 19 2018

heikobecker committed R306:7387d21c4516: Clean up old, unreachable code (authored by heikobecker).
Clean up old, unreachable code
Feb 19 2018, 1:29 PM
heikobecker closed D10340: Clean up old, unreachable code.
Feb 19 2018, 1:29 PM · Frameworks

Feb 17 2018

heikobecker committed R364:6760a6b4af35: Merge remote-tracking branch 'origin/Applications/17.12' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/17.12'
Feb 17 2018, 7:09 PM
heikobecker committed R364:9c9586579f6f: Adjust to "new" version of the thumbnail standard (authored by heikobecker).
Adjust to "new" version of the thumbnail standard
Feb 17 2018, 7:01 PM

Feb 16 2018

heikobecker added a comment to D10526: Port core application away from kdelibs4.

fwitw I've build-tested the patch and it builds and starts up fine.

Feb 16 2018, 3:45 PM · Amarok
heikobecker committed R878:cf64323795b9: Search runtime dependencies on QML modules (authored by heikobecker).
Search runtime dependencies on QML modules
Feb 16 2018, 3:41 PM
heikobecker closed D10579: Search runtime dependencies on QML modules.
Feb 16 2018, 3:41 PM · Plasma
heikobecker updated the diff for D10579: Search runtime dependencies on QML modules.

Also updated README

Feb 16 2018, 3:39 PM · Plasma
heikobecker committed R878:15dc67016117: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Feb 16 2018, 3:35 PM
heikobecker closed D10580: Add .arcconfig.
Feb 16 2018, 3:35 PM · Plasma
heikobecker requested review of D10580: Add .arcconfig.
Feb 16 2018, 1:25 PM · Plasma
heikobecker requested review of D10579: Search runtime dependencies on QML modules.
Feb 16 2018, 1:23 PM · Plasma

Feb 13 2018

heikobecker committed R261:294433abf85c: Fix build with QtWebEngine (authored by heikobecker).
Fix build with QtWebEngine
Feb 13 2018, 2:01 PM
heikobecker closed D10479: Fix build with QtWebEngine.
Feb 13 2018, 2:01 PM