Feed Advanced Search

Thu, Oct 3

heikobecker accepted D24381: Register Play/Pause as global shortcut again.
Thu, Oct 3, 6:58 PM
heikobecker accepted D24135: Fix missing directory separators when saving podcasts to disk.

Do you have commit access or should I push this for you?

Thu, Oct 3, 6:58 PM

Tue, Sep 24

heikobecker accepted D24103: CMake: Bump CMake minimum version to 3.5.

I don't think so and Frameworks also need 3.5 since quite some time.

Tue, Sep 24, 6:43 AM · KDE Telepathy

Thu, Sep 19

heikobecker committed R119:3569d0df1207: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.17'
Thu, Sep 19, 10:25 PM
heikobecker committed R119:3a27e8ceb53e: Remove unnecessary KF5People dependency (authored by heikobecker).
Remove unnecessary KF5People dependency
Thu, Sep 19, 10:24 PM
heikobecker closed D24098: Remove unnecessary KF5People dependency.
Thu, Sep 19, 10:24 PM · Plasma
heikobecker committed R99:3ac6c4b90d6c: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by heikobecker).
Merge remote-tracking branch 'origin/Plasma/5.17'
Thu, Sep 19, 10:19 PM
heikobecker closed D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Thu, Sep 19, 10:19 PM · Plasma
heikobecker committed R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists (authored by heikobecker).
Create an empty config (.e.g ~/.gtkrc-2.0) if none exists
Thu, Sep 19, 10:19 PM
heikobecker requested review of D24098: Remove unnecessary KF5People dependency.
Thu, Sep 19, 8:15 PM · Plasma
heikobecker added a reverting change for R120:273969f07df7: Fix version for Plasma/5.17: R120:bd8dda6522db: Revert "Fix version for Plasma/5.17".
Thu, Sep 19, 7:49 PM
heikobecker committed R120:bd8dda6522db: Revert "Fix version for Plasma/5.17" (authored by heikobecker).
Revert "Fix version for Plasma/5.17"
Thu, Sep 19, 7:49 PM
heikobecker committed R120:273969f07df7: Fix version for Plasma/5.17 (authored by heikobecker).
Fix version for Plasma/5.17
Thu, Sep 19, 7:45 PM
heikobecker committed R119:240d9c4751e8: Remove duplicate find_package call for LibNotificationManager (authored by heikobecker).
Remove duplicate find_package call for LibNotificationManager
Thu, Sep 19, 7:34 PM
heikobecker updated the diff for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.

Used the ReadWrite flag to simplify

Thu, Sep 19, 6:20 PM · Plasma
heikobecker accepted D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Thu, Sep 19, 5:57 PM · KDE Telepathy
heikobecker added inline comments to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Thu, Sep 19, 5:02 PM · KDE Telepathy
heikobecker accepted D24040: Don't delete whole folder when deleting a track.

All those regressions from f1ab8128fdd6b2360bfea8b0bef9b5c46b8d5e68 :(

Thu, Sep 19, 4:51 PM
heikobecker added a reviewer for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists: gikari.
Thu, Sep 19, 3:24 PM · Plasma
heikobecker updated the test plan for D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Thu, Sep 19, 3:23 PM · Plasma
heikobecker requested review of D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists.
Thu, Sep 19, 3:22 PM · Plasma
heikobecker added a comment to D21524: Keep existing configurations' strings               .

This breaks the unit test locally as well as on build.kde.org, eg.: https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/51/console and https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/5/console

Thu, Sep 19, 12:39 PM · Plasma
heikobecker added inline comments to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Thu, Sep 19, 6:18 AM · KDE Telepathy
heikobecker added a comment to D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

I don't know much about python, but it works fine with python3 where it previously didn't. +1

Thu, Sep 19, 6:16 AM · KDE Telepathy
heikobecker accepted D24067: CMake: Remove own FindLibXml2.
Thu, Sep 19, 6:14 AM · KDE Telepathy

Sep 18 2019

heikobecker committed R499:5572810f121a: Don't depend on frameworks which are part of kf5umbrella (authored by heikobecker).
Don't depend on frameworks which are part of kf5umbrella
Sep 18 2019, 1:38 PM
heikobecker committed R499:f750496f72ac: kf5umbrella: Add new frameworks (authored by heikobecker).
kf5umbrella: Add new frameworks
Sep 18 2019, 1:38 PM
heikobecker committed R499:e0cf42009a17: kf5umbrella: Sort (authored by heikobecker).
kf5umbrella: Sort
Sep 18 2019, 1:38 PM

Sep 16 2019

heikobecker closed D23910: startplasma: Respect KDEWM again.
Sep 16 2019, 5:13 AM · Plasma
heikobecker committed R120:0fcd29399b9d: startplasma: Respect KDEWM again (authored by heikobecker).
startplasma: Respect KDEWM again
Sep 16 2019, 5:13 AM

Sep 12 2019

heikobecker requested review of D23910: startplasma: Respect KDEWM again.
Sep 12 2019, 4:15 PM · Plasma
heikobecker added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

Happy to help, but I don't understand yet.

kde-cli-tools doesn't use sessionmanagementbackend.h?

The only user is inside plasma-workspace source.

Sep 12 2019, 11:32 AM · Plasma
heikobecker committed R871:0f346886dc48: Use QTEST_GUILESS_MAIN for systeminformationtest (authored by heikobecker).
Use QTEST_GUILESS_MAIN for systeminformationtest
Sep 12 2019, 7:09 AM
heikobecker closed D23878: Use QTEST_GUILESS_MAIN for systeminformationtest.
Sep 12 2019, 7:09 AM · Plasma
heikobecker added a comment to D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.

Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot easily split plasma-workspace into multiple packages (actually we could, kind of, but the user would still need to build p-w and all of its dependencies). Thus we have some patches to build libkworkspace separately. Given that I could add this one too, if it's inappropriate that it'll get merged.

Sep 12 2019, 7:08 AM · Plasma

Sep 11 2019

heikobecker committed R123:5ae59b645334: Also remove the dependency on libxcb (authored by heikobecker).
Also remove the dependency on libxcb
Sep 11 2019, 5:43 PM
heikobecker added a reviewer for D23883: libkworkspace: Install sessionmanagementbackend.h with other headers: Plasma.
Sep 11 2019, 5:27 PM · Plasma
heikobecker requested review of D23883: libkworkspace: Install sessionmanagementbackend.h with other headers.
Sep 11 2019, 5:26 PM · Plasma
heikobecker committed R123:b6d6897bad6f: Remove unneeded dependencies on X11 and QtX11Extras (authored by heikobecker).
Remove unneeded dependencies on X11 and QtX11Extras
Sep 11 2019, 5:19 PM
heikobecker closed D23877: Remove unneeded dependencies on X11 and QtX11Extras.
Sep 11 2019, 5:19 PM · Plasma
heikobecker requested review of D23878: Use QTEST_GUILESS_MAIN for systeminformationtest.
Sep 11 2019, 3:50 PM · Plasma
heikobecker added a reviewer for D23877: Remove unneeded dependencies on X11 and QtX11Extras: Plasma.
Sep 11 2019, 3:39 PM · Plasma
heikobecker requested review of D23877: Remove unneeded dependencies on X11 and QtX11Extras.
Sep 11 2019, 3:39 PM · Plasma

Sep 2 2019

heikobecker committed R758:b72136689602: Don't enable plugins with no chance to disable them (authored by heikobecker).
Don't enable plugins with no chance to disable them
Sep 2 2019, 6:05 AM
heikobecker committed R758:de6fafe84498: exiv2plugin: Catch by reference (authored by heikobecker).
exiv2plugin: Catch by reference
Sep 2 2019, 6:05 AM
heikobecker committed R758:1f70606c98c4: Remove the handbook entry (authored by heikobecker).
Remove the handbook entry
Sep 2 2019, 6:05 AM

Aug 27 2019

heikobecker committed R563:e5c517317b02: Bump version for release (authored by heikobecker).
Bump version for release
Aug 27 2019, 3:45 PM
heikobecker committed R563:268a2cbfcf6f: Don't set version numbers as INT cache entries (authored by heikobecker).
Don't set version numbers as INT cache entries
Aug 27 2019, 3:45 PM
heikobecker committed R563:7f710a28fb74: Move cmake_minimum_required to the top of CMakeLists.txt (authored by heikobecker).
Move cmake_minimum_required to the top of CMakeLists.txt
Aug 27 2019, 3:45 PM
heikobecker committed R563:fda675bc7090: Remove support for Qt4 (authored by heikobecker).
Remove support for Qt4
Aug 27 2019, 3:45 PM

Aug 23 2019

heikobecker accepted D23326: Fix a crash when running 'amarok -l /path/to/file'.
Aug 23 2019, 6:27 PM

Aug 16 2019

heikobecker committed R456:bbb9c9f24f6e: Merge remote-tracking branch 'origin/Applications/19.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.08'
Aug 16 2019, 11:26 AM
heikobecker committed R456:43cc0d25c4fa: Use QTEST_GUILESS_MAIN for tests (authored by heikobecker).
Use QTEST_GUILESS_MAIN for tests
Aug 16 2019, 11:18 AM
heikobecker closed D23187: Use QTEST_GUILESS_MAIN for tests.
Aug 16 2019, 11:18 AM
heikobecker committed R340:9b2f84dfec45: Merge remote-tracking branch 'origin/Applications/19.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.08'
Aug 16 2019, 7:57 AM
heikobecker committed R340:ed92bda9af6a: Use QTEST_GUILESS_MAIN for testentry test (authored by heikobecker).
Use QTEST_GUILESS_MAIN for testentry test
Aug 16 2019, 7:47 AM
heikobecker closed D23186: Use QTEST_GUILESS_MAIN for testentry test.
Aug 16 2019, 7:47 AM · KDE Edu

Aug 15 2019

heikobecker added a reviewer for D23187: Use QTEST_GUILESS_MAIN for tests: sdepiets.
Aug 15 2019, 3:42 PM
heikobecker requested review of D23187: Use QTEST_GUILESS_MAIN for tests.
Aug 15 2019, 3:41 PM
heikobecker requested review of D23186: Use QTEST_GUILESS_MAIN for testentry test.
Aug 15 2019, 3:39 PM · KDE Edu

Aug 1 2019

heikobecker committed R224:5d7983f52df8: testsmshelper: Use QTEST_GUILESS_MAIN (authored by heikobecker).
testsmshelper: Use QTEST_GUILESS_MAIN
Aug 1 2019, 9:16 PM

Jul 24 2019

heikobecker committed R166:cdfc8fc2b26c: Merge remote-tracking branch 'origin/Applications/19.08' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.08'
Jul 24 2019, 11:53 AM
heikobecker committed R166:9a4327abd1f6: Use QTEST_GUILESS_MAIN (authored by heikobecker).
Use QTEST_GUILESS_MAIN
Jul 24 2019, 11:51 AM
heikobecker closed D22696: Use QTEST_GUILESS_MAIN.
Jul 24 2019, 11:51 AM · Spectacle

Jul 23 2019

heikobecker requested review of D22696: Use QTEST_GUILESS_MAIN.
Jul 23 2019, 6:07 PM · Spectacle

Jun 22 2019

heikobecker committed R368:6a4517c31fda: Add .arcconfig (authored by heikobecker).
Add .arcconfig
Jun 22 2019, 3:35 PM
heikobecker committed R368:80f22fe6825a: Add DesktopEntry to notifyrc (authored by heikobecker).
Add DesktopEntry to notifyrc
Jun 22 2019, 12:32 PM
heikobecker closed D21994: Add DesktopEntry to notifyrc.
Jun 22 2019, 12:32 PM
heikobecker requested review of D21994: Add DesktopEntry to notifyrc.
Jun 22 2019, 12:09 PM

Jun 20 2019

heikobecker committed R234:9c0537a6b658: Add a screenshot of audex (authored by heikobecker).
Add a screenshot of audex
Jun 20 2019, 4:56 PM
heikobecker committed R493:9dd5480ce493: Add basic appdata file (authored by heikobecker).
Add basic appdata file
Jun 20 2019, 4:14 PM
heikobecker accepted D21917: Ship the ui.rc file inside a resource.

Thanks!

Jun 20 2019, 4:02 PM
heikobecker requested changes to D21917: Ship the ui.rc file inside a resource.

Looks like a missing "git add audex.qrc" ;-)

Jun 20 2019, 12:20 PM

Jun 9 2019

heikobecker added a comment to D21695: Add FindTaglib.cmake.

I'm not entirely sure about taglib-config on Windows and Android (can't test there), but similar to pkg-config I omitted the special casing. Tried to test this by moving taglib-config out of the way on Linux and a taglib install in default locations, which worked fine.

Jun 9 2019, 3:40 PM · Build System, Frameworks
heikobecker requested review of D21695: Add FindTaglib.cmake.
Jun 9 2019, 3:34 PM · Build System, Frameworks

May 25 2019

heikobecker committed R493:ffa5d6321d1a: Fully qualify signal argument (authored by heikobecker).
Fully qualify signal argument
May 25 2019, 8:56 AM
heikobecker committed R493:e5474935d950: Avoid detaching temporary containers (authored by heikobecker).
Avoid detaching temporary containers
May 25 2019, 8:56 AM
heikobecker committed R493:a7d258942344: Don't include <QtModule/QHeader> (authored by heikobecker).
Don't include <QtModule/QHeader>
May 25 2019, 8:56 AM
heikobecker committed R493:8e2849f5f357: Move const to proper place (authored by heikobecker).
Move const to proper place
May 25 2019, 8:56 AM
heikobecker committed R493:77838d8f13c5: Make constructors which can be called with 1 argument explicit (authored by heikobecker).
Make constructors which can be called with 1 argument explicit
May 25 2019, 8:56 AM
heikobecker committed R493:116af2010321: Use single quotes for single chars (authored by heikobecker).
Use single quotes for single chars
May 25 2019, 8:56 AM

May 22 2019

heikobecker committed R493:8cfcfb9001c3: Use Q_OBJECT for QObject derived classes (authored by heikobecker).
Use Q_OBJECT for QObject derived classes
May 22 2019, 8:43 PM
heikobecker committed R493:9b54ebb78472: Use QLatin1String with startsWith/endWiths (authored by heikobecker).
Use QLatin1String with startsWith/endWiths
May 22 2019, 8:43 PM
heikobecker committed R493:32294409b177: Make comparison operator const (authored by heikobecker).
Make comparison operator const
May 22 2019, 8:43 PM
heikobecker committed R493:92c0c7b07a58: Use QString::clear() instead of assigning QString::null (authored by heikobecker).
Use QString::clear() instead of assigning QString::null
May 22 2019, 8:43 PM
heikobecker committed R493:6deb14bd3d5d: Use QString::remove instead of replace (authored by heikobecker).
Use QString::remove instead of replace
May 22 2019, 8:43 PM
heikobecker committed R493:ef65d19b17a6: Fix includes (authored by heikobecker).
Fix includes
May 22 2019, 8:43 PM
heikobecker committed R493:febf7e238d98: Use single quotes for single chars (authored by heikobecker).
Use single quotes for single chars
May 22 2019, 8:43 PM

May 11 2019

heikobecker committed R404:704e91530bef: Drop unused kmines.notifyrc (authored by heikobecker).
Drop unused kmines.notifyrc
May 11 2019, 10:22 AM
heikobecker closed D21130: Drop unused kmines.notifyrc.
May 11 2019, 10:22 AM

May 10 2019

heikobecker committed R404:1622b734ca20: Add .arcconfig (authored by heikobecker).
Add .arcconfig
May 10 2019, 8:58 PM
heikobecker requested review of D21130: Drop unused kmines.notifyrc.
May 10 2019, 2:54 PM
heikobecker closed D21129: Require KF5 5.58.0 like the rest of Plasma.
May 10 2019, 2:37 PM · Plasma
heikobecker committed R114:2a2e73781481: Require KF5 5.58.0 like the rest of Plasma (authored by heikobecker).
Require KF5 5.58.0 like the rest of Plasma
May 10 2019, 2:37 PM
heikobecker requested review of D21129: Require KF5 5.58.0 like the rest of Plasma.
May 10 2019, 2:33 PM · Plasma
heikobecker committed R201:8accd831a5ab: Merge remote-tracking branch 'origin/Applications/19.04' (authored by heikobecker).
Merge remote-tracking branch 'origin/Applications/19.04'
May 10 2019, 11:44 AM
heikobecker committed R201:34d4b059cd09: Add DesktopEntry to notifyrc (authored by heikobecker).
Add DesktopEntry to notifyrc
May 10 2019, 11:44 AM
heikobecker closed D21117: Add DesktopEntry to notifyrc.
May 10 2019, 11:44 AM · KDE PIM
heikobecker requested review of D21117: Add DesktopEntry to notifyrc.
May 10 2019, 10:21 AM · KDE PIM
heikobecker committed R181:fc370bbebf79: Set urgency to Low for track changes (authored by heikobecker).
Set urgency to Low for track changes
May 10 2019, 10:16 AM