Feed Advanced Search

Apr 26 2020

hindenburg committed R319:b6b82b790dda: Mark constructors explicit (authored by hindenburg).
Mark constructors explicit
Apr 26 2020, 10:36 PM
hindenburg committed R319:92f03de922c3: Match variable names (authored by hindenburg).
Match variable names
Apr 26 2020, 10:22 PM
hindenburg committed R319:caeca72a0144: Change depreciated orientation() to angleDelta() (authored by ahmadsamir).
Change depreciated orientation() to angleDelta()
Apr 26 2020, 6:51 PM
hindenburg committed R319:56c6d592899b: Revert "Change depreciated orientation() to angleDelta()" (authored by hindenburg).
Revert "Change depreciated orientation() to angleDelta()"
Apr 26 2020, 6:51 PM
hindenburg added a reverting change for R319:e8b66b5b65b4: Change depreciated orientation() to angleDelta(): R319:56c6d592899b: Revert "Change depreciated orientation() to angleDelta()".
Apr 26 2020, 6:51 PM
hindenburg committed R319:e8b66b5b65b4: Change depreciated orientation() to angleDelta() (authored by sandsmark).
Change depreciated orientation() to angleDelta()
Apr 26 2020, 6:14 PM
hindenburg committed R319:61047714dce8: Add Qt check for position() - fix build on Qt5.12 (authored by hindenburg).
Add Qt check for position() - fix build on Qt5.12
Apr 26 2020, 4:56 PM
hindenburg committed R319:425f70ff131e: Change obsolete pos() to position() (authored by hindenburg).
Change obsolete pos() to position()
Apr 26 2020, 4:47 PM
hindenburg committed R319:785fedbe535b: fix deprecated qset warnings (authored by sandsmark).
fix deprecated qset warnings
Apr 26 2020, 4:14 PM

Apr 19 2020

hindenburg committed R319:febe306f7025: Fix Build (authored by tcanabrava).
Fix Build
Apr 19 2020, 1:46 PM
hindenburg committed R319:ec379a27301d: Do not depend on c++17 (authored by tcanabrava).
Do not depend on c++17
Apr 19 2020, 1:46 PM
hindenburg committed R319:0c905f5539ee: Replace manual memory management with unique_ptr (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Replace manual memory management with unique_ptr
Apr 19 2020, 1:46 PM
hindenburg committed R319:8afacdd0b549: Const Correctness (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Const Correctness
Apr 19 2020, 1:46 PM
hindenburg committed R319:632c4677551e: Remove the calls to java based iterators (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Remove the calls to java based iterators
Apr 19 2020, 1:46 PM
hindenburg committed R319:d908d309fecc: Declare and initialize the variable in one go (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Declare and initialize the variable in one go
Apr 19 2020, 1:46 PM
hindenburg committed R319:9d46f31e1fb5: Use structured bingings to return the value of multiple variables (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Use structured bingings to return the value of multiple variables
Apr 19 2020, 1:46 PM
hindenburg committed R319:de5617cddcb2: Use ternary to return a multiple choice (authored by Tomaz Canabrava <tcanabraba@kde.org>).
Use ternary to return a multiple choice
Apr 19 2020, 1:46 PM

Apr 14 2020

hindenburg committed R319:bc8530f71e34: For hotspot links use https instead of http (authored by hindenburg).
For hotspot links use https instead of http
Apr 14 2020, 12:55 PM
hindenburg committed R319:d1dcf25a9ac7: Change links http to https (authored by hindenburg).
Change links http to https
Apr 14 2020, 12:55 PM
hindenburg committed R319:79ad055855cf: Add ViewSplitter::showEvent() (authored by bergentroll).
Add ViewSplitter::showEvent()
Apr 14 2020, 12:00 PM
hindenburg committed R319:db15532f6caf: Remove un-needed semi-colons (authored by hindenburg).
Remove un-needed semi-colons
Apr 14 2020, 1:52 AM
hindenburg committed R319:5e56c44a645d: Add note about missing Q_OBJECT (authored by hindenburg).
Add note about missing Q_OBJECT
Apr 14 2020, 1:52 AM
hindenburg committed R319:dcf8cf3f2255: [BookmarkMenu] Adapt the code to KBookmarks 5.69 changes (authored by ahmadsamir).
[BookmarkMenu] Adapt the code to KBookmarks 5.69 changes
Apr 14 2020, 1:12 AM
hindenburg committed R319:2795c0a17a8e: Attempt to fix PartTest build (authored by hindenburg).
Attempt to fix PartTest build
Apr 14 2020, 1:06 AM

Apr 13 2020

hindenburg committed R319:3590453b0e20: Add newline at end of file (authored by hindenburg).
Add newline at end of file
Apr 13 2020, 2:56 PM
hindenburg committed R319:7cfbb8bb1651: Better accesibility to maximize view (authored by harogaston).
Better accesibility to maximize view
Apr 13 2020, 1:47 PM

Apr 10 2020

hindenburg committed R319:340d8fc061ef: Show separate status icons in view (split) headers (authored by mglb).
Show separate status icons in view (split) headers
Apr 10 2020, 6:21 PM
hindenburg committed R319:fc660b0bfab7: Change notification and broadcast icons (authored by mglb).
Change notification and broadcast icons
Apr 10 2020, 6:21 PM
hindenburg committed R319:3643dae2b3b9: TerminalHeaderBar: Put icon on the left (authored by mglb).
TerminalHeaderBar: Put icon on the left
Apr 10 2020, 6:21 PM
hindenburg committed R319:11608cdf1932: Show state and notifications on tab icon (authored by mglb).
Show state and notifications on tab icon
Apr 10 2020, 6:21 PM
hindenburg committed R319:74631635935a: Add copyInputChanged() and readOnlyChanged() signals (authored by mglb).
Add copyInputChanged() and readOnlyChanged() signals
Apr 10 2020, 6:21 PM
hindenburg committed R319:416e6629454b: Do not change session icon to indicate state (authored by mglb).
Do not change session icon to indicate state
Apr 10 2020, 6:21 PM
hindenburg committed R319:e3ea217d2ef0: Use insertTab instead of addTab (authored by mglb).
Use insertTab instead of addTab
Apr 10 2020, 6:21 PM
hindenburg committed R319:b355a844b120: Simplify TabbedViewContainer::disconnectTerminalDisplay() (authored by mglb).
Simplify TabbedViewContainer::disconnectTerminalDisplay()
Apr 10 2020, 6:21 PM
hindenburg committed R319:5f002cc3959a: Remove commented code (authored by mglb).
Remove commented code
Apr 10 2020, 6:21 PM
hindenburg committed R319:7c028a10101b: Add SessionController::isCopyInputActive() (authored by mglb).
Add SessionController::isCopyInputActive()
Apr 10 2020, 6:21 PM
hindenburg committed R319:0d594fef08cf: Update tab title only when new title comes from active split (authored by mglb).
Update tab title only when new title comes from active split
Apr 10 2020, 6:21 PM
hindenburg committed R319:e301ae96ed2b: Fix indents (authored by mglb).
Fix indents
Apr 10 2020, 6:21 PM
hindenburg committed R319:e2385f73e567: Update tab icon when active split changes (authored by mglb).
Update tab icon when active split changes
Apr 10 2020, 6:21 PM
hindenburg committed R319:ac1d3a1a0df8: Update tab icon when profile icon is changed (authored by mglb).
Update tab icon when profile icon is changed
Apr 10 2020, 6:21 PM
hindenburg committed R319:a77f75bf7cbe: activeTerminalDisplay(): find parent TD if needed (authored by mglb).
activeTerminalDisplay(): find parent TD if needed
Apr 10 2020, 6:21 PM
hindenburg committed R319:1fb00df308fe: Reorder functions definitions (authored by mglb).
Reorder functions definitions
Apr 10 2020, 6:21 PM
hindenburg committed R319:f8d8c3aa0832: Disable activity/silence signal only when both options are off (authored by mglb).
Disable activity/silence signal only when both options are off
Apr 10 2020, 6:21 PM
hindenburg committed R319:9855b2c125ff: Use flags for each session notification type (authored by mglb).
Use flags for each session notification type
Apr 10 2020, 6:21 PM
hindenburg committed R319:9e52df8d2bf9: Show profile icon on split header from the beginning (authored by mglb).
Show profile icon on split header from the beginning
Apr 10 2020, 6:21 PM
hindenburg committed R319:9ee21b9c62f6: Report TerminalDisplay focus when any of its children is focused (authored by mglb).
Report TerminalDisplay focus when any of its children is focused
Apr 10 2020, 6:21 PM

Mar 31 2020

hindenburg committed R319:c3ada2be32a6: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Mar 31 2020, 4:55 PM
hindenburg committed R319:a889f6aa4b2b: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Mar 31 2020, 4:46 PM

Mar 28 2020

hindenburg committed R319:fbe6295bb8e8: Use empty() for emptiness instead of size() (authored by hindenburg).
Use empty() for emptiness instead of size()
Mar 28 2020, 8:24 PM
hindenburg committed R319:3e8401391aa9: Add comments about QSet deprecated methods (authored by hindenburg).
Add comments about QSet deprecated methods
Mar 28 2020, 7:31 PM
hindenburg committed R319:09df31fe6adc: Remove un-needed semi-colons (authored by hindenburg).
Remove un-needed semi-colons
Mar 28 2020, 7:31 PM
hindenburg committed R319:b6973dfe6df1: Set QT5.12 as minimum as next release will be 20.08 (authored by hindenburg).
Set QT5.12 as minimum as next release will be 20.08
Mar 28 2020, 6:57 PM
hindenburg committed R319:449fdd90c974: Revert "Replace deprecated QSet::toList and QSet::fromList()" (authored by hindenburg).
Revert "Replace deprecated QSet::toList and QSet::fromList()"
Mar 28 2020, 6:41 PM
hindenburg added a reverting change for R319:c07210056cea: Replace deprecated QSet::toList and QSet::fromList(): R319:449fdd90c974: Revert "Replace deprecated QSet::toList and QSet::fromList()".
Mar 28 2020, 6:41 PM
hindenburg committed R319:c07210056cea: Replace deprecated QSet::toList and QSet::fromList() (authored by joaoeudes7).
Replace deprecated QSet::toList and QSet::fromList()
Mar 28 2020, 6:21 PM
hindenburg committed R319:ab0636de8ab3: Q_UNUSED() does not need semi-colon at end (authored by hindenburg).
Q_UNUSED() does not need semi-colon at end
Mar 28 2020, 6:07 PM
hindenburg committed R319:f476e936eaf1: Remove un-needed includes (authored by joaoeudes7).
Remove un-needed includes
Mar 28 2020, 5:39 PM
hindenburg committed R319:d65e6e9709a1: Remove shortcut for detach tab (authored by hindenburg).
Remove shortcut for detach tab
Mar 28 2020, 4:30 PM
hindenburg committed R319:8ad28a12574c: Group rendered characters by script (authored by mglb).
Group rendered characters by script
Mar 28 2020, 3:14 PM
hindenburg committed R319:86085d4acdc4: Allow for grouping extended characters (authored by mglb).
Allow for grouping extended characters
Mar 28 2020, 3:14 PM
hindenburg committed R319:94ff722fc0e6: Malayalam support: primitive PoC (authored by mglb).
Malayalam support: primitive PoC
Mar 28 2020, 3:14 PM

Mar 25 2020

hindenburg committed R319:5d2bae3cbf83: Revert "CMakeLists.txt: use ccache if present" (authored by asturmlechner).
Revert "CMakeLists.txt: use ccache if present"
Mar 25 2020, 1:10 AM
hindenburg added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: R319:5d2bae3cbf83: Revert "CMakeLists.txt: use ccache if present".
Mar 25 2020, 1:10 AM
hindenburg abandoned D28006: Fix build with Qt 5.15 beta2.

Thanks ,someone already committed this.

Mar 25 2020, 1:06 AM · Konsole
hindenburg commandeered D28006: Fix build with Qt 5.15 beta2.
Mar 25 2020, 1:06 AM · Konsole
hindenburg added a comment to D27110: Fix scrollbar sometimes reappearing when set to 'hidden' and scrolling using the touchpad.

I'm having problems updating my laptop - can anyone confirm the issue and fix?

Mar 25 2020, 1:05 AM · Konsole
hindenburg committed R319:3c171015c0d5: Revert "CMakeLists.txt: use ccache if present" (authored by asturmlechner).
Revert "CMakeLists.txt: use ccache if present"
Mar 25 2020, 1:03 AM
hindenburg added a reverting change for R319:007c2a085238: CMakeLists.txt: use ccache if present: R319:3c171015c0d5: Revert "CMakeLists.txt: use ccache if present".
Mar 25 2020, 1:03 AM
hindenburg closed D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 25 2020, 1:03 AM · Konsole
hindenburg accepted D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 25 2020, 12:50 AM · Konsole
hindenburg updated the summary of D24805: Revert "CMakeLists.txt: use ccache if present".
Mar 25 2020, 12:45 AM · Konsole

Mar 24 2020

hindenburg added a comment to D24805: Revert "CMakeLists.txt: use ccache if present".

Is there really any reason to fully revert? Why not just make it not the default per the above comment.

Mar 24 2020, 1:13 PM · Konsole

Feb 22 2020

hindenburg added a comment to D27110: Fix scrollbar sometimes reappearing when set to 'hidden' and scrolling using the touchpad.

Looks fine - thanks - I'll commit shortly

Feb 22 2020, 5:06 PM · Konsole
hindenburg committed R319:173806fc61f3: Konsole tests: update Unicode texts from the Kermit project (authored by knambiar).
Konsole tests: update Unicode texts from the Kermit project
Feb 22 2020, 2:02 PM
hindenburg closed D26599: Konsole tests: update Unicode texts from the Kermit project.
Feb 22 2020, 2:02 PM · Konsole
hindenburg accepted D26599: Konsole tests: update Unicode texts from the Kermit project.

Thanks, if you can in the future do gitlab merge requests. We can still do these phabricator until they shut it down.

Feb 22 2020, 1:51 PM · Konsole

Feb 1 2020

hindenburg committed R319:9babfb2efe65: Re-add correct ProvidersUrl; needed for non-Plasma systems per ml (authored by hindenburg).
Re-add correct ProvidersUrl; needed for non-Plasma systems per ml
Feb 1 2020, 2:16 AM

Jan 30 2020

hindenburg committed R319:048edf73955a: Remove default ProvidersUrl to use KNewStuff's default (authored by hindenburg).
Remove default ProvidersUrl to use KNewStuff's default
Jan 30 2020, 1:10 PM
hindenburg committed R319:72a5acc335d0: Revert "Use RAII to manage QApplication memory" (authored by sandsmark).
Revert "Use RAII to manage QApplication memory"
Jan 30 2020, 1:04 PM
hindenburg added a reverting change for R319:d5d8496cd285: Use RAII to manage QApplication memory: R319:72a5acc335d0: Revert "Use RAII to manage QApplication memory".
Jan 30 2020, 1:04 PM
hindenburg closed D26764: Another revert to unbreak crash fix.
Jan 30 2020, 1:04 PM · Konsole
hindenburg added a comment to D26764: Another revert to unbreak crash fix.

Is there a consensus here? Should we revert to previous code and then if someone wants to put in another merge request.

Jan 30 2020, 1:37 AM · Konsole
hindenburg committed R319:09cc4f6bb97d: Fix Separator (authored by tcanabrava).
Fix Separator
Jan 30 2020, 1:11 AM
hindenburg committed R319:96cda154c16e: Fix context menu actions when search bar is enabled (authored by tcanabrava).
Fix context menu actions when search bar is enabled
Jan 30 2020, 1:11 AM

Jan 24 2020

hindenburg added a comment to D26761: Unbreak opening in separate process and fix crashes.

Is there still some confusion here?

Jan 24 2020, 1:57 AM · Konsole
hindenburg added a comment to D26764: Another revert to unbreak crash fix.

I don't have a problem w/ reverting this. @kkharlamov if you want to try again, please make sure you add the other people here for their comments on it.

Jan 24 2020, 1:57 AM · Konsole

Jan 17 2020

hindenburg committed R319:967c42a1b094: Support status report requests for text-colors (authored by muesli).
Support status report requests for text-colors
Jan 17 2020, 3:34 PM

Jan 8 2020

hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

Yea I noticed that - he does that a lot - thanks for this patch regardless - you can close this.

Jan 8 2020, 3:27 PM · Konsole

Jan 7 2020

hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

But konsole's minimum KF5 version is 5.6.0 currently. Maybe this should be increased?

As the minimum Qt version is 5.9.0, I highly doubt that anyone would want to build konsole with KF5 5.6.0 (which is more than 2 years older) anyway...

Jan 7 2020, 3:05 PM · Konsole
hindenburg committed R319:7ee9350bbab8: Update copyright year (authored by hindenburg).
Update copyright year
Jan 7 2020, 2:14 AM
hindenburg committed R319:2fc470507e42: ColorScheme: fix stack-use-after-scope detected by ASAN (authored by mglb).
ColorScheme: fix stack-use-after-scope detected by ASAN
Jan 7 2020, 2:06 AM
hindenburg added a comment to D26479: Fix warning on launch from QCommandLineParser.

Thanks I just noticed this - I wonder when it started or if depends on KF5/Qt5 version.

Jan 7 2020, 1:56 AM · Konsole

Jan 5 2020

hindenburg committed R319:7cfe2c8a36fd: Copy _colorRandomization when copying a new ColorScheme (authored by wbauer).
Copy _colorRandomization when copying a new ColorScheme
Jan 5 2020, 6:28 PM
hindenburg committed R319:771c1733fd5e: Copy _colorRandomization when copying a new ColorScheme (authored by wbauer).
Copy _colorRandomization when copying a new ColorScheme
Jan 5 2020, 6:25 PM
hindenburg closed D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:25 PM · Konsole
hindenburg updated the summary of D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:20 PM · Konsole
hindenburg updated the test plan for D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:16 PM · Konsole
hindenburg updated the test plan for D26439: Copy _colorRandomization when copying a new ColorScheme.
Jan 5 2020, 6:15 PM · Konsole
hindenburg accepted D26439: Copy _colorRandomization when copying a new ColorScheme.

Thanks nice catch. We are trying to migrate to gitlab; if you can in the future use merge requests.

Jan 5 2020, 6:12 PM · Konsole
hindenburg committed R319:23ddfcc4fcd3: Fix token buffer indexing (authored by mglb).
Fix token buffer indexing
Jan 5 2020, 3:51 PM