Feed Advanced Search

Sep 2 2020

hindenburg added a comment to T12185: KService: deprecate/slim down KToolInvocation.

This change in Konsole broke all the tests

Sep 2 2020, 12:20 PM · KF6

Jul 11 2020

hindenburg added a comment to D13854: Refactor Profile and ColorScheme.

Do you want to try to save this?

Jul 11 2020, 7:52 PM · Konsole
hindenburg abandoned D16138: Create the default profile if it doesn't exist.
Jul 11 2020, 7:50 PM · Konsole
hindenburg commandeered D16138: Create the default profile if it doesn't exist.

I've saved a copy of this patch. I think we want to include a default profile instead of this. I'll close this now as we've moved to invent MRs.

Jul 11 2020, 7:50 PM · Konsole
hindenburg added a comment to D29502: kwidgetsaddons: Add a named colors support in KColorCombo..

What's the status of this? Did it get moved to invent MR?

Jul 11 2020, 7:23 PM · Frameworks
hindenburg added a comment to D15570: Use new connection style.

Looks like this needs up looked at - moved to invent MR

Jul 11 2020, 7:21 PM · Konsole
hindenburg added a comment to D20439: Fix alignment boundary.

Any interesting in updating this or moving to invent mR?

Jul 11 2020, 7:15 PM · Konsole
hindenburg abandoned D16134: Secure history file.
Jul 11 2020, 7:11 PM · Konsole
hindenburg commandeered D16134: Secure history file.

The suggested fix for this is to use an encrypted disk/folder/file for this. If we put this in Konsole, we are responsible for the security of it. I will save a copy of this patch for future reference as phabricator will be shutdown shortly.

Jul 11 2020, 7:11 PM · Konsole
hindenburg abandoned D21123: Compile without Q_FOREACH.
Jul 11 2020, 7:02 PM · Konsole
hindenburg commandeered D21123: Compile without Q_FOREACH.

already done

Jul 11 2020, 7:02 PM · Konsole
hindenburg added a comment to D17742: Clean up content rect in TerminalDisplay.

It looks like this is still open - do you want to move this to an invent MR?

Jul 11 2020, 7:01 PM · Konsole
hindenburg abandoned D21055: Highlight lines coming into view when scrolling.
Jul 11 2020, 6:58 PM · Konsole
hindenburg commandeered D21055: Highlight lines coming into view when scrolling.

moved to invent

Jul 11 2020, 6:58 PM · Konsole
hindenburg abandoned D26761: Unbreak opening in separate process and fix crashes.
Jul 11 2020, 6:57 PM · Konsole
hindenburg commandeered D26761: Unbreak opening in separate process and fix crashes.

moved to invent MR. https://invent.kde.org/utilities/konsole/-/merge_requests/110

Jul 11 2020, 6:57 PM · Konsole

Jun 20 2020

hindenburg committed R319:f99271caad14: Use https when allowed (authored by hindenburg).
Use https when allowed
Jun 20 2020, 1:49 AM
hindenburg committed R319:e2bc31c0230d: Old docs change to https (authored by hindenburg).
Old docs change to https
Jun 20 2020, 1:23 AM
hindenburg committed R319:99dae2d841a7: Update developer URLs (authored by hindenburg).
Update developer URLs
Jun 20 2020, 1:23 AM
hindenburg committed R319:7e63b92f0a35: Correct URls; change to use https (authored by hindenburg).
Correct URls; change to use https
Jun 20 2020, 1:23 AM
hindenburg committed R319:4b290de8cad7: Update URL to https (authored by hindenburg).
Update URL to https
Jun 20 2020, 1:04 AM
hindenburg committed R319:df8b60268e11: Update kcfg URLS to https (authored by hindenburg).
Update kcfg URLS to https
Jun 20 2020, 1:04 AM
hindenburg committed R319:42e10f109890: Update URLs (authored by hindenburg).
Update URLs
Jun 20 2020, 1:04 AM
hindenburg committed R319:436a979b8251: Update URL to use https (authored by hindenburg).
Update URL to use https
Jun 20 2020, 1:04 AM
hindenburg committed R319:f4959efe014e: License urls change to https (authored by hindenburg).
License urls change to https
Jun 20 2020, 12:41 AM
hindenburg committed R319:399ba9eb1fa2: Use https for URLs (authored by hindenburg).
Use https for URLs
Jun 20 2020, 12:31 AM
hindenburg committed R319:0eb1c7e8ff00: Update konsoleprofile link for info (authored by hindenburg).
Update konsoleprofile link for info
Jun 20 2020, 12:28 AM
hindenburg committed R319:4b35c5d53f1c: Use https for URLs (authored by hindenburg).
Use https for URLs
Jun 20 2020, 12:14 AM

Jun 19 2020

hindenburg committed R319:c046967e1bc1: Test: for loop - avoid creating copies (authored by hindenburg).
Test: for loop - avoid creating copies
Jun 19 2020, 11:55 PM
hindenburg committed R319:a42293995c64: Add hint to also translate a leading space (authored by clel).
Add hint to also translate a leading space
Jun 19 2020, 11:39 PM
hindenburg committed R319:37ffb50e59fb: Reproduction test case for a crash described in Bug 330066 (authored by Lukasz Kotula <lukasz.kotula@gmx.com>).
Reproduction test case for a crash described in Bug 330066
Jun 19 2020, 11:27 PM
hindenburg committed R319:b5d02842fc3c: Fix for a crash caused by buffer-overflow in case of '>=1024' columns (authored by Lukasz Kotula <lukasz.kotula@gmx.com>).
Fix for a crash caused by buffer-overflow in case of '>=1024' columns
Jun 19 2020, 11:27 PM
hindenburg committed R319:6b6a1e552492: Don't add extra newlines when pasting from GTK applications (authored by ahmadsamir).
Don't add extra newlines when pasting from GTK applications
Jun 19 2020, 2:51 PM
hindenburg committed R319:6e51fa2fad90: Change 'Rename Tab' menu items to 'Configure Tab Settings' (authored by hindenburg).
Change 'Rename Tab' menu items to 'Configure Tab Settings'
Jun 19 2020, 2:22 PM

Jun 18 2020

hindenburg committed R319:6f15730ad1c8: Merge branch 'rename_renametab' into 'master' (authored by hindenburg).
Merge branch 'rename_renametab' into 'master'
Jun 18 2020, 6:49 AM
hindenburg committed R319:b19ab92cd8ba: Merge branch 'rename_renametab' into 'master' (authored by hindenburg).
Merge branch 'rename_renametab' into 'master'
Jun 18 2020, 12:07 AM

Jun 16 2020

hindenburg committed R319:09d4895ed75a: Merge branch 'rename_renametab' into 'master' (authored by hindenburg).
Merge branch 'rename_renametab' into 'master'
Jun 16 2020, 5:10 PM
hindenburg committed R319:55f0ca4151ef: Change 'Rename Tab' to 'Temporary Tab Settings' (authored by hindenburg).
Change 'Rename Tab' to 'Temporary Tab Settings'
Jun 16 2020, 5:04 PM

Jun 15 2020

hindenburg committed R319:57c942d91b6d: Add default shortcut to switch-to-tab-9 action (authored by Axel Navarro <navarroaxel@gmail.com>).
Add default shortcut to switch-to-tab-9 action
Jun 15 2020, 5:02 PM
hindenburg committed R319:9bb2c059b180: Fix shortcuts for Yakuake grow-terminal actions (authored by Axel Navarro <navarroaxel@gmail.com>).
Fix shortcuts for Yakuake grow-terminal actions
Jun 15 2020, 4:39 PM
hindenburg committed R319:3a2eb7652a04: Replace Q_DECL_OVERRIDE with override (authored by nicolasfella).
Replace Q_DECL_OVERRIDE with override
Jun 15 2020, 3:52 AM
hindenburg committed R319:73d8bff036b1: Merge branch 'remove-detachtab-shortcut' into 'master' (authored by hindenburg).
Merge branch 'remove-detachtab-shortcut' into 'master'
Jun 15 2020, 3:52 AM
hindenburg committed R319:58e6d0ed973e: Fixes following review (authored by harogaston).
Fixes following review
Jun 15 2020, 3:51 AM
hindenburg committed R319:616dca34080b: Better accesibility to maximize view (authored by harogaston).
Better accesibility to maximize view
Jun 15 2020, 3:51 AM
hindenburg committed R319:eabe7d978493: Merge branch 'dbus_security_options' into 'master' (authored by hindenburg).
Merge branch 'dbus_security_options' into 'master'
Jun 15 2020, 3:48 AM

Jun 6 2020

hindenburg committed R319:7d1e286102d4: Fix lambda capture 'this' is not used (authored by hindenburg).
Fix lambda capture 'this' is not used
Jun 6 2020, 10:22 AM
hindenburg committed R319:399a551b02d8: Notify current cursor position might be changed to input methods (authored by Fuminobu TAKEYAMA <ftake@geeko.jp>).
Notify current cursor position might be changed to input methods
Jun 6 2020, 10:22 AM
hindenburg committed R319:4e15b1fdd58f: Fix lambda capture 'this' is not used (authored by hindenburg).
Fix lambda capture 'this' is not used
Jun 6 2020, 2:50 AM
hindenburg committed R319:56ffdbbb29d2: Correctly handle selection and opening via clicks (authored by tcanabrava).
Correctly handle selection and opening via clicks
Jun 6 2020, 2:44 AM
hindenburg committed R319:a6a726f150bc: Add copyright and license (authored by hindenburg).
Add copyright and license
Jun 6 2020, 2:30 AM
hindenburg committed R319:d2d818b08b58: konsole: Convert depreciated QString::SkipEmptyParts and QButtonGroup::idClicked (authored by carneirogustavo).
konsole: Convert depreciated QString::SkipEmptyParts and QButtonGroup::idClicked
Jun 6 2020, 2:02 AM
hindenburg committed R319:d86b0547ead1: Notify current cursor position might be changed to input methods (authored by Fuminobu TAKEYAMA <ftake@geeko.jp>).
Notify current cursor position might be changed to input methods
Jun 6 2020, 1:59 AM
hindenburg committed R319:877fd0caf4a1: Add thumbnails for certain file types on mouse hover (authored by tcanabrava).
Add thumbnails for certain file types on mouse hover
Jun 6 2020, 1:53 AM

Jun 5 2020

hindenburg committed R319:197e8f22fd39: Fix SearchTask memleak (authored by tcanabrava).
Fix SearchTask memleak
Jun 5 2020, 2:39 AM
hindenburg committed R319:86aaef4a6e57: Speedups: Use brace-initializer for vector (authored by tcanabrava).
Speedups: Use brace-initializer for vector
Jun 5 2020, 2:01 AM
hindenburg committed R319:881b0d4b5c46: Access QPointer Directly (authored by tcanabrava).
Access QPointer Directly
Jun 5 2020, 1:57 AM

Jun 3 2020

hindenburg committed R319:e713c90c5e0b: Only recalculate the directories when we change dirs (authored by tcanabrava).
Only recalculate the directories when we change dirs
Jun 3 2020, 11:42 AM
hindenburg committed R319:0b489b0c69b8: Use QSet to search for strings instead of QStringList (authored by tcanabrava).
Use QSet to search for strings instead of QStringList
Jun 3 2020, 11:42 AM

Jun 2 2020

hindenburg committed R319:0c3240a1bef1: Fix override switch-to-tab action in Yakuake (authored by Axel Navarro <navarroaxel@gmail.com>).
Fix override switch-to-tab action in Yakuake
Jun 2 2020, 1:11 PM

May 29 2020

hindenburg committed R319:27ee6a27380c: [SessionController] Fix crash caused by text encoding menu (authored by ahmadsamir).
[SessionController] Fix crash caused by text encoding menu
May 29 2020, 12:06 PM
hindenburg committed R319:d40e3c72f2ad: Fix konsolepart segfault when closing after showing context menu (authored by mschiller).
Fix konsolepart segfault when closing after showing context menu
May 29 2020, 12:06 PM
hindenburg committed R319:e7e8e9d1a9b1: [SessionController] Fix crash caused by text encoding menu (authored by ahmadsamir).
[SessionController] Fix crash caused by text encoding menu
May 29 2020, 11:43 AM
hindenburg committed R319:1d7142ed24ef: Fix konsolepart segfault when closing after showing context menu (authored by mschiller).
Fix konsolepart segfault when closing after showing context menu
May 29 2020, 11:43 AM

May 28 2020

hindenburg committed R319:76f3764b4798: Fix crash when closing session in KonsolePart via menu (authored by nicolasfella).
Fix crash when closing session in KonsolePart via menu
May 28 2020, 1:59 PM
hindenburg committed R319:fdfae2566573: Fix crash when closing session in KonsolePart via menu (authored by nicolasfella).
Fix crash when closing session in KonsolePart via menu
May 28 2020, 1:38 PM
hindenburg committed R319:6d2924e31abc: Send notification when the session'a foreground process finishes (authored by wwestrop).
Send notification when the session'a foreground process finishes
May 28 2020, 12:25 PM

May 23 2020

hindenburg added a reverting change for R319:ff0a8bcbeb7b: Test breaking build still sends out email: R319:724560da40aa: Revert "Test breaking build still sends out email".
May 23 2020, 1:09 AM
hindenburg committed R319:724560da40aa: Revert "Test breaking build still sends out email" (authored by hindenburg).
Revert "Test breaking build still sends out email"
May 23 2020, 1:09 AM
hindenburg committed R319:ff0a8bcbeb7b: Test breaking build still sends out email (authored by hindenburg).
Test breaking build still sends out email
May 23 2020, 1:07 AM

May 10 2020

hindenburg committed R319:d8b9ccd24e8a: Simpify return after else statements (authored by hindenburg).
Simpify return after else statements
May 10 2020, 9:07 PM
hindenburg committed R319:90c81d0ecfeb: Simpify return after else statements (authored by hindenburg).
Simpify return after else statements
May 10 2020, 8:46 PM
hindenburg committed R319:9a80c74bff9e: Fix some implicit-bool-conversions (authored by hindenburg).
Fix some implicit-bool-conversions
May 10 2020, 7:13 PM
hindenburg committed R319:6733a9367bc6: Convert QFontMetrics depreciated width to horizontalAdvance (authored by hindenburg).
Convert QFontMetrics depreciated width to horizontalAdvance
May 10 2020, 6:15 PM
hindenburg committed R319:5c793cb0424c: Convert depreciated setWorldMatrix to setWorldTransform (authored by hindenburg).
Convert depreciated setWorldMatrix to setWorldTransform
May 10 2020, 5:38 PM
hindenburg committed R319:e788b2a89409: Konsole: Add a color tabs support in Konsole (authored by carneirogustavo).
Konsole: Add a color tabs support in Konsole
May 10 2020, 3:23 PM

May 5 2020

hindenburg committed R319:35ff3a72cefe: Use Qurl::fromPercentEncoding for bookmarks (authored by ZaWertun).
Use Qurl::fromPercentEncoding for bookmarks
May 5 2020, 1:37 AM

May 3 2020

hindenburg committed R319:f3f8cca628a4: Use auto when initializing with a template cast to avoid duplicating the type (authored by hindenburg).
Use auto when initializing with a template cast to avoid duplicating the type
May 3 2020, 2:10 AM
hindenburg committed R319:251125833817: Use a braced initializer list (authored by hindenburg).
Use a braced initializer list
May 3 2020, 2:10 AM
hindenburg committed R319:d3519ae24c0d: Use Qurl::fromPercentEncoding for bookmarks (authored by ZaWertun).
Use Qurl::fromPercentEncoding for bookmarks
May 3 2020, 2:00 AM
hindenburg closed D29322: Fix bookmark command being percent encoded.
May 3 2020, 2:00 AM · Konsole

May 2 2020

hindenburg added a comment to D29322: Fix bookmark command being percent encoded.

Thanks, it appears at one time I looked at converting this to use " QUrl::fromPercentEncoding(bm_url.url().toUtf8());" since that is in the autotests. But it appears I didn't put that in the main code.

May 2 2020, 3:21 PM · Konsole

Apr 30 2020

hindenburg committed R319:eaef61e1c417: Add DBus call setDefaultProfile() to ViewManager (authored by z3ntu).
Add DBus call setDefaultProfile() to ViewManager
Apr 30 2020, 2:27 PM
hindenburg closed D29236: Add setDefaultProfile() to ViewManager.
Apr 30 2020, 2:27 PM · Konsole
hindenburg added a comment to D29236: Add setDefaultProfile() to ViewManager.

Thanks it looks fine. I'll commit shortly.

Apr 30 2020, 2:17 PM · Konsole
hindenburg added a reviewer for D29236: Add setDefaultProfile() to ViewManager: Konsole.

All of KDE is moving to gitlab - please add a merge request there https://invent.kde.org/kde/konsole/-/merge_requests

Apr 30 2020, 2:26 AM · Konsole

Apr 29 2020

hindenburg committed R319:76776c6b59f4: Do not show "Search for" if web shortcuts are disabled (authored by hindenburg).
Do not show "Search for" if web shortcuts are disabled
Apr 29 2020, 2:28 AM
hindenburg committed R319:e1fbdcb64cc4: [TerminalDisplay] Change the mouse cursor shape back to beam on leaveEvent (authored by ahmadsamir).
[TerminalDisplay] Change the mouse cursor shape back to beam on leaveEvent
Apr 29 2020, 2:28 AM
hindenburg committed R319:a1b78079c58b: Remove unneeded <optional> include (authored by kossebau).
Remove unneeded <optional> include
Apr 29 2020, 1:08 AM

Apr 28 2020

hindenburg committed R319:1b08f3058ae7: Do not show "Search for" if web shortcuts are disabled (authored by hindenburg).
Do not show "Search for" if web shortcuts are disabled
Apr 28 2020, 3:07 PM
hindenburg committed R319:b35a13e5530a: Remove unused variable (authored by hindenburg).
Remove unused variable
Apr 28 2020, 1:02 PM
hindenburg committed R319:2a48850688d4: Cursor thickness follows font size (authored by harogaston).
Cursor thickness follows font size
Apr 28 2020, 12:54 PM
hindenburg committed R319:474886dba88d: [TerminalDisplay] Change the mouse cursor shape back to beam on leaveEvent (authored by ahmadsamir).
[TerminalDisplay] Change the mouse cursor shape back to beam on leaveEvent
Apr 28 2020, 12:44 PM

Apr 27 2020

hindenburg committed R319:028a31edda4a: Use std::array (authored by hindenburg).
Use std::array
Apr 27 2020, 4:03 AM
hindenburg committed R319:795180cb4a44: Do not call a virtual function during construction (authored by hindenburg).
Do not call a virtual function during construction
Apr 27 2020, 3:05 AM
hindenburg committed R319:1563ed9b8937: initialize variable in constructor (authored by hindenburg).
initialize variable in constructor
Apr 27 2020, 2:13 AM
hindenburg committed R319:79c6cefe5c0e: Remove unused variable (authored by hindenburg).
Remove unused variable
Apr 27 2020, 2:13 AM
hindenburg committed R319:bb157d33c8a3: Use = default to define a trivial default destructor (authored by hindenburg).
Use = default to define a trivial default destructor
Apr 27 2020, 1:23 AM
hindenburg committed R319:0d1504993b18: Simplify boolean expression (authored by hindenburg).
Simplify boolean expression
Apr 27 2020, 1:14 AM

Apr 26 2020

hindenburg committed R319:0aaa53db54c5: Remove unused code and assignment (authored by hindenburg).
Remove unused code and assignment
Apr 26 2020, 11:19 PM
hindenburg committed R319:c7ea0413adca: Simplify redundant else logic (authored by hindenburg).
Simplify redundant else logic
Apr 26 2020, 10:40 PM