Compiled and tested, no problems found

Compiled and tested, no problems found

Compiled and tested, works as intended.

Compiled and tested, no problems found.

Tested on:

Tested on:

Built and tested on :

Built and tested on :

Built and tested on :

Built and tested on :

Built and tested on :

Built and tested on :

Tested on:

Tested on:

Tested on:

Tested on:

Work fine, tested locally and with ftp:, fish: and smb: with success.

Fine to me

Fine to me

Sounds good to me, no errors found

Compiled and tested on QT 5.14.1, QT 5.9.5 (Ubuntu 18.04) and QT 5.12.4 (Ubuntu 19.10); all fine

All good, thanks.

All tests fine.

In D26334#601440, @abika wrote:

Although the current fix works for me, i propose to change the added line into

panel->view->setNameToMakeCurrent(nameToMakeCurrent);

Safe to delete, related code was removed in R167:7e23b9223b9a6fc7e9f48ecd5d275e900bbe35d3

Closed in favor of adding FileManager1 dbus interface to Krusader

Updated docbook as stated by @yurchor.

Compiled and tested with no errors, thanks

Thanks Nicolas, compiled with GCC 9 and Clang 9, no errors were detected (also because Q_DECL_OVERRIDE is a macro for the override).

Tested Synchronizer, Konfigurator and DiskUsage, no problems found.

I personally think that the original repo could be used, my perfect solution would be a scratch repo. But (this is a big but) the target of this set of patches shouldn't be a normal user but a distro packager, and we must show big warning saying that this does not mean that the developing is active and only trivial patches for critical bugs could be backported; sometime a single-line patch cannot be backported because all the logic around was changed, or the backport does not fix at all or even worse. Also, because the development is closed, no bugs should be reported because the first answer would be "can you try on a newer version?".

I don't have write access to the repo, can someone please push? Thanks

The patch works fine, although it requires KIO 5.62 or a reverse patch

Tested, it works perfectly with every archive as if it had been opened with Ark

In D22434#508964, @asensi wrote:

An article about it has been published recently:

About deprecation of QFontMetrics::width()
https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

by @cfeck (Christoph Feck, who has commited some changes to the repository of Krusader).

No objections

Changed with macro, as suggested by @nmel; the code now is cleaner (and QFONTMETRICS_HORIZONTAL_ADVANCE seems a bit long)

@yurchor : I follwed the guidelines from the documentation (https://doc.qt.io/qt-5/qfontmetrics-obsolete.html#width); I haven't tried to see where the difference really is, I think there could be some pixel overlapped or some extra space.

Looking at Qt, all the new methods are present in version 5.9 so that no checks with preprocessor are needed.