Implement Shift+Del to remove cruft from the history of: the "Host" comboBox on the "New Network Connection" dialog
ClosedPublic

Authored by asensi on Apr 18 2020, 7:48 PM.

Details

Summary

When Krusader users utilize the "Host" comboBox on the "New Network
Connection" dialog: they often see bad suggestions because there are obsolete
entries, mistakes and so on, but normal Krusader users can't remove those
entries. For example, web browsers have Shift+Del in order to remove the
thwarting entries.

With a KrHistoryComboBox, Krusader users are able to delete wrong entries
from history lists, and therefore they can remove those bad suggestions that
they were seeing.

Test Plan

Press Ctrl+N to open the "New Network Connection" dialog. Using the "Host"
comboBox on the "New Network Connection" dialog, several times: add a new host
address (e.g. a non-existent one like "example.com"), press the «Connect»
button. Open the "New Network Connection" dialog again, delete the recently
added host address:
a) using Shift+Del when the popup list is seen;
b) or using the arrow keys and Shift+Del when the popup list is not visible;

Try to delete all the host addresses until the list is empty, press Shift+Del
again. Press the «Connect» button.

Open the "New Network Connection" dialog again, check that the list is empty.

Start a new connection (e.g. an FTP one), just in case.

Note: Those changes are designed to be tried after applying the ones
described in https://phabricator.kde.org/D28961

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Apr 18 2020, 7:48 PM
asensi created this revision.

Thanks for testing and informing, Yuri!

asensi edited the summary of this revision. (Show Details)Apr 21 2020, 10:28 PM
asensi edited the test plan for this revision. (Show Details)
gengisdave accepted this revision.Apr 27 2020, 8:44 PM
gengisdave added a subscriber: gengisdave.

Compiled and tested, no problems found

This revision is now accepted and ready to land.Apr 27 2020, 8:44 PM
This revision was automatically updated to reflect the committed changes.