Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog
ClosedPublic

Authored by asensi on Apr 18 2020, 7:43 PM.

Details

Summary

When Krusader users utilize some comboBoxes on the search dialog: they often
see bad suggestions because there are obsolete entries, mistakes and so on, but
normal Krusader users can't remove those entries. For example, web browsers have
Shift+Del in order to remove the thwarting entries.

If the KrHistoryComboBox class is used, then Krusader users are able to
delete wrong entries from history lists, and therefore they can remove those bad
suggestions that they were seeing.

Test Plan

Press Ctrl+S to see the search dialog. Using the "Contains text"
comboBox on the Search dialog, several times: add a new search term, search with
it, delete the search term:
a) using Shift+Del when the popup list is seen;
b) or using the arrow keys and Shift+Del when the popup list is not visible;
monitor the changes in the ~/.config/krusaderrc file. Try to delete all
the search terms until the list is empty, press Shift+Del again.

Press

Ctrl and +

and perform equivalent tests.

Press

Ctrl and -

and perform equivalent tests.

Press Ctrl+S to see the search dialog. Using the "Exclude Folder Names"
comboBox on the Search dialog, several times: add a new {folder name to be
excluded}, search using it, delete the {folder name to be excluded}:
a) using Shift+Del when the popup list is seen;
b) or using the arrow keys and Shift+Del when the popup list is not visible;
monitor the changes in the ~/.config/krusaderrc file. Try to delete all
the {folder names to be excluded} until the list is empty, press Shift+Del
again.

Search text inside the files of a folder, just in case.

Note: Those changes are designed to be tried after applying the ones
described in https://phabricator.kde.org/D28959

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asensi requested review of this revision.Apr 18 2020, 7:43 PM
asensi created this revision.
asensi retitled this revision from Implement Shift+Del to remove cruft from the history of: the "Contains text" comboBox on the search dialog to Implement Shift+Del to remove cruft from the history of: some comboBoxes on the search dialog.Apr 19 2020, 6:44 AM
asensi edited the summary of this revision. (Show Details)
asensi edited the test plan for this revision. (Show Details)
asensi updated this revision to Diff 80519.Apr 19 2020, 6:50 AM

Some changes which are applied to the same files have been joined into the same code review, in order to ease the testing and reviewing.

Thanks for testing and informing, Yuri!

asensi edited the summary of this revision. (Show Details)Apr 21 2020, 10:24 PM
asensi edited the test plan for this revision. (Show Details)
asensi edited the summary of this revision. (Show Details)
gengisdave accepted this revision.Apr 27 2020, 8:36 PM
gengisdave added a subscriber: gengisdave.

Compiled and tested, works as intended.

This revision is now accepted and ready to land.Apr 27 2020, 8:36 PM
This revision was automatically updated to reflect the committed changes.