Differential D26155

Add RPM support to Krarc
ClosedPublic
Actions

Authored by gengisdave on Dec 22 2019, 3:58 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:a6d068dee88a: [KUrlNavigator] Add RPM support to krarc:
Summary

This fix the conflict between file: and krarc: protocols when and RPM is opened

FIXED: [ 408082 ] krarc stopped working with rpm
BUG: 408082

Test Plan

Compile and test with and without krusader installed.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gengisdave created this revision.Dec 22 2019, 3:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptDec 22 2019, 3:58 PM
gengisdave requested review of this revision.Dec 22 2019, 3:58 PM
dfaure accepted this revision.Dec 23 2019, 8:15 AM

This doesn't really scale. It sounds like we should list those mimetypes in the krarc protocol definition (used to be .protocol file, probably part of the JSON nowadays) and query that at runtime (via KProtocolManager)....

This revision is now accepted and ready to land.Dec 23 2019, 8:15 AM
Closed by commit R241:a6d068dee88a: [KUrlNavigator] Add RPM support to krarc: (authored by gengisdave). · Explain WhyJan 1 2020, 10:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filewidgets/kurlnavigator.cpp (2 lines)

Diff 72519

View Options

src/filewidgets/kurlnavigator.cpp

Loading...