Manage what happens when a PanelViewerBase (e.g. using Shift+F3) tries to open a nonexistent local file
ClosedPublic

Authored by asensi on Sat, Feb 8, 7:16 PM.

Details

Reviewers
gengisdave
Group Reviewers
Krusader
Summary

This solves some problems. For example, if users press Shift+F3 and paste the path of a local nonexistent file: Krusader opens a viewer window as it that file existed and was empty (but that file is not empty, it really does not exist). Note: That problem doesn't happen in the case of remote nonexistent files.

FIXED: [ 395737 ] If the user presses Shift+F3 and writes the name of an inexistent file: Krusader opens a viewer window
BUG: 395737

Test Plan

Using Shift+F3 to try to open a:

  • local file that exists: /etc/passwd
  • local file (or folder) that doesn't exist: /etc/nonexistent
  • local folder that exists: /etc
  • remote file that exists: smb://user@IP_ADDRESS/PATH/EXISTENT_FILE
  • remote file that doesn't exist : smb://user@IP_ADDRESS/NONEXISTENT
  • remote file that exists: fish://user@IP_ADDRESS:PORT/PATH/EXISTENT_FILE
  • remote file that doesn't exist : fish://user@IP_ADDRESS:PORT/NONEXISTENT
  • remote folder that exists: smb://user@IP_ADDRESS/PATH/EXISTENT_FOLDER
  • remote folder that exists: fish://user@IP_ADDRESS:PORT/PATH/EXISTENT_FOLDER

Opening the existing files, but using F3 instead of Shift+F3.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi requested review of this revision.Sat, Feb 8, 7:16 PM
asensi created this revision.
yurchor added a subscriber: yurchor.Sat, Feb 8, 8:25 PM

Tested to work as expected.

+1

gengisdave accepted this revision as: gengisdave.Mon, Feb 10, 9:47 AM
gengisdave added a subscriber: gengisdave.

All tests fine.

Thanks!

This revision is now accepted and ready to land.Mon, Feb 10, 9:47 AM

Thanks, Yuri and Davide!