In D20140#450349, @GB_2 wrote:

Ping

I can't think of any more suggestions that would be an obvious improvement, so I'll accept this.

Can you flip the direction of the 16px version? I know the icon you're copying the design of is also like this, but I think it needs to be fixed.

• Turn window-keep-* into symlinks to go-up/down-skip

Now I'll need to turn window-keep-above and window-keep-below into symlinks to go-up-skip and go-down-skip. arc patch hates it when files or symlinks are converted to each other, so I'll hold off doing that until this gets accepted.

• Change to 3 icons

In D19874#444153, @filipf wrote:

This makes Kickoff even a bit more more left-centered = looking like it's wasting horizontal space. That's why I prefer the way it was before, but I tested the patch and everything seems symmetric at least.

It seems that in the screenshots the "Small" font is set to be bigger than normal. With default font sizes Kickoff can end up looking like this (ignore the lack of few other patches):

That's a lot of unused horizontal space, while the benefits of reduced padding are only for apps with really long descriptions (which are minority) or for people using a bigger font size for "Small" text.

If everyone else is on board I won't object though.

I haven't tested this with many different fonts, but the current version of this patch works well for Noto Sans at 10, 11 and 12 pts.

• Remove commented out bit of old code

Use smallSpacing for KickoffItem and KickoffHighlight

Those curves are perfect 👌

Alright. I'll finish it when I have time.

In D20226#442934, @bruns wrote:

Diagonal or round shapes are not required to be pixel grid aligned. Actually, it is not even possible, as there is always some antialiasing. It even helps to make round shapes a little bit bit larger than the pixel grid, so some of the corner/edge pixels are solid color.

In D20226#442906, @GB_2 wrote:

In D20226#442882, @ngraham wrote:

Also, could we create a 22x22 version too?

How can you efficiently do that without having to realign everything to the new grid manually?

The proportions aren't quite right.

I've already made Qt Widget-like tabs for Breeze and Breeze Dark at these repos, so you can just borrow from those:

Does the theme have to use PNGs? It would also be nice if the tabs could look more like Qt tabs like in https://store.kde.org/p/1193435/

In D20166#441863, @kossebau wrote:

IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata.
Only the deployed graphics resource should then be limited and optimized for what is needed at runtime.

At least I had dealt with quite some "final rendered" SVG files I would have liked to modify for some needs, but could hardly as the base resources where not available (and if it was only guides & Co.).

In D20166#441807, @ngraham wrote:

Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would ultimately be interested in as well).

Be careful that you are not stripping stylesheets when you use SVG Cleaner. scour is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more distros.

Yes, this is much better. Wow, that application-x-executable icon is really blurry.

Another alternative would be to turn the thumbnail outline into a real outline instead of a rounded rectangle behind the thumbnailArea. Then it could go on top of the thumbnailArea and the thumbnail highlight could fit perfectly inside of it. This would give previews of rectangular images rounded corners and is significantly more complicated than the current change, but I feel like it should be possible.

Here is how no radius for the thumbnailArea and thumbnail highlight looks:

In D20140#440989, @ngraham wrote:

It's probably going to be more noticeable for High DPI users. It seems like there must be a way to fix this rather than just removing the thumbnail radius.

• Remove radius from thumbnailArea highlight

@otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name.

Oh wait no, it's not there yet, but it still looks pretty good.

In D20063#439465, @ngraham wrote:

I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you.

This is very nice.

In D19952#439031, @arvidhansson wrote:

In D19952#438965, @ndavis wrote:

The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else.

Sorry for the confusion, as I'm new to this I really need help and aren't able to do this alone, just just wanted to bring some attention to this and learn how to work with KDE. Thanks for all help, should we now use t-ask's first icon(the right one) or something else?

What if:

The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else.

Navigation is so much faster in tree view. I think navigation speed is what matters most of the time when people are selecting files or locations.

In D19952#438130, @arvidhansson wrote:

In D19952#437726, @ndavis wrote:

In D19952#437670, @arvidhansson wrote:

In D19952#437419, @ndavis wrote:

This can be done in the system tray widget instead of making a separate icon for off. Ever notice how the notifications icon is grey when it's not active?

Sorry, I don't understand, never had noticed anything special with the notifications.

Top icon is for notifications (partly transparent), bottom icon is for Redshift (100% opacity)

In D19952#437664, @arvidhansson wrote:

[...] is it just me or is the transparent icon more like grey?

It's not just you, but that's how partly transparent black on a white background is supposed to look.

Okay, I get it, what should we do now?

In D19952#437670, @arvidhansson wrote:

In D19952#437419, @ndavis wrote:

This can be done in the system tray widget instead of making a separate icon for off. Ever notice how the notifications icon is grey when it's not active?

Sorry, I don't understand, never had noticed anything special with the notifications.

In D19952#436853, @arvidhansson wrote:

In D19952#436834, @taskf wrote:

There is one issue I'm not sure about. The user might feel pressured to check something if the symbol is stroked as it fells like "something is wrong". In that case I would suggest just using the ON version and make it 50% transparent in OFF mode.

I agree, it isn't even an caps-lock-off key. A 50% tranparent icon would fit better

In D12055#436424, @filipf wrote:

In D12055#436412, @ndavis wrote:

I don't see this border at all in the current version of Breeze GTK with Firefox.

Try with a non-default theme

Here's my attempt:

In D19952#436425, @taskf wrote:

Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task.

They are not polished as you can see from the screenshot. The left version symbolizes a lock, while the right one, which I like more, symbolizes a keyboard key.

I don't see this border at all in the current version of Breeze GTK with Firefox.

You need to make the icons on 16x16px and 22x22px canvases. If you use a grid with 1 line every pixel, it will be easier to make icons look sharp. When you make shapes of any kind, even latin characters or numbers, it's best to use the Line, Rectangle and Ellipse tools. If you use strokes, they need to be converted into paths when you're done with the icon.

That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools?

In D19736#434274, @ngraham wrote:

Maybe the rectangle itself doesn't need to be so big? Or maybe it could be even bigger and have the arrows inside?

In D19736#434616, @apol wrote:

How about having 3 icons? autorotate, locked portrait and locked landscape?

This way we don't need to have a weird red strike-through.

Another thing is the ratio between the left/right margins and the top/bottom margins varies with font size, so maybe Kickoff really does need some fixing up.

In D19874#434319, @ngraham wrote:

+1 conceptually. Since Kickoff has its own side margins, these additional margins in the items themselves are just unnecessary.

This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px.

@ngraham Here's something similar to what you asked for:

In D19694#434169, @ngraham wrote:

I was talking about the problem of small monochrome icons in the sidebar itself, not in the tooltip. But anyway since then I fixed the tooltip too.

Any more VDG or Plasma opinions on this?

In D19812#433941, @guoyunhe wrote:

In D19812#433916, @ndavis wrote:

Could you use #eff0f1 and #31363b for the light and dark backgrounds since those are the colors we normally use for window backgrounds?

Like this?

Could you use #eff0f1 and #31363b for the light and dark backgrounds since those are the colors we normally use for window backgrounds?

In D19690#432671, @arvidhansson wrote:

What type of item is it(https://hig.kde.org/style/icon.html)? Is there any way to download the current image?

The current image is preferences-desktop-display from the breeze-icons repo.

Update input-gaming and make circle around dpad and colored buttons darker

In D19733#431237, @GB_2 wrote:

In D19733#431139, @ndavis wrote:

I think preferences-desktop-theme-applications is fine, but preferences-desktop-theme-windowdecorations looks odd with that border.

Well, what do you suggest? This is the most accurate design.

I think preferences-desktop-theme-applications is fine, but preferences-desktop-theme-windowdecorations looks odd with that border.

+1 to this. Fitts' law comes to mind.

In D17469#430647, @ngraham wrote:

Hmm, I see what you mean. Okay, let's go with this one!

BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb:

********* Start testing of DupeTest *********
Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.3.0)
PASS   : DupeTest::initTestCase()
FAIL!  : DupeTest::test_duplicates() 
  The following files are duplicates but not links:
    - /home/dev/kde/src/breeze-icons/icons/actions/22/go-up.svg
    - /home/dev/kde/src/breeze-icons/icons/actions/24/go-up.svg

   Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
FAIL!  : DupeTest::test_duplicates() 
  The following files are duplicates but not links:
    - /home/dev/kde/src/breeze-icons/icons-dark/actions/22/go-up.svg
    - /home/dev/kde/src/breeze-icons/icons-dark/actions/24/go-up.svg

   Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]

Do you think you could fix that after landing this?

In D17469#430616, @ngraham wrote:

No room? Instead of widening the grips by one pixel to make room for the contrast border, how about building it in, effectively narrowing the grips by one pixel?

Darken the handle grips

In D17469#430573, @ngraham wrote:

Better, but the dark parts of the dark version still disappear against a dark background. Most of the time we solve this with a transparent outline (we did this for the clock icon recently), and I think that could work well here too.

In D19736#430545, @ngraham wrote:

Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude mockup illustrates: