Differential D20147

Improve executable dialog buttons' icons
ClosedPublic
Actions

Authored by ngraham on Mar 31 2019, 7:12 PM.

Details

Reviewers
GB_2
ndavis
Group Reviewers
VDG
Commits
R241:89557a218d7b: Improve executable dialog buttons' icons
Summary

The buttons were using mimetype icons, which don't change their colors to reflect the theme, and aren't designed for display at those sizes inside buttons.

BUG: 406090
FIXED-IN: 5.57

Test Plan

Before, light:


After, light:

Before, dark:

After, dark:

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 31 2019, 7:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 31 2019, 7:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 31 2019, 7:12 PM
GB_2 accepted this revision.Mar 31 2019, 7:17 PM
This revision is now accepted and ready to land.Mar 31 2019, 7:17 PM
ndavis accepted this revision.Mar 31 2019, 7:27 PM
ndavis added a subscriber: ndavis.

Yes, this is much better. Wow, that application-x-executable icon is really blurry.

Closed by commit R241:89557a218d7b: Improve executable dialog buttons' icons (authored by ngraham). · Explain WhyMar 31 2019, 7:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55149

View Options

src/widgets/executablefileopendialog.cpp

Loading...