In D10832#613043, @meven wrote:

ping @rominf
It would probably need some rebasing after so long....

Looks good for me!

In D11382#417116, @ngraham wrote:

@rominf, are you planning to come back and work on this at all?

• Replace #ifdef with #if

• Consider criticism

• Add a trailing newline to the end of the file

• Actualy fixing build

• Consider criticism
• Split multiple statements to put one statement on a line

• Consider criticism

• Revert setDefault to the Yes button when closing multiple tabs

In D10959#228679, @elvisangelaccio wrote:

Am I wrong of defocus does not work? Did we agree to ignore it?

In D10990#228540, @rkflx wrote:

In D10990#228470, @elvisangelaccio wrote:

Thanks, remember to use a descriptive commit message :)

@rominf If Elvis is hinting at something but you don't change anything, you should think twice before committing. This should have merely referred to the other commit with the same name and included the fact that here you are doing a follow-up commit to fix problems of the original commit.

Please respect that for future patches. Those requirements are not there to annoy you, but to keep the Git history usable for everyone working on Dolphin now and in the future.

I commited my changes and then landed them with:

git commit -am 'Rename "Show Original" -> "Show Target"'
arc land --revision D10990

• focusTerminal -> focusTerminalPanel

• "Focus Terminal" -> "Focus Terminal Panel"

• Take criticism into account

• Use semantic tag filename in warning message

In D11382#227082, @broulik wrote:

How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.

It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running? If so, how to check this? DBus?

• m_emptyTrashButton->show/hide -> m_emptyTrashButton->setVisible

• Bump dolphinui.rc version

OK, the main problem from your comments is that it's enabled by default. I followed the example of Okular with it's hjkl keys for movements (those keys are enabled by default, you can test it).

Lot's of actions can also be implemented. I'm looking for a feedback. If feedback will be positive, I'll implement additional functionality like switching between tabs.

• Take @elvisangelaccio criticism into account

• Remove unnecessary line

• Disable if multiple files are selected

• Add "Show Original" to file menu

• Close action: "Close" -> "Close Tab"

In D10804#223457, @markg wrote:

In D10804#223410, @rominf wrote:

In D10804#223394, @markg wrote:

@rominf if i restore from within the trash (trash is empty after restoring), the trash icon in the places menu and the "Empty Trash" button both stay active.
Could you take a look at that?

It works for me. Can you check it again (I rebased this on master).

Just done that, same as before.
The icon only updates if i click on the trash again.

Still cannot reproduce. @elvisangelaccio, @ngraham Can you ckeck it?

• Cleanup

• Move isNtfsHidden to file ioslave

In D10960#225162, @ngraham wrote:

For the confirmation dialog added here, I'm unsure whether we should follow the advice of our inline conversation and make the Quit button be default. Depending on what's running in the Terminal panel, killing it could be quite destructive. But I won't block on that, and will accept whatever Dolphin maintainers decide.

I agree with @ngraham (I also for Cancel as a default). @elvisangelaccio what do you think?

@ngraham OK, no problem.

• Remove unused line

• Remove unrelated changes

• Set Cancel active by default when closing Dolphin with multiple tabs or running

program in terminal panel

Please review

In D10832#223393, @elvisangelaccio wrote:

There is no reason to rush this in now, I'd suggest to wait the feature freeze on March 22 [1] so that we have enough time to be sure we don't break anything.

[1]: https://community.kde.org/Schedules/Applications/18.04_Release_Schedule

In D10832#223379, @markg wrote:

Large review!
I was going to give a ship it till i compile tested it. It failed!
You can find the output here: https://p.sc2.nl/HJDBOJmtM

In D10804#223394, @markg wrote:

@rominf if i restore from within the trash (trash is empty after restoring), the trash icon in the places menu and the "Empty Trash" button both stay active.
Could you take a look at that?

It works for me. Can you check it again (I rebased this on master).

• Rebase on master

• Take criticism into account

• Take criticism into account

Please review.

• Trash::instance.*empty -> Trash::*empty

• Rebase on master

• Add this as receiver argument

• Rebase on master

• Rebase on master

• Trash::instance.*empty -> Trash::*empty

• Accept feedback

• Show a message about reopening the terminal panel instead of polling