rominf (Roman Inflianskas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 20 2018, 1:54 PM (17 w, 2 d)
Availability
Available

Recent Activity

Apr 13 2018

rominf committed R318:ec12391a1bb8: Convert hard coded shortcuts to standard keys (authored by rominf).
Convert hard coded shortcuts to standard keys
Apr 13 2018, 6:33 PM
rominf closed D11048: Convert hard coded shortcuts to standard keys.
Apr 13 2018, 6:33 PM

Mar 29 2018

rominf committed R241:f1ab805c4ebc: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa (authored by rominf).
Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa
Mar 29 2018, 5:07 PM
rominf closed D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
Mar 29 2018, 5:07 PM · Frameworks

Mar 27 2018

rominf updated the diff for D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
  • Replace #ifdef with #if
Mar 27 2018, 7:19 AM · Frameworks

Mar 26 2018

rominf updated the diff for D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
  • Consider criticism
Mar 26 2018, 1:44 PM · Frameworks
rominf updated the diff for D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
  • Add a trailing newline to the end of the file
Mar 26 2018, 1:40 PM · Frameworks
rominf updated the diff for D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
  • Actualy fixing build
Mar 26 2018, 1:39 PM · Frameworks
rominf added inline comments to D11204: Support NTFS hidden files.
Mar 26 2018, 1:22 PM · Frameworks
rominf requested review of D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa.
Mar 26 2018, 1:20 PM · Frameworks
rominf committed R241:d7cce9937d5e: Support NTFS hidden files (authored by rominf).
Support NTFS hidden files
Mar 26 2018, 7:06 AM
rominf closed D11204: Support NTFS hidden files.
Mar 26 2018, 7:06 AM · Frameworks
rominf updated the summary of D11204: Support NTFS hidden files.
Mar 26 2018, 6:56 AM · Frameworks

Mar 25 2018

rominf updated the diff for D11204: Support NTFS hidden files.
  • Consider criticism
  • Split multiple statements to put one statement on a line
Mar 25 2018, 9:27 AM · Frameworks
rominf added inline comments to D11204: Support NTFS hidden files.
Mar 25 2018, 7:11 AM · Frameworks
rominf updated the diff for D11204: Support NTFS hidden files.
  • Consider criticism
Mar 25 2018, 7:10 AM · Frameworks

Mar 22 2018

rominf updated the diff for D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
  • Revert setDefault to the Yes button when closing multiple tabs
Mar 22 2018, 6:48 PM · Dolphin
rominf accepted D11562: Fix missing entries in context menu for links.
Mar 22 2018, 11:50 AM

Mar 18 2018

rominf added a comment to D10959: Add action for focusing Terminal Panel.

Am I wrong of defocus does not work? Did we agree to ignore it?

Mar 18 2018, 7:34 PM · Dolphin
rominf added a comment to D10990: Add "Show Target" into symlink context menu and file menu.

Thanks, remember to use a descriptive commit message :)

@rominf If Elvis is hinting at something but you don't change anything, you should think twice before committing. This should have merely referred to the other commit with the same name and included the fact that here you are doing a follow-up commit to fix problems of the original commit.

Please respect that for future patches. Those requirements are not there to annoy you, but to keep the Git history usable for everyone working on Dolphin now and in the future.

I commited my changes and then landed them with:

git commit -am 'Rename "Show Original" -> "Show Target"'
arc land --revision D10990
Mar 18 2018, 12:24 PM
rominf added inline comments to D11334: Disable Create New menu and button when Trash dir is active.
Mar 18 2018, 12:12 PM · Dolphin
rominf committed R318:6f05c66cc0d2: Add "Show Target" into symlink context menu and file menu (authored by rominf).
Add "Show Target" into symlink context menu and file menu
Mar 18 2018, 12:09 PM
rominf closed D10990: Add "Show Target" into symlink context menu and file menu.
Mar 18 2018, 12:09 PM
rominf updated the diff for D10959: Add action for focusing Terminal Panel.
  • focusTerminal -> focusTerminalPanel
Mar 18 2018, 12:06 PM · Dolphin
rominf updated the diff for D10959: Add action for focusing Terminal Panel.
  • "Focus Terminal" -> "Focus Terminal Panel"
Mar 18 2018, 12:04 PM · Dolphin
rominf updated the diff for D10959: Add action for focusing Terminal Panel.
  • Take criticism into account
Mar 18 2018, 12:00 PM · Dolphin
rominf updated the diff for D10990: Add "Show Target" into symlink context menu and file menu.
  • Use semantic tag filename in warning message
Mar 18 2018, 10:56 AM
rominf committed R318:eb68fae15cdb: Show "Empty Trash" button inside trash directory (authored by rominf).
Show "Empty Trash" button inside trash directory
Mar 18 2018, 10:46 AM
rominf closed D10804: Show "Empty Trash" button inside trash directory.
Mar 18 2018, 10:46 AM · Dolphin

Mar 16 2018

rominf added a reviewer for D11382: Add an option to show tabs from last time when Dolphin starts: VDG.
Mar 16 2018, 11:08 AM
rominf added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.

It opens a new instance of Dolphin identical to the previous one... I guess that's a wrong behavior. Should the new instance be fresh if there are other Dolphins running? If so, how to check this? DBus?

Mar 16 2018, 7:59 AM
rominf updated the test plan for D11382: Add an option to show tabs from last time when Dolphin starts.
Mar 16 2018, 7:48 AM
rominf updated the test plan for D11382: Add an option to show tabs from last time when Dolphin starts.
Mar 16 2018, 7:47 AM
rominf updated the test plan for D11382: Add an option to show tabs from last time when Dolphin starts.
Mar 16 2018, 7:47 AM
rominf requested review of D11382: Add an option to show tabs from last time when Dolphin starts.
Mar 16 2018, 7:46 AM
rominf updated the diff for D10804: Show "Empty Trash" button inside trash directory.
  • m_emptyTrashButton->show/hide -> m_emptyTrashButton->setVisible
Mar 16 2018, 6:26 AM · Dolphin
rominf updated the diff for D10990: Add "Show Target" into symlink context menu and file menu.
  • Bump dolphinui.rc version
Mar 16 2018, 5:43 AM

Mar 15 2018

rominf added a comment to D11354: Add vi-mode.

OK, the main problem from your comments is that it's enabled by default. I followed the example of Okular with it's hjkl keys for movements (those keys are enabled by default, you can test it).

Mar 15 2018, 3:03 PM
rominf added a comment to D11354: Add vi-mode.

Lot's of actions can also be implemented. I'm looking for a feedback. If feedback will be positive, I'll implement additional functionality like switching between tabs.

Mar 15 2018, 1:52 PM
rominf updated the summary of D11354: Add vi-mode.
Mar 15 2018, 1:48 PM
rominf requested review of D11354: Add vi-mode.
Mar 15 2018, 1:47 PM
rominf updated the summary of D10990: Add "Show Target" into symlink context menu and file menu.
Mar 15 2018, 11:28 AM
rominf updated the summary of D10990: Add "Show Target" into symlink context menu and file menu.
Mar 15 2018, 11:28 AM
rominf added inline comments to D10990: Add "Show Target" into symlink context menu and file menu.
Mar 15 2018, 11:22 AM
rominf updated the diff for D10990: Add "Show Target" into symlink context menu and file menu.
Mar 15 2018, 11:22 AM
rominf added inline comments to D11334: Disable Create New menu and button when Trash dir is active.
Mar 15 2018, 6:53 AM · Dolphin
rominf updated the diff for D11334: Disable Create New menu and button when Trash dir is active.
  • Remove unnecessary line
Mar 15 2018, 6:49 AM · Dolphin
rominf added inline comments to D10804: Show "Empty Trash" button inside trash directory.
Mar 15 2018, 6:20 AM · Dolphin

Mar 14 2018

rominf committed R318:86f4fcb8cd57: Add "Open symlink destination folder" into symlink's context menu (authored by rominf).
Add "Open symlink destination folder" into symlink's context menu
Mar 14 2018, 7:02 PM
rominf closed D10990: Add "Show Target" into symlink context menu and file menu.
Mar 14 2018, 7:02 PM
rominf updated the summary of D11334: Disable Create New menu and button when Trash dir is active.
Mar 14 2018, 5:47 PM · Dolphin
rominf requested review of D11334: Disable Create New menu and button when Trash dir is active.
Mar 14 2018, 5:40 PM · Dolphin
rominf added inline comments to D11204: Support NTFS hidden files.
Mar 14 2018, 5:00 PM · Frameworks
rominf updated the diff for D10990: Add "Show Target" into symlink context menu and file menu.
  • Disable if multiple files are selected
Mar 14 2018, 10:29 AM
rominf updated the diff for D10990: Add "Show Target" into symlink context menu and file menu.
  • Add "Show Original" to file menu
Mar 14 2018, 10:26 AM
rominf updated the diff for D11048: Convert hard coded shortcuts to standard keys.
  • Close action: "Close" -> "Close Tab"
Mar 14 2018, 10:09 AM
rominf added a comment to D10804: Show "Empty Trash" button inside trash directory.

@rominf if i restore from within the trash (trash is empty after restoring), the trash icon in the places menu and the "Empty Trash" button both stay active.
Could you take a look at that?

It works for me. Can you check it again (I rebased this on master).

Just done that, same as before.
The icon only updates if i click on the trash again.

Still cannot reproduce. @elvisangelaccio, @ngraham Can you ckeck it?

Mar 14 2018, 9:53 AM · Dolphin
rominf updated the diff for D11204: Support NTFS hidden files.
  • Cleanup
Mar 14 2018, 9:24 AM · Frameworks
rominf updated the diff for D11204: Support NTFS hidden files.
  • Move isNtfsHidden to file ioslave
Mar 14 2018, 9:20 AM · Frameworks
rominf added a comment to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.

For the confirmation dialog added here, I'm unsure whether we should follow the advice of our inline conversation and make the Quit button be default. Depending on what's running in the Terminal panel, killing it could be quite destructive. But I won't block on that, and will accept whatever Dolphin maintainers decide.

I agree with @ngraham (I also for Cancel as a default). @elvisangelaccio what do you think?

Mar 14 2018, 6:40 AM · Dolphin
rominf abandoned D11293: Use Cancel button by default when closing Dolphin with multiple tabs.

@ngraham OK, no problem.

Mar 14 2018, 6:34 AM

Mar 13 2018

rominf updated the diff for D11293: Use Cancel button by default when closing Dolphin with multiple tabs.
  • Remove unused line
Mar 13 2018, 5:58 PM
rominf added inline comments to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Mar 13 2018, 5:51 PM · Dolphin
rominf updated the diff for D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
  • Remove unrelated changes
Mar 13 2018, 5:50 PM · Dolphin
rominf requested review of D11293: Use Cancel button by default when closing Dolphin with multiple tabs.
Mar 13 2018, 5:47 PM
rominf added inline comments to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Mar 13 2018, 5:35 PM · Dolphin
rominf updated the diff for D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
  • Set Cancel active by default when closing Dolphin with multiple tabs or running

program in terminal panel

Mar 13 2018, 4:10 PM · Dolphin
rominf added a comment to D10959: Add action for focusing Terminal Panel.

Please review

Mar 13 2018, 9:03 AM · Dolphin

Mar 12 2018

rominf added a comment to D10832: Replace all enum to enum class.

There is no reason to rush this in now, I'd suggest to wait the feature freeze on March 22 [1] so that we have enough time to be sure we don't break anything.

[1]: https://community.kde.org/Schedules/Applications/18.04_Release_Schedule

Mar 12 2018, 5:35 AM · Dolphin
rominf added a comment to D10832: Replace all enum to enum class.

Large review!
I was going to give a ship it till i compile tested it. It failed!
You can find the output here: https://p.sc2.nl/HJDBOJmtM

Mar 12 2018, 5:34 AM · Dolphin
rominf added inline comments to D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program.
Mar 12 2018, 5:17 AM · Dolphin

Mar 11 2018

rominf added a comment to D10804: Show "Empty Trash" button inside trash directory.

@rominf if i restore from within the trash (trash is empty after restoring), the trash icon in the places menu and the "Empty Trash" button both stay active.
Could you take a look at that?

It works for me. Can you check it again (I rebased this on master).

Mar 11 2018, 5:47 PM · Dolphin
rominf updated the diff for D10804: Show "Empty Trash" button inside trash directory.
  • Rebase on master
Mar 11 2018, 5:46 PM · Dolphin
rominf committed R318:68a924af05e7: Show a message if Konsole part is not installed (authored by rominf).
Show a message if Konsole part is not installed
Mar 11 2018, 5:42 PM
rominf closed D11118: Show a message if Konsole part is not installed.
Mar 11 2018, 5:42 PM
rominf updated the diff for D10804: Show "Empty Trash" button inside trash directory.
  • Take criticism into account
Mar 11 2018, 5:22 PM · Dolphin
rominf updated the diff for D11118: Show a message if Konsole part is not installed.
  • Take criticism into account
Mar 11 2018, 5:18 PM
rominf added a comment to D10832: Replace all enum to enum class.

Please review.

Mar 11 2018, 5:01 PM · Dolphin
rominf updated the summary of D11118: Show a message if Konsole part is not installed.
Mar 11 2018, 4:53 PM
rominf updated the diff for D10804: Show "Empty Trash" button inside trash directory.
  • Trash::instance.*empty -> Trash::*empty
Mar 11 2018, 4:52 PM · Dolphin
rominf committed R318:c0797e8adef5: Update trash icon after restore operation (authored by rominf).
Update trash icon after restore operation
Mar 11 2018, 4:47 PM
rominf closed D11216: Update trash icon after restore operation.
Mar 11 2018, 4:47 PM
rominf updated the diff for D11216: Update trash icon after restore operation.
  • Rebase on master
Mar 11 2018, 4:42 PM
rominf updated the diff for D11216: Update trash icon after restore operation.
  • Add this as receiver argument
Mar 11 2018, 4:40 PM
rominf removed a dependent revision for D11216: Update trash icon after restore operation: D10804: Show "Empty Trash" button inside trash directory.
Mar 11 2018, 4:13 PM
rominf removed a dependency for D10804: Show "Empty Trash" button inside trash directory: D11216: Update trash icon after restore operation.
Mar 11 2018, 4:13 PM · Dolphin
rominf updated the diff for D10804: Show "Empty Trash" button inside trash directory.
  • Rebase on master
Mar 11 2018, 4:12 PM · Dolphin
rominf updated the diff for D11216: Update trash icon after restore operation.
  • Rebase on master
Mar 11 2018, 2:37 PM
rominf committed R318:f16fbcba4e9e: Add Trash (empty, isEmpty, emptinessChanged) (authored by rominf).
Add Trash (empty, isEmpty, emptinessChanged)
Mar 11 2018, 2:33 PM
rominf closed D11012: Add Trash (empty, isEmpty, emptinessChanged).
Mar 11 2018, 2:33 PM
rominf updated the diff for D11012: Add Trash (empty, isEmpty, emptinessChanged).
  • Trash::instance.*empty -> Trash::*empty
Mar 11 2018, 2:32 PM
rominf updated the diff for D11012: Add Trash (empty, isEmpty, emptinessChanged).
  • Accept feedback
Mar 11 2018, 1:49 PM
rominf updated the diff for D11118: Show a message if Konsole part is not installed.
  • Show a message about reopening the terminal panel instead of polling
Mar 11 2018, 7:44 AM
rominf edited dependencies for D10804: Show "Empty Trash" button inside trash directory, added: 1; removed: 1.
Mar 11 2018, 7:18 AM · Dolphin
rominf added a dependent revision for D11216: Update trash icon after restore operation: D10804: Show "Empty Trash" button inside trash directory.
Mar 11 2018, 7:18 AM
rominf removed a dependent revision for D11012: Add Trash (empty, isEmpty, emptinessChanged): D10804: Show "Empty Trash" button inside trash directory.
Mar 11 2018, 7:18 AM
rominf added a comment to D11012: Add Trash (empty, isEmpty, emptinessChanged).

I think it gets complicated now.
This patch and D11216 are now both not correct anymore (they are both the same, both do too much).

Reduce this patch to just the Trash addition. Just the refactoring that is needed for that.
So no icon changes in here.

It's already true. If you are talking about the code that updates the icon with the notification signal, it's the part of refactoring. No logic changes involved.

Mar 11 2018, 7:16 AM

Mar 10 2018

rominf planned changes to D11048: Convert hard coded shortcuts to standard keys.
Mar 10 2018, 8:38 PM
rominf updated the diff for D11048: Convert hard coded shortcuts to standard keys.
  • dolphinui.rc version bump
Mar 10 2018, 8:38 PM
rominf planned changes to D11048: Convert hard coded shortcuts to standard keys.
Mar 10 2018, 8:25 PM