Differential D11216

Update trash icon after restore operation
ClosedPublic
Actions

Authored by rominf on Mar 10 2018, 7:36 PM.

Details

Reviewers
elvisangelaccio
markg
Commits
R318:c0797e8adef5: Update trash icon after restore operation
Summary

After restoring all the files from the trash, the trash icon remain 'full'. This patch fixes this.

BUG: 252483

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rominf requested review of this revision.Mar 10 2018, 7:36 PM
rominf created this revision.
rominf added a dependency: D11012: Add Trash (empty, isEmpty, emptinessChanged).Mar 10 2018, 7:37 PM
rominf changed the visibility from "Public (No Login Required)" to "No One".
rominf changed the visibility from "No One" to "Public (No Login Required)".
rominf updated this revision to Diff 29241.Mar 11 2018, 2:37 PM
  • Rebase on master
elvisangelaccio requested changes to this revision.Mar 11 2018, 4:16 PM
elvisangelaccio added a subscriber: elvisangelaccio.
elvisangelaccio added inline comments.
src/trash/dolphintrash.cpp
44

Please add this as receiver argument (I already fixed the connect() above, forgot to mention it in the previous review).

This revision now requires changes to proceed.Mar 11 2018, 4:16 PM
rominf updated this revision to Diff 29251.Mar 11 2018, 4:40 PM
  • Add this as receiver argument
rominf updated this revision to Diff 29252.Mar 11 2018, 4:42 PM
  • Rebase on master
elvisangelaccio accepted this revision.Mar 11 2018, 4:46 PM
elvisangelaccio removed a reviewer: Dolphin.
This revision is now accepted and ready to land.Mar 11 2018, 4:46 PM
markg accepted this revision.Mar 11 2018, 4:47 PM
markg added a subscriber: markg.

+1, finally :)
Nice job, @rominf!

Closed by commit R318:c0797e8adef5: Update trash icon after restore operation (authored by rominf). · Explain WhyMar 11 2018, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/trash/dolphintrash.cpp (1 line)

Diff 29253

View Options

src/trash/dolphintrash.cpp

Loading...