Check all changed shortcuts on all platforms.
- Group Reviewers
- R318:ec12391a1bb8: Convert hard coded shortcuts to standard keys
QKeySequence::AddTab == Ctrl + T .
This is the default for QKeySequence::Deselect. If this is used in other Kapplications this could create an inconsistency in a common action. Maybe we can come up with a different shortcut for this? Crtl+I is common or Ctrl + Shift + I . Personally I am not fond of using another letter maybe ctrl+alt+ A ?
I agree that Ctrl+T should be our main shortcut. This looks like a work around for a Qt bug now so I get why we are sending both. Maybe we should talk with Qt about resolving this bug?
I'm not sure that it's Qt bug. It can be the bug of kxmlgui (actionCollection()->setDefaultShortcut()). I wanted to verify this, but couldn't build it on my openSUSE, because it has extra-cmake-modules version 5.43, while kxmlgui requires 5.44.
If you have a chance, please, try it.
Whether or not this action should get a shortcut (I think it should!) Is unrelated to this patch and should be handled separately. But in fact I don't even see it exposed in the UI at all...
What I said in D11012 applies also here: commit message should be more descriptive.
|220 ↗||(On Diff #28992)|
This is a different action, please revert.
|253 ↗||(On Diff #28992)|
Same. This is a different action, please revert the change.
We also need to replace select_all with edit_select_all (which is the name from kstandardaction) in dolphinui.rc, otherwise the action won't show up in the Edit menu.
Same: please replace close_tab with file_close in dolphinui.rc.
Please replace new_window with file_new in dolphinui.rc.
This should be ported to KStandardAction::redisplay().
Please port to KStandardAction::selectAll() also here.