Fix missing entries in context menu for links
ClosedPublic

Authored by ngraham on Mar 21 2018, 11:09 PM.

Details

Summary

https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.

Test Plan
  • Context menus for files, folders, and file links are unchanged.
  • The missing context menu items for folder links have returned:

I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Mar 21 2018, 11:09 PM
ngraham created this revision.
ngraham edited the summary of this revision. (Show Details)Mar 21 2018, 11:10 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)Mar 21 2018, 11:28 PM
rkflx accepted this revision.Mar 22 2018, 11:12 AM
rkflx added a subscriber: rkflx.

Thanks Nate for stepping up and fixing the mistake.

Patch works fine and the change LGTM.

This revision is now accepted and ready to land.Mar 22 2018, 11:12 AM
rominf accepted this revision.Mar 22 2018, 11:50 AM
This revision was automatically updated to reflect the committed changes.