In D27563#615561, @ngraham wrote:

What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of convergence.

Similar fix applied to plasma-nm. Looks good to me.

Thank you David.

Thank you David.

In D27199#613246, @ngraham wrote:

In D27199#612689, @jgrulich wrote:

This is probably not related to the UI, it might be issue in the internals. Can you open a bug for it? Ideally if you can restart plasmashell and enable plasma-nm debug

Will do. How do I do enable plasma-nm debug?

Accepting from my side. I'll wait for Nate to do the final review as I don't consider myself expert to QML and UI.

In D27199#611665, @ngraham wrote:

In D27199#611308, @gvgeo wrote:

I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393

@ngraham Before I make any change here, can you tell me if you can still reproduce the problem, with this diff on master?

withoutCpp.diff22 KBDownload

It exludes changes in modelitem and C++ in general.

Yes, I can still reproduce the issue with this diff applied on top of master. HOWECVER! I just noticed that I can reproduce the issue on master right now, with no patches. I can't believe I missed this before, sorry!

I like it. I didn't go through the code changes yet, I'll wait until you finish it completely.

Looking at some other frameworks, they basically have same code to generate pri files, are they all broken?

Improve cmake file

Fixed all issues.

Improve includes

Drop unrelated change

• Fix cmake variable name

Simplify cmake code

Thinking about it now, what's the reason to put the checkboxes in the plasma-nm applet at the bottom? In this case they overrule what it's visible below, e.g. you turn off WiFi and all wireless networks will disappear. Similar situation is with the notification applet, where the "Do not disturb" checkbox is at the top, because it overrules what's below. It makes more sense when this is placed at the top as it has bigger effect.

In T10470#219347, @gvgeo wrote:

Something like this?
Easy to differentiate connected vs available(with a bit more space around the line) , and communicates sort order.

SSID needs to stay with the current system.
But can show 'Last used' only when need.

• Add comment why we reverted that change and when it can be removed

• Code improvements

Address review comments:

1. Add text to the toolbutton and make it checkable
2. Allow to create hotspot only if WiFi is available or it's not used as primary connection

In D26392#592288, @ngraham wrote:

In D26392#592133, @jgrulich wrote:

Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon?

@cblack is working on it IIRC. It's too late to show the icon in Plasma 5.18 anyway (the icon will be in the breeze-icons repo which is a framework, and Frameworks 5.66 which Plasma 5.18 relies on has already been tagged. So there's no huge rush there IMO.

I'm still unable to test this because of the odd build failure that I cannot understand, explain, or overcome. :/

In D26392#592136, @apol wrote:

In D26392#588345, @jgrulich wrote:

In D26392#587159, @mthw wrote:

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

That's a question. Do we want to allow to create a hotspot if users are already connected to w WiFi network? You are allowed to do this for example on Android. Users might not realize why they are not allowed to create a hotspot and disconnecting from WiFi doesn't seem to me be a good first step.

Leaving the user without a connection would be quite dishearting and possibly confusing.

I can imagine the use-case of: I am in this building with weird authentication (thinking university) and I want to share that connection with my phone, so I create a hotspot and we don't have to do weird configuration on the phone. Would apply to e.g. vpns too.

Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon?

In D26392#590884, @ngraham wrote:

No, even with networkmanager-qt from git master, I still get the same build failure here. :(

In D26392#588994, @ngraham wrote:

This no longer compiles for me:

/home/nate/kde/src/plasma-nm/libs/handler.cpp: In member function ‘void Handler::createHotspot()’:
/home/nate/kde/src/plasma-nm/libs/handler.cpp:622:94: error: ‘addAndActivateConnection2’ is not a member of ‘NetworkManager’; did you mean ‘addAndActivateConnection’?
  622 |     QDBusPendingReply<QDBusObjectPath, QDBusObjectPath, QVariantMap> reply = NetworkManager::addAndActivateConnection2(connectionSettings->toMap(), wifiDev->uni(), QString(), options);
      |                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                                              addAndActivateConnection

I don't really remember, but I can see in the userHash() it's not used so this is probably safe. In the userHash() we directly use KUser().

It requires networkmanager-qt from master (upcoming 5.66 version).

I used ToolButton instead of a regular button, reason is that I don't think there is enough space. If there is modem device available, there will be three checkboxes on the left and with a regular button in various languages this might not be enough space.

Use button instead of checkbox

In D26392#587200, @alexde wrote:

UI-wise, this would probably be better off as a button than a checkbox.

Personally, I'm more inclined to a checkbox. Why is "turn wifi on/off" not an action? Right now, I don't see the big difference.

Is the new "hotspot" equivalent to the "shared wifi", you can already set up?
If so, without really reading the patch details yet, just some remarks or ideas:

1. If you have configured several hotspots in the KCM, you probably need to choose a default one or a specific one when activating the hotspot.

In D26392#587159, @mthw wrote:

@apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi network. Currently enabling hotspot disables your previous connection (WiFi) and hides available WiFi networks.

There are two things which need work or I'm not sure about:

1. If this should be placed as a checkbox in the applet
2. We need a different icon for the hotspot, currently there is no such icon in the Plasma theme and freeze for Plasma 5.18 is soon. This is meant to be a kind request for someone who does icons for Plasma.

I will land this once Flatpak 1.6 is released. While this can be used by older Flatpak version, it will not build with older Flatpak versions.

Simplify tooltips